mihailom-db commented on code in PR #45891:
URL: https://github.com/apache/spark/pull/45891#discussion_r1560747241
##
sql/api/src/main/scala/org/apache/spark/sql/internal/types/AbstractStringType.scala:
##
@@ -15,30 +15,30 @@
* limitations under the License.
*/
-package
stefankandic commented on code in PR #45891:
URL: https://github.com/apache/spark/pull/45891#discussion_r1560698270
##
sql/api/src/main/scala/org/apache/spark/sql/internal/types/AbstractStringType.scala:
##
@@ -15,30 +15,30 @@
* limitations under the License.
*/
-package
cloud-fan closed pull request #45891: [SPARK-47736][SQL] Add support for
AbstractArrayType
URL: https://github.com/apache/spark/pull/45891
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
cloud-fan commented on PR #45891:
URL: https://github.com/apache/spark/pull/45891#issuecomment-2049111906
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
cloud-fan commented on code in PR #45891:
URL: https://github.com/apache/spark/pull/45891#discussion_r1558908333
##
sql/api/src/main/scala/org/apache/spark/sql/types/ArrayType.scala:
##
@@ -43,6 +43,23 @@ object ArrayType extends AbstractDataType {
override private[spark]
cloud-fan commented on code in PR #45891:
URL: https://github.com/apache/spark/pull/45891#discussion_r155890
##
sql/api/src/main/scala/org/apache/spark/sql/internal/types/AbstractArrayType.scala:
##
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
mihailom-db commented on PR #45891:
URL: https://github.com/apache/spark/pull/45891#issuecomment-2045750423
@cloud-fan Did some refactoring with some renaming, so I re-requested approve
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
cloud-fan commented on code in PR #45891:
URL: https://github.com/apache/spark/pull/45891#discussion_r1557312729
##
sql/api/src/main/scala/org/apache/spark/sql/types/ArrayType.scala:
##
@@ -43,6 +43,23 @@ object ArrayType extends AbstractDataType {
override private[spark]
cloud-fan commented on code in PR #45891:
URL: https://github.com/apache/spark/pull/45891#discussion_r1557314805
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala:
##
@@ -1017,6 +1017,9 @@ object TypeCoercion extends TypeCoercionBase {
cloud-fan commented on code in PR #45891:
URL: https://github.com/apache/spark/pull/45891#discussion_r1557313843
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala:
##
@@ -1017,6 +1017,9 @@ object TypeCoercion extends TypeCoercionBase {
mihailom-db commented on code in PR #45891:
URL: https://github.com/apache/spark/pull/45891#discussion_r1556979888
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/StringTypeCollated.scala:
##
@@ -52,3 +52,20 @@ case object StringTypeAnyCollation extends
11 matches
Mail list logo
