Re: [PR] [SPARK-47902][SQL]Making Compute Current Time* expressions foldable [spark]

2024-04-21 Thread via GitHub
cloud-fan closed pull request #46120: [SPARK-47902][SQL]Making Compute Current Time* expressions foldable URL: https://github.com/apache/spark/pull/46120 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [SPARK-47902][SQL]Making Compute Current Time* expressions foldable [spark]

2024-04-21 Thread via GitHub
cloud-fan commented on PR #46120: URL: https://github.com/apache/spark/pull/46120#issuecomment-2068419611 thanks, merging to master! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [SPARK-47902][SQL]Making Compute Current Time* expressions foldable [spark]

2024-04-19 Thread via GitHub
dbatomic commented on code in PR #46120: URL: https://github.com/apache/spark/pull/46120#discussion_r1572580087 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/ExpressionTypeCheckingSuite.scala: ## @@ -811,4 +811,10 @@ class ExpressionTypeCheckingSuite

Re: [PR] [SPARK-47902][SQL]Making Compute Current Time* expressions foldable [spark]

2024-04-19 Thread via GitHub
cloud-fan commented on code in PR #46120: URL: https://github.com/apache/spark/pull/46120#discussion_r1572478404 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/ExpressionTypeCheckingSuite.scala: ## @@ -811,4 +811,10 @@ class ExpressionTypeCheckingSuite

Re: [PR] [SPARK-47902][SQL]Making Compute Current Time* expressions foldable [spark]

2024-04-19 Thread via GitHub
dbatomic commented on code in PR #46120: URL: https://github.com/apache/spark/pull/46120#discussion_r1571993071 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/ConstantFoldingSuite.scala: ## @@ -437,6 +437,21 @@ class ConstantFoldingSuite extends PlanTest

Re: [PR] [SPARK-47902][SQL]Making Compute Current Time* expressions foldable [spark]

2024-04-18 Thread via GitHub
cloud-fan commented on code in PR #46120: URL: https://github.com/apache/spark/pull/46120#discussion_r1571683122 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/ConstantFoldingSuite.scala: ## @@ -437,6 +437,21 @@ class ConstantFoldingSuite extends

[PR] [SPARK-47902][SQL]Making Compute Current Time* expressions foldable [spark]

2024-04-18 Thread via GitHub
dbatomic opened a new pull request, #46120: URL: https://github.com/apache/spark/pull/46120 ### What changes were proposed in this pull request? This PR is a followed of [this](https://github.com/apache/spark/pull/44261) PR that made "compute current time" family of