dongjoon-hyun closed pull request #6: [SPARK-47929] Setup Static Analysis for
Operator
URL: https://github.com/apache/spark-kubernetes-operator/pull/6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
jiangzho commented on code in PR #6:
URL:
https://github.com/apache/spark-kubernetes-operator/pull/6#discussion_r1575438072
##
config/checkstyle/checkstyle.xml:
##
@@ -0,0 +1,195 @@
+
+
+https://checkstyle.org/dtds/configuration_1_3.dtd;>
+
+
+
+
Review Comment:
Yes, this
jiangzho commented on PR #6:
URL:
https://github.com/apache/spark-kubernetes-operator/pull/6#issuecomment-2071080506
Thanks @dongjoon-hyun for the review!
yes, we target latest versions as possible
[Checkstyle](https://checkstyle.sourceforge.io/) latest 10.15.0
dongjoon-hyun commented on code in PR #6:
URL:
https://github.com/apache/spark-kubernetes-operator/pull/6#discussion_r1575230305
##
config/lombok/lombok.config:
##
@@ -0,0 +1,4 @@
+config.stopBubbling = true
+lombok.addLombokGeneratedAnnotation = true
dongjoon-hyun commented on code in PR #6:
URL:
https://github.com/apache/spark-kubernetes-operator/pull/6#discussion_r1575226996
##
build.gradle:
##
@@ -6,7 +20,71 @@ subprojects {
targetCompatibility = 17
repositories {
- mavenCentral()
- jcenter()
+
dongjoon-hyun commented on code in PR #6:
URL:
https://github.com/apache/spark-kubernetes-operator/pull/6#discussion_r1575224070
##
config/pmd/ruleset.xml:
##
@@ -0,0 +1,33 @@
+
+
+
+
+
Review Comment:
ditto. Please use `2-space` indentation.
--
This is an
dongjoon-hyun commented on code in PR #6:
URL:
https://github.com/apache/spark-kubernetes-operator/pull/6#discussion_r1575223691
##
gradle.properties:
##
@@ -0,0 +1,23 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license
dongjoon-hyun commented on code in PR #6:
URL:
https://github.com/apache/spark-kubernetes-operator/pull/6#discussion_r1575221017
##
gradle.properties:
##
@@ -0,0 +1,23 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license
dongjoon-hyun commented on code in PR #6:
URL:
https://github.com/apache/spark-kubernetes-operator/pull/6#discussion_r1575219192
##
config/checkstyle/checkstyle.xml:
##
@@ -0,0 +1,195 @@
+
+
+https://checkstyle.org/dtds/configuration_1_3.dtd;>
+
+
+
+
+
Review Comment:
dongjoon-hyun commented on code in PR #6:
URL:
https://github.com/apache/spark-kubernetes-operator/pull/6#discussion_r1575218204
##
config/checkstyle/checkstyle.xml:
##
@@ -0,0 +1,195 @@
+
+
+https://checkstyle.org/dtds/configuration_1_3.dtd;>
+
+
+
+
Review Comment:
This
dongjoon-hyun commented on code in PR #6:
URL:
https://github.com/apache/spark-kubernetes-operator/pull/6#discussion_r1575216351
##
build.gradle:
##
@@ -6,7 +20,71 @@ subprojects {
targetCompatibility = 17
repositories {
- mavenCentral()
- jcenter()
+
dongjoon-hyun commented on code in PR #6:
URL:
https://github.com/apache/spark-kubernetes-operator/pull/6#discussion_r1575215880
##
build.gradle:
##
@@ -1,3 +1,17 @@
+buildscript {
+ repositories {
+maven {
+ url = uri("https://plugins.gradle.org/m2/;)
+}
+ }
+
jiangzho opened a new pull request, #6:
URL: https://github.com/apache/spark-kubernetes-operator/pull/6
### What changes were proposed in this pull request?
This is a breakdown PR from #2 - setting up common build tasks and required
plugins.
Checkstyle xml is
13 matches
Mail list logo
