Re: [PR] [SPARK-47994][SQL] Fix bug with CASE WHEN column filter push down in SQLServer [spark]

2024-04-29 Thread via GitHub
yaooqinn closed pull request #46231: [SPARK-47994][SQL] Fix bug with CASE WHEN column filter push down in SQLServer URL: https://github.com/apache/spark/pull/46231 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [SPARK-47994][SQL] Fix bug with CASE WHEN column filter push down in SQLServer [spark]

2024-04-29 Thread via GitHub
yaooqinn commented on PR #46231: URL: https://github.com/apache/spark/pull/46231#issuecomment-208257 Thank you @stefanbuk-db Merged to master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [SPARK-47994][SQL] Fix bug with CASE WHEN column filter push down in SQLServer [spark]

2024-04-29 Thread via GitHub
yaooqinn commented on PR #46231: URL: https://github.com/apache/spark/pull/46231#issuecomment-2082208303 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [SPARK-47994][SQL] Fix bug with CASE WHEN column filter push down in SQLServer [spark]

2024-04-29 Thread via GitHub
yaooqinn commented on code in PR #46231: URL: https://github.com/apache/spark/pull/46231#discussion_r1582720271 ## sql/core/src/main/scala/org/apache/spark/sql/jdbc/MsSqlServerDialect.scala: ## @@ -92,6 +92,7 @@ private case class MsSqlServerDialect() extends JdbcDialect {

Re: [PR] [SPARK-47994][SQL] Fix bug with CASE WHEN column filter push down in SQLServer [spark]

2024-04-29 Thread via GitHub
yaooqinn commented on code in PR #46231: URL: https://github.com/apache/spark/pull/46231#discussion_r1582719516 ## sql/core/src/main/scala/org/apache/spark/sql/jdbc/MsSqlServerDialect.scala: ## @@ -92,6 +92,7 @@ private case class MsSqlServerDialect() extends JdbcDialect {

Re: [PR] [SPARK-47994][SQL] Fix bug with CASE WHEN column filter push down in SQLServer [spark]

2024-04-29 Thread via GitHub
stefanbuk-db commented on code in PR #46231: URL: https://github.com/apache/spark/pull/46231#discussion_r1582716492 ## sql/core/src/main/scala/org/apache/spark/sql/jdbc/MsSqlServerDialect.scala: ## @@ -92,6 +92,7 @@ private case class MsSqlServerDialect() extends JdbcDialect {

Re: [PR] [SPARK-47994][SQL] Fix bug with CASE WHEN column filter push down in SQLServer [spark]

2024-04-29 Thread via GitHub
yaooqinn commented on code in PR #46231: URL: https://github.com/apache/spark/pull/46231#discussion_r1582712347 ## sql/core/src/main/scala/org/apache/spark/sql/jdbc/MsSqlServerDialect.scala: ## @@ -92,6 +92,7 @@ private case class MsSqlServerDialect() extends JdbcDialect {

Re: [PR] [SPARK-47994][SQL] Fix bug with CASE WHEN column filter push down in SQLServer [spark]

2024-04-29 Thread via GitHub
stefanbuk-db commented on PR #46231: URL: https://github.com/apache/spark/pull/46231#issuecomment-2082141133 cc @yaooqinn -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [SPARK-47994][SQL] Fix bug with CASE WHEN column filter push down in SQLServer [spark]

2024-04-26 Thread via GitHub
HyukjinKwon commented on PR #46231: URL: https://github.com/apache/spark/pull/46231#issuecomment-2078890912 cc @beliefer FYI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] [SPARK-47994][SQL] Fix bug with CASE WHEN column filter push down in SQLServer [spark]

2024-04-25 Thread via GitHub
stefanbuk-db opened a new pull request, #46231: URL: https://github.com/apache/spark/pull/46231 ### What changes were proposed in this pull request? In this PR I propose a change in QueryBuilder for SQLServer. This change restricts push down of predicate that contains a