cloud-fan closed pull request #46599: [SPARK-48000][SQL] Enable hash join
support for all collations (StringType)
URL: https://github.com/apache/spark/pull/46599
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
cloud-fan commented on PR #46599:
URL: https://github.com/apache/spark/pull/46599#issuecomment-2136500679
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
cloud-fan commented on PR #46599:
URL: https://github.com/apache/spark/pull/46599#issuecomment-2135782446
@uros-db unfortunately it has merge conflicts now...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
cloud-fan commented on code in PR #46599:
URL: https://github.com/apache/spark/pull/46599#discussion_r1617637707
##
sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala:
##
@@ -1030,6 +999,135 @@ class CollationSuite extends DatasourceV2SQLBase with
AdaptiveSparkPl
cloud-fan commented on code in PR #46599:
URL: https://github.com/apache/spark/pull/46599#discussion_r1617637460
##
sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala:
##
@@ -1030,6 +999,135 @@ class CollationSuite extends DatasourceV2SQLBase with
AdaptiveSparkPl
uros-db commented on code in PR #46599:
URL: https://github.com/apache/spark/pull/46599#discussion_r1612779931
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala:
##
@@ -279,6 +280,7 @@ abstract class Optimizer(catalogManager: CatalogManager)
uros-db commented on code in PR #46599:
URL: https://github.com/apache/spark/pull/46599#discussion_r1612779931
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala:
##
@@ -279,6 +280,7 @@ abstract class Optimizer(catalogManager: CatalogManager)
uros-db commented on code in PR #46599:
URL: https://github.com/apache/spark/pull/46599#discussion_r1612774784
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala:
##
@@ -250,7 +250,8 @@ abstract class Optimizer(catalogManager: CatalogManager)
uros-db commented on code in PR #46599:
URL: https://github.com/apache/spark/pull/46599#discussion_r1612774784
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala:
##
@@ -250,7 +250,8 @@ abstract class Optimizer(catalogManager: CatalogManager)
cloud-fan commented on code in PR #46599:
URL: https://github.com/apache/spark/pull/46599#discussion_r1612585293
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala:
##
@@ -250,7 +250,8 @@ abstract class Optimizer(catalogManager: CatalogManager
uros-db commented on code in PR #46599:
URL: https://github.com/apache/spark/pull/46599#discussion_r1609865411
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteCollationJoin.scala:
##
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation
cloud-fan commented on code in PR #46599:
URL: https://github.com/apache/spark/pull/46599#discussion_r1609856726
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteCollationJoin.scala:
##
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundati
uros-db commented on code in PR #46599:
URL: https://github.com/apache/spark/pull/46599#discussion_r1609845984
##
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java:
##
@@ -284,4 +284,15 @@ public static UTF8String getCollationKey(UTF8String inp
uros-db commented on code in PR #46599:
URL: https://github.com/apache/spark/pull/46599#discussion_r1609836738
##
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java:
##
@@ -284,4 +284,15 @@ public static UTF8String getCollationKey(UTF8String inp
uros-db commented on code in PR #46599:
URL: https://github.com/apache/spark/pull/46599#discussion_r1609836738
##
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java:
##
@@ -284,4 +284,15 @@ public static UTF8String getCollationKey(UTF8String inp
cloud-fan commented on code in PR #46599:
URL: https://github.com/apache/spark/pull/46599#discussion_r1609832522
##
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java:
##
@@ -284,4 +284,15 @@ public static UTF8String getCollationKey(UTF8String i
cloud-fan commented on code in PR #46599:
URL: https://github.com/apache/spark/pull/46599#discussion_r1609825428
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteCollationJoin.scala:
##
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundati
dbatomic commented on code in PR #46599:
URL: https://github.com/apache/spark/pull/46599#discussion_r1604648152
##
sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala:
##
@@ -768,7 +768,7 @@ class CollationSuite extends DatasourceV2SQLBase with
AdaptiveSparkPlanHe
dbatomic commented on code in PR #46599:
URL: https://github.com/apache/spark/pull/46599#discussion_r1604643347
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/CollationKey.scala:
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
dbatomic commented on code in PR #46599:
URL: https://github.com/apache/spark/pull/46599#discussion_r1604640371
##
sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala:
##
@@ -778,25 +778,25 @@ class CollationSuite extends DatasourceV2SQLBase with
AdaptiveSparkPlan
uros-db commented on code in PR #46599:
URL: https://github.com/apache/spark/pull/46599#discussion_r160330
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteCollationJoin.scala:
##
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation
21 matches
Mail list logo
