Re: [PR] [SPARK-48004][SQL] Add WriteFilesExecBase trait for v1 write [spark]

2024-04-27 Thread via GitHub
cloud-fan commented on PR #46240: URL: https://github.com/apache/spark/pull/46240#issuecomment-2081340902 late LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [SPARK-48004][SQL] Add WriteFilesExecBase trait for v1 write [spark]

2024-04-26 Thread via GitHub
yaooqinn closed pull request #46240: [SPARK-48004][SQL] Add WriteFilesExecBase trait for v1 write URL: https://github.com/apache/spark/pull/46240 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [SPARK-48004][SQL] Add WriteFilesExecBase trait for v1 write [spark]

2024-04-26 Thread via GitHub
yaooqinn commented on PR #46240: URL: https://github.com/apache/spark/pull/46240#issuecomment-2079123777 Thanks, merged to master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [SPARK-48004][SQL] Add WriteFilesExecBase trait for v1 write [spark]

2024-04-26 Thread via GitHub
ulysses-you commented on PR #46240: URL: https://github.com/apache/spark/pull/46240#issuecomment-2078886099 cc @cloud-fan @yaooqinn thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] [SPARK-48004][SQL] Add WriteFilesExecBase trait for v1 write [spark]

2024-04-26 Thread via GitHub
ulysses-you opened a new pull request, #46240: URL: https://github.com/apache/spark/pull/46240 ### What changes were proposed in this pull request? This pr adds a new trait `WriteFilesExecBase` for v1 write, so that the downstream project can inherit `WriteFilesExecBase`