Re: [PR] [SPARK-48273][SQL] Fix late rewrite of PlanWithUnresolvedIdentifier [spark]

2024-05-29 Thread via GitHub
cloud-fan commented on PR #46580: URL: https://github.com/apache/spark/pull/46580#issuecomment-2138051309 fixing at https://github.com/apache/spark/pull/46794 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [SPARK-48273][SQL] Fix late rewrite of PlanWithUnresolvedIdentifier [spark]

2024-05-29 Thread via GitHub
LuciferYang commented on PR #46580: URL: https://github.com/apache/spark/pull/46580#issuecomment-2137364776 there are new failing cases in `SQLQueryTestSuite` and `ThriftServerQueryTestSuite ` after this one is merged into branch-3.5: - ThriftServerQueryTestSuite :

Re: [PR] [SPARK-48273][SQL] Fix late rewrite of PlanWithUnresolvedIdentifier [spark]

2024-05-28 Thread via GitHub
cloud-fan closed pull request #46580: [SPARK-48273][SQL] Fix late rewrite of PlanWithUnresolvedIdentifier URL: https://github.com/apache/spark/pull/46580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [SPARK-48273][SQL] Fix late rewrite of PlanWithUnresolvedIdentifier [spark]

2024-05-28 Thread via GitHub
cloud-fan commented on PR #46580: URL: https://github.com/apache/spark/pull/46580#issuecomment-2135723638 thanks, merging to master/3.5! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [SPARK-48273][SQL] Fix late rewrite of PlanWithUnresolvedIdentifier [spark]

2024-05-27 Thread via GitHub
nikolamand-db commented on code in PR #46580: URL: https://github.com/apache/spark/pull/46580#discussion_r1616397169 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveIdentifierClause.scala: ## @@ -20,19 +20,23 @@ package

Re: [PR] [SPARK-48273][SQL] Fix late rewrite of PlanWithUnresolvedIdentifier [spark]

2024-05-24 Thread via GitHub
cloud-fan commented on code in PR #46580: URL: https://github.com/apache/spark/pull/46580#discussion_r1613945984 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveIdentifierClause.scala: ## @@ -20,19 +20,23 @@ package

Re: [PR] [SPARK-48273][SQL] Fix late rewrite of PlanWithUnresolvedIdentifier [spark]

2024-05-24 Thread via GitHub
nikolamand-db commented on PR #46580: URL: https://github.com/apache/spark/pull/46580#issuecomment-2129615940 > I think this fixes https://issues.apache.org/jira/browse/SPARK-46625 as well. Can we add a test to verify? Checked locally, seems like these changes don't resolve the

Re: [PR] [SPARK-48273][SQL] Fix late rewrite of PlanWithUnresolvedIdentifier [spark]

2024-05-22 Thread via GitHub
cloud-fan commented on PR #46580: URL: https://github.com/apache/spark/pull/46580#issuecomment-2124575129 I think this fixes https://issues.apache.org/jira/browse/SPARK-46625 as well. Can we add a test to verify? -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] [SPARK-48273][SQL] Fix late rewrite of PlanWithUnresolvedIdentifier [spark]

2024-05-22 Thread via GitHub
cloud-fan commented on code in PR #46580: URL: https://github.com/apache/spark/pull/46580#discussion_r1609790546 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveIdentifierClause.scala: ## @@ -20,19 +20,20 @@ package

Re: [PR] [SPARK-48273][SQL] Fix late rewrite of PlanWithUnresolvedIdentifier [spark]

2024-05-22 Thread via GitHub
cloud-fan commented on code in PR #46580: URL: https://github.com/apache/spark/pull/46580#discussion_r1609786723 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala: ## @@ -254,7 +254,7 @@ class Analyzer(override val catalogManager: