Re: [PR] [SPARK-48282][SQL] Alter string search logic for UTF8_BINARY_LCASE collation (StringReplace, FindInSet) [spark]

uros-db commented on code in PR #46682: URL: https://github.com/apache/spark/pull/46682#discussion_r1618206224 ## common/unsafe/src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java: ## @@ -639,81 +639,93 @@ public void testStringInstr() throws SparkException {

Re: [PR] [SPARK-48282][SQL] Alter string search logic for UTF8_BINARY_LCASE collation (StringReplace, FindInSet) [spark]

mkaravel commented on code in PR #46682: URL: https://github.com/apache/spark/pull/46682#discussion_r1617954653 ## common/unsafe/src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java: ## @@ -639,81 +639,93 @@ public void testStringInstr() throws SparkException {

Re: [PR] [SPARK-48282][SQL] Alter string search logic for UTF8_BINARY_LCASE collation (StringReplace, FindInSet) [spark]

uros-db commented on code in PR #46682: URL: https://github.com/apache/spark/pull/46682#discussion_r1613448325 ## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationAwareUTF8String.java: ## @@ -34,6 +34,155 @@ * Utility class for collation-aware UTF8String

Re: [PR] [SPARK-48282][SQL] Alter string search logic for UTF8_BINARY_LCASE collation (StringReplace, FindInSet) [spark]

uros-db commented on code in PR #46682: URL: https://github.com/apache/spark/pull/46682#discussion_r1613447350 ## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationAwareUTF8String.java: ## @@ -34,6 +34,155 @@ * Utility class for collation-aware UTF8String

Re: [PR] [SPARK-48282][SQL] Alter string search logic for UTF8_BINARY_LCASE collation (StringReplace, FindInSet) [spark]

uros-db commented on code in PR #46682: URL: https://github.com/apache/spark/pull/46682#discussion_r1613408156 ## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationAwareUTF8String.java: ## @@ -34,6 +34,155 @@ * Utility class for collation-aware UTF8String

Re: [PR] [SPARK-48282][SQL] Alter string search logic for UTF8_BINARY_LCASE collation (StringReplace, FindInSet) [spark]

uros-db commented on code in PR #46682: URL: https://github.com/apache/spark/pull/46682#discussion_r1613407352 ## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationAwareUTF8String.java: ## @@ -34,6 +34,155 @@ * Utility class for collation-aware UTF8String

Re: [PR] [SPARK-48282][SQL] Alter string search logic for UTF8_BINARY_LCASE collation (StringReplace, FindInSet) [spark]

uros-db commented on code in PR #46682: URL: https://github.com/apache/spark/pull/46682#discussion_r1613404598 ## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationAwareUTF8String.java: ## @@ -34,6 +34,155 @@ * Utility class for collation-aware UTF8String

Re: [PR] [SPARK-48282][SQL] Alter string search logic for UTF8_BINARY_LCASE collation (StringReplace, FindInSet) [spark]

uros-db commented on code in PR #46682: URL: https://github.com/apache/spark/pull/46682#discussion_r1613401443 ## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationAwareUTF8String.java: ## @@ -34,6 +34,155 @@ * Utility class for collation-aware UTF8String

Re: [PR] [SPARK-48282][SQL] Alter string search logic for UTF8_BINARY_LCASE collation (StringReplace, FindInSet) [spark]

uros-db commented on code in PR #46682: URL: https://github.com/apache/spark/pull/46682#discussion_r1613221638 ## common/unsafe/src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java: ## @@ -610,8 +610,42 @@ public void testFindInSet() throws SparkException {

Re: [PR] [SPARK-48282][SQL] Alter string search logic for UTF8_BINARY_LCASE collation (StringReplace, FindInSet) [spark]

uros-db commented on code in PR #46682: URL: https://github.com/apache/spark/pull/46682#discussion_r1612793743 ## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationAwareUTF8String.java: ## @@ -34,6 +34,155 @@ * Utility class for collation-aware UTF8String

Re: [PR] [SPARK-48282][SQL] Alter string search logic for UTF8_BINARY_LCASE collation (StringReplace, FindInSet) [spark]

uros-db commented on code in PR #46682: URL: https://github.com/apache/spark/pull/46682#discussion_r1612791411 ## common/unsafe/src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java: ## @@ -610,8 +610,42 @@ public void testFindInSet() throws SparkException {

Re: [PR] [SPARK-48282][SQL] Alter string search logic for UTF8_BINARY_LCASE collation (StringReplace, FindInSet) [spark]

mkaravel commented on code in PR #46682: URL: https://github.com/apache/spark/pull/46682#discussion_r1612519155 ## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationAwareUTF8String.java: ## @@ -34,6 +34,155 @@ * Utility class for collation-aware UTF8Strin

Re: [PR] [SPARK-48282][SQL] Alter string search logic for UTF8_BINARY_LCASE collation (StringReplace, FindInSet) [spark]

mkaravel commented on PR #46682: URL: https://github.com/apache/spark/pull/46682#issuecomment-2128279874 > ### Why are the changes needed? > Fix functions that give unusable results due to one-to-many conditional case mapping when performing string search under UTF8_BINARY_LCASE (see exam