Re: [PR] [SPARK-48411][SS][PYTHON] Add E2E test for DropDuplicateWithinWatermark [spark]

2024-06-11 Thread via GitHub
HeartSaVioR closed pull request #46740: [SPARK-48411][SS][PYTHON] Add E2E test for DropDuplicateWithinWatermark URL: https://github.com/apache/spark/pull/46740 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [SPARK-48411][SS][PYTHON] Add E2E test for DropDuplicateWithinWatermark [spark]

2024-06-11 Thread via GitHub
HeartSaVioR commented on PR #46740: URL: https://github.com/apache/spark/pull/46740#issuecomment-2162047423 Thanks, merging to master! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [SPARK-48411][SS][PYTHON] Add E2E test for DropDuplicateWithinWatermark [spark]

2024-06-04 Thread via GitHub
anishshri-db commented on code in PR #46740: URL: https://github.com/apache/spark/pull/46740#discussion_r1626795999 ## python/pyspark/sql/tests/streaming/test_streaming.py: ## @@ -392,6 +392,30 @@ def test_streaming_with_temporary_view(self): set([Row(value="vie

Re: [PR] [SPARK-48411][SS][PYTHON] Add E2E test for DropDuplicateWithinWatermark [spark]

2024-05-30 Thread via GitHub
eason-yuchen-liu commented on code in PR #46740: URL: https://github.com/apache/spark/pull/46740#discussion_r1621544776 ## python/pyspark/sql/tests/streaming/test_streaming.py: ## @@ -392,6 +392,31 @@ def test_streaming_with_temporary_view(self): set([Row(value=

Re: [PR] [SPARK-48411][SS][PYTHON] Add E2E test for DropDuplicateWithinWatermark [spark]

2024-05-30 Thread via GitHub
WweiL commented on code in PR #46740: URL: https://github.com/apache/spark/pull/46740#discussion_r1621506306 ## python/pyspark/sql/tests/streaming/test_streaming.py: ## @@ -392,6 +392,31 @@ def test_streaming_with_temporary_view(self): set([Row(value="view_a"),

Re: [PR] [SPARK-48411][SS][PYTHON] Add E2E test for DropDuplicateWithinWatermark [spark]

2024-05-30 Thread via GitHub
WweiL commented on code in PR #46740: URL: https://github.com/apache/spark/pull/46740#discussion_r1621504283 ## python/pyspark/sql/tests/streaming/test_streaming.py: ## @@ -392,6 +392,31 @@ def test_streaming_with_temporary_view(self): set([Row(value="view_a"),

Re: [PR] [SPARK-48411][SS][PYTHON] Add E2E test for DropDuplicateWithinWatermark [spark]

2024-05-30 Thread via GitHub
WweiL commented on code in PR #46740: URL: https://github.com/apache/spark/pull/46740#discussion_r1621503817 ## python/pyspark/sql/tests/streaming/test_streaming.py: ## @@ -392,6 +392,31 @@ def test_streaming_with_temporary_view(self): set([Row(value="view_a"),

Re: [PR] [SPARK-48411][SS][PYTHON] Add E2E test for DropDuplicateWithinWatermark [spark]

2024-05-30 Thread via GitHub
WweiL commented on code in PR #46740: URL: https://github.com/apache/spark/pull/46740#discussion_r1621503560 ## python/pyspark/sql/tests/streaming/test_streaming.py: ## @@ -392,6 +392,31 @@ def test_streaming_with_temporary_view(self): set([Row(value="view_a"),

Re: [PR] [SPARK-48411][SS][PYTHON] Add E2E test for DropDuplicateWithinWatermark [spark]

2024-05-29 Thread via GitHub
WweiL commented on PR #46740: URL: https://github.com/apache/spark/pull/46740#issuecomment-2138186674 @eason-yuchen-liu, could you please setup the CI as shown in the error message https://github.com/apache/spark/pull/46740/checks?check_run_id=25522033987 Thank you! -- This is an auto

Re: [PR] [SPARK-48411][SS][PYTHON] Add E2E test for DropDuplicateWithinWatermark [spark]

2024-05-29 Thread via GitHub
anishshri-db commented on PR #46740: URL: https://github.com/apache/spark/pull/46740#issuecomment-2138162093 cc - @HeartSaVioR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] [SPARK-48411][SS][PYTHON] Add E2E test for DropDuplicateWithinWatermark [spark]

2024-05-29 Thread via GitHub
anishshri-db commented on PR #46740: URL: https://github.com/apache/spark/pull/46740#issuecomment-2138159903 @eason-yuchen-liu - same here. seems like the GH actions is not running the tests as expected ? -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] [SPARK-48411][SS][PYTHON] Add E2E test for DropDuplicateWithinWatermark [spark]

2024-05-28 Thread via GitHub
eason-yuchen-liu commented on code in PR #46740: URL: https://github.com/apache/spark/pull/46740#discussion_r1617863817 ## python/pyspark/sql/tests/streaming/test_streaming.py: ## @@ -392,6 +394,30 @@ def test_streaming_with_temporary_view(self): set([Row(value=

[PR] [SPARK-48411][SS][PYTHON] Add E2E test for DropDuplicateWithinWatermark [spark]

2024-05-24 Thread via GitHub
eason-yuchen-liu opened a new pull request, #46740: URL: https://github.com/apache/spark/pull/46740 ### What changes were proposed in this pull request? This PR adds a test for API DropDuplicateWithinWatermark, which was previously missing. ### Why are the changes needed? Ch