Re: [PR] [WIP] Don't review: E2e [spark]

2024-05-24 Thread via GitHub
GideonPotok closed pull request #46670: [WIP] Don't review: E2e URL: https://github.com/apache/spark/pull/46670 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] [WIP] Don't review: E2e [spark]

2024-05-21 Thread via GitHub
uros-db commented on PR #46670: URL: https://github.com/apache/spark/pull/46670#issuecomment-2123327859 Yes, aggregation buffers are InternalRows in Spark, however - I would not suggest extending stuff as you described in order to get this working. This approach turned out to not be as

Re: [PR] [WIP] Don't review: E2e [spark]

2024-05-21 Thread via GitHub
GideonPotok commented on PR #46670: URL: https://github.com/apache/spark/pull/46670#issuecomment-2123283997 @uros-db adding the map binaryValues to Mode doesn't persist the mappings as desired. It looks to me like the general pattern for accumulating anything in spark aggregation functions

[PR] [WIP] Don't review: E2e [spark]

2024-05-20 Thread via GitHub
GideonPotok opened a new pull request, #46670: URL: https://github.com/apache/spark/pull/46670 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ###