dongjoon-hyun commented on PR #46160:
URL: https://github.com/apache/spark/pull/46160#issuecomment-2071442761
Merged to master. Thank you, @pan3793 and all!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
dongjoon-hyun closed pull request #46160: [SPARK-44170][BUILD][FOLLOWUP] Align
JUnit5 dependency's version and clean up exclusions
URL: https://github.com/apache/spark/pull/46160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
pan3793 commented on code in PR #46160:
URL: https://github.com/apache/spark/pull/46160#discussion_r1575535040
##
pom.xml:
##
@@ -220,6 +220,9 @@
4.1.109.Final
2.0.65.Final
72.1
+5.9.1
Review Comment:
@dongjoon-hyun sorry, that's a typo, corrected
--
pan3793 commented on code in PR #46160:
URL: https://github.com/apache/spark/pull/46160#discussion_r1575534643
##
pom.xml:
##
@@ -220,6 +220,9 @@
4.1.109.Final
2.0.65.Final
72.1
+5.9.1
Review Comment:
```suggestion
5.9.3
```
--
This is an
dongjoon-hyun commented on code in PR #46160:
URL: https://github.com/apache/spark/pull/46160#discussion_r1575402128
##
pom.xml:
##
@@ -220,6 +220,9 @@
4.1.109.Final
2.0.65.Final
72.1
+5.9.1
Review Comment:
May I ask why we downgrade this, @pan3793 ?
pan3793 commented on code in PR #46160:
URL: https://github.com/apache/spark/pull/46160#discussion_r1574586567
##
pom.xml:
##
@@ -1236,13 +1220,49 @@
org.junit.jupiter
junit-jupiter
-5.9.3
+${junit-jupiter.version}
Review Comment:
I
LuciferYang commented on code in PR #46160:
URL: https://github.com/apache/spark/pull/46160#discussion_r1574537815
##
pom.xml:
##
@@ -1236,13 +1220,49 @@
org.junit.jupiter
junit-jupiter
-5.9.3
+${junit-jupiter.version}
Review Comment:
LuciferYang commented on PR #46160:
URL: https://github.com/apache/spark/pull/46160#issuecomment-2069074161
> run `mvn clean install -pl core -am
-Dtest.exclude.tags=org.apache.spark.tags.ExtendedLevelDBTest`
>
> ```
> [ERROR] java.lang.NoClassDefFoundError:
pan3793 commented on code in PR #46160:
URL: https://github.com/apache/spark/pull/46160#discussion_r1574508952
##
pom.xml:
##
@@ -1236,13 +1220,49 @@
org.junit.jupiter
junit-jupiter
-5.9.3
+${junit-jupiter.version}
+test
+
