Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

uros-db commented on code in PR #45643: URL: https://github.com/apache/spark/pull/45643#discussion_r1570050123 ## common/unsafe/src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java: ## @@ -261,6 +261,84 @@ public void testEndsWith() throws SparkException {

Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

uros-db commented on code in PR #45643: URL: https://github.com/apache/spark/pull/45643#discussion_r1570050746 ## common/unsafe/src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java: ## @@ -261,6 +261,84 @@ public void testEndsWith() throws SparkException {

Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

uros-db commented on code in PR #45643: URL: https://github.com/apache/spark/pull/45643#discussion_r1570041252 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CollationTypeCasts.scala: ## @@ -18,9 +18,7 @@ package org.apache.spark.sql.catalyst.analysis

Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

miland-db commented on code in PR #45643: URL: https://github.com/apache/spark/pull/45643#discussion_r1565868020 ## sql/core/src/test/scala/org/apache/spark/sql/CollationStringExpressionsSuite.scala: ## @@ -17,13 +17,11 @@ package org.apache.spark.sql -import

Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

uros-db commented on code in PR #45643: URL: https://github.com/apache/spark/pull/45643#discussion_r1565859516 ## sql/core/src/test/scala/org/apache/spark/sql/CollationStringExpressionsSuite.scala: ## @@ -17,13 +17,11 @@ package org.apache.spark.sql -import

Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

miland-db commented on code in PR #45643: URL: https://github.com/apache/spark/pull/45643#discussion_r1565854152 ## sql/core/src/test/scala/org/apache/spark/sql/CollationStringExpressionsSuite.scala: ## @@ -17,13 +17,11 @@ package org.apache.spark.sql -import

Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

uros-db commented on code in PR #45643: URL: https://github.com/apache/spark/pull/45643#discussion_r1565850753 ## sql/core/src/test/scala/org/apache/spark/sql/CollationStringExpressionsSuite.scala: ## @@ -17,13 +17,11 @@ package org.apache.spark.sql -import

Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

miland-db commented on code in PR #45643: URL: https://github.com/apache/spark/pull/45643#discussion_r1565815937 ## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationSupport.java: ## @@ -138,72 +138,72 @@ public static boolean execICU(final UTF8String l,

Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

uros-db commented on code in PR #45643: URL: https://github.com/apache/spark/pull/45643#discussion_r1565772062 ## common/unsafe/src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java: ## @@ -249,6 +249,86 @@ public void testEndsWith() throws SparkException {

Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

uros-db commented on code in PR #45643: URL: https://github.com/apache/spark/pull/45643#discussion_r1565771738 ## common/unsafe/src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java: ## @@ -249,6 +249,86 @@ public void testEndsWith() throws SparkException {

Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

uros-db commented on code in PR #45643: URL: https://github.com/apache/spark/pull/45643#discussion_r1565770706 ## common/unsafe/src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java: ## @@ -249,6 +249,86 @@ public void testEndsWith() throws SparkException {

Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

uros-db commented on code in PR #45643: URL: https://github.com/apache/spark/pull/45643#discussion_r1565766846 ## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationSupport.java: ## @@ -138,72 +138,72 @@ public static boolean execICU(final UTF8String l,

Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

miland-db commented on code in PR #45643: URL: https://github.com/apache/spark/pull/45643#discussion_r1565559690 ## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationSupport.java: ## @@ -169,6 +239,46 @@ private static boolean matchAt(final UTF8String

Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

uros-db commented on code in PR #45643: URL: https://github.com/apache/spark/pull/45643#discussion_r1565559007 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala: ## @@ -974,15 +974,19 @@ case class StringTranslate(srcExpr:

Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

miland-db commented on code in PR #45643: URL: https://github.com/apache/spark/pull/45643#discussion_r156472 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala: ## @@ -974,15 +974,19 @@ case class StringTranslate(srcExpr:

Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

uros-db commented on code in PR #45643: URL: https://github.com/apache/spark/pull/45643#discussion_r1565531354 ## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationSupport.java: ## @@ -169,6 +239,46 @@ private static boolean matchAt(final UTF8String

Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

uros-db commented on code in PR #45643: URL: https://github.com/apache/spark/pull/45643#discussion_r1565524362 ## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationSupport.java: ## @@ -169,6 +239,46 @@ private static boolean matchAt(final UTF8String

Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

uros-db commented on code in PR #45643: URL: https://github.com/apache/spark/pull/45643#discussion_r1565508312 ## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationSupport.java: ## @@ -137,6 +137,76 @@ public static boolean execICU(final UTF8String l,

Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

uros-db commented on code in PR #45643: URL: https://github.com/apache/spark/pull/45643#discussion_r1565521994 ## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationSupport.java: ## @@ -169,6 +239,46 @@ private static boolean matchAt(final UTF8String

Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

uros-db commented on code in PR #45643: URL: https://github.com/apache/spark/pull/45643#discussion_r1565521994 ## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationSupport.java: ## @@ -169,6 +239,46 @@ private static boolean matchAt(final UTF8String

Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

uros-db commented on code in PR #45643: URL: https://github.com/apache/spark/pull/45643#discussion_r1565521994 ## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationSupport.java: ## @@ -169,6 +239,46 @@ private static boolean matchAt(final UTF8String

Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

uros-db commented on code in PR #45643: URL: https://github.com/apache/spark/pull/45643#discussion_r1565521994 ## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationSupport.java: ## @@ -169,6 +239,46 @@ private static boolean matchAt(final UTF8String

Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

uros-db commented on code in PR #45643: URL: https://github.com/apache/spark/pull/45643#discussion_r1565515634 ## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationSupport.java: ## @@ -169,6 +239,46 @@ private static boolean matchAt(final UTF8String

Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

uros-db commented on code in PR #45643: URL: https://github.com/apache/spark/pull/45643#discussion_r1565510703 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala: ## @@ -974,15 +974,19 @@ case class StringTranslate(srcExpr:

Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

uros-db commented on code in PR #45643: URL: https://github.com/apache/spark/pull/45643#discussion_r1565508312 ## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationSupport.java: ## @@ -137,6 +137,76 @@ public static boolean execICU(final UTF8String l,

Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

uros-db commented on code in PR #45643: URL: https://github.com/apache/spark/pull/45643#discussion_r1565502312 ## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationSupport.java: ## @@ -137,6 +137,76 @@ public static boolean execICU(final UTF8String l,

Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

uros-db commented on code in PR #45643: URL: https://github.com/apache/spark/pull/45643#discussion_r1565502312 ## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationSupport.java: ## @@ -137,6 +137,76 @@ public static boolean execICU(final UTF8String l,

Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

uros-db commented on code in PR #45643: URL: https://github.com/apache/spark/pull/45643#discussion_r1565494137 ## sql/core/src/test/scala/org/apache/spark/sql/CollationStringExpressionsSuite.scala: ## @@ -96,6 +95,107 @@ class CollationStringExpressionsSuite

Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

uros-db commented on code in PR #45643: URL: https://github.com/apache/spark/pull/45643#discussion_r1565494692 ## sql/core/src/test/scala/org/apache/spark/sql/CollationStringExpressionsSuite.scala: ## @@ -96,6 +95,107 @@ class CollationStringExpressionsSuite

Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

uros-db commented on code in PR #45643: URL: https://github.com/apache/spark/pull/45643#discussion_r1565494692 ## sql/core/src/test/scala/org/apache/spark/sql/CollationStringExpressionsSuite.scala: ## @@ -96,6 +95,107 @@ class CollationStringExpressionsSuite

Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

uros-db commented on code in PR #45643: URL: https://github.com/apache/spark/pull/45643#discussion_r1565492245 ## sql/core/src/test/scala/org/apache/spark/sql/CollationStringExpressionsSuite.scala: ## @@ -96,6 +95,107 @@ class CollationStringExpressionsSuite

Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

uros-db commented on code in PR #45643: URL: https://github.com/apache/spark/pull/45643#discussion_r1565490452 ## sql/core/src/test/scala/org/apache/spark/sql/CollationStringExpressionsSuite.scala: ## @@ -96,6 +95,107 @@ class CollationStringExpressionsSuite

Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

uros-db commented on code in PR #45643: URL: https://github.com/apache/spark/pull/45643#discussion_r1565489630 ## sql/core/src/test/scala/org/apache/spark/sql/CollationStringExpressionsSuite.scala: ## @@ -96,6 +95,107 @@ class CollationStringExpressionsSuite

Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

uros-db commented on code in PR #45643: URL: https://github.com/apache/spark/pull/45643#discussion_r1565484403 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala: ## @@ -1346,20 +1350,24 @@ case class StringTrimRight(srcStr:

Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

uros-db commented on code in PR #45643: URL: https://github.com/apache/spark/pull/45643#discussion_r1565482699 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala: ## @@ -974,15 +974,19 @@ case class StringTranslate(srcExpr:

Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

uros-db commented on PR #45643: URL: https://github.com/apache/spark/pull/45643#issuecomment-2049812695 heads up: we’ve done some major code restructuring in https://github.com/apache/spark/pull/45978, so please sync these changes before moving on @miland-db you’ll likely need to

Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

dbatomic commented on code in PR #45643: URL: https://github.com/apache/spark/pull/45643#discussion_r1555475151 ## common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java: ## @@ -549,6 +549,51 @@ public int findInSet(UTF8String match) { return 0; } +

Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

cloud-fan commented on code in PR #45643: URL: https://github.com/apache/spark/pull/45643#discussion_r1555443962 ## common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java: ## @@ -549,6 +549,51 @@ public int findInSet(UTF8String match) { return 0; }

Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

miland-db commented on code in PR #45643: URL: https://github.com/apache/spark/pull/45643#discussion_r1555394471 ## common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java: ## @@ -549,6 +549,51 @@ public int findInSet(UTF8String match) { return 0; }

Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

dbatomic commented on code in PR #45643: URL: https://github.com/apache/spark/pull/45643#discussion_r1555389826 ## common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java: ## @@ -549,6 +549,51 @@ public int findInSet(UTF8String match) { return 0; } +

Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

dbatomic commented on code in PR #45643: URL: https://github.com/apache/spark/pull/45643#discussion_r1555378573 ## common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java: ## @@ -549,6 +549,51 @@ public int findInSet(UTF8String match) { return 0; } +

Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

cloud-fan commented on code in PR #45643: URL: https://github.com/apache/spark/pull/45643#discussion_r1555173817 ## common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java: ## @@ -549,6 +549,51 @@ public int findInSet(UTF8String match) { return 0; }

Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

miland-db commented on PR #45643: URL: https://github.com/apache/spark/pull/45643#issuecomment-2039386033 @MaxGekk can you please review this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

miland-db commented on code in PR #45643: URL: https://github.com/apache/spark/pull/45643#discussion_r1549579283 ## common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java: ## @@ -549,6 +549,45 @@ public int findInSet(UTF8String match) { return 0; }

Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

miland-db commented on code in PR #45643: URL: https://github.com/apache/spark/pull/45643#discussion_r1551227337 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala: ## @@ -994,15 +994,29 @@ case class StringTranslate(srcExpr:

Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

uros-db commented on code in PR #45643: URL: https://github.com/apache/spark/pull/45643#discussion_r1551195271 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala: ## @@ -994,15 +994,29 @@ case class StringTranslate(srcExpr:

Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

miland-db commented on code in PR #45643: URL: https://github.com/apache/spark/pull/45643#discussion_r1551132518 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala: ## @@ -1002,15 +1002,34 @@ case class StringTranslate(srcExpr:

Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

uros-db commented on code in PR #45643: URL: https://github.com/apache/spark/pull/45643#discussion_r1550968894 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala: ## @@ -1002,15 +1002,34 @@ case class StringTranslate(srcExpr:

Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

miland-db commented on code in PR #45643: URL: https://github.com/apache/spark/pull/45643#discussion_r1549579283 ## common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java: ## @@ -549,6 +549,45 @@ public int findInSet(UTF8String match) { return 0; }

Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

uros-db commented on code in PR #45643: URL: https://github.com/apache/spark/pull/45643#discussion_r1549419980 ## common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java: ## @@ -549,6 +549,45 @@ public int findInSet(UTF8String match) { return 0; } +

Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

uros-db commented on code in PR #45643: URL: https://github.com/apache/spark/pull/45643#discussion_r1549393104 ## sql/core/src/test/scala/org/apache/spark/sql/CollationStringExpressionsSuite.scala: ## @@ -73,17 +74,78 @@ class CollationStringExpressionsSuite extends QueryTest

Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

uros-db commented on code in PR #45643: URL: https://github.com/apache/spark/pull/45643#discussion_r1549393104 ## sql/core/src/test/scala/org/apache/spark/sql/CollationStringExpressionsSuite.scala: ## @@ -73,17 +74,78 @@ class CollationStringExpressionsSuite extends QueryTest

Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

uros-db commented on code in PR #45643: URL: https://github.com/apache/spark/pull/45643#discussion_r1549387717 ## sql/core/src/test/scala/org/apache/spark/sql/CollationStringExpressionsSuite.scala: ## @@ -73,17 +74,78 @@ class CollationStringExpressionsSuite extends QueryTest

Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

uros-db commented on code in PR #45643: URL: https://github.com/apache/spark/pull/45643#discussion_r1549378473 ## common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java: ## @@ -549,6 +549,45 @@ public int findInSet(UTF8String match) { return 0; } +

Re: [PR] [SPARK-47411][SQL] Support INSTR & FIND_IN_SET functions to work with collated strings [spark]

uros-db commented on code in PR #45643: URL: https://github.com/apache/spark/pull/45643#discussion_r1549356302 ## common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java: ## @@ -549,6 +549,45 @@ public int findInSet(UTF8String match) { return 0; } +