[GitHub] spark pull request: [SPARK-3787] Assembly jar name is wrong when w...

2014-10-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2647#issuecomment-57896058 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3787] Assembly jar name is wrong when w...

2014-10-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2647#issuecomment-57896055 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21286/consoleFull) for PR 2647 at commit

[GitHub] spark pull request: [SPARK-3790][MLlib] CosineSimilarity Example

2014-10-04 Thread rezazadeh
Github user rezazadeh commented on the pull request: https://github.com/apache/spark/pull/2622#issuecomment-57896484 Parameters are now configurable. Added approximation error reporting. Added JIRA. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-3790][MLlib] CosineSimilarity Example

2014-10-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2622#issuecomment-57896544 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21287/consoleFull) for PR 2622 at commit

[GitHub] spark pull request: [Spark-3525] Adding gradient boosting

2014-10-04 Thread epahomov
Github user epahomov closed the pull request at: https://github.com/apache/spark/pull/2394 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-3713][SQL] Uses JSON to serialize DataT...

2014-10-04 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/2563#issuecomment-57897337 @davis Thanks for all the suggestions, really makes things a lot cleaner! --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-3720][SQL]initial support ORC in spark ...

2014-10-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2576#issuecomment-57897374 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21288/consoleFull) for PR 2576 at commit

[GitHub] spark pull request: [SPARK-3713][SQL] Uses JSON to serialize DataT...

2014-10-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2563#issuecomment-57897375 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21289/consoleFull) for PR 2563 at commit

[GitHub] spark pull request: [SPARK-3720][SQL]initial support ORC in spark ...

2014-10-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2576#issuecomment-57897385 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3713][SQL] Uses JSON to serialize DataT...

2014-10-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2563#issuecomment-57897538 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21291/consoleFull) for PR 2563 at commit

[GitHub] spark pull request: [SPARK-3720][SQL]initial support ORC in spark ...

2014-10-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2576#issuecomment-57897540 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21290/consoleFull) for PR 2576 at commit

[GitHub] spark pull request: [SPARK-3720][SQL]initial support ORC in spark ...

2014-10-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2576#issuecomment-57897553 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3790][MLlib] CosineSimilarity Example

2014-10-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2622#issuecomment-57897798 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21287/consoleFull) for PR 2622 at commit

[GitHub] spark pull request: [SPARK-3790][MLlib] CosineSimilarity Example

2014-10-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2622#issuecomment-57897801 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3713][SQL] Uses JSON to serialize DataT...

2014-10-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2563#issuecomment-57898946 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21291/consoleFull) for PR 2563 at commit

[GitHub] spark pull request: [SPARK-3713][SQL] Uses JSON to serialize DataT...

2014-10-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2563#issuecomment-57898948 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3713][SQL] Uses JSON to serialize DataT...

2014-10-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2563#issuecomment-57899622 **[Tests timed out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21289/consoleFull)** after a configured wait of `120m`. --- If your project

[GitHub] spark pull request: [SPARK-3713][SQL] Uses JSON to serialize DataT...

2014-10-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2563#issuecomment-57899624 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3713][SQL] Uses JSON to serialize DataT...

2014-10-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2563#issuecomment-57900055 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/265/consoleFull) for PR 2563 at commit

[GitHub] spark pull request: [SPARK-3645][SQL] Makes table caching eager by...

2014-10-04 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/2513#issuecomment-57902212 Rebased to the master, with the new `CACHE LAZY TABLE t` syntax. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-3645][SQL] Makes table caching eager by...

2014-10-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2513#issuecomment-57902286 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21292/consoleFull) for PR 2513 at commit

[GitHub] spark pull request: [SPARK-3720][SQL]initial support ORC in spark ...

2014-10-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2576#issuecomment-57902624 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21293/consoleFull) for PR 2576 at commit

[GitHub] spark pull request: [SPARK-3007][SQL] Adds dynamic partitioning su...

2014-10-04 Thread scwf
Github user scwf commented on the pull request: https://github.com/apache/spark/pull/2616#issuecomment-57902670 Hi, @liancheng, master branch test failed in my machine for all dynamic partition , [info] - dynamic_partition *** FAILED *** [info] - Dynamic partition folder

[GitHub] spark pull request: [SPARK-3792][SQL]enable JavaHiveQLSuite

2014-10-04 Thread scwf
GitHub user scwf opened a pull request: https://github.com/apache/spark/pull/2652 [SPARK-3792][SQL]enable JavaHiveQLSuite Do not use TestSQLContext in JavaHiveQLSuite, that may lead to two SparkContext and enable JavaHiveQLSuite You can merge this pull request into a Git

[GitHub] spark pull request: [SPARK-3792][SQL]enable JavaHiveQLSuite

2014-10-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2652#issuecomment-57903264 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-3645][SQL] Makes table caching eager by...

2014-10-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2513#issuecomment-57903715 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3645][SQL] Makes table caching eager by...

2014-10-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2513#issuecomment-57903713 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21292/consoleFull) for PR 2513 at commit

[GitHub] spark pull request: [SPARK-3720][SQL]initial support ORC in spark ...

2014-10-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2576#issuecomment-57905623 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-2750] support https in spark web ui

2014-10-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1980#issuecomment-57905663 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21294/consoleFull) for PR 1980 at commit

[GitHub] spark pull request: [SPARK-2365] Add IndexedRDD, an efficient upda...

2014-10-04 Thread MLnick
Github user MLnick commented on the pull request: https://github.com/apache/spark/pull/1297#issuecomment-57905819 This looks really interesting. Is there a blocker for supporting generic keys (or at least say `String`), or is that a performance issue? --- If your project is set up

[GitHub] spark pull request: SPARK-3770: Make userFeatures accessible from ...

2014-10-04 Thread MLnick
Github user MLnick commented on the pull request: https://github.com/apache/spark/pull/2636#issuecomment-57905979 Can we use the existing `pairRDDToPython ` function?

[GitHub] spark pull request: [SPARK-3773][PySpark][Doc] Sphinx build warnin...

2014-10-04 Thread cocoatomo
GitHub user cocoatomo opened a pull request: https://github.com/apache/spark/pull/2653 [SPARK-3773][PySpark][Doc] Sphinx build warning When building Sphinx documents for PySpark, we have 12 warnings. Their causes are almost docstrings in broken ReST format. To reproduce

[GitHub] spark pull request: [SPARK-3773][PySpark][Doc] Sphinx build warnin...

2014-10-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2653#issuecomment-57906805 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-2706][SQL] Enable Spark to support Hive...

2014-10-04 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/2241#discussion_r18429655 --- Diff: sql/hive/v0.13.1/src/main/scala/org/apache/spark/sql/hive/Shim.scala --- @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-2750] support https in spark web ui

2014-10-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1980#issuecomment-57907416 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-2750] support https in spark web ui

2014-10-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1980#issuecomment-57907414 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21294/consoleFull) for PR 1980 at commit

[GitHub] spark pull request: [SPARK-3007][SQL] Adds dynamic partitioning su...

2014-10-04 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/2616#issuecomment-57907458 @scwf Can you elaborate on what configurations you're using? Details like compilation flags, environment variables and building process can be helpful. I've been

[GitHub] spark pull request: [SPARK-3645][SQL] Makes table caching eager by...

2014-10-04 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/2513#discussion_r18429700 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/SqlParser.scala --- @@ -91,42 +92,42 @@ class SqlParser extends StandardTokenParsers

[GitHub] spark pull request: [SPARK-3645][SQL] Makes table caching eager by...

2014-10-04 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/2513#discussion_r18429702 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/SqlParser.scala --- @@ -91,42 +92,42 @@ class SqlParser extends StandardTokenParsers

[GitHub] spark pull request: [SPARK-2706][SQL] Enable Spark to support Hive...

2014-10-04 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/2241#discussion_r18429712 --- Diff: sql/hive/v0.13.1/src/main/scala/org/apache/spark/sql/hive/Shim.scala --- @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-3007][SQL] Adds dynamic partitioning su...

2014-10-04 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/2616#issuecomment-57907663 @scwf Or could you please describe the steps to reproduce this failure from a newly checked out master branch? I guess once you can reproduce it, it happens

[GitHub] spark pull request: [SPARK-2706][SQL] Enable Spark to support Hive...

2014-10-04 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/2241#discussion_r18429736 --- Diff: sql/hive/v0.13.1/src/main/scala/org/apache/spark/sql/hive/Shim.scala --- @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-3007][SQL] Adds dynamic partitioning su...

2014-10-04 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/2616#issuecomment-57907852 Ah, just found out that I can reproduce it with `-Phive`, had been using `-Phive,hadoop-2.4` all the time and just couldn't reproduce this, thanks! --- If your

[GitHub] spark pull request: [SPARK-3007][SQL] Adds dynamic partitioning su...

2014-10-04 Thread scwf
Github user scwf commented on the pull request: https://github.com/apache/spark/pull/2616#issuecomment-57908014 Yes, i will use -Phive,hadoop-2.4 to see whether it has the peoblem --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-2706][SQL] Enable Spark to support Hive...

2014-10-04 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/2241#discussion_r18429781 --- Diff: sql/hive/v0.13.1/src/main/scala/org/apache/spark/sql/hive/Shim.scala --- @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-2706][SQL] Enable Spark to support Hive...

2014-10-04 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/2241#discussion_r18429783 --- Diff: sql/hive/v0.13.1/src/main/scala/org/apache/spark/sql/hive/Shim.scala --- @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [Minor] Trivial fix to make codes more readabl...

2014-10-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2654#issuecomment-57908521 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [Minor] Trivial fix to make codes more readabl...

2014-10-04 Thread viirya
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/2654 [Minor] Trivial fix to make codes more readable It should just use `maxResults` there. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] spark pull request: [SPARK-3793][SQL]use hiveconf when parse hive ...

2014-10-04 Thread scwf
GitHub user scwf opened a pull request: https://github.com/apache/spark/pull/2655 [SPARK-3793][SQL]use hiveconf when parse hive ql This PR is to make hive ql parser more general and compatible with both hive-0.12 and hive-0.13. In hive-0.13 we may need hiveconf(or hivecontext) when

[GitHub] spark pull request: [SPARK-3007][SQL] Adds dynamic partitioning su...

2014-10-04 Thread scwf
Github user scwf commented on the pull request: https://github.com/apache/spark/pull/2616#issuecomment-57908927 using -Phive,hadoop-2.4 is ok in my local maching --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-3793][SQL]use hiveconf when parse hive ...

2014-10-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2655#issuecomment-57908961 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-2750] support https in spark web ui

2014-10-04 Thread scwf
Github user scwf commented on the pull request: https://github.com/apache/spark/pull/1980#issuecomment-57909017 Updated and fix the confilct, @JoshRosen you can have a test for this refer to my last comment. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-3758] [Windows] Wrong EOL character in ...

2014-10-04 Thread nchammas
Github user nchammas commented on the pull request: https://github.com/apache/spark/pull/2612#issuecomment-57909026 I'm worried since most of us develop on mac/linux that this will end up in a weird state where there are mixed EOL characters. I'd worry about this, too. If

[GitHub] spark pull request: [SPARK-3007][SQL] Adds dynamic partitioning su...

2014-10-04 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/2616#issuecomment-57909183 So this bug can be triggered by lower versions of Hadoop, e.g. 1.0.3. I haven't validate the exact range yet. In `Hive.loadDynamicPartitions`, Hive calls

[GitHub] spark pull request: [SPARK-3777] Display Executor ID for Tasks i...

2014-10-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2642#issuecomment-57909187 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21295/consoleFull) for PR 2642 at commit

[GitHub] spark pull request: [SPARK-3007][SQL] Adds dynamic partitioning su...

2014-10-04 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/2616#issuecomment-57909238 @scwf Thanks for all the information you provided offline :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-3777] Display Executor ID for Tasks i...

2014-10-04 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/2642#issuecomment-57909316 As horizontal space is precious for including more metrics, might it make sense to combine Address / Executor and Executor ID into a single Executor column, with values

[GitHub] spark pull request: [SPARK-3007][SQL] Adds dynamic partitioning su...

2014-10-04 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/2616#issuecomment-57909423 According to previous failed Jenkins builds ([1](https://amplab.cs.berkeley.edu/jenkins/job/Spark-Master-SBT/752/),

[GitHub] spark pull request: [SPARK-3007][SQL] Adds dynamic partitioning su...

2014-10-04 Thread scwf
Github user scwf commented on the pull request: https://github.com/apache/spark/pull/2616#issuecomment-57909534 Get it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-2706][SQL] Enable Spark to support Hive...

2014-10-04 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/2241#discussion_r18430042 --- Diff: sql/hive/v0.12.0/src/main/scala/org/apache/spark/sql/hive/Shim.scala --- @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-3777] Display Executor ID for Tasks i...

2014-10-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2642#issuecomment-57911257 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3777] Display Executor ID for Tasks i...

2014-10-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2642#issuecomment-57911254 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21295/consoleFull) for PR 2642 at commit

[GitHub] spark pull request: [SPARK-2706][SQL] Enable Spark to support Hive...

2014-10-04 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/2241#discussion_r18430235 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/TestHive.scala --- @@ -369,6 +371,7 @@ class TestHiveContext(sc: SparkContext) extends

[GitHub] spark pull request: [SPARK-2706][SQL] Enable Spark to support Hive...

2014-10-04 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/2241#discussion_r18430262 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/TestHive.scala --- @@ -78,6 +79,7 @@ class TestHiveContext(sc: SparkContext) extends

[GitHub] spark pull request: [SPARK-2706][SQL] Enable Spark to support Hive...

2014-10-04 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/2241#discussion_r18430322 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala --- @@ -80,8 +81,10 @@ class StatisticsSuite extends QueryTest with

[GitHub] spark pull request: [SPARK-2706][SQL] Enable Spark to support Hive...

2014-10-04 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/2241#discussion_r18430463 --- Diff: sql/hive/v0.13.1/src/main/scala/org/apache/spark/sql/hive/Shim.scala --- @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-2706][SQL] Enable Spark to support Hive...

2014-10-04 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/2241#discussion_r18430480 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala --- @@ -212,7 +214,18 @@ private[hive] object HiveQl { /** * Returns the

[GitHub] spark pull request: [SPARK-2706][SQL] Enable Spark to support Hive...

2014-10-04 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/2241#discussion_r18430557 --- Diff: sql/hive/v0.13.1/src/main/scala/org/apache/spark/sql/hive/Shim.scala --- @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-2706][SQL] Enable Spark to support Hive...

2014-10-04 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/2241#discussion_r18430590 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala --- @@ -557,11 +557,14 @@ class HiveQuerySuite extends

[GitHub] spark pull request: [SPARK-2706][SQL] Enable Spark to support Hive...

2014-10-04 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/2241#discussion_r18430600 --- Diff: sql/hive/v0.12.0/src/main/scala/org/apache/spark/sql/hive/Shim.scala --- @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-2706][SQL] Enable Spark to support Hive...

2014-10-04 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/2241#discussion_r18430657 --- Diff: sql/hive/pom.xml --- @@ -119,6 +83,74 @@ profiles profile + idhive-default/id + activation +

[GitHub] spark pull request: [SPARK-2706][SQL] Enable Spark to support Hive...

2014-10-04 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/2241#discussion_r18431391 --- Diff: sql/hive/v0.13.1/src/main/scala/org/apache/spark/sql/hive/Shim.scala --- @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-2365] Add IndexedRDD, an efficient upda...

2014-10-04 Thread ankurdave
Github user ankurdave commented on the pull request: https://github.com/apache/spark/pull/1297#issuecomment-57917807 @MLnick It's a slight performance issue, since we currently use PrimitiveKeyOpenHashMap which optimizes for primitive keys by avoiding null tracking, but I think the

[GitHub] spark pull request: [SPARK-3798][SQL] Store the output of a genera...

2014-10-04 Thread marmbrus
GitHub user marmbrus opened a pull request: https://github.com/apache/spark/pull/2656 [SPARK-3798][SQL] Store the output of a generator in a val This prevents it from changing during serialization, leading to corrupted results. You can merge this pull request into a Git repository

[GitHub] spark pull request: [SQL] Add type checking debugging functions

2014-10-04 Thread marmbrus
GitHub user marmbrus opened a pull request: https://github.com/apache/spark/pull/2657 [SQL] Add type checking debugging functions Adds some functions that were very useful when trying to track down the bug from #2656. You can merge this pull request into a Git repository by

[GitHub] spark pull request: [Minor] Trivial fix to make codes more readabl...

2014-10-04 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/2654#issuecomment-57919211 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-3798][SQL] Store the output of a genera...

2014-10-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2656#issuecomment-57919209 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21296/consoleFull) for PR 2656 at commit

[GitHub] spark pull request: [SPARK-3792][SQL]enable JavaHiveQLSuite

2014-10-04 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/2652#issuecomment-57919225 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-1655][MLLIB] Add option for distributed...

2014-10-04 Thread staple
Github user staple commented on the pull request: https://github.com/apache/spark/pull/2491#issuecomment-57919277 @mengxr Ok, updated to address your suggestions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [Minor] Trivial fix to make codes more readabl...

2014-10-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2654#issuecomment-57919347 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21299/consoleFull) for PR 2654 at commit

[GitHub] spark pull request: [SQL] Add type checking debugging functions

2014-10-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2657#issuecomment-57919342 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21297/consoleFull) for PR 2657 at commit

[GitHub] spark pull request: [SPARK-1655][MLLIB] Add option for distributed...

2014-10-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2491#issuecomment-57919346 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21300/consoleFull) for PR 2491 at commit

[GitHub] spark pull request: [SPARK-3792][SQL]enable JavaHiveQLSuite

2014-10-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2652#issuecomment-57919345 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21298/consoleFull) for PR 2652 at commit

[GitHub] spark pull request: [SQL] Add type checking debugging functions

2014-10-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2657#issuecomment-57919377 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SQL] Add type checking debugging functions

2014-10-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2657#issuecomment-57919376 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21297/consoleFull) for PR 2657 at commit

[GitHub] spark pull request: [Minor] Trivial fix to make codes more readabl...

2014-10-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2654#issuecomment-57920602 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21299/consoleFull) for PR 2654 at commit

[GitHub] spark pull request: [SPARK-3792][SQL]enable JavaHiveQLSuite

2014-10-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2652#issuecomment-57920595 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21298/consoleFull) for PR 2652 at commit

[GitHub] spark pull request: [SPARK-3773][PySpark][Doc] Sphinx build warnin...

2014-10-04 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/2653#issuecomment-57920629 Jenkins, this is ok to test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-3798][SQL] Store the output of a genera...

2014-10-04 Thread mateiz
Github user mateiz commented on the pull request: https://github.com/apache/spark/pull/2656#issuecomment-57920689 Is there any way to add a unit test for this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-1655][MLLIB] Add option for distributed...

2014-10-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2491#issuecomment-57920705 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21300/consoleFull) for PR 2491 at commit

[GitHub] spark pull request: [SPARK-1655][MLLIB] Add option for distributed...

2014-10-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2491#issuecomment-57920707 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3773][PySpark][Doc] Sphinx build warnin...

2014-10-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2653#issuecomment-57920747 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21301/consoleFull) for PR 2653 at commit

[GitHub] spark pull request: [Minor] Trivial fix to make codes more readabl...

2014-10-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2654#issuecomment-57920603 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3792][SQL]enable JavaHiveQLSuite

2014-10-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2652#issuecomment-57920598 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3798][SQL] Store the output of a genera...

2014-10-04 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/2656#issuecomment-57920778 Unfortunately, I haven't found a way to reproduce it deterministically. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-1655][MLLIB] Add option for distributed...

2014-10-04 Thread staple
Github user staple commented on the pull request: https://github.com/apache/spark/pull/2491#issuecomment-57920855 Again, python tests failed because the python interface is disabled in order to focus on the scala implementation first. --- If your project is set up for it, you can

[GitHub] spark pull request: [SPARK-3597][Mesos] Implement `killTask`.

2014-10-04 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/2453#issuecomment-57921063 This looks good to me. I tested this patch against Mesos 0.20.1 running in Docker with a modified version of a test from Spark's JobCancellationSuite .

[GitHub] spark pull request: [SPARK-3765][Doc] add testing with sbt to docs

2014-10-04 Thread scwf
Github user scwf commented on the pull request: https://github.com/apache/spark/pull/2629#issuecomment-57921350 @JoshRosen, can you test this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-3765][Doc] add testing with sbt to docs

2014-10-04 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/2629#issuecomment-57921539 Jenkins, this is ok to test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-3765][Doc] add testing with sbt to docs

2014-10-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2629#issuecomment-57921605 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21302/consoleFull) for PR 2629 at commit

  1   2   >