Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/9207#issuecomment-152091359
re-ping @jkbradley
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/8587#discussion_r43352853
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/functions.scala
---
@@ -524,6 +525,116 @@ case class Sum(child:
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9346#issuecomment-152094846
**[Test build #44559 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44559/consoleFull)**
for PR 9346 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9350#issuecomment-152094171
**[Test build #44573 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44573/consoleFull)**
for PR 9350 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9351#issuecomment-152094813
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9351#issuecomment-152094900
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9326#issuecomment-152096108
**[Test build #44562 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44562/consoleFull)**
for PR 9326 at commit
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/9305#issuecomment-152097828
Thanks for the review. Will merge this to master pending Jenkins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9327#issuecomment-152098323
**[Test build #44578 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44578/consoleFull)**
for PR 9327 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9313#issuecomment-152107516
**[Test build #44567 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44567/consoleFull)**
for PR 9313 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9315#issuecomment-152110166
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9315#issuecomment-152110067
**[Test build #44576 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44576/consoleFull)**
for PR 9315 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9344#issuecomment-152085697
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9344#issuecomment-152085683
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9340#issuecomment-152085696
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9340#issuecomment-152085688
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user yinxusen commented on the pull request:
https://github.com/apache/spark/pull/9340#issuecomment-152087569
@pravingadakh You need to label `$example on$` and `$example off$` in
comments of example codes. Otherwise, the include_example cannot trim the code
snippt out.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/9344#issuecomment-152088973
/cc @davies @andrewor14 for review. This is still WIP pending some tests,
but the high-level design is ready for comments. I've posted a PR description
to help guide
Github user yinxusen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9340#discussion_r43352124
--- Diff:
examples/src/main/java/org/apache/spark/examples/mllib/JavaPrefixSpanExample.java
---
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9241#issuecomment-152089228
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9241#issuecomment-152089158
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9241#issuecomment-152089469
**[Test build #1960 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1960/consoleFull)**
for PR 9241 at commit
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/9340#issuecomment-152090442
@yinxusen I will do the changes mentioned. I am confused about one thing
though, FPGrowth examples are already available in scala and java language, and
it's
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9350#issuecomment-152092650
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9350#issuecomment-152092670
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9349#issuecomment-152092653
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9340#issuecomment-152092324
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9340#issuecomment-152092320
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user watermen commented on the pull request:
https://github.com/apache/spark/pull/9349#issuecomment-152092774
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user yinxusen commented on the pull request:
https://github.com/apache/spark/pull/9340#issuecomment-152092666
@pravingadakh I perfer to use the existing example code. @mengxr What is
your opinion?
---
If your project is set up for it, you can reply to this email and have your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9351#issuecomment-152096373
**[Test build #44574 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44574/consoleFull)**
for PR 9351 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9348#issuecomment-152096399
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9351#issuecomment-152099069
**[Test build #44574 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44574/consoleFull)**
for PR 9351 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9351#issuecomment-152099105
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9351#issuecomment-152099107
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/9327#issuecomment-152099924
@HyukjinKwon Could you please add a test for this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9350#issuecomment-152100905
**[Test build #44573 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44573/consoleFull)**
for PR 9350 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9350#issuecomment-152100950
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/9348#discussion_r43355402
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -417,6 +417,14 @@ object NullPropagation extends
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/9339#issuecomment-152105287
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9339#discussion_r43357280
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkAppHandle.java ---
@@ -19,7 +19,7 @@
/**
* A handle to a running Spark
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9339#issuecomment-152105767
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9347#issuecomment-152106481
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9347#issuecomment-152106479
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9206#issuecomment-152106496
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9313#issuecomment-152107622
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/8374#discussion_r43359470
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala ---
@@ -278,3 +285,59 @@ case object MsSqlServerDialect extends JdbcDialect {
Github user maropu commented on the pull request:
https://github.com/apache/spark/pull/8374#issuecomment-152111324
Great work! I left some trivial comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9241#issuecomment-152111686
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
GitHub user sureshthalamati opened a pull request:
https://github.com/apache/spark/pull/9352
[SPARK-10849][SQL] Adding field metadata property to override default jdbc
data source type mapping.
This patch allows users to override default type mapping of data frame
field to
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9352#issuecomment-152112655
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9241#issuecomment-152112891
**[Test build #44572 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44572/consoleFull)**
for PR 9241 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9241#issuecomment-152112973
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9305#issuecomment-152114395
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9348#issuecomment-152116291
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user wzhfy commented on the pull request:
https://github.com/apache/spark/pull/9349#issuecomment-152116547
@davies
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9348#issuecomment-152116289
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/9340#issuecomment-152118502
@yinxusen When you say use the existing example code, you mean the one in
the doc or the one which is readily available in examples directory?
---
If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9206#issuecomment-152123057
**[Test build #44584 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44584/consoleFull)**
for PR 9206 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9241#issuecomment-152126836
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9339#issuecomment-152127091
**[Test build #44581 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44581/consoleFull)**
for PR 9339 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9241#issuecomment-152126838
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9339#issuecomment-152127164
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9339#issuecomment-152127163
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9305#issuecomment-152114268
**[Test build #44577 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44577/consoleFull)**
for PR 9305 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9305#issuecomment-152114396
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9327#issuecomment-152116901
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9327#issuecomment-152116722
**[Test build #44578 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44578/consoleFull)**
for PR 9327 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9327#issuecomment-152116900
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/9291#issuecomment-152128296
+1 to @holdenk's comment. If you're changing all invocations of
`makePageLink` it might be easier to just change `makePageLink` itself.
---
If your project is set up
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9241#issuecomment-152112976
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user BrickXu commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-152114579
@tnachen thanks very much, I will merge this PR in our private spark repo,
and report issues ASAP if it does not work well.
Thanks again!
---
If your project is
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9348#issuecomment-152116062
**[Test build #44575 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44575/consoleFull)**
for PR 9348 at commit
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/9206#issuecomment-152118828
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9206#issuecomment-152119412
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9206#issuecomment-152119345
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/9237#issuecomment-152122635
I'm a little worried that disabling `SO_REUSEADDR` might cause ugly log
messages when you start applications back to back... aside from avoiding
inadvertently running
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9182#discussion_r43363947
--- Diff:
yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnSchedulerBackend.scala
---
@@ -51,6 +51,41 @@ private[spark] abstract class
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9241#issuecomment-152126730
**[Test build #44579 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44579/consoleFull)**
for PR 9241 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9315#issuecomment-152131556
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/9348#discussion_r43367492
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/OptimizeInSuite.scala
---
@@ -36,6 +36,7 @@ class OptimizeInSuite extends
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/9337#issuecomment-152136227
Thanks, merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/9232#discussion_r43368611
--- Diff:
yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnSparkHadoopUtilSuite.scala
---
@@ -245,4 +247,55 @@ class YarnSparkHadoopUtilSuite
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/9232#discussion_r43369014
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -1337,55 +1337,9 @@ object Client extends Logging {
conf:
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9311#issuecomment-152138352
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9311#issuecomment-152138354
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/9308#discussion_r43369777
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -1870,4 +1870,19 @@ class SQLQuerySuite extends QueryTest with
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/9352#issuecomment-152142416
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9352#issuecomment-152145309
**[Test build #44586 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44586/consoleFull)**
for PR 9352 at commit
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/9330#issuecomment-152145164
Thanks, merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9315#issuecomment-152131558
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9315#issuecomment-152131433
**[Test build #44580 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44580/consoleFull)**
for PR 9315 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9206#issuecomment-152134493
**[Test build #44583 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44583/consoleFull)**
for PR 9206 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9206#issuecomment-152134636
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9206#issuecomment-152134637
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/9348#discussion_r43367315
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -417,6 +417,14 @@ object NullPropagation extends
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/9339#issuecomment-152135261
jenkins retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/9339#issuecomment-152135237
Hmmm, test fails with the following beautiful error:
[error] (core/test:test) sbt.TestsFailedException: Tests unsuccessful
[error] Total time:
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9311#issuecomment-152135568
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9311#issuecomment-152135541
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
701 - 800 of 930 matches
Mail list logo
