Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9165#issuecomment-156670070
**[Test build #2058 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2058/consoleFull)**
for PR 9165 at commit
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9550#issuecomment-156669939
OK, that seems fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user jackieMaKing commented on the pull request:
https://github.com/apache/spark/pull/9649#issuecomment-156671960
cloud-fun, I have add a test for SPARK-11679 in JavaDataFrameSuite.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9660
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9715#issuecomment-156687355
**[Test build #45928 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45928/consoleFull)**
for PR 9715 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9715#issuecomment-156687376
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9715#issuecomment-156687377
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9714#issuecomment-156690358
**[Test build #2059 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2059/consoleFull)**
for PR 9714 at commit
Github user alberskib commented on the pull request:
https://github.com/apache/spark/pull/9642#issuecomment-156692847
After rebasing to current master all tests are passing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9264#discussion_r44856629
--- Diff:
core/src/test/scala/org/apache/spark/rdd/AsyncRDDActionsSuite.scala ---
@@ -27,7 +27,7 @@ import org.scalatest.BeforeAndAfterAll
import
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9264#discussion_r44856637
--- Diff:
core/src/test/scala/org/apache/spark/rdd/AsyncRDDActionsSuite.scala ---
@@ -197,4 +197,50 @@ class AsyncRDDActionsSuite extends SparkFunSuite with
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9591#issuecomment-156676336
**[Test build #45925 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45925/consoleFull)**
for PR 9591 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9591#issuecomment-156676360
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9591#issuecomment-156676358
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/9649#issuecomment-156678981
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9712#issuecomment-156679591
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user vectorijk commented on the pull request:
https://github.com/apache/spark/pull/9715#issuecomment-156682594
cc @srowen @jaceklaskowski
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9715#issuecomment-156685241
**[Test build #45928 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45928/consoleFull)**
for PR 9715 at commit
Github user vectorijk commented on a diff in the pull request:
https://github.com/apache/spark/pull/8795#discussion_r44857345
--- Diff: docs/configuration.md ---
@@ -330,13 +330,13 @@ Apart from these, the following properties are also
available, and may be useful
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9715
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/9642#issuecomment-156693107
```UnsafeRow``` and ```SpecificRow``` have similar problems. Shouldn't we
fix those as well? For example:
import org.apache.spark.sql.types.IntegerType
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9264#discussion_r44856616
--- Diff: core/src/main/scala/org/apache/spark/FutureAction.scala ---
@@ -276,10 +219,11 @@ class ComplexFutureAction[T] extends FutureAction[T] {
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9264#discussion_r44856609
--- Diff: core/src/main/scala/org/apache/spark/rdd/AsyncRDDActions.scala ---
@@ -95,19 +102,18 @@ class AsyncRDDActions[T: ClassTag](self: RDD[T])
extends
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9264#discussion_r44856611
--- Diff: core/src/main/scala/org/apache/spark/rdd/AsyncRDDActions.scala ---
@@ -66,14 +65,22 @@ class AsyncRDDActions[T: ClassTag](self: RDD[T])
extends
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/9660#issuecomment-156681414
Thanks! Merging to master and branch-1.6.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9715#issuecomment-156684153
Good catch. A quick search suggests that's all of them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8795#discussion_r44857336
--- Diff: docs/configuration.md ---
@@ -330,13 +330,13 @@ Apart from these, the following properties are also
available, and may be useful
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9550#issuecomment-156690488
Merged to master/1.6
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9649#issuecomment-156690535
**[Test build #45927 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45927/consoleFull)**
for PR 9649 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9550
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9649#issuecomment-156690562
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9264#discussion_r44856623
--- Diff: core/src/main/scala/org/apache/spark/FutureAction.scala ---
@@ -177,80 +150,50 @@ class SimpleFutureAction[T] private[spark](jobWaiter:
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9264#discussion_r44856621
--- Diff: core/src/main/scala/org/apache/spark/FutureAction.scala ---
@@ -177,80 +150,50 @@ class SimpleFutureAction[T] private[spark](jobWaiter:
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9264#discussion_r44856628
--- Diff: core/src/main/scala/org/apache/spark/FutureAction.scala ---
@@ -116,57 +119,27 @@ class SimpleFutureAction[T] private[spark](jobWaiter:
GitHub user RohanBhanderi opened a pull request:
https://github.com/apache/spark/pull/9714
Typo in comment: use 2 seconds instead of 1
Use 2 seconds batch size as duration specified in JavaStreamingContext
constructor is 2000 ms
You can merge this pull request into a Git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9712#issuecomment-156679559
**[Test build #45926 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45926/consoleFull)**
for PR 9712 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9712#issuecomment-156679592
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user vectorijk commented on a diff in the pull request:
https://github.com/apache/spark/pull/8795#discussion_r44857202
--- Diff: docs/configuration.md ---
@@ -330,13 +330,13 @@ Apart from these, the following properties are also
available, and may be useful
Github user vectorijk commented on a diff in the pull request:
https://github.com/apache/spark/pull/8795#discussion_r44857200
--- Diff: docs/configuration.md ---
@@ -305,7 +305,7 @@ Apart from these, the following properties are also
available, and may be useful
daily
Github user vectorijk commented on a diff in the pull request:
https://github.com/apache/spark/pull/8795#discussion_r44857214
--- Diff: docs/configuration.md ---
@@ -330,13 +330,13 @@ Apart from these, the following properties are also
available, and may be useful
Github user vectorijk commented on a diff in the pull request:
https://github.com/apache/spark/pull/8795#discussion_r44857212
--- Diff: docs/configuration.md ---
@@ -330,13 +330,13 @@ Apart from these, the following properties are also
available, and may be useful
GitHub user vectorijk opened a pull request:
https://github.com/apache/spark/pull/9715
[MINOR] [Docs] typo in docs/configuration.md
`<\code>` end tag missing backslash in
docs/configuration.md{L308-L339}
ref #8795
You can merge this pull request into a Git repository
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9716#issuecomment-156687789
**[Test build #45929 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45929/consoleFull)**
for PR 9716 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9649#issuecomment-156690563
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9714#issuecomment-156691120
**[Test build #2059 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2059/consoleFull)**
for PR 9714 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9714#issuecomment-156673111
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9649#issuecomment-156680024
**[Test build #45927 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45927/consoleFull)**
for PR 9649 at commit
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9714#issuecomment-156679953
OK. Any other comments like this that need a fix? might be worth looking at
related files.
---
If your project is set up for it, you can reply to this email and have
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/9658#discussion_r44857287
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetIOSuite.scala
---
@@ -230,6 +230,31 @@ class ParquetIOSuite
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/9658#discussion_r44857285
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetIOSuite.scala
---
@@ -230,6 +230,31 @@ class ParquetIOSuite
GitHub user yinxusen opened a pull request:
https://github.com/apache/spark/pull/9716
[SPARK-11728] Replace example code in ml-ensembles.md using include_example
JIRA issue https://issues.apache.org/jira/browse/SPARK-11728.
The ml-ensembles.md file contains
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9716#issuecomment-156689964
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9716#issuecomment-156689963
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9716#issuecomment-156689941
**[Test build #45929 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45929/consoleFull)**
for PR 9716 at commit
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9715#issuecomment-156690391
Merged to master/1.6
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/9613#discussion_r44867038
--- Diff: R/pkg/R/generics.R ---
@@ -971,6 +986,9 @@ setGeneric("size", function(x) {
standardGeneric("size") })
#' @export
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/9613#discussion_r44867045
--- Diff: R/pkg/R/DataFrame.R ---
@@ -2200,4 +2200,101 @@ setMethod("coltypes",
rTypes[naIndices] <- types[naIndices]
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9703
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/9712#discussion_r44867544
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/RowEncoderSuite.scala
---
@@ -68,7 +117,36 @@ class RowEncoderSuite extends
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/9703#issuecomment-156781368
I've merged this in master and branch-1.6.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9718#issuecomment-156783662
**[Test build #45946 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45946/consoleFull)**
for PR 9718 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9272#issuecomment-156784631
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9272#issuecomment-156784614
**[Test build #45944 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45944/consoleFull)**
for PR 9272 at commit
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9542#discussion_r44866975
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveUDFSuite.scala
---
@@ -356,6 +356,66 @@ class HiveUDFSuite extends QueryTest with
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9542#discussion_r44866968
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveUDFSuite.scala
---
@@ -356,6 +356,66 @@ class HiveUDFSuite extends QueryTest with
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9542#discussion_r44866981
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveUDFSuite.scala
---
@@ -356,6 +356,66 @@ class HiveUDFSuite extends QueryTest with
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/9613#discussion_r44867068
--- Diff: R/pkg/R/DataFrame.R ---
@@ -2200,4 +2200,101 @@ setMethod("coltypes",
rTypes[naIndices] <- types[naIndices]
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9700#issuecomment-156777353
**[Test build #45943 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45943/consoleFull)**
for PR 9700 at commit
GitHub user mengxr opened a pull request:
https://github.com/apache/spark/pull/9719
[SPARK-11672] [ML] set active SQLContext in JavaDefaultReadWriteSuite
The same as #9694, but for Java test suite.
You can merge this pull request into a Git repository by running:
$ git pull
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9718#issuecomment-156789219
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9718#issuecomment-156789202
**[Test build #45946 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45946/consoleFull)**
for PR 9718 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9718#issuecomment-156789220
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9272#issuecomment-156774463
**[Test build #45944 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45944/consoleFull)**
for PR 9272 at commit
Github user yolandagao commented on the pull request:
https://github.com/apache/spark/pull/9272#issuecomment-156774495
Thank you Yin for the review. Updated the comments accordingly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9703#issuecomment-156775586
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/9613#discussion_r44867029
--- Diff: R/pkg/R/DataFrame.R ---
@@ -2200,4 +2200,101 @@ setMethod("coltypes",
rTypes[naIndices] <- types[naIndices]
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9718#issuecomment-156775646
**[Test build #45945 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45945/consoleFull)**
for PR 9718 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9703#issuecomment-156775585
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9718#issuecomment-156783007
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9718#issuecomment-156782998
**[Test build #45945 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45945/consoleFull)**
for PR 9718 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9718#issuecomment-156783008
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/9437#issuecomment-156787029
I don't think `collectAsync` and `countAsync` cause this issue.
It's because `takeAsync` calls `ComplexFutureAction#run`.
---
If your project is set up for it, you
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9700#issuecomment-156771080
**[Test build #45943 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45943/consoleFull)**
for PR 9700 at commit
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/9272#issuecomment-156775010
LGTM pending jenkins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9703#issuecomment-156775574
**[Test build #45941 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45941/consoleFull)**
for PR 9703 at commit
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/9613#discussion_r44867049
--- Diff: R/pkg/R/DataFrame.R ---
@@ -2200,4 +2200,101 @@ setMethod("coltypes",
rTypes[naIndices] <- types[naIndices]
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/9613#discussion_r44867056
--- Diff: R/pkg/R/DataFrame.R ---
@@ -2200,4 +2200,101 @@ setMethod("coltypes",
rTypes[naIndices] <- types[naIndices]
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/9613#discussion_r44867054
--- Diff: R/pkg/R/DataFrame.R ---
@@ -2200,4 +2200,101 @@ setMethod("coltypes",
rTypes[naIndices] <- types[naIndices]
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9700#issuecomment-156777598
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9700#issuecomment-156777595
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9272#issuecomment-156784632
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9542#discussion_r44866992
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveUDFSuite.scala
---
@@ -356,6 +356,66 @@ class HiveUDFSuite extends QueryTest with
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9542#discussion_r44866994
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveUDFSuite.scala
---
@@ -356,6 +356,66 @@ class HiveUDFSuite extends QueryTest with
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9542#discussion_r44866988
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveUDFSuite.scala
---
@@ -356,6 +356,66 @@ class HiveUDFSuite extends QueryTest with
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/9542#issuecomment-156775499
@xwu0226 Looks good! I left a few comments regarding the format.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9542#discussion_r44866996
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveUDFSuite.scala
---
@@ -356,6 +356,66 @@ class HiveUDFSuite extends QueryTest with
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9542#discussion_r44866990
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveUDFSuite.scala
---
@@ -356,6 +356,66 @@ class HiveUDFSuite extends QueryTest with
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9542#discussion_r44866993
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveUDFSuite.scala
---
@@ -356,6 +356,66 @@ class HiveUDFSuite extends QueryTest with
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9542#discussion_r44866986
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveUDFSuite.scala
---
@@ -356,6 +356,66 @@ class HiveUDFSuite extends QueryTest with
Github user alberskib commented on the pull request:
https://github.com/apache/spark/pull/9642#issuecomment-156694329
Hey @hvanhovell ! Thanks for the comment. I agree with you that if we want
to introduce this change we need to take care of `UnsafeRow` and `SpecificRow`
as well.
1 - 100 of 207 matches
Mail list logo
