[GitHub] spark pull request: [SPARK-12094][SQL] Prettier tree string for Tr...

2015-12-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10099#issuecomment-161313910 **[Test build #47063 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47063/consoleFull)** for PR 10099 at commit

[GitHub] spark pull request: [SPARK-12044] [SparkR] Fix usage of isnan, isn...

2015-12-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10037#issuecomment-161313328 **[Test build #47065 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47065/consoleFull)** for PR 10037 at commit

[GitHub] spark pull request: [SPARK-12044] [SparkR] Fix usage of isnan, isn...

2015-12-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10037#issuecomment-161313652 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12096] [MLlib] remove the old constrain...

2015-12-02 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/10103#issuecomment-161329692 OK, seems reasonable --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-12074] Avoid memory copy involving Byte...

2015-12-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10069#issuecomment-161345176 **[Test build #47070 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47070/consoleFull)** for PR 10069 at commit

[GitHub] spark pull request: [SPARK-12074] Avoid memory copy involving Byte...

2015-12-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10069#issuecomment-161345183 Build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-12094][SQL] Prettier tree string for Tr...

2015-12-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10099#issuecomment-161314258 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10585][SQL] only copy data once when ge...

2015-12-02 Thread tyro89
Github user tyro89 commented on the pull request: https://github.com/apache/spark/pull/8747#issuecomment-161338170 I believe there might be an issue here with respect to the buffer growing strategy: https://issues.apache.org/jira/browse/SPARK-12089 --- If your project is set up for

[GitHub] spark pull request: [SPARK-12073] [Streaming] backpressure rate co...

2015-12-02 Thread koeninger
Github user koeninger commented on a diff in the pull request: https://github.com/apache/spark/pull/10089#discussion_r46431401 --- Diff: external/kafka/src/test/scala/org/apache/spark/streaming/kafka/DirectKafkaStreamSuite.scala --- @@ -364,8 +365,8 @@ class

[GitHub] spark pull request: [SPARK-12073] [Streaming] backpressure rate co...

2015-12-02 Thread koeninger
Github user koeninger commented on a diff in the pull request: https://github.com/apache/spark/pull/10089#discussion_r46431493 --- Diff: external/kafka/src/test/scala/org/apache/spark/streaming/kafka/DirectKafkaStreamSuite.scala --- @@ -36,9 +36,10 @@ import

[GitHub] spark pull request: [SPARK-11314] [YARN] add service API and test ...

2015-12-02 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/9182#discussion_r46434094 --- Diff: yarn/src/test/scala/org/apache/spark/scheduler/cluster/ExtensionServiceIntegrationSuite.scala --- @@ -0,0 +1,87 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-12000] [Build] remove scala-compiler an...

2015-12-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10071#issuecomment-161318754 **[Test build #47059 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47059/consoleFull)** for PR 10071 at commit

[GitHub] spark pull request: [SPARK-12000] [Build] remove scala-compiler an...

2015-12-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10071#issuecomment-161318946 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10749][MESOS] Support multiple roles wi...

2015-12-02 Thread dragos
Github user dragos commented on the pull request: https://github.com/apache/spark/pull/8872#issuecomment-161336155 So, I like the code as it is now. I'm having trouble running Spark on Mesos in cluster mode, as always, so I didn't manage to test it, but that's most likely unrelated

[GitHub] spark pull request: [SPARK-10266][Documentation, ML] Fixed @Since ...

2015-12-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9338#issuecomment-161336585 **[Test build #47069 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47069/consoleFull)** for PR 9338 at commit

[GitHub] spark pull request: [SPARK-12074] Avoid memory copy involving Byte...

2015-12-02 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/spark/pull/10069#discussion_r46429985 --- Diff: core/src/main/scala/org/apache/spark/scheduler/Task.scala --- @@ -193,7 +192,7 @@ private[spark] object Task { dataOut.flush() val

[GitHub] spark pull request: [SPARK-12074] Avoid memory copy involving Byte...

2015-12-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10069#issuecomment-161345184 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12073] [Streaming] backpressure rate co...

2015-12-02 Thread koeninger
Github user koeninger commented on the pull request: https://github.com/apache/spark/pull/10089#issuecomment-161352747 This generally looks sensible to me, would like to see if it solves your issue first. Thanks for working on it. --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-12096] [MLlib] remove the old constrain...

2015-12-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10103#issuecomment-161327890 **[Test build #47066 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47066/consoleFull)** for PR 10103 at commit

[GitHub] spark pull request: Add links howto to setup IDEs for developing s...

2015-12-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/10104#discussion_r46429689 --- Diff: README.md --- @@ -27,6 +27,8 @@ To build Spark and its example programs, run: (You do not need to do this if you downloaded a pre-built

[GitHub] spark pull request: [SPARK-9778][SQL] remove unnecessary evaluatio...

2015-12-02 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/8066#issuecomment-161340834 Hi @marmbrus , I updated it and did some simplification, could you take a look? Thanks! --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-10266][Documentation, ML] Fixed @Since ...

2015-12-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9338#issuecomment-161350879 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12096] [MLlib] remove the old constrain...

2015-12-02 Thread hhbyyh
GitHub user hhbyyh opened a pull request: https://github.com/apache/spark/pull/10103 [SPARK-12096] [MLlib] remove the old constraint in word2vec jira: https://issues.apache.org/jira/browse/SPARK-12096 word2vec now can handle much bigger vocabulary. The old constraint

[GitHub] spark pull request: [SPARK][SPARK-10842]Eliminate creating duplica...

2015-12-02 Thread squito
Github user squito commented on the pull request: https://github.com/apache/spark/pull/8923#issuecomment-161311392 @suyanNone still needs the test case --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-12073] [Streaming] backpressure rate co...

2015-12-02 Thread koeninger
Github user koeninger commented on a diff in the pull request: https://github.com/apache/spark/pull/10089#discussion_r46431828 --- Diff: external/kafka/src/main/scala/org/apache/spark/streaming/kafka/DirectKafkaInputDStream.scala --- @@ -89,23 +89,29 @@ class

[GitHub] spark pull request: [SPARK-12073] [Streaming] backpressure rate co...

2015-12-02 Thread koeninger
Github user koeninger commented on a diff in the pull request: https://github.com/apache/spark/pull/10089#discussion_r46438227 --- Diff: external/kafka/src/main/scala/org/apache/spark/streaming/kafka/DirectKafkaInputDStream.scala --- @@ -89,23 +89,29 @@ class

[GitHub] spark pull request: [SPARK-11395][SPARKR] Support over and window ...

2015-12-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10094#issuecomment-161328065 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12096] [MLlib] remove the old constrain...

2015-12-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10103#issuecomment-161328139 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11395][SPARKR] Support over and window ...

2015-12-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10094#issuecomment-161328381 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11314] [YARN] add service API and test ...

2015-12-02 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/9182#discussion_r46432466 --- Diff: yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnSchedulerBackend.scala --- @@ -51,6 +51,64 @@ private[spark] abstract class

[GitHub] spark pull request: [SPARK-12044] [SparkR] Fix usage of isnan, isn...

2015-12-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10037#issuecomment-161313648 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12094][SQL] Prettier tree string for Tr...

2015-12-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10099#issuecomment-161314262 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12096] [MLlib] remove the old constrain...

2015-12-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10103#issuecomment-161314416 **[Test build #47066 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47066/consoleFull)** for PR 10103 at commit

[GitHub] spark pull request: Add links howto to setup IDEs for developing s...

2015-12-02 Thread kaklakariada
GitHub user kaklakariada opened a pull request: https://github.com/apache/spark/pull/10104 Add links howto to setup IDEs for developing spark These links make it easier for new developers to work with Spark in their IDE. You can merge this pull request into a Git repository by

[GitHub] spark pull request: [SPARK-12000] [Build] remove scala-compiler an...

2015-12-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10071#issuecomment-161318950 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4681] Enable executor blacklisting by d...

2015-12-02 Thread squito
Github user squito commented on the pull request: https://github.com/apache/spark/pull/10045#issuecomment-161324412 :open_mouth: wow that is definitely not a situation I had given a lot of thought to :) But would you agree this is a special case, behavior that a user would have

[GitHub] spark pull request: [SPARK-11395][SPARKR] Support over and window ...

2015-12-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10094#issuecomment-161328382 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12074] Avoid memory copy involving Byte...

2015-12-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10069#issuecomment-161343250 **[Test build #47070 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47070/consoleFull)** for PR 10069 at commit

[GitHub] spark pull request: [SPARK-9778][SQL] remove unnecessary evaluatio...

2015-12-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8066#issuecomment-161343319 **[Test build #47071 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47071/consoleFull)** for PR 8066 at commit

[GitHub] spark pull request: [SPARK-12081] Make unified memory manager work...

2015-12-02 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/spark/pull/10081#discussion_r46432025 --- Diff: core/src/main/scala/org/apache/spark/memory/UnifiedMemoryManager.scala --- @@ -130,6 +130,12 @@ private[spark] class UnifiedMemoryManager

[GitHub] spark pull request: [SPARK-10266][Documentation, ML] Fixed @Since ...

2015-12-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9338#issuecomment-161350874 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10266][Documentation, ML] Fixed @Since ...

2015-12-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9338#issuecomment-161350650 **[Test build #47069 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47069/consoleFull)** for PR 9338 at commit

[GitHub] spark pull request: [SPARK-12096] [MLlib] remove the old constrain...

2015-12-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10103#issuecomment-161328137 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11395][SPARKR] Support over and window ...

2015-12-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10094#issuecomment-161328379 **[Test build #47068 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47068/consoleFull)** for PR 10094 at commit

[GitHub] spark pull request: [SPARK-11395][SPARKR] Support over and window ...

2015-12-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10094#issuecomment-161327831 **[Test build #47068 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47068/consoleFull)** for PR 10094 at commit

[GitHub] spark pull request: [SPARK-11395][SPARKR] Support over and window ...

2015-12-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10094#issuecomment-161328068 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: Add links howto to setup IDEs for developing s...

2015-12-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10104#issuecomment-161336649 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-5929] Pyspark: Register a pip requireme...

2015-12-02 Thread DoHe
Github user DoHe commented on the pull request: https://github.com/apache/spark/pull/4897#issuecomment-161336531 For the test you could also add a local egg file to the repository and install this instead of relying on the external pypi server. --- If your project is set up for it,

[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...

2015-12-02 Thread dskrvk
Github user dskrvk commented on the pull request: https://github.com/apache/spark/pull/9867#issuecomment-161337172 Thanks @rxin. Would appreciate a "Ship it" on this (unless there are issues). Don't mean to whine, but the longer we wait, the bigger this PR becomes as I have to fix

[GitHub] spark pull request: [SPARK-11605] [MLlib] ML 1.6 QA: API: Java com...

2015-12-02 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/10102#discussion_r46431705 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/stat/test/StreamingTest.scala --- @@ -17,13 +17,31 @@ package

[GitHub] spark pull request: [SPARK-11314] [YARN] add service API and test ...

2015-12-02 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/9182#discussion_r46432648 --- Diff: yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnSchedulerBackend.scala --- @@ -51,6 +51,64 @@ private[spark] abstract class

[GitHub] spark pull request: [SPARK-11314] [YARN] add service API and test ...

2015-12-02 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/9182#discussion_r46433390 --- Diff: yarn/src/main/scala/org/apache/spark/scheduler/cluster/SchedulerExtensionService.scala --- @@ -0,0 +1,158 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-11314] [YARN] add service API and test ...

2015-12-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9182#issuecomment-16135 **[Test build #47072 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47072/consoleFull)** for PR 9182 at commit

[GitHub] spark pull request: [SPARK-9778][SQL] remove unnecessary evaluatio...

2015-12-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8066#issuecomment-161388544 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12098] Cross validator with multi-arm b...

2015-12-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10105#issuecomment-161392614 **[Test build #47075 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47075/consoleFull)** for PR 10105 at commit

[GitHub] spark pull request: [SPARK-12098] Cross validator with multi-arm b...

2015-12-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10105#issuecomment-161392709 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12094][SQL] Prettier tree string for Tr...

2015-12-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10099 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-11293] Fix shuffle memory leaks in Spil...

2015-12-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9427#issuecomment-161375635 [Test build #2150 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2150/consoleFull) for PR 9427 at commit

[GitHub] spark pull request: [SPARK-12084][Core]Fix codes that uses ByteBuf...

2015-12-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10083#issuecomment-161385655 **[Test build #47077 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47077/consoleFull)** for PR 10083 at commit

[GitHub] spark pull request: [SPARK-9778][SQL] remove unnecessary evaluatio...

2015-12-02 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/8066#discussion_r46452046 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/SortOptimizeSuite.scala --- @@ -0,0 +1,128 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-9778][SQL] remove unnecessary evaluatio...

2015-12-02 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/8066#discussion_r46452998 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -919,3 +920,63 @@ object

[GitHub] spark pull request: [SPARK-12040][PYSPARK][MLLIB] add toJson & fro...

2015-12-02 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/10106#issuecomment-161394118 cc @yanboliang who created the Jira --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-12032] [SQL] Re-order inner joins to do...

2015-12-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10073#issuecomment-161378117 **[Test build #2151 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2151/consoleFull)** for PR 10073 at commit

[GitHub] spark pull request: [SPARK-12084][Core]Fix codes that uses ByteBuf...

2015-12-02 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/10083#discussion_r46448867 --- Diff: examples/src/main/scala/org/apache/spark/examples/pythonconverters/AvroConverters.scala --- @@ -79,7 +79,10 @@ object AvroConversionUtil extends

[GitHub] spark pull request: [SPARK-12073] [Streaming] backpressure rate co...

2015-12-02 Thread JasonMWhite
Github user JasonMWhite commented on a diff in the pull request: https://github.com/apache/spark/pull/10089#discussion_r46449571 --- Diff: external/kafka/src/main/scala/org/apache/spark/streaming/kafka/DirectKafkaInputDStream.scala --- @@ -89,23 +89,29 @@ class

[GitHub] spark pull request: [SPARK-12073] [Streaming] backpressure rate co...

2015-12-02 Thread JasonMWhite
Github user JasonMWhite commented on a diff in the pull request: https://github.com/apache/spark/pull/10089#discussion_r46449467 --- Diff: external/kafka/src/test/scala/org/apache/spark/streaming/kafka/DirectKafkaStreamSuite.scala --- @@ -364,8 +365,8 @@ class

[GitHub] spark pull request: [SPARK-12073] [Streaming] backpressure rate co...

2015-12-02 Thread JasonMWhite
Github user JasonMWhite commented on a diff in the pull request: https://github.com/apache/spark/pull/10089#discussion_r46449516 --- Diff: external/kafka/src/test/scala/org/apache/spark/streaming/kafka/DirectKafkaStreamSuite.scala --- @@ -36,9 +36,10 @@ import

[GitHub] spark pull request: [SPARK-12078][Core]Fix ByteBuffer.limit misuse

2015-12-02 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/10076#issuecomment-161387484 I want to put this one on hold until #10083 gets merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-11624][SPARK-11972][SQL]fix commands th...

2015-12-02 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/9589#issuecomment-161387321 Unfortunately RC1 has been cut already and changes to initialization are too likely to break things at this point. --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-12091] [PYSPARK] [Minor] Default storag...

2015-12-02 Thread mateiz
Github user mateiz commented on the pull request: https://github.com/apache/spark/pull/10092#issuecomment-161365442 It might be nice to only expose a smaller # of storage levels in Python, i.e. call them memory_only and memory_and_disk, but always use the serialized ones underneath.

[GitHub] spark pull request: [SPARK-4681] Enable executor blacklisting by d...

2015-12-02 Thread mridulm
Github user mridulm commented on the pull request: https://github.com/apache/spark/pull/10045#issuecomment-161370485 Sure, I am fine with it not being default behavior - but there should be some way to override the default behavior. For example here, as long as there exists a way to

[GitHub] spark pull request: [SPARK-12094][SQL] Prettier tree string for Tr...

2015-12-02 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/10099#issuecomment-161374655 Merging to master and branch 1.6. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-12084][Core]Fix codes that uses ByteBuf...

2015-12-02 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/10083#discussion_r46451232 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/UnsafeRowParquetRecordReader.java --- @@ -334,10 +334,11 @@ private

[GitHub] spark pull request: [SPARK-11624][SPARK-11972][SQL]fix commands th...

2015-12-02 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9589#discussion_r46451745 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/ClientWrapper.scala --- @@ -151,29 +152,34 @@ private[hive] class ClientWrapper(

[GitHub] spark pull request: [SPARK-9778][SQL] remove unnecessary evaluatio...

2015-12-02 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/8066#discussion_r46452734 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/SortOptimizeSuite.scala --- @@ -0,0 +1,128 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-12032] [SQL] Re-order inner joins to do...

2015-12-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10073#issuecomment-161390668 **[Test build #2151 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2151/consoleFull)** for PR 10073 at commit

[GitHub] spark pull request: [SPARK-12098] Cross validator with multi-arm b...

2015-12-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10105#issuecomment-161392711 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12032] [SQL] Re-order inner joins to do...

2015-12-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10073#issuecomment-161386298 **[Test build #47076 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47076/consoleFull)** for PR 10073 at commit

[GitHub] spark pull request: [SPARK-9778][SQL] remove unnecessary evaluatio...

2015-12-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8066#issuecomment-161359505 **[Test build #47073 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47073/consoleFull)** for PR 8066 at commit

[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...

2015-12-02 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/9867#issuecomment-161371851 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...

2015-12-02 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/9867#issuecomment-161371987 Hey @dskrvk, sorry to let this slip through the cracks. I'm going to shepherd this today to try to get it merged. --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-9778][SQL] remove unnecessary evaluatio...

2015-12-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8066#issuecomment-161373647 **[Test build #47071 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47071/consoleFull)** for PR 8066 at commit

[GitHub] spark pull request: [SPARK-9778][SQL] remove unnecessary evaluatio...

2015-12-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8066#issuecomment-161373888 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...

2015-12-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9867#issuecomment-161373793 **[Test build #47074 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47074/consoleFull)** for PR 9867 at commit

[GitHub] spark pull request: [SPARK-9778][SQL] remove unnecessary evaluatio...

2015-12-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8066#issuecomment-161373891 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12098] Cross validator with multi-arm b...

2015-12-02 Thread yinxusen
GitHub user yinxusen opened a pull request: https://github.com/apache/spark/pull/10105 [SPARK-12098] Cross validator with multi-arm bandit search https://issues.apache.org/jira/browse/SPARK-12098 The classic cross-validation requires all inner classifiers iterate to a

[GitHub] spark pull request: [SPARK-11949][SQL] Check bitmasks to set nulla...

2015-12-02 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/10067#issuecomment-161388052 no problem! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-9778][SQL] remove unnecessary evaluatio...

2015-12-02 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/8066#discussion_r46452176 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/SortOptimizeSuite.scala --- @@ -0,0 +1,128 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-9778][SQL] remove unnecessary evaluatio...

2015-12-02 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/8066#issuecomment-161389843 A few minor comments, overall LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-12091] [PYSPARK] [Minor] Default storag...

2015-12-02 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/10092#issuecomment-161372323 @mateiz Thank you for your answer! Will try to do it soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-12098] Cross validator with multi-arm b...

2015-12-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10105#issuecomment-161381057 **[Test build #47075 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47075/consoleFull)** for PR 10105 at commit

[GitHub] spark pull request: [SPARK-12084][Core]Fix codes that uses ByteBuf...

2015-12-02 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/10083#discussion_r46451156 --- Diff: core/src/main/scala/org/apache/spark/serializer/GenericAvroSerializer.scala --- @@ -81,7 +81,10 @@ private[serializer] class

[GitHub] spark pull request: [SPARK-9778][SQL] remove unnecessary evaluatio...

2015-12-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8066#issuecomment-161388326 **[Test build #47073 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47073/consoleFull)** for PR 8066 at commit

[GitHub] spark pull request: [SPARK-9778][SQL] remove unnecessary evaluatio...

2015-12-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8066#issuecomment-161388547 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12040][PYSPARK][MLLIB] add toJson & fro...

2015-12-02 Thread holdenk
GitHub user holdenk opened a pull request: https://github.com/apache/spark/pull/10106 [SPARK-12040][PYSPARK][MLLIB] add toJson & fromJson to Vectors in PySpark Add toJson/fromJson to Vectors for PySpark, please refer the Scala one SPARK-11766. You can merge this pull request into

[GitHub] spark pull request: [SPARK-10582][Yarn][Core] Fix AM failure situa...

2015-12-02 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/9963#discussion_r46458512 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/YarnSchedulerBackend.scala --- @@ -168,6 +178,13 @@ private[spark] abstract class

[GitHub] spark pull request: [SPARK-12040][PYSPARK][MLLIB] add toJson & fro...

2015-12-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10106#issuecomment-161399622 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10582][Yarn][Core] Fix AM failure situa...

2015-12-02 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/9963#discussion_r46458391 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala --- @@ -341,6 +341,24 @@ class

[GitHub] spark pull request: [SPARK-11315] [YARN] WiP Add YARN extension se...

2015-12-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8744#issuecomment-161402743 **[Test build #47080 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47080/consoleFull)** for PR 8744 at commit

[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...

2015-12-02 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/9867#discussion_r46461693 --- Diff: dev/lint-java --- @@ -0,0 +1,34 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF) under one or more

  1   2   3   4   5   6   7   >