[GitHub] spark pull request: [SPARK-14963][Yarn] Using recoveryPath if NM r...

2016-05-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12994#issuecomment-217764184 **[Test build #58116 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58116/consoleFull)** for PR 12994 at commit

[GitHub] spark pull request: [SPARK-14963][Yarn] Using recoveryPath if NM r...

2016-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12994#issuecomment-217764237 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14963][Yarn] Using recoveryPath if NM r...

2016-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12994#issuecomment-217764236 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15125][SQL] Changing CSV data source ma...

2016-05-08 Thread sureshthalamati
Github user sureshthalamati commented on the pull request: https://github.com/apache/spark/pull/12904#issuecomment-217765505 I am not sure what was the history behind returning empty String for null value. In my opinion it should be null be default. current behavior is also

[GitHub] spark pull request: [SPARK-15125][SQL] Changing CSV data source ma...

2016-05-08 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/12904#issuecomment-217765823 +1 for @sureshthalamati #12921 handles the inconsistent behaviour and this is why I think we should hold off this until that PR is merged. --- If your

[GitHub] spark pull request: [SPARK-14098][SQL] Generate Java code that get...

2016-05-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11956#issuecomment-217766571 **[Test build #58117 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58117/consoleFull)** for PR 11956 at commit

[GitHub] spark pull request: [SPARK-15187] [SQL] Disallow Dropping Default ...

2016-05-08 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/12962#issuecomment-217770405 @cloud-fan https://github.com/apache/spark/pull/12993 resolves the issue you mentioned above. Will change this PR too for resolving the issues of database names by

[GitHub] spark pull request: [SPARK-15209] Fix display of job descriptions ...

2016-05-08 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/12995#issuecomment-217769825 /cc @andrewor14 as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-15217] [SQL] Always Case Insensitive in...

2016-05-08 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/12993#issuecomment-217770263 cc @cloud-fan @rxin @yhuai @andrewor14 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15209] Fix display of job descriptions ...

2016-05-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12995#issuecomment-217769812 **[Test build #58118 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58118/consoleFull)** for PR 12995 at commit

[GitHub] spark pull request: [SPARK-15209] Fix display of job descriptions ...

2016-05-08 Thread JoshRosen
GitHub user JoshRosen opened a pull request: https://github.com/apache/spark/pull/12995 [SPARK-15209] Fix display of job descriptions with single quotes in web UI timeline ## What changes were proposed in this pull request? This patch fixes an escaping bug in the Web UI's

[GitHub] spark pull request: [SPARK-15180][SQL] Support subexpression elimi...

2016-05-08 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/12956#issuecomment-217768690 cc @davies This is ready for review. Please take a look of this. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-13064] Make sure attemptId not none for...

2016-05-08 Thread jerryshao
Github user jerryshao commented on the pull request: https://github.com/apache/spark/pull/12075#issuecomment-217768123 @srowen , currently we assume attempt id is `None` when spark application is running on yarn client mode. This assumption is used not only in REST api, but also in

[GitHub] spark pull request: [SPARK-13232][YARN] Fix executor node label

2016-05-08 Thread jerryshao
Github user jerryshao commented on the pull request: https://github.com/apache/spark/pull/11129#issuecomment-217768853 >now, maximally devious would be to catch the exception and downgrade Maybe we could do this in Spark side, though a little complicated but doable.

[GitHub] spark pull request: [SPARK-15211][SQL] Select features column from...

2016-05-08 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/12986#issuecomment-217768128 ping @liancheng @yhuai Please take a look of this. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-14098][SQL] Generate Java code that get...

2016-05-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11956#issuecomment-217773178 **[Test build #58117 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58117/consoleFull)** for PR 11956 at commit

[GitHub] spark pull request: [SPARK-14098][SQL] Generate Java code that get...

2016-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11956#issuecomment-217773265 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14098][SQL] Generate Java code that get...

2016-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11956#issuecomment-217773268 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15080][CORE] Break copyAndReset into co...

2016-05-08 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/12936#discussion_r62449624 --- Diff: core/src/main/scala/org/apache/spark/executor/TaskMetrics.scala --- @@ -291,11 +291,20 @@ private[spark] object TaskMetrics extends Logging {

[GitHub] spark pull request: [SPARK-15199] [SQL] Disallow Dropping Build-in...

2016-05-08 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/12975#discussion_r62449710 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala --- @@ -157,6 +157,9 @@ case class DropFunction(

[GitHub] spark pull request: [SPARK-15185] [SQL] InMemoryCatalog: Silent Re...

2016-05-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12960 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-15185] [SQL] InMemoryCatalog: Silent Re...

2016-05-08 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/12960#issuecomment-217774838 thanks, merging to master and 2.0! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-15199] [SQL] Disallow Dropping Build-in...

2016-05-08 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/12975#discussion_r62449958 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala --- @@ -157,6 +157,9 @@ case class DropFunction(

[GitHub] spark pull request: [SPARK-15217] [SQL] Always Case Insensitive in...

2016-05-08 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/12993#issuecomment-217773874 I think we need to discuss it more: 1. should we allow the case sensitivity to be configurable? It's sometimes out of our control like hive catalog, which is

[GitHub] spark pull request: [SPARK-14098][SQL] Generate Java code that get...

2016-05-08 Thread kiszk
Github user kiszk commented on the pull request: https://github.com/apache/spark/pull/11956#issuecomment-217775281 @davies As you suggested, I moved most of the implmentation from ```WholeStageCodegenExec``` to ```InMemoryTableScanExec```. Now, the number of changed lines in

[GitHub] spark pull request: [SPARK-15184] [SQL] Fix Silent Removal of An E...

2016-05-08 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/12959#issuecomment-217776816 thanks, merging to master and 2.0! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-15184] [SQL] Fix Silent Removal of An E...

2016-05-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12959 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-15199] [SQL] Disallow Dropping Build-in...

2016-05-08 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/12975#discussion_r62450713 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala --- @@ -157,6 +157,9 @@ case class DropFunction(

[GitHub] spark pull request: [SPARK-14495][SQL][1.6] fix resolution failure...

2016-05-08 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/12974#discussion_r62450742 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DistinctAggregationRewriter.scala --- @@ -123,15 +119,7 @@ case class

[GitHub] spark pull request: [SPARK-14939][SQL] Add FoldablePropagation opt...

2016-05-08 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/12719#discussion_r62450837 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -90,6 +90,8 @@ abstract class

[GitHub] spark pull request: [SPARK-14939][SQL] Add FoldablePropagation opt...

2016-05-08 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/12719#discussion_r62450948 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -90,6 +90,8 @@ abstract class

[GitHub] spark pull request: [SPARK-15217] [SQL] Always Case Insensitive in...

2016-05-08 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/12993#issuecomment-21713 Agree. We need to be careful for deciding the design. This PR is just to recover our previous behavior in `HiveContext`. Regarding case sensitivity, it is

[GitHub] spark pull request: [SPARK-15202][SPARKR] add dapplyCollect() meth...

2016-05-08 Thread sun-rui
Github user sun-rui commented on the pull request: https://github.com/apache/spark/pull/12989#issuecomment-21755 cc @shivaram, @felixcheung , @NarineK --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-15160][SQL] support data source table i...

2016-05-08 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/12935#issuecomment-21835 I'll update it after https://github.com/apache/spark/pull/12949 --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-15064][ML] Locale support in StopWordsR...

2016-05-08 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/12968#discussion_r62451347 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/StopWordsRemover.scala --- @@ -73,22 +75,37 @@ class StopWordsRemover(override val uid: String)

[GitHub] spark pull request: [SPARK-15209] Fix display of job descriptions ...

2016-05-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12995#issuecomment-217779047 **[Test build #58118 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58118/consoleFull)** for PR 12995 at commit

[GitHub] spark pull request: [SPARK-15064][ML] Locale support in StopWordsR...

2016-05-08 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/12968#discussion_r62451393 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/StopWordsRemover.scala --- @@ -73,22 +75,37 @@ class StopWordsRemover(override val uid: String)

[GitHub] spark pull request: [SPARK-15209] Fix display of job descriptions ...

2016-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12995#issuecomment-217779133 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15209] Fix display of job descriptions ...

2016-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12995#issuecomment-217779134 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15064][ML] Locale support in StopWordsR...

2016-05-08 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/12968#discussion_r62451491 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/StopWordsRemover.scala --- @@ -73,22 +75,37 @@ class StopWordsRemover(override val uid: String)

[GitHub] spark pull request: [SPARK-15199] [SQL] Disallow Dropping Build-in...

2016-05-08 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/12975#discussion_r62451866 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala --- @@ -157,6 +157,9 @@ case class DropFunction(

[GitHub] spark pull request: [SPARK-15199] [SQL] Disallow Dropping Build-in...

2016-05-08 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/12975#discussion_r62451961 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala --- @@ -157,6 +157,9 @@ case class DropFunction(

[GitHub] spark pull request: [SPARK-13902][SCHEDULER] Make DAGScheduler.get...

2016-05-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12655#issuecomment-217780312 **[Test build #58119 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58119/consoleFull)** for PR 12655 at commit

[GitHub] spark pull request: [SPARK-13902][SCHEDULER] Make DAGScheduler.get...

2016-05-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12655#issuecomment-217780496 **[Test build #58119 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58119/consoleFull)** for PR 12655 at commit

[GitHub] spark pull request: [SPARK-13902][SCHEDULER] Make DAGScheduler.get...

2016-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12655#issuecomment-217780498 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15064][ML] Locale support in StopWordsR...

2016-05-08 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/12968#discussion_r62452057 --- Diff: mllib/src/test/scala/org/apache/spark/ml/feature/StopWordsRemoverSuite.scala --- @@ -98,6 +98,7 @@ class StopWordsRemoverSuite

[GitHub] spark pull request: [SPARK-13902][SCHEDULER] Make DAGScheduler.get...

2016-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12655#issuecomment-217780501 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15064][ML] Locale support in StopWordsR...

2016-05-08 Thread hhbyyh
Github user hhbyyh commented on the pull request: https://github.com/apache/spark/pull/12968#issuecomment-217780806 Made a pass. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-13902][SCHEDULER] Make DAGScheduler.get...

2016-05-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12655#issuecomment-217780852 **[Test build #58121 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58121/consoleFull)** for PR 12655 at commit

[GitHub] spark pull request: [SPARK-14939][SQL] Add FoldablePropagation opt...

2016-05-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12719#issuecomment-217780844 **[Test build #58120 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58120/consoleFull)** for PR 12719 at commit

[GitHub] spark pull request: [MINOR][PySpark] update _shared_params_code_ge...

2016-05-08 Thread zhengruifeng
GitHub user zhengruifeng opened a pull request: https://github.com/apache/spark/pull/12996 [MINOR][PySpark] update _shared_params_code_gen.py ## What changes were proposed in this pull request? 1, add arg-checkings for `tol` and `stepSize` to keep in line with

[GitHub] spark pull request: [MINOR][PySpark] update _shared_params_code_ge...

2016-05-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12996#issuecomment-217781272 **[Test build #58122 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58122/consoleFull)** for PR 12996 at commit

[GitHub] spark pull request: [DO-NOT-MERGE][TEST] Unify 'range' usage

2016-05-08 Thread zhengruifeng
GitHub user zhengruifeng opened a pull request: https://github.com/apache/spark/pull/12983 [DO-NOT-MERGE][TEST] Unify 'range' usage ## What changes were proposed in this pull request? Most python file directly use `range` ignoring the different implement between python 2 and 3.

[GitHub] spark pull request: [SPARK-12479][SPARKR] sparkR collect on Groupe...

2016-05-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12976 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-15096][ML]:LogisticRegression MultiClas...

2016-05-08 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/12969#discussion_r62428194 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -744,7 +744,13 @@ private[classification] class

[GitHub] spark pull request: [DO-NOT-MERGE][TEST] Unify 'range' usage

2016-05-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12983#issuecomment-217701113 **[Test build #58094 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58094/consoleFull)** for PR 12983 at commit

[GitHub] spark pull request: [DO-NOT-MERGE][TEST] Unify 'range' usage

2016-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12983#issuecomment-217701120 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [DO-NOT-MERGE][TEST] Unify 'range' usage

2016-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12983#issuecomment-217701119 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15180][SQL] Support subexpression elimi...

2016-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12956#issuecomment-217699205 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15210][SQL] Add missing @DeveloperApi a...

2016-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12982#issuecomment-217699194 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14642][SQL] import org.apache.spark.sql...

2016-05-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12458#issuecomment-217699238 **[Test build #58093 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58093/consoleFull)** for PR 12458 at commit

[GitHub] spark pull request: [SPARK-14642][SQL] import org.apache.spark.sql...

2016-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12458#issuecomment-217699240 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14642][SQL] import org.apache.spark.sql...

2016-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12458#issuecomment-217699239 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15196][SparkR] Add a wrapper for dapply...

2016-05-08 Thread sun-rui
Github user sun-rui commented on the pull request: https://github.com/apache/spark/pull/12966#issuecomment-217699516 @NarineK, it is guaranteed that all items in a same group will be in a same partition. But it is not guaranteed that there is only single group in a partition. There

[GitHub] spark pull request: [SPARK-15203][Deploy]The spark daemon shell sc...

2016-05-08 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/12978#discussion_r62428386 --- Diff: sbin/spark-daemon.sh --- @@ -164,7 +164,7 @@ run_command() { echo "$newpid" > "$pid" sleep 2 # Check if the process has died;

[GitHub] spark pull request: [SPARK-15064][ML] Locale support in StopWordsR...

2016-05-08 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/12968#discussion_r62428404 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/StopWordsRemover.scala --- @@ -73,22 +75,37 @@ class StopWordsRemover(override val uid: String)

[GitHub] spark pull request: [SPARK-15207][BUILD] Use Travis CI for Java/Sc...

2016-05-08 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/12980#issuecomment-217702414 I don't think this hurts, except that it adds yet another place to look for test results. (PS you want to add "test-compile" as a target too). What is the reason it's

[GitHub] spark pull request: [SPARK-15054] Deprecate old accumulator API

2016-05-08 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/12832#discussion_r62428568 --- Diff: core/src/main/scala/org/apache/spark/Accumulable.scala --- @@ -49,6 +48,7 @@ import org.apache.spark.util.Utils * @tparam R the full

[GitHub] spark pull request: [SPARK-15141][EXAMPLE][DOC] Update OneVsRest E...

2016-05-08 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/12920#discussion_r62428631 --- Diff: examples/src/main/java/org/apache/spark/examples/ml/JavaOneVsRestExample.java --- @@ -17,222 +17,69 @@ package

[GitHub] spark pull request: [DO-NOT-MERGE][TEST] Unify 'range' usage

2016-05-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12983#issuecomment-217702985 **[Test build #58095 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58095/consoleFull)** for PR 12983 at commit

[GitHub] spark pull request: [DO-NOT-MERGE][TEST] Unify 'range' usage

2016-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12983#issuecomment-217703021 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [DO-NOT-MERGE][TEST] Unify 'range' usage

2016-05-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12983#issuecomment-217703020 **[Test build #58095 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58095/consoleFull)** for PR 12983 at commit

[GitHub] spark pull request: [DO-NOT-MERGE][TEST] Unify 'range' usage

2016-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12983#issuecomment-217703023 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [DO-NOT-MERGE][TEST] Unify 'range' usage

2016-05-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12983#issuecomment-217703733 **[Test build #58096 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58096/consoleFull)** for PR 12983 at commit

[GitHub] spark pull request: [SPARK-15172][ML] Explicitly tell user initial...

2016-05-08 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/12948#issuecomment-217704199 Jenkins retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-15172][ML] Explicitly tell user initial...

2016-05-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12948#issuecomment-217704288 **[Test build #58097 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58097/consoleFull)** for PR 12948 at commit

[GitHub] spark pull request: [SPARK-14542][CORE] PipeRDD should allow confi...

2016-05-08 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/12309#discussion_r62429048 --- Diff: project/MimaExcludes.scala --- @@ -686,6 +686,10 @@ object MimaExcludes { ProblemFilters.exclude[IncompatibleMethTypeProblem](

[GitHub] spark pull request: [SPARK-15172][ML] Explicitly tell user initial...

2016-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12948#issuecomment-217704356 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15172][ML] Explicitly tell user initial...

2016-05-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12948#issuecomment-217704353 **[Test build #58097 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58097/consoleFull)** for PR 12948 at commit

[GitHub] spark pull request: [SPARK-15172][ML] Explicitly tell user initial...

2016-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12948#issuecomment-217704355 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14542][CORE] PipeRDD should allow confi...

2016-05-08 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/12309#issuecomment-217704387 Aside from one final question I think this is OK. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [DO-NOT-MERGE][TEST] Unify 'range' usage

2016-05-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12983#issuecomment-217704501 **[Test build #58096 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58096/consoleFull)** for PR 12983 at commit

[GitHub] spark pull request: [DO-NOT-MERGE][TEST] Unify 'range' usage

2016-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12983#issuecomment-217704515 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [DO-NOT-MERGE][TEST] Unify 'range' usage

2016-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12983#issuecomment-217704516 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15067] [YARN] YARN executors are launch...

2016-05-08 Thread srowen
GitHub user srowen opened a pull request: https://github.com/apache/spark/pull/12985 [SPARK-15067] [YARN] YARN executors are launched with fixed perm gen size ## What changes were proposed in this pull request? Look for MaxPermSize arguments anywhere in an arg, to account

[GitHub] spark pull request: [SPARK-15136][PySpark][DOC] Fix links to sphin...

2016-05-08 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/12918#issuecomment-217705447 That LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-15067] [YARN] YARN executors are launch...

2016-05-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12985#issuecomment-217705494 **[Test build #58098 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58098/consoleFull)** for PR 12985 at commit

[GitHub] spark pull request: [SPARK-15211][SQL] Select features column from...

2016-05-08 Thread viirya
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/12986 [SPARK-15211][SQL] Select features column from LibSVMRelation causes failure ## What changes were proposed in this pull request? We need to use `requiredSchema` in `LibSVMRelation` to

[GitHub] spark pull request: [SPARK-14340][EXAMPLE][DOC] Update Examples an...

2016-05-08 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/11844#issuecomment-217705549 @MLnick I opened a PR #12986 for that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-15211][SQL] Select features column from...

2016-05-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12986#issuecomment-217705668 **[Test build #58099 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58099/consoleFull)** for PR 12986 at commit

[GitHub] spark pull request: [SPARK-15141][EXAMPLE][DOC] Update OneVsRest E...

2016-05-08 Thread zhengruifeng
Github user zhengruifeng commented on a diff in the pull request: https://github.com/apache/spark/pull/12920#discussion_r62429495 --- Diff: examples/src/main/java/org/apache/spark/examples/ml/JavaOneVsRestExample.java --- @@ -17,222 +17,69 @@ package

[GitHub] spark pull request: [SPARK-15141][EXAMPLE][DOC] Update OneVsRest E...

2016-05-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12920#issuecomment-217706791 **[Test build #58100 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58100/consoleFull)** for PR 12920 at commit

[GitHub] spark pull request: [SPARK-15141][EXAMPLE][DOC] Update OneVsRest E...

2016-05-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12920#issuecomment-217707084 **[Test build #58100 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58100/consoleFull)** for PR 12920 at commit

[GitHub] spark pull request: [SPARK-15141][EXAMPLE][DOC] Update OneVsRest E...

2016-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12920#issuecomment-217707105 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15141][EXAMPLE][DOC] Update OneVsRest E...

2016-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12920#issuecomment-217707107 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15211][SQL] Select features column from...

2016-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12986#issuecomment-217707527 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15211][SQL] Select features column from...

2016-05-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12986#issuecomment-217707528 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15211][SQL] Select features column from...

2016-05-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12986#issuecomment-217707511 **[Test build #58099 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58099/consoleFull)** for PR 12986 at commit

[GitHub] spark pull request: [SPARK-15150][EXAMPLE][DOC] Add python example...

2016-05-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12927#issuecomment-217707939 **[Test build #58101 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58101/consoleFull)** for PR 12927 at commit

[GitHub] spark pull request: [SPARK-15150][EXAMPLE][DOC] Update LDA example...

2016-05-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12927#issuecomment-217708122 **[Test build #58102 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58102/consoleFull)** for PR 12927 at commit

  1   2   3   >