[GitHub] spark pull request: [SPARK-15473][SQL] CSV data source fails to wr...

2016-05-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13252#issuecomment-220827396 **[Test build #59101 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59101/consoleFull)** for PR 13252 at commit

[GitHub] spark pull request: [SPARK-15143][SPARK-15144][SQL] Add CSV tests ...

2016-05-22 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/12921#issuecomment-220827427 Hi @cloud-fan, Could you please take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-15471][SQL] ScalaReflection cleanup

2016-05-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13250#issuecomment-220827475 **[Test build #59094 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59094/consoleFull)** for PR 13250 at commit

[GitHub] spark pull request: [SPARK-15475][SQL] Add tests for writing and r...

2016-05-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13253#issuecomment-220834605 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15475][SQL] Add tests for writing and r...

2016-05-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13253#issuecomment-220834603 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15431][SQL] Support LIST FILE(s)|JAR(s)...

2016-05-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13212#issuecomment-220840805 **[Test build #59111 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59111/consoleFull)** for PR 13212 at commit

[GitHub] spark pull request: [SPARK-15311] [SQL] Disallow DML on Regular Ta...

2016-05-22 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13093#discussion_r64153076 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -441,7 +441,15 @@ class Analyzer( object

[GitHub] spark pull request: [SPARK-15311] [SQL] Disallow DML on Regular Ta...

2016-05-22 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13093#discussion_r64153082 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -433,6 +433,18 @@ class SessionCatalog( }

[GitHub] spark pull request: [SPARK-15285][SQL] Generated SpecificSafeProje...

2016-05-22 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13243#discussion_r64153170 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -232,27 +232,55 @@ case class NewInstance(

[GitHub] spark pull request: [SPARK-15285][SQL] Generated SpecificSafeProje...

2016-05-22 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13243#discussion_r64162830 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -232,27 +232,55 @@ case class NewInstance(

[GitHub] spark pull request: [SPARK-11753][SQL][test-hadoop2.2] Make allowN...

2016-05-22 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/9759#discussion_r64164602 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JacksonParser.scala --- @@ -129,13 +129,14 @@ object JacksonParser extends

[GitHub] spark pull request: [SPARK-11753][SQL][test-hadoop2.2] Make allowN...

2016-05-22 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/9759#discussion_r64166002 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JacksonParser.scala --- @@ -129,13 +129,14 @@ object JacksonParser extends

[GitHub] spark pull request: [SPARK-15466][SQL] Make `SparkSession` as the ...

2016-05-22 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/13245#issuecomment-220880599 Sorry, it wasn't a good idea of extending SparkSession for RDD. I'm closing this PR. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-15324] [SQL] Add the takeSample functio...

2016-05-22 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/13116#discussion_r64160441 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -51,6 +49,7 @@ import org.apache.spark.sql.execution.python.EvaluatePython

[GitHub] spark pull request: [SPARK-15285][SQL] Generated SpecificSafeProje...

2016-05-22 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/13243#discussion_r64163700 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -232,27 +232,55 @@ case class NewInstance(

[GitHub] spark pull request: [SPARK-15379][SQL] check special invalid date

2016-05-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13169 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-15379][SQL] check special invalid date

2016-05-22 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/13169#issuecomment-220875681 thanks, merging to master and 2.0! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-15388][SQL] Fix spark sql CREATE FUNCTI...

2016-05-22 Thread wangyang1992
Github user wangyang1992 commented on the pull request: https://github.com/apache/spark/pull/13177#issuecomment-220880826 Hi @andrewor14, sorry to bother you, but does this pr need to be further refined, or it is ready to merge? Could you please give me some instructions? Thanks.

[GitHub] spark pull request: [SPARK-15425][SQL] Disallow cross joins by def...

2016-05-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13209#issuecomment-220886265 **[Test build #59120 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59120/consoleFull)** for PR 13209 at commit

[GitHub] spark pull request: [SPARK-15425][SQL] Disallow cross joins by def...

2016-05-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13209#issuecomment-220887533 **[Test build #59121 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59121/consoleFull)** for PR 13209 at commit

[GitHub] spark pull request: [SPARK-10372] [CORE] basic test framework for ...

2016-05-22 Thread markhamstra
Github user markhamstra commented on a diff in the pull request: https://github.com/apache/spark/pull/8559#discussion_r64169565 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskResult.scala --- @@ -59,7 +59,7 @@ private[spark] class DirectTaskResult[T](

[GitHub] spark pull request: [SPARK-15475][SQL] Support for reading text da...

2016-05-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13254#issuecomment-220870837 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15475][SQL] Support for reading text da...

2016-05-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13254#issuecomment-220870836 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15285][SQL] Generated SpecificSafeProje...

2016-05-22 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/13243#discussion_r64162262 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -232,27 +232,55 @@ case class NewInstance(

[GitHub] spark pull request: [SPARK-15285][SQL] Generated SpecificSafeProje...

2016-05-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13243#issuecomment-220876025 **[Test build #59118 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59118/consoleFull)** for PR 13243 at commit

[GitHub] spark pull request: [SPARK-15466][SQL] Make `SparkSession` as the ...

2016-05-22 Thread dongjoon-hyun
Github user dongjoon-hyun closed the pull request at: https://github.com/apache/spark/pull/13245 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark pull request: [SPARK-15474][SQL]ORC data source fails to wri...

2016-05-22 Thread sbcd90
Github user sbcd90 commented on the pull request: https://github.com/apache/spark/pull/13257#issuecomment-220885344 Hello @HyukjinKwon , I have added a testcase now. Please review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-15474][SQL]ORC data source fails to wri...

2016-05-22 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/13257#issuecomment-220886604 Hi @sbcd90 I am not a committer but I just left a comment because I like your PR. Let me add some more comments which I think might be changed. --- If your

[GitHub] spark pull request: [SPARK-10372] [CORE] basic test framework for ...

2016-05-22 Thread markhamstra
Github user markhamstra commented on a diff in the pull request: https://github.com/apache/spark/pull/8559#discussion_r64170026 --- Diff: core/src/test/resources/META-INF/services/org.apache.spark.scheduler.ExternalClusterManager --- @@ -1 +1,2 @@

[GitHub] spark pull request: [SPARK-15311] [SQL] Disallow DML on Regular Ta...

2016-05-22 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/13093#issuecomment-220875134 LGTM, cc @yhuai to take another look --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-15285][SQL] Generated SpecificSafeProje...

2016-05-22 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/13243#discussion_r64164066 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -232,27 +232,55 @@ case class NewInstance(

[GitHub] spark pull request: [SPARK-11753][SQL][test-hadoop2.2] Make allowN...

2016-05-22 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/9759#discussion_r64164980 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JacksonParser.scala --- @@ -129,13 +129,14 @@ object JacksonParser extends

[GitHub] spark pull request: [SPARK-11753][SQL][test-hadoop2.2] Make allowN...

2016-05-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9759#issuecomment-220880780 **[Test build #59119 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59119/consoleFull)** for PR 9759 at commit

[GitHub] spark pull request: [SPARK-15285][SQL] Generated SpecificSafeProje...

2016-05-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13243#issuecomment-220883664 **[Test build #59118 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59118/consoleFull)** for PR 13243 at commit

[GitHub] spark pull request: [SPARK-15425][SQL] Disallow cross joins by def...

2016-05-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13209#issuecomment-220886847 **[Test build #59120 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59120/consoleFull)** for PR 13209 at commit

[GitHub] spark pull request: [SPARK-15425][SQL] Disallow cross joins by def...

2016-05-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13209#issuecomment-220886854 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15425][SQL] Disallow cross joins by def...

2016-05-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13209#issuecomment-220886852 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15475][SQL] Support for reading text da...

2016-05-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13254#issuecomment-220870762 **[Test build #59117 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59117/consoleFull)** for PR 13254 at commit

[GitHub] spark pull request: [SPARK-15285][SQL] Generated SpecificSafeProje...

2016-05-22 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13243#discussion_r64166173 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -232,27 +232,54 @@ case class NewInstance(

[GitHub] spark pull request: [SPARK-15285][SQL] Generated SpecificSafeProje...

2016-05-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13243#issuecomment-220883773 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15285][SQL] Generated SpecificSafeProje...

2016-05-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13243#issuecomment-220883772 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15425][SQL] Disallow cross joins by def...

2016-05-22 Thread sameeragarwal
Github user sameeragarwal commented on the pull request: https://github.com/apache/spark/pull/13209#issuecomment-220887288 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-15425][SQL] Disallow cross joins by def...

2016-05-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13209#issuecomment-220887426 **[Test build #3010 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3010/consoleFull)** for PR 13209 at commit

[GitHub] spark pull request: [SPARK-11753][SQL][test-hadoop2.2] Make allowN...

2016-05-22 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/9759#issuecomment-220828725 @srowen I had managed paranamer up to 2.8 and used `[test-hadoop2.2]` to test. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-15475][SQL] Add tests for writing and r...

2016-05-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13253#issuecomment-220830411 **[Test build #59102 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59102/consoleFull)** for PR 13253 at commit

[GitHub] spark pull request: [SPARK-15475][SQL] Support for reading text da...

2016-05-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13254#issuecomment-220831936 **[Test build #59104 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59104/consoleFull)** for PR 13254 at commit

[GitHub] spark pull request: [SPARK-15064][ML] Locale support in StopWordsR...

2016-05-22 Thread burakkose
Github user burakkose commented on the pull request: https://github.com/apache/spark/pull/12968#issuecomment-220838621 Can you specify the blocking? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-15064][ML] Locale support in StopWordsR...

2016-05-22 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/12968#discussion_r64151936 --- Diff: mllib/src/test/scala/org/apache/spark/ml/feature/StopWordsRemoverSuite.scala --- @@ -98,6 +98,7 @@ class StopWordsRemoverSuite

[GitHub] spark pull request: [SPARK-15285][SQL] Generated SpecificSafeProje...

2016-05-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13243#issuecomment-220840617 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: Master

2016-05-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13256#issuecomment-220842900 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15282][SQL][DOCS] Add notes of the dete...

2016-05-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13087#issuecomment-220857000 **[Test build #59113 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59113/consoleFull)** for PR 13087 at commit

[GitHub] spark pull request: [SPARK-15311] [SQL] Disallow DML on Regular Ta...

2016-05-22 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/13093#discussion_r64156688 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -433,6 +433,18 @@ class SessionCatalog( }

[GitHub] spark pull request: [SPARK-15282][SQL][DOCS] Add notes of the dete...

2016-05-22 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/13087#issuecomment-220857498 I added for Scaladoc/Javadoc/Pydoc, but I cannot find proper places exposed in SparkR doc. Hi, @shivaram , @davies , @felixcheung . Should we need to

[GitHub] spark pull request: [SPARK-15311] [SQL] Disallow DML on Regular Ta...

2016-05-22 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/13093#discussion_r64156604 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -441,7 +441,15 @@ class Analyzer( object

[GitHub] spark pull request: [SPARK-15324] [SQL] Add the takeSample functio...

2016-05-22 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/13116#issuecomment-220857549 @burness that is no problem. I have taken a look at the current implementation of the `RDD`'s `takeSample`; it is very similar to your implementation. I do still

[GitHub] spark pull request: [SPARK-15076][SQL] Improve ConstantFolding opt...

2016-05-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12850#issuecomment-220859004 **[Test build #59114 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59114/consoleFull)** for PR 12850 at commit

[GitHub] spark pull request: [SPARK-15474][SQL]ORC data source fails to wri...

2016-05-22 Thread sbcd90
GitHub user sbcd90 opened a pull request: https://github.com/apache/spark/pull/13257 [SPARK-15474][SQL]ORC data source fails to write and read back empty dataframe ## What changes were proposed in this pull request? Currently ORC data source fails to write and read empty

[GitHub] spark pull request: [SPARK-15455] For IsolatedClientLoader, we nee...

2016-05-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13236#issuecomment-220862906 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15076][SQL] Improve ConstantFolding opt...

2016-05-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12850#issuecomment-220862881 **[Test build #59114 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59114/consoleFull)** for PR 12850 at commit

[GitHub] spark pull request: [SPARK-15455] For IsolatedClientLoader, we nee...

2016-05-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13236#issuecomment-220862857 **[Test build #59115 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59115/consoleFull)** for PR 13236 at commit

[GitHub] spark pull request: [SPARK-15311] [SQL] Disallow DML on Regular Ta...

2016-05-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13093#issuecomment-220864268 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15475][SQL] Support for reading text da...

2016-05-22 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/13254#issuecomment-220866532 @andrewor14 Could you please take a look maybe? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-15282][SQL][DOCS] Add notes of the dete...

2016-05-22 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/spark/pull/13087#issuecomment-220858022 @dongjoon-hyun I don't think we support UDF this way in SparkR? Maybe something we could add to `dapply`? @sun-rui --- If your project is set up for it, you

[GitHub] spark pull request: [SPARK-15311] [SQL] Disallow DML on Regular Ta...

2016-05-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13093#issuecomment-220860196 **[Test build #59116 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59116/consoleFull)** for PR 13093 at commit

[GitHub] spark pull request: [SPARK-15474][SQL]ORC data source fails to wri...

2016-05-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13257#issuecomment-220860424 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15475][SQL] Support for reading text da...

2016-05-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13254#issuecomment-220866525 **[Test build #59117 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59117/consoleFull)** for PR 13254 at commit

[GitHub] spark pull request: [SPARK-15311] [SQL] Disallow DML on Regular Ta...

2016-05-22 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/13093#discussion_r64156652 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -441,7 +441,15 @@ class Analyzer( object

[GitHub] spark pull request: [SPARK-15282][SQL][DOCS] Add notes of the dete...

2016-05-22 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/13087#issuecomment-220858268 Thank you, @felixcheung ! Then, this PR is enough for the current master branch. :) If SparkR have something related to this in the future, we can add a note

[GitHub] spark pull request: [SPARK-15455] For IsolatedClientLoader, we nee...

2016-05-22 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/13236#discussion_r64157471 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala --- @@ -73,7 +74,7 @@ import org.apache.spark.util.{CircularBuffer,

[GitHub] spark pull request: [SPARK-15282][SQL][DOCS] Add notes of the dete...

2016-05-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13087#issuecomment-220860842 **[Test build #59113 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59113/consoleFull)** for PR 13087 at commit

[GitHub] spark pull request: [SPARK-15282][SQL][DOCS] Add notes of the dete...

2016-05-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13087#issuecomment-220860885 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15282][SQL][DOCS] Add notes of the dete...

2016-05-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13087#issuecomment-220860884 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15455] For IsolatedClientLoader, we nee...

2016-05-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13236#issuecomment-220859959 **[Test build #59115 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59115/consoleFull)** for PR 13236 at commit

[GitHub] spark pull request: [SPARK-15474][SQL]ORC data source fails to wri...

2016-05-22 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/13257#issuecomment-220860596 @sbcd90 I think we will need a test to make sure this fixes the issue and other changes in the future do not break this change. --- If your project is set up for

[GitHub] spark pull request: [SPARK-15455] For IsolatedClientLoader, we nee...

2016-05-22 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/13236#discussion_r64157490 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala --- @@ -73,7 +74,7 @@ import org.apache.spark.util.{CircularBuffer,

[GitHub] spark pull request: [SPARK-15076][SQL] Improve ConstantFolding opt...

2016-05-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12850#issuecomment-220862945 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15076][SQL] Improve ConstantFolding opt...

2016-05-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12850#issuecomment-220862943 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15455] For IsolatedClientLoader, we nee...

2016-05-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13236#issuecomment-220862905 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15311] [SQL] Disallow DML on Regular Ta...

2016-05-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13093#issuecomment-220864230 **[Test build #59116 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59116/consoleFull)** for PR 13093 at commit

[GitHub] spark pull request: [SPARK-15311] [SQL] Disallow DML on Regular Ta...

2016-05-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13093#issuecomment-220864269 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15431][SQL] Support LIST FILE(s)|JAR(s)...

2016-05-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13212#issuecomment-220847232 **[Test build #59111 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59111/consoleFull)** for PR 13212 at commit

[GitHub] spark pull request: [SPARK-14400] [SQL] ScriptTransformation does ...

2016-05-22 Thread tejasapatil
Github user tejasapatil commented on the pull request: https://github.com/apache/spark/pull/12194#issuecomment-220848477 Can anyone please review this PR ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-13073] [MLib] [WIP] creating R like sum...

2016-05-22 Thread mbaddar1
Github user mbaddar1 commented on the pull request: https://github.com/apache/spark/pull/11729#issuecomment-220850123 @srowen @jkbradley Will work on the comments added by @jkbradley and will update the PR ASAP --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-13135][SQL] Don't print expressions rec...

2016-05-22 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/13192#issuecomment-220851707 Hi, @davies and @rxin . Could you review this PR again when you have some time? --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-15282][SQL] PushDownPredicate should no...

2016-05-22 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/13087#issuecomment-220855166 All issues are resolved now. I'll update this PR now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-15431][SQL] Support LIST FILE(s)|JAR(s)...

2016-05-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13212#issuecomment-220847275 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15431][SQL] Support LIST FILE(s)|JAR(s)...

2016-05-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13212#issuecomment-220847276 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15459][SQL] Make Range logical and phys...

2016-05-22 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/13239#discussion_r64154982 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala --- @@ -359,8 +359,8 @@ private[sql] abstract class

[GitHub] spark pull request: [SPARK-15282][SQL] PushDownPredicate should no...

2016-05-22 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/13087#issuecomment-220855050 Thank you for sharing this, @linbojin . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15473][SQL] CSV data source fails to wr...

2016-05-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13252#issuecomment-220830670 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15473][SQL] CSV data source fails to wr...

2016-05-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13252#issuecomment-220830672 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [MINOR] More than 100 chars in line in SparkSu...

2016-05-22 Thread techaddict
Github user techaddict commented on the pull request: https://github.com/apache/spark/pull/13249#issuecomment-220834246 @srowen Its failing `dev/lint-java` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-15285][SQL] Generated SpecificSafeProje...

2016-05-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13243#issuecomment-220835818 **[Test build #59109 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59109/consoleFull)** for PR 13243 at commit

[GitHub] spark pull request: fix SPARK-15429

2016-05-22 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/13255#issuecomment-220837482 @chengqiangboy fix the title please? https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark --- If your project is set up for it, you can reply to

[GitHub] spark pull request: [SPARK-15472][SQL][Streaming] Add support for ...

2016-05-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13251#issuecomment-220829500 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15472][SQL][Streaming] Add support for ...

2016-05-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13251#issuecomment-220829446 **[Test build #59100 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59100/consoleFull)** for PR 13251 at commit

[GitHub] spark pull request: [SPARK-15473][SQL] CSV data source fails to wr...

2016-05-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13252#issuecomment-220830619 **[Test build #59101 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59101/consoleFull)** for PR 13252 at commit

[GitHub] spark pull request: [MINOR] More than 100 chars in line in SparkSu...

2016-05-22 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/13249#issuecomment-220831720 Does this cause a failure? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-15475][SQL] Add tests for writing and r...

2016-05-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13253#issuecomment-220831712 **[Test build #59103 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59103/consoleFull)** for PR 13253 at commit

[GitHub] spark pull request: [SPARK-15468] [SQL] fix some typos

2016-05-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13246 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

  1   2   3   >