[GitHub] spark pull request #13982: [SPARK-16304] LinkageError should not crash Spark...

2016-06-30 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/13982#discussion_r69079471 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -406,7 +406,7 @@ private[spark] class Executor( // Don't

[GitHub] spark issue #13989: [SPARK-16311][SQL] Improve metadata refresh

2016-06-30 Thread petermaxlee
Github user petermaxlee commented on the issue: https://github.com/apache/spark/pull/13989 Would this work? Traverse the logical plan to find whether it references any catalog relation, and if it does, call catalog.refreshTable("...")? --- If your project is set up for it, you can

[GitHub] spark pull request #13976: [SPARK-16288][SQL] Implement inline table generat...

2016-06-30 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/13976#discussion_r69083901 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala --- @@ -149,3 +149,42 @@ case class Explode(child:

[GitHub] spark issue #13737: [SPARK-15954][SQL][PySpark][TEST] Fix TestHiveContext in...

2016-06-30 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/13737 BTW Jenkins seems to be fine with Python? What's the problem? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request #13940: [SPARK-16241] [ML] model loading backward compati...

2016-06-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13940 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement various xpath functions

2016-06-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13991 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61530/ Test PASSed. ---

[GitHub] spark issue #13991: [SPARK-16318][SQL] Implement various xpath functions

2016-06-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13991 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13993: [SPARK-16144][SPARKR] update R API doc for mllib

2016-06-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13993 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #13966: [SPARK-16276][SQL] Implement elt SQL function

2016-06-30 Thread janplus
Github user janplus commented on a diff in the pull request: https://github.com/apache/spark/pull/13966#discussion_r69098161 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -162,6 +163,46 @@ case class

[GitHub] spark issue #13993: [SPARK-16144][SPARKR] update R API doc for mllib

2016-06-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13993 **[Test build #61533 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61533/consoleFull)** for PR 13993 at commit

[GitHub] spark pull request #13894: [SPARK-15254][DOC] Improve ML pipeline Cross Vali...

2016-06-30 Thread krishnakalyan3
Github user krishnakalyan3 commented on a diff in the pull request: https://github.com/apache/spark/pull/13894#discussion_r69103201 --- Diff: python/pyspark/ml/tuning.py --- @@ -266,7 +269,7 @@ class CrossValidatorModel(Model, ValidatorParams): """ .. note::

[GitHub] spark issue #13989: [SPARK-16311][SQL] Improve metadata refresh

2016-06-30 Thread liancheng
Github user liancheng commented on the issue: https://github.com/apache/spark/pull/13989 One concern of mine is that, analyzed plan, optimized plan, and executed (physical) plan stored in `QueryExecution` are all lazy vals, which means that they won't be re-optimized/planned

[GitHub] spark issue #13906: [SPARK-16208][SQL] Add `CollapseEmptyPlan` optimizer

2016-06-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13906 **[Test build #61535 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61535/consoleFull)** for PR 13906 at commit

[GitHub] spark issue #13971: [SPARK-16289][SQL] Implement posexplode table generating...

2016-06-30 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/13971 If I understand correctly, the remaining issue is `checkEvaluation`. I'm sorry for this, but I'm still not sure how to use `checkEvaluation` for the generators. --- If your project is

[GitHub] spark pull request #13906: [SPARK-16208][SQL] Add `CollapseEmptyPlan` optimi...

2016-06-30 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/13906#discussion_r69110745 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CollapseEmptyPlan.scala --- @@ -0,0 +1,70 @@ +/* + * Licensed to

[GitHub] spark issue #13995: [MINOR] [BUILD] master branch should reference 2.1.0-SNA...

2016-06-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13995 **[Test build #61539 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61539/consoleFull)** for PR 13995 at commit

[GitHub] spark issue #13906: [SPARK-16208][SQL] Add `CollapseEmptyPlan` optimizer

2016-06-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13906 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13967: [SPARK-16278][SPARK-16279][SQL] Implement map_keys/map_v...

2016-06-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13967 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13967: [SPARK-16278][SPARK-16279][SQL] Implement map_keys/map_v...

2016-06-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13967 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61536/ Test PASSed. ---

[GitHub] spark pull request #13993: [SPARK-16144][SPARKR] update R API doc for mllib

2016-06-30 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/13993#discussion_r69120549 --- Diff: R/pkg/R/mllib.R --- @@ -53,6 +53,28 @@ setClass("AFTSurvivalRegressionModel", representation(jobj = "jobj")) #' @note KMeansModel since

[GitHub] spark pull request #13919: [SPARK-16222] [SQL] JDBC Sources - Handling illeg...

2016-06-30 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/13919#discussion_r69080040 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -390,7 +390,11 @@ private[sql] class JDBCRDD(

[GitHub] spark pull request #13919: [SPARK-16222] [SQL] JDBC Sources - Handling illeg...

2016-06-30 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/13919#discussion_r69081296 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala --- @@ -351,11 +352,23 @@ class JDBCSuite extends SparkFunSuite

[GitHub] spark issue #13969: [SPARK-16284][SQL] Implement reflect SQL function

2016-06-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13969 **[Test build #3152 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3152/consoleFull)** for PR 13969 at commit

[GitHub] spark issue #13947: [SPARK-16257] [Build] Update spark_ec2.py to support Spa...

2016-06-30 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/13947 @briuri thank you, and the way the ASF git bot works, it can't auto-close this PR. Can you close it? it's merged now. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request #13975: [SPARK-16299][SPARKR] Capture errors from R worke...

2016-06-30 Thread sun-rui
Github user sun-rui commented on a diff in the pull request: https://github.com/apache/spark/pull/13975#discussion_r69089989 --- Diff: R/pkg/inst/worker/daemon.R --- @@ -44,7 +44,7 @@ while (TRUE) { if (inherits(p, "masterProcess")) { close(inputCon)

[GitHub] spark issue #13987: [SPARK-16313][SQL] Spark should not silently drop except...

2016-06-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13987 **[Test build #3154 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3154/consoleFull)** for PR 13987 at commit

[GitHub] spark issue #13967: [SPARK-16278][SPARK-16279][SQL] Implement map_keys/map_v...

2016-06-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13967 **[Test build #61536 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61536/consoleFull)** for PR 13967 at commit

[GitHub] spark pull request #13906: [SPARK-16208][SQL] Add `CollapseEmptyPlan` optimi...

2016-06-30 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/13906#discussion_r69111430 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CollapseEmptyPlan.scala --- @@ -0,0 +1,70 @@ +/* + * Licensed

[GitHub] spark issue #13995: [MINOR] [BUILD] master branch should reference 2.1.0-SNA...

2016-06-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13995 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61539/ Test FAILed. ---

[GitHub] spark issue #13996: [SPARK-12177] Refactored some API in Kafka 0.10 to make ...

2016-06-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13996 **[Test build #61540 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61540/consoleFull)** for PR 13996 at commit

[GitHub] spark issue #13996: [SPARK-12177] Refactored some API in Kafka 0.10 to make ...

2016-06-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13996 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13995: [MINOR] [BUILD] master branch should reference 2.1.0-SNA...

2016-06-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13995 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13996: [SPARK-12177] Refactored some API in Kafka 0.10 to make ...

2016-06-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13996 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61540/ Test FAILed. ---

[GitHub] spark issue #13995: [MINOR] [BUILD] master branch should reference 2.1.0-SNA...

2016-06-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13995 **[Test build #61539 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61539/consoleFull)** for PR 13995 at commit

[GitHub] spark pull request #13996: [SPARK-12177] Refactored some API in Kafka 0.10 t...

2016-06-30 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/13996#discussion_r69119867 --- Diff: external/kafka-0-10/src/main/scala/org/apache/spark/streaming/kafka010/ConsumerStrategy.scala --- @@ -1,314 +0,0 @@ -/* - * Licensed to the

[GitHub] spark issue #13967: [SPARK-16278][SPARK-16279][SQL] Implement map_keys/map_v...

2016-06-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13967 **[Test build #61536 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61536/consoleFull)** for PR 13967 at commit

[GitHub] spark pull request #13993: [SPARK-16144][SPARKR] update R API doc for mllib

2016-06-30 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/13993#discussion_r69120717 --- Diff: R/pkg/R/mllib.R --- @@ -53,6 +53,28 @@ setClass("AFTSurvivalRegressionModel", representation(jobj = "jobj")) #' @note KMeansModel since

[GitHub] spark issue #13906: [SPARK-16208][SQL] Add `CollapseEmptyPlan` optimizer

2016-06-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13906 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61538/ Test PASSed. ---

[GitHub] spark issue #13906: [SPARK-16208][SQL] Add `CollapseEmptyPlan` optimizer

2016-06-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13906 **[Test build #61538 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61538/consoleFull)** for PR 13906 at commit

[GitHub] spark pull request #13906: [SPARK-16208][SQL] Add `CollapseEmptyPlan` optimi...

2016-06-30 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/13906#discussion_r69110423 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CollapseEmptyPlan.scala --- @@ -0,0 +1,70 @@ +/* + * Licensed

[GitHub] spark issue #13994: [BUILD] Fix version in poms related to kafka-0-10

2016-06-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13994 **[Test build #61537 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61537/consoleFull)** for PR 13994 at commit

[GitHub] spark pull request #13976: [SPARK-16288][SQL] Implement inline table generat...

2016-06-30 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/13976#discussion_r69114498 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala --- @@ -149,3 +149,42 @@ case class Explode(child:

[GitHub] spark issue #13996: [SPARK-12177] Refactored some API in Kafka 0.10 to make ...

2016-06-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13996 **[Test build #61540 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61540/consoleFull)** for PR 13996 at commit

[GitHub] spark issue #13994: [BUILD] Fix version in poms related to kafka-0-10

2016-06-30 Thread tdas
Github user tdas commented on the issue: https://github.com/apache/spark/pull/13994 @srowen yes, i noticed that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #11863: [SPARK-12177][Streaming][Kafka] Update KafkaDStreams to ...

2016-06-30 Thread tdas
Github user tdas commented on the issue: https://github.com/apache/spark/pull/11863 I played around with the API and I found a few issues 1. I mentioned above, case classes lead to problems in the public API. The API could be simpler, and same for both Java and Scala users (dont

[GitHub] spark issue #13996: [SPARK-12177] Refactored some API in Kafka 0.10 to make ...

2016-06-30 Thread tdas
Github user tdas commented on the issue: https://github.com/apache/spark/pull/13996 @koeninger @zsxwing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #13996: [SPARK-12177] Refactored some API in Kafka 0.10 to make ...

2016-06-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13996 **[Test build #61541 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61541/consoleFull)** for PR 13996 at commit

[GitHub] spark pull request #13996: [SPARK-12177] Refactored some API in Kafka 0.10 t...

2016-06-30 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/13996#discussion_r69119515 --- Diff: external/kafka-0-10/src/main/java/org/apache/spark/streaming/kafka010/ConsumerStrategy.java --- @@ -0,0 +1,217 @@ +/* + * Licensed to the

[GitHub] spark pull request #13996: [SPARK-12177] Refactored some API in Kafka 0.10 t...

2016-06-30 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/13996#discussion_r69119555 --- Diff: external/kafka-0-10/src/main/java/org/apache/spark/streaming/kafka010/ConsumerStrategy.java --- @@ -0,0 +1,217 @@ +/* + * Licensed to the

[GitHub] spark issue #13976: [SPARK-16288][SQL] Implement inline table generating fun...

2016-06-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13976 **[Test build #61542 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61542/consoleFull)** for PR 13976 at commit

[GitHub] spark pull request #13993: [SPARK-16144][SPARKR] update R API doc for mllib

2016-06-30 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/13993#discussion_r69120905 --- Diff: R/pkg/R/mllib.R --- @@ -53,6 +53,28 @@ setClass("AFTSurvivalRegressionModel", representation(jobj = "jobj")) #' @note KMeansModel since

[GitHub] spark issue #13994: [BUILD] Fix version in poms related to kafka-0-10

2016-06-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13994 **[Test build #61537 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61537/consoleFull)** for PR 13994 at commit

[GitHub] spark issue #13906: [SPARK-16208][SQL] Add `CollapseEmptyPlan` optimizer

2016-06-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13906 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #13906: [SPARK-16208][SQL] Add `CollapseEmptyPlan` optimi...

2016-06-30 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/13906#discussion_r69111075 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/CollapseEmptyPlanSuite.scala --- @@ -0,0 +1,173 @@ +/* + * Licensed

[GitHub] spark pull request #13906: [SPARK-16208][SQL] Add `CollapseEmptyPlan` optimi...

2016-06-30 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/13906#discussion_r69111287 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/CollapseEmptyPlanSuite.scala --- @@ -0,0 +1,173 @@ +/* + *

[GitHub] spark issue #13758: [SPARK-16043][SQL] Prepare GenericArrayData implementati...

2016-06-30 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/13758 @cloud-fan, @hvanhovell I would appreciate it if you could review this again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #13906: [SPARK-16208][SQL] Add `CollapseEmptyPlan` optimizer

2016-06-30 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/13906 @liancheng . Now, the PR is updated again. - Use `AggregateFunction` instead of `DeclarativeAggregate` - Add explicit comments about INTERSECT/EXCEPT/AGGREGATE/GENERATOR. - Fix

[GitHub] spark issue #13906: [SPARK-16208][SQL] Add `CollapseEmptyPlan` optimizer

2016-06-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13906 **[Test build #61538 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61538/consoleFull)** for PR 13906 at commit

[GitHub] spark issue #13994: [BUILD] Fix version in poms related to kafka-0-10

2016-06-30 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/13994 Yeah, note to self, `master` should be on `2.1.0-SNAPSHOT` now too... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request #11863: [SPARK-12177][Streaming][Kafka] Update KafkaDStre...

2016-06-30 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/11863#discussion_r69116416 --- Diff: external/kafka-0-10/src/test/java/org/apache/spark/streaming/kafka010/JavaConsumerStrategySuite.java --- @@ -0,0 +1,84 @@ +/* + * Licensed

[GitHub] spark pull request #13994: [BUILD] Fix version in poms related to kafka-0-10

2016-06-30 Thread tdas
GitHub user tdas opened a pull request: https://github.com/apache/spark/pull/13994 [BUILD] Fix version in poms related to kafka-0-10 self explanatory You can merge this pull request into a Git repository by running: $ git pull https://github.com/tdas/spark SPARK-12177-1

[GitHub] spark pull request #13906: [SPARK-16208][SQL] Add `CollapseEmptyPlan` optimi...

2016-06-30 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/13906#discussion_r69111733 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/CollapseEmptyPlanSuite.scala --- @@ -0,0 +1,173 @@ +/* + *

[GitHub] spark issue #13680: [SPARK-15962][SQL] Introduce implementation with a dense...

2016-06-30 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/13680 @cloud-fan , could you please review this again? I added benchmark programs and their results, and addressed your review comments. --- If your project is set up for it, you can reply to this

[GitHub] spark pull request #13995: [MINOR] [BUILD] master branch should reference 2....

2016-06-30 Thread srowen
GitHub user srowen opened a pull request: https://github.com/apache/spark/pull/13995 [MINOR] [BUILD] master branch should reference 2.1.0-SNAPSHOT now that branch-2.0 exists ## What changes were proposed in this pull request? `master` branch should reference

[GitHub] spark pull request #13996: [SPARK-12177] Refactored some API in Kafka 0.10 t...

2016-06-30 Thread tdas
GitHub user tdas opened a pull request: https://github.com/apache/spark/pull/13996 [SPARK-12177] Refactored some API in Kafka 0.10 to make public API simpler ## What changes were proposed in this pull request? This refactoring make the public API simpler. Current version

[GitHub] spark pull request #13976: [SPARK-16288][SQL] Implement inline table generat...

2016-06-30 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/13976#discussion_r69117412 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala --- @@ -149,3 +149,42 @@ case class Explode(child:

[GitHub] spark pull request #13996: [SPARK-12177] Refactored some API in Kafka 0.10 t...

2016-06-30 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/13996#discussion_r69119461 --- Diff: external/kafka-0-10/src/main/java/org/apache/spark/streaming/kafka010/ConsumerStrategy.java --- @@ -0,0 +1,217 @@ +/* + * Licensed to the

[GitHub] spark issue #13906: [SPARK-16208][SQL] Add `CollapseEmptyPlan` optimizer

2016-06-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13906 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61535/ Test PASSed. ---

[GitHub] spark pull request #13996: [SPARK-12177] Refactored some API in Kafka 0.10 t...

2016-06-30 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/13996#discussion_r69119545 --- Diff: external/kafka-0-10/src/main/java/org/apache/spark/streaming/kafka010/ConsumerStrategy.java --- @@ -0,0 +1,217 @@ +/* + * Licensed to the

[GitHub] spark pull request #13996: [SPARK-12177] Refactored some API in Kafka 0.10 t...

2016-06-30 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/13996#discussion_r69119526 --- Diff: external/kafka-0-10/src/main/java/org/apache/spark/streaming/kafka010/ConsumerStrategy.java --- @@ -0,0 +1,217 @@ +/* + * Licensed to the

[GitHub] spark issue #13996: [SPARK-12177] Refactored some API in Kafka 0.10 to make ...

2016-06-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13996 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61541/ Test FAILed. ---

[GitHub] spark issue #13996: [SPARK-12177] Refactored some API in Kafka 0.10 to make ...

2016-06-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13996 **[Test build #61541 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61541/consoleFull)** for PR 13996 at commit

[GitHub] spark issue #13996: [SPARK-12177] Refactored some API in Kafka 0.10 to make ...

2016-06-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13996 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13996: [SPARK-12177] Refactored some API in Kafka 0.10 to make ...

2016-06-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13996 **[Test build #61543 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61543/consoleFull)** for PR 13996 at commit

[GitHub] spark pull request #13993: [SPARK-16144][SPARKR] update R API doc for mllib

2016-06-30 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/13993#discussion_r69121252 --- Diff: R/pkg/R/mllib.R --- @@ -53,6 +53,28 @@ setClass("AFTSurvivalRegressionModel", representation(jobj = "jobj")) #' @note KMeansModel since

[GitHub] spark issue #13994: [BUILD] Fix version in poms related to kafka-0-10

2016-06-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13994 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13994: [BUILD] Fix version in poms related to kafka-0-10

2016-06-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13994 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61537/ Test PASSed. ---

[GitHub] spark issue #13906: [SPARK-16208][SQL] Add `CollapseEmptyPlan` optimizer

2016-06-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13906 **[Test build #61535 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61535/consoleFull)** for PR 13906 at commit

[GitHub] spark pull request #13906: [SPARK-16208][SQL] Add `CollapseEmptyPlan` optimi...

2016-06-30 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13906#discussion_r69131609 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CollapseEmptyPlan.scala --- @@ -0,0 +1,72 @@ +/* + * Licensed to

[GitHub] spark pull request #13906: [SPARK-16208][SQL] Add `CollapseEmptyPlan` optimi...

2016-06-30 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13906#discussion_r69135425 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CollapseEmptyPlan.scala --- @@ -0,0 +1,72 @@ +/* + * Licensed to

[GitHub] spark issue #13494: [SPARK-15752] [SQL] support optimization for metadata on...

2016-06-30 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/13494 hi @lianhuiwang , we need to propagate partition information bottom up, but adding a `isMetadataColumn` to `NamedExpression` is kind of overkill. I tried to simplify it a little bit, and make it

[GitHub] spark issue #13996: [SPARK-12177] Refactored some API in Kafka 0.10 to make ...

2016-06-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13996 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13906: [SPARK-16208][SQL] Add `CollapseEmptyPlan` optimizer

2016-06-30 Thread liancheng
Github user liancheng commented on the issue: https://github.com/apache/spark/pull/13906 LGTM except for those comments @cloud-fan brought up. Thanks for working on this! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark issue #13924: [SPARK-15643][DOC][ML] Add breaking changes to ML migrat...

2016-06-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13924 **[Test build #61545 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61545/consoleFull)** for PR 13924 at commit

[GitHub] spark issue #13924: [SPARK-15643][DOC][ML] Add breaking changes to ML migrat...

2016-06-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13924 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61546/ Test PASSed. ---

[GitHub] spark issue #13933: [SPARK-16236] [SQL] Add Path Option back to Load API in ...

2016-06-30 Thread koertkuipers
Github user koertkuipers commented on the issue: https://github.com/apache/spark/pull/13933 For parquet, json etc. path not being put in options is not an issue since they don't retrieve it from the options On Jun 29, 2016 2:31 AM, "Xiao Li" wrote:

[GitHub] spark issue #13996: [SPARK-12177] Refactored some API in Kafka 0.10 to make ...

2016-06-30 Thread koeninger
Github user koeninger commented on the issue: https://github.com/apache/spark/pull/13996 I've got concerns about this, please don't merge these refactorings until I get a chance to look at it today On Jun 30, 2016 6:32 AM, "Tathagata Das" wrote:

[GitHub] spark issue #13994: [BUILD] Fix version in poms related to kafka-0-10

2016-06-30 Thread liancheng
Github user liancheng commented on the issue: https://github.com/apache/spark/pull/13994 Merging to branch-2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #13976: [SPARK-16288][SQL] Implement inline table generating fun...

2016-06-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13976 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #13967: [SPARK-16278][SPARK-16279][SQL] Implement map_key...

2016-06-30 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13967#discussion_r69140101 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -2753,6 +2753,22 @@ object functions { def size(e: Column): Column =

[GitHub] spark pull request #13906: [SPARK-16208][SQL] Add `CollapseEmptyPlan` optimi...

2016-06-30 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/13906#discussion_r69140206 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CollapseEmptyPlan.scala --- @@ -0,0 +1,70 @@ +/* + * Licensed to

[GitHub] spark pull request #13971: [SPARK-16289][SQL] Implement posexplode table gen...

2016-06-30 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13971#discussion_r69141133 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/GeneratorExpressionSuite.scala --- @@ -0,0 +1,71 @@ +/* + *

[GitHub] spark issue #13924: [SPARK-15643][DOC][ML] Add breaking changes to ML migrat...

2016-06-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13924 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13760: [SPARK-16012][SparkR] implement gapplyCollect which will...

2016-06-30 Thread NarineK
Github user NarineK commented on the issue: https://github.com/apache/spark/pull/13760 Do you have any questions on this @shivaram , @sun-rui ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request #13991: [SPARK-16318][SQL] Implement various xpath functi...

2016-06-30 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13991#discussion_r69145330 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/xml/XPathExpressionSuite.scala --- @@ -27,33 +27,127 @@ import

[GitHub] spark pull request #13617: [SPARK-10409] [ML] Add Multilayer Perceptron Regr...

2016-06-30 Thread JeremyNixon
Github user JeremyNixon commented on a diff in the pull request: https://github.com/apache/spark/pull/13617#discussion_r69146687 --- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala --- @@ -438,6 +478,27 @@ private[ml] object FeedForwardTopology { }

[GitHub] spark pull request #13894: [SPARK-15254][DOC] Improve ML pipeline Cross Vali...

2016-06-30 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/13894#discussion_r69132570 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala --- @@ -56,7 +56,10 @@ private[ml] trait CrossValidatorParams extends

[GitHub] spark issue #13976: [SPARK-16288][SQL] Implement inline table generating fun...

2016-06-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13976 **[Test build #61542 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61542/consoleFull)** for PR 13976 at commit

[GitHub] spark issue #13829: [SPARK-16071][SQL] Checks size limit when doubling the a...

2016-06-30 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/13829 thanks, merging to master/2.0! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #13924: [SPARK-15643][DOC][ML] Add breaking changes to ML migrat...

2016-06-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13924 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61545/ Test PASSed. ---

  1   2   3   4   5   6   7   8   >