Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/13704
@cloud-fan , regarding a ```cast```, I think that you are correct. When we
insert a ```cast```, I pass information on ```ArrayType.containsNull``` to
```Cast``` now. In this case, it is ```false```.
Github user techaddict commented on the issue:
https://github.com/apache/spark/pull/13990
cc: @cloud-fan @rxin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13680#discussion_r69386603
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/UnsafeArrayDataBenchmark.scala
---
@@ -0,0 +1,298 @@
+/*
+ * Licensed to
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13680#discussion_r69386599
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java
---
@@ -25,30 +25,36 @@
import
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14033
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61675/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14033
**[Test build #61675 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61675/consoleFull)**
for PR 14033 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14033
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user techaddict closed the pull request at:
https://github.com/apache/spark/pull/14032
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13704
**[Test build #61677 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61677/consoleFull)**
for PR 13704 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13704
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61677/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13704
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14008#discussion_r69386854
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -652,6 +656,163 @@ case class
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14008#discussion_r69386898
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -652,6 +656,163 @@ case class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14004
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14004
**[Test build #61680 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61680/consoleFull)**
for PR 14004 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14035
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14036
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61682/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14036
**[Test build #61682 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61682/consoleFull)**
for PR 14036 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14035
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61681/
Test PASSed.
---
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13976#discussion_r69388270
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala
---
@@ -195,3 +195,38 @@ case class Explode(child:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/9207
**[Test build #61683 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61683/consoleFull)**
for PR 9207 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/9207
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61683/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/9207
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13532#discussion_r69388379
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DatasetAggregatorSuite.scala ---
@@ -305,4 +305,13 @@ class DatasetAggregatorSuite extends
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/9207
**[Test build #61683 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61683/consoleFull)**
for PR 9207 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/9207
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/9207
**[Test build #61684 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61684/consoleFull)**
for PR 9207 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13990
**[Test build #61685 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61685/consoleFull)**
for PR 13990 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14036
**[Test build #61686 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61686/consoleFull)**
for PR 14036 at commit
Github user janplus commented on a diff in the pull request:
https://github.com/apache/spark/pull/14008#discussion_r69386564
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -652,6 +656,163 @@ case class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13680#discussion_r69386582
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/UnsafeArrayWriter.java
---
@@ -33,91 +38,147 @@
// The offset
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13680#discussion_r69386561
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/UnsafeArrayWriter.java
---
@@ -19,9 +19,14 @@
import
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13680#discussion_r69386593
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java
---
@@ -341,63 +324,113 @@ public UnsafeArrayData copy()
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13680#discussion_r69386586
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/UnsafeArrayWriter.java
---
@@ -33,91 +38,147 @@
// The offset
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13680#discussion_r69386574
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/UnsafeArrayWriter.java
---
@@ -33,91 +38,147 @@
// The offset
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13680#discussion_r69386595
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java
---
@@ -317,7 +301,6 @@ public boolean equals(Object
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14035
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14035
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61679/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14035
**[Test build #61679 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61679/consoleFull)**
for PR 14035 at commit
Github user janplus commented on a diff in the pull request:
https://github.com/apache/spark/pull/14008#discussion_r69386280
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -652,6 +656,163 @@ case class
Github user janplus commented on a diff in the pull request:
https://github.com/apache/spark/pull/14008#discussion_r69386305
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -652,6 +656,163 @@ case class
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14008#discussion_r69386335
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -652,6 +656,163 @@ case class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14004
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61680/
Test PASSed.
---
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/14007
and also 1.6 please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user techaddict commented on the issue:
https://github.com/apache/spark/pull/14036
cc: @cloud-fan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14004#discussion_r69388199
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -801,6 +804,49 @@ public static UTF8String concatWs(UTF8String
GitHub user techaddict opened a pull request:
https://github.com/apache/spark/pull/14036
[SPARK-16323] [SQL] Add IntegerDivide to avoid unnecessary cast
## What changes were proposed in this pull request?
Add IntegerDivide to avoid unnecessary cast
Before:
```
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/9207
**[Test build #61684 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61684/consoleFull)**
for PR 9207 at commit
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14035#discussion_r69390189
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/RandomForestClassifierSuite.scala
---
@@ -158,7 +159,7 @@ class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14035#discussion_r69390204
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/evaluation/RegressionEvaluatorSuite.scala
---
@@ -42,9 +43,10 @@ class RegressionEvaluatorSuite
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14035#discussion_r69390216
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/CountVectorizerSuite.scala ---
@@ -44,7 +45,7 @@ class CountVectorizerSuite extends
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14035#discussion_r69391151
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/GeneralizedLinearRegressionSuite.scala
---
@@ -52,23 +53,20 @@ class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14035#discussion_r69391139
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/VectorIndexerSuite.scala ---
@@ -102,7 +103,7 @@ class VectorIndexerSuite extends
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14035#discussion_r69391176
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/util/MLUtilsSuite.scala ---
@@ -282,9 +281,7 @@ class MLUtilsSuite extends SparkFunSuite with
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13704#discussion_r69391625
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -837,8 +837,36 @@ case class Cast(child: Expression,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14031
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14031
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61687/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14031
**[Test build #61687 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61687/consoleFull)**
for PR 14031 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14031
**[Test build #61687 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61687/consoleFull)**
for PR 14031 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14036
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14036
**[Test build #61686 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61686/consoleFull)**
for PR 14036 at commit
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14035#discussion_r69390132
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/GBTClassifierSuite.scala
---
@@ -134,15 +135,14 @@ class GBTClassifierSuite
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14035#discussion_r69390144
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
---
@@ -55,7 +56,7 @@ class LogisticRegressionSuite
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14035#discussion_r69390147
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
---
@@ -869,8 +870,7 @@ class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14035#discussion_r69390185
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/OneVsRestSuite.scala ---
@@ -55,7 +56,7 @@ class OneVsRestSuite extends
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14035#discussion_r69390178
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/NaiveBayesSuite.scala
---
@@ -47,7 +48,7 @@ class NaiveBayesSuite extends
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14035#discussion_r69390388
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/NormalizerSuite.scala ---
@@ -61,7 +62,7 @@ class NormalizerSuite extends SparkFunSuite
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14035#discussion_r69390273
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/MinMaxScalerSuite.scala ---
@@ -57,8 +58,7 @@ class MinMaxScalerSuite extends
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14035#discussion_r69390423
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/OneHotEncoderSuite.scala ---
@@ -29,10 +29,11 @@ import org.apache.spark.sql.types._
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14035#discussion_r69391120
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/StringIndexerSuite.scala ---
@@ -39,7 +40,7 @@ class StringIndexerSuite
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13990#discussion_r69392032
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -393,3 +393,73 @@ case class
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14031
Jenkins add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14031
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14031
Jenkins test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14036
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61686/
Test FAILed.
---
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14035#discussion_r69390117
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/ClassifierSuite.scala
---
@@ -71,8 +71,7 @@ class ClassifierSuite extends
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14035#discussion_r69390173
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifierSuite.scala
---
@@ -116,7 +117,7 @@ class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13990
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61685/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13990
**[Test build #61685 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61685/consoleFull)**
for PR 13990 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13990
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14036#discussion_r69392061
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
---
@@ -234,6 +234,7 @@ object FunctionRegistry {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13990#discussion_r69392045
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2471,6 +2471,24 @@ object functions {
def second(e: Column): Column =
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14004
Rebased to resolve conflicts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14033
Rebased to resolve conflicts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14033
cc @rxin and @cloud-fan .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14033
**[Test build #61693 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61693/consoleFull)**
for PR 14033 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13494#discussion_r69394848
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2865,4 +2865,15 @@ class SQLQuerySuite extends QueryTest with
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14004
**[Test build #61694 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61694/consoleFull)**
for PR 14004 at commit
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/13976#discussion_r69394891
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala
---
@@ -195,3 +195,38 @@ case class Explode(child:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13494#discussion_r69394890
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/MetadataOnlyOptimizer.scala
---
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the Apache
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13494#discussion_r69394921
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkOptimizer.scala ---
@@ -30,6 +30,7 @@ class SparkOptimizer(
extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13494#discussion_r69394970
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/MetadataOnlyOptimizerSuite.scala
---
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13494#discussion_r69395014
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/MetadataOnlyOptimizerSuite.scala
---
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13494#discussion_r69395021
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2865,4 +2865,15 @@ class SQLQuerySuite extends QueryTest with
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14008
So far, there were some different opinions on `new URL` error handling and
`Literal Pattern` handling. It's a frequent pattern of comments. :)
I agree @cloud-fan 's opinions also. If I
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/13494
LGTM exception some naming/testing comments.
This is not a small patch and definitely need more reviewers. Let's also
add more comments inside the new rule to make it easier to review.
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13976#discussion_r69395123
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala
---
@@ -195,3 +195,38 @@ case class Explode(child:
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13976
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/13976
merging to master, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13971#discussion_r69395230
--- Diff: python/pyspark/sql/functions.py ---
@@ -1637,6 +1637,27 @@ def explode(col):
return Column(jc)
+@since(2.1)
+def
101 - 200 of 312 matches
Mail list logo
