Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14958
@yhuai ack OK I'll fix that. I must have managed to miss something in the
deps file when I resolved conflicts on the cherry pick. It can't be complex to
touch up though.
---
If your project is set
Github user junyangq commented on a diff in the pull request:
https://github.com/apache/spark/pull/14980#discussion_r7495
--- Diff: R/pkg/vignettes/sparkr-vignettes.Rmd ---
@@ -0,0 +1,853 @@
+---
+title: "SparkR - Practical Guide"
+output:
+ html_document:
GitHub user srowen opened a pull request:
https://github.com/apache/spark/pull/14992
[SPARK-17378] [HOTFIX] Upgrade snappy-java to 1.1.2.6 -- fix Hadoop 1 deps
## What changes were proposed in this pull request?
Also update Hadoop 1 deps file to reflect Snappy 1.1.2.6
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14949
@jkbradley @zhengruifeng @MLnick I wonder if I could ask you for comments
on this change? it's a behavior change, so not something I'd do lightly, but I
do think it improves the semantics here.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/14914
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14619
**[Test build #65033 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65033/consoleFull)**
for PR 14619 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14788
**[Test build #65034 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65034/consoleFull)**
for PR 14788 at commit
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/14788#discussion_r77794368
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -72,57 +72,76 @@ case class
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/14991
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/14993
cc @jkbradley @mengxr @shivaram @felixcheung @junyangq
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14136
**[Test build #65036 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65036/consoleFull)**
for PR 14136 at commit
Github user tone-zhang commented on the issue:
https://github.com/apache/spark/pull/14894
@srowen I checked DDLSuite.scala, the case "Create Database using Default
Warehouse Path" is used to test the default "spark-warehouse" setting. In the
doc, the default path should be
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14788
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65034/
Test PASSed.
---
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14962#discussion_r77809524
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLViewSuite.scala
---
@@ -95,12 +95,12 @@ class SQLViewSuite extends QueryTest
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14788
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14995
**[Test build #65041 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65041/consoleFull)**
for PR 14995 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14962#discussion_r77810897
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -159,12 +171,13 @@ case class AlterTableRenameCommand(
Github user lianhuiwang commented on the issue:
https://github.com/apache/spark/pull/13979
@JoshRosen Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
GitHub user witgo opened a pull request:
https://github.com/apache/spark/pull/14995
[Test Only][not ready for review][SPARK-6235][CORE]Address various 2G
limits
## What changes were proposed in this pull request?
### motivation
The various 2G limit in Spark.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14980
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65037/
Test FAILed.
---
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14962#discussion_r77809642
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -159,12 +171,13 @@ case class AlterTableRenameCommand(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14719#discussion_r77820548
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -524,11 +524,16 @@ class Analyzer(
val
Github user witgo closed the pull request at:
https://github.com/apache/spark/pull/14977
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14994
**[Test build #65038 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65038/consoleFull)**
for PR 14994 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14995
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14995
**[Test build #65039 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65039/consoleFull)**
for PR 14995 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14995
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65039/
Test FAILed.
---
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/14962
> Found a common bug in the following ALTER TABLE commands:
let's fix them in separated PRs.
> In addition, we need to carefully review all the places that are using
these three
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14961
Hm, I can't get this test to fail with Netty 4.0.41 when I 'mvn install'
and run the test suite locally. I'm having a hard time seeing what could
alleviate the failure.
I suspect that this
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/14994
[SPARK-17432][SQL] PreprocessDDL should respect case sensitivity when
checking duplicated columns
## What changes were proposed in this pull request?
In `PreprocessDDL` we will check if
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/14994
cc @yhuai @gatorsmile
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14750
**[Test build #65040 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65040/consoleFull)**
for PR 14750 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14995
**[Test build #65039 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65039/consoleFull)**
for PR 14995 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14962#discussion_r77808727
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/TempViewManager.scala
---
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14894
Yes, I think it wouldn't hurt to always try to delete the default
spark-warehouse in this suite after each test. Try running all tests after
you're done to see if anything leaves it behind; the goal
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14136
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65036/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14136
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14962#discussion_r77808532
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -189,31 +189,39 @@ case class DropTableCommand(
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14788
**[Test build #65034 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65034/consoleFull)**
for PR 14788 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14980
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14980
**[Test build #65037 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65037/consoleFull)**
for PR 14980 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14988#discussion_r77812716
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveTableScanExec.scala
---
@@ -164,4 +164,11 @@ case class HiveTableScanExec(
Github user junyangq commented on a diff in the pull request:
https://github.com/apache/spark/pull/14980#discussion_r5442
--- Diff: R/pkg/vignettes/sparkr-vignettes.Rmd ---
@@ -0,0 +1,853 @@
+---
+title: "SparkR - Practical Guide"
+output:
+ html_document:
Github user junyangq commented on a diff in the pull request:
https://github.com/apache/spark/pull/14980#discussion_r7073
--- Diff: R/pkg/vignettes/sparkr-vignettes.Rmd ---
@@ -0,0 +1,853 @@
+---
+title: "SparkR - Practical Guide"
+output:
+ html_document:
Github user junyangq commented on a diff in the pull request:
https://github.com/apache/spark/pull/14980#discussion_r7086
--- Diff: R/pkg/vignettes/sparkr-vignettes.Rmd ---
@@ -0,0 +1,853 @@
+---
+title: "SparkR - Practical Guide"
+output:
+ html_document:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14960
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14960
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65030/
Test PASSed.
---
GitHub user yanboliang opened a pull request:
https://github.com/apache/spark/pull/14993
[SPARK-15509][Follow-up][ML][SparkR] R MLlib algorithms should support
input columns "features" and "label"
## What changes were proposed in this pull request?
(Please fill in changes
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/14788
Looks pretty good. I left a few more comments.
Could you also add a test for TruncDate that covers a day light saving
scenario?
---
If your project is set up for it, you can reply to
Github user Stibbons commented on the issue:
https://github.com/apache/spark/pull/14180
I have written a blog post about this pull request to explain what we can
do with it: http://www.great-a-blog.co/wheel-deployment-for-pyspark/
---
If your project is set up for it, you can reply
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14619
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65033/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14619
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user junyangq commented on a diff in the pull request:
https://github.com/apache/spark/pull/14980#discussion_r77780090
--- Diff: R/pkg/vignettes/sparkr-vignettes.Rmd ---
@@ -0,0 +1,853 @@
+---
+title: "SparkR - Practical Guide"
+output:
+ html_document:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14989
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65028/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14989
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14788#discussion_r77796464
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2551,7 +2551,11 @@ object functions {
* Returns date truncated to
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14788#discussion_r77799005
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -834,8 +874,29 @@ object DateTimeUtils {
}
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14976
**[Test build #65032 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65032/consoleFull)**
for PR 14976 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/14989
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/14984
Merging to 2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14992
**[Test build #65031 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65031/consoleFull)**
for PR 14992 at commit
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14788#discussion_r77794238
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -916,21 +944,25 @@ case class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14788#discussion_r77796182
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -72,57 +72,76 @@ case class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14788#discussion_r77796067
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -72,57 +72,76 @@ case class
Github user sarutak commented on the issue:
https://github.com/apache/spark/pull/14960
LGTM. Merging this into `master` and `branch-2.0`. Thanks @HyukjinKwon !
And thanks @shivaram and @felixcheung for the review !
---
If your project is set up for it, you can reply to this
Github user ChinaChaos commented on the issue:
https://github.com/apache/spark/pull/14577
HI @Sherry302 , @srowen , @rxin
this patch will make the UI not compatible with Firefox and safari;
Started time, Completed time,Last Updated time cant display
rightï¼just like
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14788#discussion_r77799138
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -834,8 +874,29 @@ object DateTimeUtils {
}
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14619
**[Test build #65033 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65033/consoleFull)**
for PR 14619 at commit
Github user junyangq commented on a diff in the pull request:
https://github.com/apache/spark/pull/14980#discussion_r77804870
--- Diff: R/pkg/vignettes/sparkr-vignettes.Rmd ---
@@ -0,0 +1,853 @@
+---
+title: "SparkR - Practical Guide"
+output:
+ html_document:
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14956
@mateiz pardon for the ping but I think you authored the line / comment I'm
changing here. See my note at
https://github.com/apache/spark/pull/14948#issuecomment-244597251 -- does that
logic make
Github user junyangq commented on a diff in the pull request:
https://github.com/apache/spark/pull/14980#discussion_r9369
--- Diff: R/pkg/vignettes/sparkr-vignettes.Rmd ---
@@ -0,0 +1,853 @@
+---
+title: "SparkR - Practical Guide"
+output:
+ html_document:
Github user tangpengbupt commented on a diff in the pull request:
https://github.com/apache/spark/pull/14577#discussion_r77793610
--- Diff: core/src/main/resources/org/apache/spark/ui/static/historypage.js
---
@@ -31,9 +31,20 @@ function makeIdNumeric(id) {
return resl;
Github user tangpengbupt commented on a diff in the pull request:
https://github.com/apache/spark/pull/14577#discussion_r77793614
--- Diff: core/src/main/resources/org/apache/spark/ui/static/historypage.js
---
@@ -31,9 +31,20 @@ function makeIdNumeric(id) {
return resl;
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14993
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14993
**[Test build #65035 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65035/consoleFull)**
for PR 14993 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14993
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65035/
Test PASSed.
---
Github user srowen closed the pull request at:
https://github.com/apache/spark/pull/14992
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14976
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65032/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14976
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14980
**[Test build #65037 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65037/consoleFull)**
for PR 14980 at commit
Github user junyangq commented on a diff in the pull request:
https://github.com/apache/spark/pull/14980#discussion_r9018
--- Diff: R/pkg/vignettes/sparkr-vignettes.Rmd ---
@@ -0,0 +1,853 @@
+---
+title: "SparkR - Practical Guide"
+output:
+ html_document:
Github user junyangq commented on a diff in the pull request:
https://github.com/apache/spark/pull/14980#discussion_r77780774
--- Diff: R/pkg/vignettes/sparkr-vignettes.Rmd ---
@@ -0,0 +1,853 @@
+---
+title: "SparkR - Practical Guide"
+output:
+ html_document:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14960
**[Test build #65030 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65030/consoleFull)**
for PR 14960 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14993
**[Test build #65035 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65035/consoleFull)**
for PR 14993 at commit
Github user sarutak commented on the issue:
https://github.com/apache/spark/pull/14960
I noticed this PR is not able to be merged cleanly to `branch-2.0`.
@HyukjinKwon If you would like to merge this into `branch-2.0`, please feel
free to open another PR.
---
If your project is
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/14960
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14788#discussion_r77797979
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -42,12 +42,20 @@ object DateTimeUtils {
//
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14788#discussion_r77798052
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -42,12 +42,20 @@ object DateTimeUtils {
//
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14985
**[Test build #3252 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3252/consoleFull)**
for PR 14985 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14136
**[Test build #65036 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65036/consoleFull)**
for PR 14136 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14985
Looks good to me as a minimal change. It's not hard to use the Java
executors here too if that would be preferable but would require more rewrite
and some more code.
---
If your project is set up
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14985
**[Test build #3252 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3252/consoleFull)**
for PR 14985 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14989
**[Test build #65028 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65028/consoleFull)**
for PR 14989 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14976
**[Test build #65032 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65032/consoleFull)**
for PR 14976 at commit
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14788#discussion_r77793869
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -72,57 +72,76 @@ case class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14788#discussion_r77798210
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -90,6 +98,14 @@ object DateTimeUtils {
}
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14788
Sure. Thanks for your close look. I will address the comments tomorrow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14989
Merged to master/2.0
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user junyangq commented on a diff in the pull request:
https://github.com/apache/spark/pull/14980#discussion_r8144
--- Diff: R/pkg/vignettes/sparkr-vignettes.Rmd ---
@@ -0,0 +1,853 @@
+---
+title: "SparkR - Practical Guide"
+output:
+ html_document:
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14981
Good question. The Kinesis (non-assembly) artifact does not itself bundle
any Amazon-licensed code. However it of course strongly depends on it.
But, the Kinesis artifact itself is optional
1 - 100 of 555 matches
Mail list logo