[GitHub] spark issue #15889: [SPARK-18445][BUILD][DOCS] Fix the markdown for `Note:`/...

2016-11-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15889 **[Test build #68850 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68850/consoleFull)** for PR 15889 at commit

[GitHub] spark issue #15866: [SPARK-18422][CORE] Fix wholeTextFiles test to pass on W...

2016-11-18 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15866 OK if it makes the test in question here pass, let's merge it, as a fix for that test. That much is OK right @HyukjinKwon ? --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request #15907: [SPARK-18458][CORE] Fix signed integer overflow p...

2016-11-18 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/15907#discussion_r88670855 --- Diff: core/src/test/scala/org/apache/spark/util/collection/unsafe/sort/RadixSortSuite.scala --- @@ -30,7 +32,7 @@ import

[GitHub] spark issue #15930: [SPARK-18501][ML][SparkR] Fix spark.glm errors when fitt...

2016-11-18 Thread yanboliang
Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/15930 cc @felixcheung --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark pull request #15901: [SPARK-18467][SQL] Extracts method for preparing ...

2016-11-18 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/15901#discussion_r88682412 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -245,51 +311,31 @@ case class NewInstance(

[GitHub] spark issue #15889: [SPARK-18445][BUILD][DOCS] Fix the markdown for `Note:`/...

2016-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15889 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68850/ Test PASSed. ---

[GitHub] spark issue #14038: [SPARK-16317][SQL] Add a new interface to filter files i...

2016-11-18 Thread steveloughran
Github user steveloughran commented on the issue: https://github.com/apache/spark/pull/14038 @maropu if you create a PR for your work I'll comment on it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark issue #15927: [SPARK-18500][SQL] Make GenericStrategy be able to prune...

2016-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15927 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #15932: [SPARK-18448][CORE] SparkSession should implement...

2016-11-18 Thread srowen
GitHub user srowen opened a pull request: https://github.com/apache/spark/pull/15932 [SPARK-18448][CORE] SparkSession should implement java.lang.AutoCloseable like JavaSparkContext ## What changes were proposed in this pull request? Just adds `close()` + `Closeable` as a

[GitHub] spark issue #15932: [SPARK-18448][CORE] SparkSession should implement java.l...

2016-11-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15932 **[Test build #68854 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68854/consoleFull)** for PR 15932 at commit

[GitHub] spark issue #15927: [SPARK-18500][SQL] Make GenericStrategy be able to prune...

2016-11-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15927 **[Test build #68852 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68852/consoleFull)** for PR 15927 at commit

[GitHub] spark issue #15927: [SPARK-18500][SQL] Make GenericStrategy be able to prune...

2016-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15927 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68852/ Test PASSed. ---

[GitHub] spark issue #15866: [SPARK-18422][CORE] Fix wholeTextFiles test to pass on W...

2016-11-18 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15866 Yes please. I am pretty sure that this is a right fix without any other side effects. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request #15901: [SPARK-18467][SQL] Extracts method for preparing ...

2016-11-18 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/15901#discussion_r88682370 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -164,28 +232,26 @@ case class Invoke(

[GitHub] spark pull request #13930: [SPARK-16228][SQL] HiveSessionCatalog should retu...

2016-11-18 Thread fabboe
Github user fabboe commented on a diff in the pull request: https://github.com/apache/spark/pull/13930#discussion_r88684273 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveUDFSuite.scala --- @@ -142,6 +142,13 @@ class HiveUDFSuite extends QueryTest with

[GitHub] spark issue #15868: [SPARK-18413][SQL] Add `maxConnections` JDBCOption

2016-11-18 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15868 Thank you for review again, @cloud-fan , @liancheng , and @srowen . I had the same opinion with @srowen . Also, let's think about the background of this issue. Currently, in

[GitHub] spark issue #13909: [SPARK-16213][SQL] Reduce runtime overhead of a program ...

2016-11-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13909 **[Test build #68856 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68856/consoleFull)** for PR 13909 at commit

[GitHub] spark pull request #13909: [SPARK-16213][SQL] Reduce runtime overhead of a p...

2016-11-18 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/13909#discussion_r88675871 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameComplexTypeSuite.scala --- @@ -26,6 +26,20 @@ import

[GitHub] spark pull request #15889: [SPARK-18445][BUILD][DOCS] Fix the markdown for `...

2016-11-18 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/15889#discussion_r88679304 --- Diff: core/src/main/scala/org/apache/spark/rdd/PairRDDFunctions.scala --- @@ -57,15 +57,18 @@ class PairRDDFunctions[K, V](self: RDD[(K, V)])

[GitHub] spark issue #15898: [SPARK-18457][SQL] ORC and other columnar formats using ...

2016-11-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15898 **[Test build #68853 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68853/consoleFull)** for PR 15898 at commit

[GitHub] spark issue #15898: [SPARK-18457][SQL] ORC and other columnar formats using ...

2016-11-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15898 **[Test build #68853 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68853/consoleFull)** for PR 15898 at commit

[GitHub] spark issue #15868: [SPARK-18413][SQL] Add `maxConnections` JDBCOption

2016-11-18 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15868 For document, may I add more description about the behavior to help the user understanding? **BEFORE** > The number of JDBC connections, which specifies the maximum number of

[GitHub] spark issue #15898: [SPARK-18457][SQL] ORC and other columnar formats using ...

2016-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15898 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68853/ Test PASSed. ---

[GitHub] spark pull request #13909: [SPARK-16213][SQL] Reduce runtime overhead of a p...

2016-11-18 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/13909#discussion_r88680455 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CodeGenerationSuite.scala --- @@ -117,7 +117,10 @@ class CodeGenerationSuite

[GitHub] spark pull request #15901: [SPARK-18467][SQL] Extracts method for preparing ...

2016-11-18 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/15901#discussion_r88684544 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -164,23 +233,20 @@ case class Invoke(

[GitHub] spark issue #15889: [SPARK-18445][BUILD][DOCS] Fix the markdown for `Note:`/...

2016-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15889 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #13909: [SPARK-16213][SQL] Reduce runtime overhead of a p...

2016-11-18 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/13909#discussion_r88671591 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala --- @@ -56,29 +56,50 @@ case class

[GitHub] spark issue #15898: [SPARK-18457][SQL] ORC and other columnar formats using ...

2016-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15898 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13909: [SPARK-16213][SQL] Reduce runtime overhead of a program ...

2016-11-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13909 **[Test build #68857 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68857/consoleFull)** for PR 13909 at commit

[GitHub] spark pull request #15780: [SPARK-18284][SQL] Make ExpressionEncoder.seriali...

2016-11-18 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/15780#discussion_r88683023 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala --- @@ -574,7 +574,12 @@ object ScalaReflection extends

[GitHub] spark issue #15932: [SPARK-18448][CORE] SparkSession should implement java.l...

2016-11-18 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15932 Sure I'll put it in first thing tomorrow if there are no objections. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark issue #15868: [SPARK-18413][SQL] Add `maxConnections` JDBCOption

2016-11-18 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15868 Yeah, please improve the document comments and PR descriptions. It sounds like this is almost ready to merge after these changes. --- If your project is set up for it, you can reply to

[GitHub] spark issue #15868: [SPARK-18413][SQL] Add `maxConnections` JDBCOption

2016-11-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15868 **[Test build #68871 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68871/consoleFull)** for PR 15868 at commit

[GitHub] spark issue #15933: [SPARK-18505][SQL] Simplify AnalyzeColumnCommand

2016-11-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15933 **[Test build #68872 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68872/consoleFull)** for PR 15933 at commit

[GitHub] spark pull request #15935: [SPARK-] add checksum for blocks of broadcast

2016-11-18 Thread davies
GitHub user davies opened a pull request: https://github.com/apache/spark/pull/15935 [SPARK-] add checksum for blocks of broadcast ## What changes were proposed in this pull request? A TorrentBroadcast is serialized and compressed first, then splitted as fixed size blocks,

[GitHub] spark issue #13065: [SPARK-15214][SQL] Code-generation for Generate

2016-11-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13065 **[Test build #68875 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68875/consoleFull)** for PR 13065 at commit

[GitHub] spark issue #15936: [SPARK-18504][SQL] Scalar subquery with extra group by c...

2016-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15936 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #15935: [SPARK-18188] add checksum for blocks of broadcast

2016-11-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15935 **[Test build #68874 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68874/consoleFull)** for PR 15935 at commit

[GitHub] spark issue #15936: [SPARK-18504][SQL] Scalar subquery with extra group by c...

2016-11-18 Thread nsyca
Github user nsyca commented on the issue: https://github.com/apache/spark/pull/15936 I think I have contaminated the PR with some of my old code. I will push a new PR soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request #11119: [SPARK-10780][ML] Add an initial model to kmeans

2016-11-18 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/9#discussion_r88713359 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala --- @@ -284,11 +309,26 @@ class KMeans @Since("1.5.0") ( /** @group

[GitHub] spark pull request #11119: [SPARK-10780][ML] Add an initial model to kmeans

2016-11-18 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/9#discussion_r88715322 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala --- @@ -306,6 +346,25 @@ class KMeans @Since("1.5.0") ( @Since("1.5.0")

[GitHub] spark pull request #11119: [SPARK-10780][ML] Add an initial model to kmeans

2016-11-18 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/9#discussion_r88725396 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala --- @@ -35,7 +38,25 @@ import org.apache.spark.sql.functions.{col, udf}

[GitHub] spark pull request #11119: [SPARK-10780][ML] Add an initial model to kmeans

2016-11-18 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/9#discussion_r88713635 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala --- @@ -284,11 +309,26 @@ class KMeans @Since("1.5.0") ( /** @group

[GitHub] spark pull request #11119: [SPARK-10780][ML] Add an initial model to kmeans

2016-11-18 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/9#discussion_r88714626 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala --- @@ -124,7 +147,8 @@ class KMeansModel private[ml] ( @Since("2.0.0")

[GitHub] spark pull request #11119: [SPARK-10780][ML] Add an initial model to kmeans

2016-11-18 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/9#discussion_r88713108 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala --- @@ -414,6 +414,8 @@ object KMeans { val RANDOM = "random"

[GitHub] spark pull request #11119: [SPARK-10780][ML] Add an initial model to kmeans

2016-11-18 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/9#discussion_r88725427 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala --- @@ -35,7 +38,25 @@ import org.apache.spark.sql.functions.{col, udf}

[GitHub] spark pull request #11119: [SPARK-10780][ML] Add an initial model to kmeans

2016-11-18 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/9#discussion_r88722547 --- Diff: mllib/src/test/scala/org/apache/spark/ml/clustering/KMeansSuite.scala --- @@ -145,18 +150,67 @@ class KMeansSuite extends SparkFunSuite with

[GitHub] spark pull request #11119: [SPARK-10780][ML] Add an initial model to kmeans

2016-11-18 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/9#discussion_r88724978 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala --- @@ -35,7 +38,25 @@ import org.apache.spark.sql.functions.{col, udf}

[GitHub] spark issue #15870: [SPARK-18425][Structured Streaming][Tests] Test `Compact...

2016-11-18 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/15870 Thanks for doing this. Could you resolve the conflicts, please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #15874: [Spark-18408][ML] API Improvements for LSH

2016-11-18 Thread Yunni
Github user Yunni commented on the issue: https://github.com/apache/spark/pull/15874 @jkbradley Awesome, thanks so much! :) Now that the API is finalized, I will work on the User Doc --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark issue #15868: [SPARK-18413][SQL] Add `maxConnections` JDBCOption

2016-11-18 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15868 > This option applies only to writing with additional coalesce operation. It is not clear. We do not always call `coalesce`. : ) --- If your project is set up for it, you can reply to

[GitHub] spark pull request #15933: [SPARK-18505][SQL] Simplify AnalyzeColumnCommand

2016-11-18 Thread rxin
GitHub user rxin opened a pull request: https://github.com/apache/spark/pull/15933 [SPARK-18505][SQL] Simplify AnalyzeColumnCommand ## What changes were proposed in this pull request? I'm spending more time at the design & code level for cost-based optimizer now, and have found

[GitHub] spark pull request #15933: [SPARK-18505][SQL] Simplify AnalyzeColumnCommand

2016-11-18 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15933#discussion_r88747950 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala --- @@ -97,7 +97,7 @@ private[hive] class HiveClientImpl( }

[GitHub] spark issue #15868: [SPARK-18413][SQL] Add `maxConnections` JDBCOption

2016-11-18 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15868 Documentation and PR descriptions are updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #15923: [SPARK-4105] retry the fetch or stage if shuffle block i...

2016-11-18 Thread davies
Github user davies commented on the issue: https://github.com/apache/spark/pull/15923 @joshrosen @zsxwing Could you help to review this one ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request #13065: [SPARK-15214][SQL] Code-generation for Generate

2016-11-18 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/13065#discussion_r88753306 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.scala --- @@ -103,5 +109,182 @@ case class GenerateExec( }

[GitHub] spark issue #15874: [Spark-18408][ML] API Improvements for LSH

2016-11-18 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/15874 @Yunni Thanks for the updates! I don't think we should include AND-amplification for 2.1 since we're already in QA. But it'd be nice to get it in 2.2. Also, 2.2 will give us plenty of time to

[GitHub] spark issue #15926: [SPARK-16803] [SQL] SaveAsTable does not work when targe...

2016-11-18 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15926 cc @cloud-fan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark pull request #15866: [SPARK-18422][CORE] Fix wholeTextFiles test to pa...

2016-11-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/15866 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #15866: [SPARK-18422][CORE] Fix wholeTextFiles test to pass on W...

2016-11-18 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/15866 Merged to master/2.1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #15934: [SPARK-18497][SS]Make ForeachSink support watermark

2016-11-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15934 **[Test build #68873 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68873/consoleFull)** for PR 15934 at commit

[GitHub] spark issue #11119: [SPARK-10780][ML] Add an initial model to kmeans

2016-11-18 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/9 @yinxusen I took a look at the updates. Will you be able to create the design doc that Joseph mentioned? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark issue #15874: [Spark-18408][ML] API Improvements for LSH

2016-11-18 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/15874 I will take a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #15868: [SPARK-18413][SQL] Add `maxConnections` JDBCOption

2016-11-18 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15868 Ah, right. Now always! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #15923: [SPARK-4105] retry the fetch or stage if shuffle block i...

2016-11-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15923 **[Test build #68870 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68870/consoleFull)** for PR 15923 at commit

[GitHub] spark issue #15923: [SPARK-4105] retry the fetch or stage if shuffle block i...

2016-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15923 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68870/ Test PASSed. ---

[GitHub] spark issue #15923: [SPARK-4105] retry the fetch or stage if shuffle block i...

2016-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15923 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15934: [SPARK-18497][SS]Make ForeachSink support watermark

2016-11-18 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/15934 cc @marmbrus --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark pull request #15934: [SPARK-18497][SS]Make ForeachSink support waterma...

2016-11-18 Thread zsxwing
GitHub user zsxwing opened a pull request: https://github.com/apache/spark/pull/15934 [SPARK-18497][SS]Make ForeachSink support watermark ## What changes were proposed in this pull request? The issue in ForeachSink is the new created DataSet still uses the old

[GitHub] spark pull request #15936: [SPARK-18504][SQL] Scalar subquery with extra gro...

2016-11-18 Thread nsyca
GitHub user nsyca opened a pull request: https://github.com/apache/spark/pull/15936 [SPARK-18504][SQL] Scalar subquery with extra group by columns returning incorrect result ## What changes were proposed in this pull request? This PR blocks an incorrect result scenario in

[GitHub] spark pull request #13065: [SPARK-15214][SQL] Code-generation for Generate

2016-11-18 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/13065#discussion_r88740233 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.scala --- @@ -103,5 +109,182 @@ case class GenerateExec( }

[GitHub] spark issue #15880: [SPARK-17913][SQL] compare long and string type column m...

2016-11-18 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15880 In the future, more code changes might break Hive compatibility accidentally or intentionally. Maybe, we can introduce a configuration flag. For example, in DB2, we have a flag like

[GitHub] spark issue #15934: [SPARK-18497][SS]Make ForeachSink support watermark

2016-11-18 Thread marmbrus
Github user marmbrus commented on the issue: https://github.com/apache/spark/pull/15934 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #14650: [SPARK-17062][MESOS] add conf option to mesos dispatcher

2016-11-18 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/14650 @rxin @srowen could I get merge pls if there are no other issues? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request #13065: [SPARK-15214][SQL] Code-generation for Generate

2016-11-18 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/13065#discussion_r88754155 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala --- @@ -113,4 +117,25 @@ class WholeStageCodegenSuite extends

[GitHub] spark pull request #13909: [SPARK-16213][SQL] Reduce runtime overhead of a p...

2016-11-18 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/13909#discussion_r88668425 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala --- @@ -42,15 +42,55 @@ trait ExpressionEvalHelper

[GitHub] spark issue #15907: [SPARK-18458][CORE] Fix signed integer overflow problem ...

2016-11-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15907 **[Test build #68855 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68855/consoleFull)** for PR 15907 at commit

[GitHub] spark pull request #13065: [SPARK-15214][SQL] Code-generation for Generate

2016-11-18 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/13065#discussion_r88755507 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.scala --- @@ -103,5 +109,192 @@ case class GenerateExec( }

[GitHub] spark issue #15435: [SPARK-17139][ML] Add model summary for MultinomialLogis...

2016-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15435 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68864/ Test FAILed. ---

[GitHub] spark issue #15435: [SPARK-17139][ML] Add model summary for MultinomialLogis...

2016-11-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15435 **[Test build #68864 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68864/consoleFull)** for PR 15435 at commit

[GitHub] spark issue #15932: [SPARK-18448][CORE] SparkSession should implement java.l...

2016-11-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15932 **[Test build #68854 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68854/consoleFull)** for PR 15932 at commit

[GitHub] spark issue #15921: [SPARK-18493] Add missing python APIs: withWatermark and...

2016-11-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15921 **[Test build #68866 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68866/consoleFull)** for PR 15921 at commit

[GitHub] spark issue #15921: [SPARK-18493] Add missing python APIs: withWatermark and...

2016-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15921 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15921: [SPARK-18493] Add missing python APIs: withWatermark and...

2016-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15921 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68866/ Test FAILed. ---

[GitHub] spark issue #13909: [SPARK-16213][SQL] Reduce runtime overhead of a program ...

2016-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13909 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13909: [SPARK-16213][SQL] Reduce runtime overhead of a program ...

2016-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13909 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68857/ Test FAILed. ---

[GitHub] spark issue #13909: [SPARK-16213][SQL] Reduce runtime overhead of a program ...

2016-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13909 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15435: [SPARK-17139][ML] Add model summary for MultinomialLogis...

2016-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15435 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15435: [SPARK-17139][ML] Add model summary for MultinomialLogis...

2016-11-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15435 **[Test build #68865 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68865/consoleFull)** for PR 15435 at commit

[GitHub] spark issue #13909: [SPARK-16213][SQL] Reduce runtime overhead of a program ...

2016-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13909 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68856/ Test PASSed. ---

[GitHub] spark issue #13736: [SPARK-12113][SQL] Add some timing metrics for blocking ...

2016-11-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13736 **[Test build #68862 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68862/consoleFull)** for PR 13736 at commit

[GitHub] spark issue #15921: [SPARK-18493] Add missing python APIs: withWatermark and...

2016-11-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15921 **[Test build #68866 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68866/consoleFull)** for PR 15921 at commit

[GitHub] spark issue #15907: [SPARK-18458][CORE] Fix signed integer overflow problem ...

2016-11-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15907 **[Test build #68855 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68855/consoleFull)** for PR 15907 at commit

[GitHub] spark issue #15907: [SPARK-18458][CORE] Fix signed integer overflow problem ...

2016-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15907 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68855/ Test PASSed. ---

[GitHub] spark issue #15907: [SPARK-18458][CORE] Fix signed integer overflow problem ...

2016-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15907 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15921: [SPARK-18493] Add missing python APIs: withWatermark and...

2016-11-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15921 **[Test build #68867 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68867/consoleFull)** for PR 15921 at commit

[GitHub] spark issue #15921: [SPARK-18493] Add missing python APIs: withWatermark and...

2016-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15921 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68867/ Test FAILed. ---

[GitHub] spark issue #15921: [SPARK-18493] Add missing python APIs: withWatermark and...

2016-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15921 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13909: [SPARK-16213][SQL] Reduce runtime overhead of a program ...

2016-11-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13909 **[Test build #68856 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68856/consoleFull)** for PR 13909 at commit

[GitHub] spark issue #14812: [SPARK-17237][SQL] Remove unnecessary backticks in a piv...

2016-11-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14812 **[Test build #68860 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68860/consoleFull)** for PR 14812 at commit

  1   2   3   4   5   >