[GitHub] spark pull request #16898: [SPARK-19563][SQL] advoid unnecessary sort in Fil...

2017-02-12 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16898#discussion_r100687410 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala --- @@ -134,8 +142,23 @@ object FileFormatWriter

[GitHub] spark pull request #16386: [SPARK-18352][SQL] Support parsing multiline json...

2017-02-12 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/16386#discussion_r100687458 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala --- @@ -48,69 +47,110 @@ class JacksonParser( // A

[GitHub] spark issue #16870: [SPARK-19496][SQL]to_date udf to return null when input ...

2017-02-12 Thread windpiger
Github user windpiger commented on the issue: https://github.com/apache/spark/pull/16870 @tejasapatil thanks for your review! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #16870: [SPARK-19496][SQL]to_date udf to return null when...

2017-02-12 Thread windpiger
Github user windpiger commented on a diff in the pull request: https://github.com/apache/spark/pull/16870#discussion_r100687862 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala --- @@ -95,9 +95,10 @@ object DateTimeUtils { sdf

[GitHub] spark issue #16900: [SPARK-19564][SS][KAFKA] KafkaOffsetReader's consumers s...

2017-02-12 Thread lw-lin
Github user lw-lin commented on the issue: https://github.com/apache/spark/pull/16900 ok, all 100 times of `KafkaSourceSuite` passed. let's now do a full pass of testing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark issue #16900: [SPARK-19564][SS][KAFKA] KafkaOffsetReader's consumers s...

2017-02-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16900 **[Test build #72778 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72778/testReport)** for PR 16900 at commit

[GitHub] spark issue #16900: [SPARK-19564][SS][KAFKA] KafkaOffsetReader's consumers s...

2017-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16900 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16900: [SPARK-19564][SS][KAFKA] KafkaOffsetReader's consumers s...

2017-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16900 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72778/ Test PASSed. ---

[GitHub] spark pull request #16898: [SPARK-19563][SQL] advoid unnecessary sort in Fil...

2017-02-12 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/16898#discussion_r100692348 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala --- @@ -134,8 +142,26 @@ object FileFormatWriter

[GitHub] spark issue #16724: [SPARK-19352][SQL] Preserve sort order when saving datas...

2017-02-12 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/16724 Close this in favor of #16898. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #16724: [SPARK-19352][SQL] Preserve sort order when savin...

2017-02-12 Thread viirya
Github user viirya closed the pull request at: https://github.com/apache/spark/pull/16724 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #16870: [SPARK-19496][SQL]to_date udf to return null when input ...

2017-02-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16870 **[Test build #72768 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72768/testReport)** for PR 16870 at commit

[GitHub] spark issue #16899: [DO_NOT_MERGE][Test] Investigate KafkaSourceSuite flakin...

2017-02-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16899 **[Test build #72771 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72771/testReport)** for PR 16899 at commit

[GitHub] spark issue #16672: [SPARK-19329][SQL]Reading from or writing to a table wit...

2017-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16672 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16672: [SPARK-19329][SQL]Reading from or writing to a table wit...

2017-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16672 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72766/ Test PASSed. ---

[GitHub] spark issue #16672: [SPARK-19329][SQL]Reading from or writing to a table wit...

2017-02-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16672 **[Test build #72766 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72766/testReport)** for PR 16672 at commit

[GitHub] spark issue #16870: [SPARK-19496][SQL]to_date udf to return null when input ...

2017-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16870 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16777: [SPARK-19435][SQL] Type coercion between ArrayTypes

2017-02-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16777 **[Test build #72777 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72777/testReport)** for PR 16777 at commit

[GitHub] spark issue #16870: [SPARK-19496][SQL]to_date udf to return null when input ...

2017-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16870 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72769/ Test PASSed. ---

[GitHub] spark issue #16777: [SPARK-19435][SQL] Type coercion between ArrayTypes

2017-02-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16777 **[Test build #72779 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72779/testReport)** for PR 16777 at commit

[GitHub] spark issue #16900: [SPARK-19564][SS][KAFKA] KafkaOffsetReader's consumers s...

2017-02-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16900 **[Test build #72778 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72778/testReport)** for PR 16900 at commit

[GitHub] spark pull request #16899: [DO_NOT_MERGE][Test] Investigate KafkaSourceSuite...

2017-02-12 Thread lw-lin
Github user lw-lin closed the pull request at: https://github.com/apache/spark/pull/16899 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #16777: [SPARK-19435][SQL] Type coercion between ArrayTypes

2017-02-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16777 **[Test build #72782 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72782/testReport)** for PR 16777 at commit

[GitHub] spark issue #16674: [SPARK-19331][SQL][TESTS] Improve the test coverage of S...

2017-02-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16674 **[Test build #72774 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72774/testReport)** for PR 16674 at commit

[GitHub] spark issue #16674: [SPARK-19331][SQL][TESTS] Improve the test coverage of S...

2017-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16674 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16900: [SPARK-19564][SS][KAFKA] KafkaOffsetReader's consumers s...

2017-02-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16900 **[Test build #72783 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72783/testReport)** for PR 16900 at commit

[GitHub] spark issue #16672: [SPARK-19329][SQL]Reading from or writing to a table wit...

2017-02-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16672 **[Test build #72775 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72775/testReport)** for PR 16672 at commit

[GitHub] spark issue #16898: [SPARK-19563][SQL] advoid unnecessary sort in FileFormat...

2017-02-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16898 **[Test build #72764 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72764/testReport)** for PR 16898 at commit

[GitHub] spark pull request #16724: [SPARK-19352][SQL] Preserve sort order when savin...

2017-02-12 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16724#discussion_r100687150 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala --- @@ -369,7 +371,78 @@ object FileFormatWriter

[GitHub] spark pull request #16724: [SPARK-19352][SQL] Preserve sort order when savin...

2017-02-12 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16724#discussion_r100687176 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategySuite.scala --- @@ -487,6 +487,36 @@ class

[GitHub] spark pull request #16898: [SPARK-19563][SQL] advoid unnecessary sort in Fil...

2017-02-12 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16898#discussion_r100687628 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala --- @@ -120,9 +127,10 @@ object FileFormatWriter

[GitHub] spark issue #16870: [SPARK-19496][SQL]to_date udf to return null when input ...

2017-02-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16870 **[Test build #72769 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72769/testReport)** for PR 16870 at commit

[GitHub] spark issue #16899: [DO_NOT_MERGE][Test] Investigate KafkaSourceSuite flakin...

2017-02-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16899 **[Test build #72770 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72770/testReport)** for PR 16899 at commit

[GitHub] spark issue #16899: [DO_NOT_MERGE][Test] Investigate KafkaSourceSuite flakin...

2017-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16899 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72770/ Test FAILed. ---

[GitHub] spark issue #16899: [DO_NOT_MERGE][Test] Investigate KafkaSourceSuite flakin...

2017-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16899 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16777: [SPARK-19435][SQL] Type coercion between ArrayTypes

2017-02-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16777 **[Test build #72781 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72781/testReport)** for PR 16777 at commit

[GitHub] spark issue #16901: [SPARK-19565] Improve DAGScheduler tests.

2017-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16901 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #16832: [WIP][SPARK-19490][SQL] ignore case sensitivity when fil...

2017-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16832 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16620: [WIP][SPARK-19263] DAGScheduler should avoid sending con...

2017-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16620 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72761/ Test FAILed. ---

[GitHub] spark issue #16620: [WIP][SPARK-19263] DAGScheduler should avoid sending con...

2017-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16620 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16777: [SPARK-19435][SQL] Type coercion between ArrayTypes

2017-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16777 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72762/ Test FAILed. ---

[GitHub] spark issue #16832: [WIP][SPARK-19490][SQL] ignore case sensitivity when fil...

2017-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16832 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72763/ Test FAILed. ---

[GitHub] spark issue #16777: [SPARK-19435][SQL] Type coercion between ArrayTypes

2017-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16777 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #16724: [SPARK-19352][SQL] Preserve sort order when savin...

2017-02-12 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16724#discussion_r100687248 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala --- @@ -369,7 +371,78 @@ object FileFormatWriter

[GitHub] spark issue #16724: [SPARK-19352][SQL] Preserve sort order when saving datas...

2017-02-12 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/16724 @cloud-fan ok. I will look into it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request #16724: [SPARK-19352][SQL] Preserve sort order when savin...

2017-02-12 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16724#discussion_r100687252 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategySuite.scala --- @@ -487,6 +487,36 @@ class

[GitHub] spark issue #16899: [DO_NOT_MERGE][Test] Investigate KafkaSourceSuite flakin...

2017-02-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16899 **[Test build #72770 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72770/testReport)** for PR 16899 at commit

[GitHub] spark issue #16870: [SPARK-19496][SQL]to_date udf to return null when input ...

2017-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16870 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16900: [SPARK-19564][SS][KAFKA] KafkaOffsetReader's consumers s...

2017-02-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16900 **[Test build #72773 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72773/testReport)** for PR 16900 at commit

[GitHub] spark issue #16900: [SPARK-19564][SS][KAFKA] KafkaOffsetReader's consumers s...

2017-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16900 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16870: [SPARK-19496][SQL]to_date udf to return null when input ...

2017-02-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16870 **[Test build #72768 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72768/testReport)** for PR 16870 at commit

[GitHub] spark issue #16900: [SPARK-19564][SS][KAFKA] KafkaOffsetReader's consumers s...

2017-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16900 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72773/ Test PASSed. ---

[GitHub] spark issue #16870: [SPARK-19496][SQL]to_date udf to return null when input ...

2017-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16870 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72768/ Test PASSed. ---

[GitHub] spark issue #11192: [SPARK-13257] [Improvement] Scala naive Bayes example: c...

2017-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/11192 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #16777: [SPARK-19435][SQL] Type coercion between ArrayTypes

2017-02-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16777 **[Test build #72780 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72780/testReport)** for PR 16777 at commit

[GitHub] spark pull request #16898: [SPARK-19563][SQL] advoid unnecessary sort in Fil...

2017-02-12 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/16898#discussion_r100692415 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala --- @@ -134,8 +142,26 @@ object FileFormatWriter

[GitHub] spark issue #16900: [SPARK-19564][SS][KAFKA] KafkaOffsetReader's consumers s...

2017-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16900 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72783/ Test PASSed. ---

[GitHub] spark issue #16900: [SPARK-19564][SS][KAFKA] KafkaOffsetReader's consumers s...

2017-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16900 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16897: Remove two useless blank lines in HashJoin.scala

2017-02-12 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/16897 @yucai far too trivial. Please close this and don't open PRs like this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request #16777: [SPARK-19435][SQL] Type coercion between ArrayTyp...

2017-02-12 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/16777#discussion_r100690775 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercionSuite.scala --- @@ -379,6 +386,67 @@ class TypeCoercionSuite

[GitHub] spark issue #16870: [SPARK-19496][SQL]to_date udf to return null when input ...

2017-02-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16870 **[Test build #72769 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72769/testReport)** for PR 16870 at commit

[GitHub] spark issue #16672: [SPARK-19329][SQL]Reading from or writing to a table wit...

2017-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16672 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72775/ Test PASSed. ---

[GitHub] spark issue #16672: [SPARK-19329][SQL]Reading from or writing to a table wit...

2017-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16672 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #16898: [SPARK-19563][SQL] advoid unnecessary sort in Fil...

2017-02-12 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16898#discussion_r100687347 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala --- @@ -134,8 +142,23 @@ object FileFormatWriter

[GitHub] spark issue #16672: [SPARK-19329][SQL]Reading from or writing to a data-sour...

2017-02-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16672 **[Test build #72766 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72766/testReport)** for PR 16672 at commit

[GitHub] spark pull request #16898: [SPARK-19563][SQL] advoid unnecessary sort in Fil...

2017-02-12 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16898#discussion_r100687380 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala --- @@ -134,8 +142,23 @@ object FileFormatWriter

[GitHub] spark issue #16900: [SPARK-19564][SS][KAFKA] KafkaOffsetReader's consumers s...

2017-02-12 Thread lw-lin
Github user lw-lin commented on the issue: https://github.com/apache/spark/pull/16900 Let's start by running only `KafkaSourceSuite` for 1000 times --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #16672: [SPARK-19329][SQL]Reading from or writing to a table wit...

2017-02-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16672 **[Test build #72765 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72765/testReport)** for PR 16672 at commit

[GitHub] spark issue #16672: [SPARK-19329][SQL]Reading from or writing to a table wit...

2017-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16672 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16672: [SPARK-19329][SQL]Reading from or writing to a table wit...

2017-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16672 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72765/ Test PASSed. ---

[GitHub] spark issue #16672: [SPARK-19329][SQL]Reading from or writing to a table wit...

2017-02-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16672 **[Test build #72775 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72775/testReport)** for PR 16672 at commit

[GitHub] spark issue #16620: [SPARK-19263] DAGScheduler should avoid sending conflict...

2017-02-12 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/16620 @kayousterhout Thanks a lot for the clear explanation. It makes great sense to me and help me understand the logic a lot. Also I think the way of testing is very good and make the code very

[GitHub] spark pull request #16898: [SPARK-19563][SQL] advoid unnecessary sort in Fil...

2017-02-12 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/16898 [SPARK-19563][SQL] advoid unnecessary sort in FileFormatWriter ## What changes were proposed in this pull request? In `FileFormatWriter`, we will sort the input rows by partition columns

[GitHub] spark issue #16898: [SPARK-19563][SQL] advoid unnecessary sort in FileFormat...

2017-02-12 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16898 cc @viirya @gatorsmile --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #16870: [SPARK-19496][SQL]to_date udf to return null when...

2017-02-12 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16870#discussion_r100687520 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala --- @@ -95,9 +95,10 @@ object DateTimeUtils { sdf

[GitHub] spark pull request #16898: [SPARK-19563][SQL] advoid unnecessary sort in Fil...

2017-02-12 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16898#discussion_r100687514 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala --- @@ -134,8 +142,26 @@ object FileFormatWriter

[GitHub] spark issue #16898: [SPARK-19563][SQL] advoid unnecessary sort in FileFormat...

2017-02-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16898 **[Test build #72767 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72767/testReport)** for PR 16898 at commit

[GitHub] spark pull request #16674: [SPARK-19331][SQL][TESTS] Improve the test covera...

2017-02-12 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/16674#discussion_r100689894 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -617,13 +617,17 @@ class Analyzer( private

[GitHub] spark issue #16900: [SPARK-19564][SS][KAFKA] KafkaOffsetReader's consumers s...

2017-02-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16900 **[Test build #72772 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72772/testReport)** for PR 16900 at commit

[GitHub] spark issue #16777: [SPARK-19435][SQL] Type coercion between ArrayTypes

2017-02-12 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/16777 Thanks @cloud-fan for your detailed review. I will keep in mind those comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark issue #16674: [SPARK-19331][SQL][TESTS] Improve the test coverage of S...

2017-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16674 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72774/ Test FAILed. ---

[GitHub] spark pull request #16901: [SPARK-19565] Improve DAGScheduler tests.

2017-02-12 Thread jinxing64
GitHub user jinxing64 opened a pull request: https://github.com/apache/spark/pull/16901 [SPARK-19565] Improve DAGScheduler tests. ## What changes were proposed in this pull request? This is related to #16620. When fetch failed, stage will be resubmitted. There can be

[GitHub] spark issue #16901: [SPARK-19565] Improve DAGScheduler tests.

2017-02-12 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/16901 @kayousterhout @squito @markhamstra As mentioned in #16620 , I think it might make sense to make this pr. Please take a look. If you think it is too trivial, I will close. --- If your

[GitHub] spark pull request #16898: [SPARK-19563][SQL] advoid unnecessary sort in Fil...

2017-02-12 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16898#discussion_r100692456 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala --- @@ -134,8 +142,26 @@ object FileFormatWriter

[GitHub] spark issue #16870: [SPARK-19496][SQL]to_date udf to return null when input ...

2017-02-12 Thread windpiger
Github user windpiger commented on the issue: https://github.com/apache/spark/pull/16870 @cloud-fan I remove the islenient param, the tests passed, it seems remove islenient is ok --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request #16777: [SPARK-19435][SQL] Type coercion between ArrayTyp...

2017-02-12 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16777#discussion_r100687275 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercionSuite.scala --- @@ -379,6 +386,67 @@ class TypeCoercionSuite

[GitHub] spark pull request #16777: [SPARK-19435][SQL] Type coercion between ArrayTyp...

2017-02-12 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16777#discussion_r100687309 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercionSuite.scala --- @@ -379,6 +386,67 @@ class TypeCoercionSuite

[GitHub] spark pull request #16777: [SPARK-19435][SQL] Type coercion between ArrayTyp...

2017-02-12 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16777#discussion_r100687325 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercionSuite.scala --- @@ -379,6 +386,67 @@ class TypeCoercionSuite

[GitHub] spark issue #16672: [SPARK-19329][SQL]Reading from or writing to a data-sour...

2017-02-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16672 **[Test build #72765 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72765/testReport)** for PR 16672 at commit

[GitHub] spark issue #16777: [SPARK-19435][SQL] Type coercion between ArrayTypes

2017-02-12 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16777 LGTM except several minor tests about tests, thanks for working on it! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request #16898: [SPARK-19563][SQL] advoid unnecessary sort in Fil...

2017-02-12 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16898#discussion_r100687761 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala --- @@ -363,80 +393,42 @@ object FileFormatWriter

[GitHub] spark issue #16898: [SPARK-19563][SQL] advoid unnecessary sort in FileFormat...

2017-02-12 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/16898 Few comments. Others LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #16897: Remove two useless blank lines in HashJoin.scala

2017-02-12 Thread yucai
Github user yucai closed the pull request at: https://github.com/apache/spark/pull/16897 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #16897: Remove two useless blank lines in HashJoin.scala

2017-02-12 Thread yucai
Github user yucai commented on the issue: https://github.com/apache/spark/pull/16897 @srowen OK, got it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #16898: [SPARK-19563][SQL] advoid unnecessary sort in FileFormat...

2017-02-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16898 **[Test build #72764 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72764/testReport)** for PR 16898 at commit

[GitHub] spark issue #16898: [SPARK-19563][SQL] advoid unnecessary sort in FileFormat...

2017-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16898 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16898: [SPARK-19563][SQL] advoid unnecessary sort in FileFormat...

2017-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16898 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72764/ Test FAILed. ---

[GitHub] spark pull request #16899: [DO_NOT_MERGE][Test] Investigate KafkaSourceSuite...

2017-02-12 Thread lw-lin
GitHub user lw-lin opened a pull request: https://github.com/apache/spark/pull/16899 [DO_NOT_MERGE][Test] Investigate KafkaSourceSuite flakiness ## What changes were proposed in this pull request? (Please fill in changes proposed in this fix) ## How was this patch

[GitHub] spark issue #16898: [SPARK-19563][SQL] advoid unnecessary sort in FileFormat...

2017-02-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16898 **[Test build #72767 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72767/testReport)** for PR 16898 at commit

[GitHub] spark issue #16898: [SPARK-19563][SQL] advoid unnecessary sort in FileFormat...

2017-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16898 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

  1   2   3   4   >