[GitHub] spark issue #17446: [SPARK-17075][SQL][followup] Add Estimation of Constant ...

2017-03-29 Thread wzhfy
Github user wzhfy commented on the issue: https://github.com/apache/spark/pull/17446 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #15332: [SPARK-10364][SQL] Support Parquet logical type TIMESTAM...

2017-03-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15332 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75347/ Test PASSed. ---

[GitHub] spark issue #15332: [SPARK-10364][SQL] Support Parquet logical type TIMESTAM...

2017-03-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15332 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15332: [SPARK-10364][SQL] Support Parquet logical type TIMESTAM...

2017-03-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15332 **[Test build #75347 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75347/testReport)** for PR 15332 at commit

[GitHub] spark issue #17452: [SPARK-20123][build]$SPARK_HOME variable might have spac...

2017-03-29 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/17452 Yes it wouldn't work with shell expansion. I don't think that is the case here but it is fine either way. Consistency is the most important thing. --- If your project is set up for it, you can

[GitHub] spark pull request #17452: [SPARK-20123][build]$SPARK_HOME variable might ha...

2017-03-29 Thread zuotingbing
Github user zuotingbing commented on a diff in the pull request: https://github.com/apache/spark/pull/17452#discussion_r108623175 --- Diff: R/check-cran.sh --- @@ -40,7 +40,7 @@ fi if [ -d "$SPARK_JARS_DIR" ]; then # Build a zip file containing the source package

[GitHub] spark issue #17430: [SPARK-20096][Spark Submit][Minor]Expose the right queue...

2017-03-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17430 **[Test build #75351 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75351/testReport)** for PR 17430 at commit

[GitHub] spark issue #17430: [SPARK-20096][Spark Submit][Minor]Expose the right queue...

2017-03-29 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/17430 Jenkins test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark pull request #17430: [SPARK-20096][Spark Submit][Minor]Expose the righ...

2017-03-29 Thread yaooqinn
Github user yaooqinn commented on a diff in the pull request: https://github.com/apache/spark/pull/17430#discussion_r108616336 --- Diff: core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala --- @@ -148,6 +148,17 @@ class SparkSubmitSuite appArgs.childArgs

[GitHub] spark pull request #17130: [SPARK-19791] [ML] Add doc and example for fpgrow...

2017-03-29 Thread BenFradet
Github user BenFradet commented on a diff in the pull request: https://github.com/apache/spark/pull/17130#discussion_r108613380 --- Diff: docs/ml-frequent-pattern-mining.md --- @@ -0,0 +1,75 @@ +--- +layout: global +title: Frequent Pattern Mining +displayTitle:

[GitHub] spark issue #17419: [SPARK-19634][ML] Multivariate summarizer - dataframes A...

2017-03-29 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/17419 > RDD = [2482 ~ 46150 ~ 48354] records / milli the number is so varied? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark issue #17446: [SPARK-17075][SQL][followup] Add Estimation of Constant ...

2017-03-29 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17446 `null` should not be simply treated as a `false` literal in filter estimation. Based on the definition, `Not(null)` should return `null`. If we treat `null` as `false`, `Not(null)` will return

[GitHub] spark issue #17436: [SPARK-20101][SQL] Use OffHeapColumnVector when "spark.m...

2017-03-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17436 **[Test build #75350 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75350/testReport)** for PR 17436 at commit

[GitHub] spark issue #17465: [SPARK-20136][SQL] Add num files and metadata operation ...

2017-03-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17465 **[Test build #75349 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75349/testReport)** for PR 17465 at commit

[GitHub] spark pull request #17450: [SPARK-20121][SQL] simplify NullPropagation with ...

2017-03-29 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17450#discussion_r108607884 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -297,8 +297,8 @@ case class Lower(child:

[GitHub] spark issue #17465: [SPARK-20136][SQL] Add num files and metadata operation ...

2017-03-29 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/17465 cc @ericl, @bogdanrdc, @adrian-ionescu, @cloud-fan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #17465: [SPARK-20136][SQL] Add num files and metadata ope...

2017-03-29 Thread rxin
GitHub user rxin opened a pull request: https://github.com/apache/spark/pull/17465 [SPARK-20136][SQL] Add num files and metadata operation timing to scan operator metrics ## What changes were proposed in this pull request? This patch adds explicit metadata operation timing and

[GitHub] spark issue #17436: [SPARK-20101][SQL] Use OffHeapColumnVector when "spark.m...

2017-03-29 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/17436 jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #17446: [SPARK-17075][SQL][followup] Add Estimation of Constant ...

2017-03-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17446 **[Test build #75348 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75348/testReport)** for PR 17446 at commit

[GitHub] spark pull request #17446: [SPARK-17075][SQL][followup] Add Estimation of Co...

2017-03-29 Thread gatorsmile
GitHub user gatorsmile reopened a pull request: https://github.com/apache/spark/pull/17446 [SPARK-17075][SQL][followup] Add Estimation of Constant Literal ### What changes were proposed in this pull request? `FalseLiteral` and `TrueLiteral` should have been eliminated by

[GitHub] spark issue #17424: [SPARK-20089] [SQL] [TEST] Added DESC FUNCTION and DESC ...

2017-03-29 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/17424 To document the functions available sounds good. But I am not sure if we want to put this into test. Sounds like we use the test as document generator. --- If your project is set up for it, you can

[GitHub] spark issue #15332: [SPARK-10364][SQL] Support Parquet logical type TIMESTAM...

2017-03-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15332 **[Test build #75347 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75347/testReport)** for PR 15332 at commit

[GitHub] spark pull request #15332: [SPARK-10364][SQL] Support Parquet logical type T...

2017-03-29 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/15332#discussion_r108604022 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala --- @@ -237,6 +238,30 @@ object DateTimeUtils {

[GitHub] spark pull request #15332: [SPARK-10364][SQL] Support Parquet logical type T...

2017-03-29 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/15332#discussion_r108603952 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaSuite.scala --- @@ -965,6 +972,18 @@ class

[GitHub] spark issue #17464: [SPARK-20134][SQL] SQLMetrics.postDriverMetricUpdates to...

2017-03-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17464 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75344/ Test FAILed. ---

[GitHub] spark issue #17324: [SPARK-19969] [ML] Imputer doc and example

2017-03-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17324 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75346/ Test FAILed. ---

[GitHub] spark issue #17436: [SPARK-20101][SQL] Use OffHeapColumnVector when "spark.m...

2017-03-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17436 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75345/ Test FAILed. ---

[GitHub] spark issue #17436: [SPARK-20101][SQL] Use OffHeapColumnVector when "spark.m...

2017-03-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17436 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17464: [SPARK-20134][SQL] SQLMetrics.postDriverMetricUpdates to...

2017-03-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17464 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17324: [SPARK-19969] [ML] Imputer doc and example

2017-03-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17324 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #17464: [SPARK-20134][SQL] SQLMetrics.postDriverMetricUpd...

2017-03-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17464 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #17464: [SPARK-20134][SQL] SQLMetrics.postDriverMetricUpdates to...

2017-03-29 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/17464 Merging in master/branch-2.1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #17464: [SPARK-20134][SQL] SQLMetrics.postDriverMetricUpdates to...

2017-03-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17464 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17464: [SPARK-20134][SQL] SQLMetrics.postDriverMetricUpdates to...

2017-03-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17464 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75343/ Test PASSed. ---

[GitHub] spark issue #17464: [SPARK-20134][SQL] SQLMetrics.postDriverMetricUpdates to...

2017-03-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17464 **[Test build #75343 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75343/testReport)** for PR 17464 at commit

[GitHub] spark issue #17297: [SPARK-14649][CORE] DagScheduler should not run duplicat...

2017-03-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17297 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17297: [SPARK-14649][CORE] DagScheduler should not run duplicat...

2017-03-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17297 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75339/ Test PASSed. ---

[GitHub] spark issue #17297: [SPARK-14649][CORE] DagScheduler should not run duplicat...

2017-03-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17297 **[Test build #75339 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75339/testReport)** for PR 17297 at commit

[GitHub] spark pull request #17415: [SPARK-19408][SQL] filter estimation on two colum...

2017-03-29 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/17415#discussion_r108601698 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/FilterEstimation.scala --- @@ -515,8 +530,138 @@ case

[GitHub] spark issue #17324: [SPARK-19969] [ML] Imputer doc and example

2017-03-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17324 **[Test build #75346 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75346/testReport)** for PR 17324 at commit

[GitHub] spark pull request #17130: [SPARK-19791] [ML] Add doc and example for fpgrow...

2017-03-29 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/17130#discussion_r108600468 --- Diff: docs/ml-frequent-pattern-mining.md --- @@ -0,0 +1,75 @@ +--- +layout: global +title: Frequent Pattern Mining +displayTitle:

[GitHub] spark issue #17436: [SPARK-20101][SQL] Use OffHeapColumnVector when "spark.m...

2017-03-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17436 **[Test build #75345 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75345/testReport)** for PR 17436 at commit

[GitHub] spark issue #17464: [SPARK-20134][SQL] SQLMetrics.postDriverMetricUpdates to...

2017-03-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17464 **[Test build #75344 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75344/testReport)** for PR 17464 at commit

[GitHub] spark pull request #17464: [SPARK-20134][SQL] SQLMetrics.postDriverMetricUpd...

2017-03-29 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/17464#discussion_r108600240 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/ui/SQLListenerSuite.scala --- @@ -477,9 +477,11 @@ private case class MyPlan(sc:

[GitHub] spark issue #17379: [SPARK-20048][SQL] Cloning SessionState does not clone q...

2017-03-29 Thread kunalkhamar
Github user kunalkhamar commented on the issue: https://github.com/apache/spark/pull/17379 cc @hvanhovell --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark pull request #17464: [SPARK-20134][SQL] SQLMetrics.postDriverMetricUpd...

2017-03-29 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/17464#discussion_r108596378 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/ui/SQLListenerSuite.scala --- @@ -477,9 +477,11 @@ private case class MyPlan(sc:

[GitHub] spark pull request #17324: [SPARK-19969] [ML] Imputer doc and example

2017-03-29 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/17324#discussion_r108597395 --- Diff: examples/src/main/java/org/apache/spark/examples/ml/JavaImputerExample.java --- @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software

[GitHub] spark issue #17379: [SPARK-20048][SQL] Cloning SessionState does not clone q...

2017-03-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17379 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75338/ Test PASSed. ---

[GitHub] spark issue #17379: [SPARK-20048][SQL] Cloning SessionState does not clone q...

2017-03-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17379 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17379: [SPARK-20048][SQL] Cloning SessionState does not clone q...

2017-03-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17379 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17379: [SPARK-20048][SQL] Cloning SessionState does not clone q...

2017-03-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17379 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75337/ Test PASSed. ---

[GitHub] spark issue #17379: [SPARK-20048][SQL] Cloning SessionState does not clone q...

2017-03-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17379 **[Test build #75338 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75338/testReport)** for PR 17379 at commit

[GitHub] spark issue #17379: [SPARK-20048][SQL] Cloning SessionState does not clone q...

2017-03-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17379 **[Test build #75337 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75337/testReport)** for PR 17379 at commit

<    1   2   3   4