[GitHub] spark issue #18151: [SPARK-20929][ML] LinearSVC should use its own threshold...

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18151 **[Test build #3769 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3769/testReport)** for PR 18151 at commit

[GitHub] spark issue #18156: [SPARK-20933][SQL]when the input parameter is float type...

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18156 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #17113: [SPARK-13669][Core] Improve the blacklist mechanism to h...

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17113 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77575/ Test FAILed. ---

[GitHub] spark issue #18153: [SPARK-20931][SQL] ABS function support string type.

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18153 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18155: [SPARK-20876][SQL][Backport-2.2]If the input parameter i...

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18155 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77573/ Test FAILed. ---

[GitHub] spark issue #18157: [MINOR][SQL] Fix a few function description error.

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18157 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17113: [SPARK-13669][Core] Improve the blacklist mechanism to h...

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17113 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18153: [SPARK-20931][SQL] ABS function support string type.

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18153 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77576/ Test FAILed. ---

[GitHub] spark issue #18157: [MINOR][SQL] Fix a few function description error.

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18157 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77577/ Test FAILed. ---

[GitHub] spark issue #18155: [SPARK-20876][SQL][Backport-2.2]If the input parameter i...

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18155 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14377: [SPARK-16625][SQL] General data types to be mapped to Or...

2017-05-31 Thread vivekdixit05
Github user vivekdixit05 commented on the issue: https://github.com/apache/spark/pull/14377 While reading. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark pull request #18140: [SPARK-20917][ML][SparkR] SparkR supports string ...

2017-05-31 Thread actuaryzhang
Github user actuaryzhang commented on a diff in the pull request: https://github.com/apache/spark/pull/18140#discussion_r119285081 --- Diff: R/pkg/inst/tests/testthat/test_mllib_regression.R --- @@ -379,6 +379,49 @@ test_that("glm save/load", { unlink(modelPath) })

[GitHub] spark issue #18129: [SPARK-20365][YARN] Remove LocalSchem when add path to C...

2017-05-31 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/18129 CC @vanzin to take a review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #18153: [SPARK-20931][SQL] ABS function support string type.

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18153 **[Test build #77576 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77576/testReport)** for PR 18153 at commit

[GitHub] spark pull request #18157: [MINOR][SQL] Fix a few function description error...

2017-05-31 Thread wangyum
GitHub user wangyum opened a pull request: https://github.com/apache/spark/pull/18157 [MINOR][SQL] Fix a few function description error. ## What changes were proposed in this pull request? Fix a few function description error. ## How was this patch tested?

[GitHub] spark issue #18118: SPARK-20199 : Provided featureSubsetStrategy to GBTClass...

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18118 **[Test build #77578 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77578/testReport)** for PR 18118 at commit

[GitHub] spark issue #17113: [SPARK-13669][Core] Improve the blacklist mechanism to h...

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17113 **[Test build #77582 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77582/testReport)** for PR 17113 at commit

[GitHub] spark issue #17617: [SPARK-20244][Core] Handle incorrect bytesRead metrics w...

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17617 **[Test build #77581 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77581/testReport)** for PR 17617 at commit

[GitHub] spark pull request #17617: [SPARK-20244][Core] Handle incorrect bytesRead me...

2017-05-31 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/17617#discussion_r119276245 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala --- @@ -143,14 +144,18 @@ class SparkHadoopUtil extends Logging { *

[GitHub] spark pull request #18143: [SPARK-20919][SS] Simplificaiton of CachedKafkaCo...

2017-05-31 Thread ScrapCodes
Github user ScrapCodes commented on a diff in the pull request: https://github.com/apache/spark/pull/18143#discussion_r119277567 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/CachedKafkaConsumer.scala --- @@ -310,62 +308,45 @@ private[kafka010]

[GitHub] spark issue #18108: [SPARK-20884] Spark' masters will be both standby due to...

2017-05-31 Thread liu-zhaokun
Github user liu-zhaokun commented on the issue: https://github.com/apache/spark/pull/18108 @srowen I have tested it in my cluster with modify the version of curator,spark works normally,and the problem I encountered was resolved. --- If your project is set up for it, you can

[GitHub] spark pull request #18156: [SPARK-20933][SQL]when the input parameter is flo...

2017-05-31 Thread 10110346
GitHub user 10110346 opened a pull request: https://github.com/apache/spark/pull/18156 [SPARK-20933][SQL]when the input parameter is float type,the ’round ’ or ‘bround’ function can't work well ## What changes were proposed in this pull request? spark-sql>select

[GitHub] spark issue #18155: [SPARK-20876][SQL][Backport-2.2]If the input parameter i...

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18155 **[Test build #77579 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77579/testReport)** for PR 18155 at commit

[GitHub] spark issue #17113: [SPARK-13669][Core] Improve the blacklist mechanism to h...

2017-05-31 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/17113 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #18108: [SPARK-20884] Spark' masters will be both standby due to...

2017-05-31 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18108 Generally you need to evaluate the impact of updating a minor version of a dependency. Does it cause any compatibility problems? What version does Hadoop use? Does it add new transitive deps? You

[GitHub] spark issue #18155: [SPARK-20876][SQL][Backport-2.2]If the input parameter i...

2017-05-31 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/18155 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #18155: [SPARK-20876][SQL][Backport-2.2]If the input parameter i...

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18155 **[Test build #77580 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77580/testReport)** for PR 18155 at commit

[GitHub] spark issue #18151: [SPARK-20929][ML] LinearSVC should use its own threshold...

2017-05-31 Thread MLnick
Github user MLnick commented on the issue: https://github.com/apache/spark/pull/18151 Good catch. Agree with @sethah comment about adding a test case, otherwise LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request #18129: [SPARK-20365][YARN] Remove LocalSchem when add pa...

2017-05-31 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/18129#discussion_r119277116 --- Diff: resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ClientSuite.scala --- @@ -116,15 +116,16 @@ class ClientSuite extends

[GitHub] spark issue #18015: [SAPRK-20785][WEB-UI][SQL]Spark should provide jump link...

2017-05-31 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18015 I don't think those links are worth the vertical space they chew up --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark issue #18015: [SAPRK-20785][WEB-UI][SQL]Spark should provide jump link...

2017-05-31 Thread guoxiaolongzte
Github user guoxiaolongzte commented on the issue: https://github.com/apache/spark/pull/18015 @srowen I think the style exists to provide links that jump to Running Queries or Completed Queries because it may be well below the fold if there are many workers.Job page, stage page,

[GitHub] spark issue #18157: [MINOR][SQL] Fix a few function description error.

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18157 **[Test build #77577 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77577/testReport)** for PR 18157 at commit

[GitHub] spark issue #18151: [SPARK-20929][ML] LinearSVC should use its own threshold...

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18151 **[Test build #77574 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77574/testReport)** for PR 18151 at commit

[GitHub] spark issue #18151: [SPARK-20929][ML] LinearSVC should use its own threshold...

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18151 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77574/ Test PASSed. ---

[GitHub] spark issue #18151: [SPARK-20929][ML] LinearSVC should use its own threshold...

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18151 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #18158: Lack of the most important case about the test of...

2017-05-31 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/18158#discussion_r119298616 --- Diff: core/src/test/scala/org/apache/spark/util/UtilsSuite.scala --- @@ -473,7 +474,7 @@ class UtilsSuite extends SparkFunSuite with

[GitHub] spark issue #18108: [SPARK-20884] Spark' masters will be both standby due to...

2017-05-31 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18108 @liu-zhaokun that doesn't address any of my points here --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #18108: [SPARK-20884] Spark' masters will be both standby due to...

2017-05-31 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18108 It won't pass automated dependency checks. The tests are not relevant here. You need to investigate what has changed and what the implication is for Hadoop envs without this change --- If your

[GitHub] spark pull request #18129: [SPARK-20365][YARN] Remove LocalSchem when add pa...

2017-05-31 Thread liyichao
Github user liyichao commented on a diff in the pull request: https://github.com/apache/spark/pull/18129#discussion_r119309080 --- Diff: resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ClientSuite.scala --- @@ -116,15 +116,16 @@ class ClientSuite extends

[GitHub] spark issue #18155: [SPARK-20876][SQL][Backport-2.2]If the input parameter i...

2017-05-31 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/18155 LGTM, cc @gatorsmile --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #18155: [SPARK-20876][SQL][Backport-2.2]If the input parameter i...

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18155 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77580/ Test PASSed. ---

[GitHub] spark pull request #18160: [SPARK-20938][SQL] Keep/print the string represen...

2017-05-31 Thread HyukjinKwon
GitHub user HyukjinKwon opened a pull request: https://github.com/apache/spark/pull/18160 [SPARK-20938][SQL] Keep/print the string representation of catalyst filters in metadata for CatalystScan ## What changes were proposed in this pull request? Actual pushed-down

[GitHub] spark pull request #18158: Lack of the most important case about the test of...

2017-05-31 Thread zuotingbing
GitHub user zuotingbing opened a pull request: https://github.com/apache/spark/pull/18158 Lack of the most important case about the test of resolveURI in UtilsSuite, and add it as needed. ## What changes were proposed in this pull request? add the most important case

[GitHub] spark issue #18108: [SPARK-20884] Spark' masters will be both standby due to...

2017-05-31 Thread liu-zhaokun
Github user liu-zhaokun commented on the issue: https://github.com/apache/spark/pull/18108 @srowen I think you can test and verify your points via SparkQA's test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark issue #18118: SPARK-20199 : Provided featureSubsetStrategy to GBTClass...

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18118 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77578/ Test FAILed. ---

[GitHub] spark issue #18118: SPARK-20199 : Provided featureSubsetStrategy to GBTClass...

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18118 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18156: [SPARK-20933][SQL]when the input parameter is float type...

2017-05-31 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18156 Although I agree that 3.1415 should round to 3.141 in both cases, the value of 3.1415f is not quite the same as 3.1415. It's actually something like 3.1414... The behavior is correct,

[GitHub] spark issue #18155: [SPARK-20876][SQL][Backport-2.2]If the input parameter i...

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18155 **[Test build #77579 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77579/testReport)** for PR 18155 at commit

[GitHub] spark issue #18152: [SPARK-20930][ML] Destroy broadcasted centers after comp...

2017-05-31 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18152 Yes, I agree with that. It looks like there may be a similar instance in `GradientDescent.scala`, where `bcWeights` is used in a `treeAggregate` but then never destroyed. In every other

[GitHub] spark issue #18153: [SPARK-20931][SQL] ABS function support string type.

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18153 **[Test build #77583 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77583/testReport)** for PR 18153 at commit

[GitHub] spark issue #18153: [SPARK-20931][SQL] ABS function support string type.

2017-05-31 Thread wangyum
Github user wangyum commented on the issue: https://github.com/apache/spark/pull/18153 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #18159: [SPARK-20703][SQL][WIP] Associate metrics with da...

2017-05-31 Thread viirya
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/18159 [SPARK-20703][SQL][WIP] Associate metrics with data writes onto DataFrameWriter operations ## What changes were proposed in this pull request? Right now in the UI, after SPARK-20213, we

[GitHub] spark issue #18118: SPARK-20199 : Provided featureSubsetStrategy to GBTClass...

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18118 **[Test build #77578 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77578/testReport)** for PR 18118 at commit

[GitHub] spark issue #18155: [SPARK-20876][SQL][Backport-2.2]If the input parameter i...

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18155 **[Test build #77580 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77580/testReport)** for PR 18155 at commit

[GitHub] spark issue #18155: [SPARK-20876][SQL][Backport-2.2]If the input parameter i...

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18155 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18160: [SPARK-20938][SQL] Keep/print the string representation ...

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18160 **[Test build #77585 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77585/testReport)** for PR 18160 at commit

[GitHub] spark issue #18074: [DOCS][MINOR] Scaladoc fixes (aka typo hunting)

2017-05-31 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18074 Merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark issue #18015: [SAPRK-20785][WEB-UI][SQL]Spark should provide jump link...

2017-05-31 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18015 Yes I understand that, but I don't think the reasoning is as compelling here, and the style is a bit different. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark issue #18159: [SPARK-20703][SQL][WIP] Associate metrics with data writ...

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18159 **[Test build #77584 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77584/testReport)** for PR 18159 at commit

[GitHub] spark issue #18015: [SAPRK-20785][WEB-UI][SQL]Spark should provide jump link...

2017-05-31 Thread guoxiaolongzte
Github user guoxiaolongzte commented on the issue: https://github.com/apache/spark/pull/18015 @srowen SQL ui is really different from other ui. In the follow-up version, I will strive to improve the function of SQL ui. --- If your project is set up for it, you can reply to this

[GitHub] spark issue #18155: [SPARK-20876][SQL][Backport-2.2]If the input parameter i...

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18155 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18155: [SPARK-20876][SQL][Backport-2.2]If the input parameter i...

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18155 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77579/ Test PASSed. ---

[GitHub] spark issue #18158: Lack of the most important case about the test of resolv...

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18158 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #18158: Lack of the most important case about the test of...

2017-05-31 Thread zuotingbing
Github user zuotingbing commented on a diff in the pull request: https://github.com/apache/spark/pull/18158#discussion_r119302580 --- Diff: core/src/test/scala/org/apache/spark/util/UtilsSuite.scala --- @@ -473,7 +474,7 @@ class UtilsSuite extends SparkFunSuite with

[GitHub] spark pull request #17617: [SPARK-20244][Core] Handle incorrect bytesRead me...

2017-05-31 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/17617#discussion_r119301228 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala --- @@ -21,8 +21,10 @@ import java.io.IOException import

[GitHub] spark pull request #18139: [SPARK-20787][PYTHON] PySpark can't handle dateti...

2017-05-31 Thread rberenguel
Github user rberenguel commented on a diff in the pull request: https://github.com/apache/spark/pull/18139#discussion_r119344927 --- Diff: python/pyspark/sql/types.py --- @@ -187,8 +187,11 @@ def needConversion(self): def toInternal(self, dt): if dt is

[GitHub] spark pull request #18139: [SPARK-20787][PYTHON] PySpark can't handle dateti...

2017-05-31 Thread rberenguel
Github user rberenguel commented on a diff in the pull request: https://github.com/apache/spark/pull/18139#discussion_r119344936 --- Diff: python/pyspark/sql/types.py --- @@ -187,8 +187,11 @@ def needConversion(self): def toInternal(self, dt): if dt is

[GitHub] spark issue #18022: [SPARK-20790] [MLlib] Correctly handle negative values f...

2017-05-31 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18022 Merged to master/2.2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark pull request #18022: [SPARK-20790] [MLlib] Correctly handle negative v...

2017-05-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18022 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #18157: [MINOR][SQL] Fix a few function description error.

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18157 **[Test build #77586 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77586/testReport)** for PR 18157 at commit

[GitHub] spark pull request #18139: [SPARK-20787][PYTHON] PySpark can't handle dateti...

2017-05-31 Thread facaiy
Github user facaiy commented on a diff in the pull request: https://github.com/apache/spark/pull/18139#discussion_r119346663 --- Diff: python/pyspark/sql/types.py --- @@ -187,8 +187,11 @@ def needConversion(self): def toInternal(self, dt): if dt is not

[GitHub] spark pull request #18022: [SPARK-20790] [MLlib] Correctly handle negative v...

2017-05-31 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/18022#discussion_r119347220 --- Diff: mllib/src/test/scala/org/apache/spark/ml/recommendation/ALSSuite.scala --- @@ -455,6 +487,22 @@ class ALSSuite targetRMSE = 0.3)

[GitHub] spark issue #18143: [SPARK-20919][SS] Simplificaiton of CachedKafkaConsumer ...

2017-05-31 Thread ScrapCodes
Github user ScrapCodes commented on the issue: https://github.com/apache/spark/pull/18143 Thanks @koeninger for taking a look. I did some testing to see if performance was impacted, and made corrections. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request #18139: [SPARK-20787][PYTHON] PySpark can't handle dateti...

2017-05-31 Thread rberenguel
Github user rberenguel commented on a diff in the pull request: https://github.com/apache/spark/pull/18139#discussion_r119350488 --- Diff: python/pyspark/sql/types.py --- @@ -187,8 +187,11 @@ def needConversion(self): def toInternal(self, dt): if dt is

[GitHub] spark issue #17617: [SPARK-20244][Core] Handle incorrect bytesRead metrics w...

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17617 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17617: [SPARK-20244][Core] Handle incorrect bytesRead metrics w...

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17617 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77581/ Test PASSed. ---

[GitHub] spark issue #18157: [MINOR][SQL] Fix a few function description error.

2017-05-31 Thread wangyum
Github user wangyum commented on the issue: https://github.com/apache/spark/pull/18157 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #18153: [SPARK-20931][SQL] ABS function support string ty...

2017-05-31 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/18153#discussion_r119332964 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala --- @@ -97,20 +97,30 @@ case class UnaryPositive(child:

[GitHub] spark issue #18159: [SPARK-20703][SQL][WIP] Associate metrics with data writ...

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18159 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18159: [SPARK-20703][SQL][WIP] Associate metrics with data writ...

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18159 **[Test build #77584 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77584/testReport)** for PR 18159 at commit

[GitHub] spark issue #18160: [SPARK-20938][SQL] Keep/print the string representation ...

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18160 **[Test build #77589 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77589/testReport)** for PR 18160 at commit

[GitHub] spark issue #18157: [MINOR][SQL] Fix a few function description error.

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18157 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77586/ Test PASSed. ---

[GitHub] spark issue #18157: [MINOR][SQL] Fix a few function description error.

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18157 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18143: [SPARK-20919][SS] Simplificaiton of CachedKafkaConsumer ...

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18143 **[Test build #77590 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77590/testReport)** for PR 18143 at commit

[GitHub] spark issue #17947: [SPARK-20708][CORE] Make `addExclusionRules` up-to-date

2017-05-31 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/17947 Hi, @brkyvz . Could you review this again? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request #18165: [Core][Minor][Test] Fix comment and unnecessary c...

2017-05-31 Thread jiangxb1987
GitHub user jiangxb1987 opened a pull request: https://github.com/apache/spark/pull/18165 [Core][Minor][Test] Fix comment and unnecessary code in DAGSchedulerSuite ## What changes were proposed in this pull request? Fix comment and unnecessary code in DAGSchedulerSuite

[GitHub] spark issue #18145: [SPARK-20633][SQL] FileFormatWriter should not wrap Fetc...

2017-05-31 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/18145 merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark issue #17617: [SPARK-20244][Core] Handle incorrect bytesRead metrics w...

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17617 **[Test build #77591 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77591/testReport)** for PR 17617 at commit

[GitHub] spark pull request #18162: [SPARK-20923] Remove TaskMetrics._updatedBlockSta...

2017-05-31 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/18162#discussion_r119422001 --- Diff: core/src/main/scala/org/apache/spark/executor/TaskMetrics.scala --- @@ -110,15 +109,6 @@ class TaskMetrics private[spark] () extends

[GitHub] spark issue #18162: [SPARK-20923] Remove TaskMetrics._updatedBlockStatuses

2017-05-31 Thread JoshRosen
Github user JoshRosen commented on the issue: https://github.com/apache/spark/pull/18162 @cloud-fan has a good point about backwards-compatibility. In case any folks are actually relying on this behavior, I wonder whether we could mark it as deprecated and have a flag for disabling

[GitHub] spark issue #18165: [Core][Minor][Test] Fix comment and unnecessary code in ...

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18165 **[Test build #77598 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77598/testReport)** for PR 18165 at commit

[GitHub] spark issue #17603: [SPARK-20288] Avoid generating the MapStatus by stageId ...

2017-05-31 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/17603 merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark issue #17617: [SPARK-20244][Core] Handle incorrect bytesRead metrics w...

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17617 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17617: [SPARK-20244][Core] Handle incorrect bytesRead metrics w...

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17617 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77591/ Test PASSed. ---

[GitHub] spark pull request #18136: [SPARK-20910][SQL] Add build-int SQL function - U...

2017-05-31 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/18136#discussion_r119409458 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala --- @@ -104,3 +107,26 @@ case class CurrentDatabase() extends

[GitHub] spark issue #18075: [SPARK-18016][SQL][CATALYST] Code Generation: Constant P...

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18075 **[Test build #77597 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77597/testReport)** for PR 18075 at commit

[GitHub] spark issue #18129: [SPARK-20365][YARN] Remove LocalSchem when add path to C...

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18129 **[Test build #77596 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77596/testReport)** for PR 18129 at commit

[GitHub] spark issue #18129: [SPARK-20365][YARN] Remove LocalSchem when add path to C...

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18129 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18129: [SPARK-20365][YARN] Remove LocalSchem when add path to C...

2017-05-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18129 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77596/ Test PASSed. ---

[GitHub] spark issue #18162: [SPARK-20923] Remove TaskMetrics._updatedBlockStatuses

2017-05-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18162 **[Test build #77594 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77594/testReport)** for PR 18162 at commit

  1   2   3   4   5   >