Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/18709
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18790#discussion_r132094610
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -410,6 +413,14 @@ object PushProjectionThroughUnion
Github user lvdongr commented on the issue:
https://github.com/apache/spark/pull/18756
The target of this pr is support to insert into specified columnsï¼ all
columns is no need ï¼ like insert into t(a, c) values (1, 0.8) .
---
If your project is set up for it, you can repl
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/18707
I was just asking about different fixes, I'm ok with the current fix.
thanks, merging to master/2.2!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/18707
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18790#discussion_r132095065
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -410,6 +413,14 @@ object PushProjectionThroughUnion
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/18846
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18846
**[Test build #80443 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80443/testReport)**
for PR 18846 at commit
[`afc07ee`](https://github.com/apache/spark/commit/af
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18790
It sounds like we need to revisit all the optimizer rules for
`EventTimeWatermark`? We can do it in the separate PRs.
---
If your project is set up for it, you can reply to this email and have y
Github user WeichenXu123 commented on the issue:
https://github.com/apache/spark/pull/16774
@BryanCutler You are right. Once `Future` complete the model can be cleaned
by GC. So the memory cost of the code has been optimized already. I didn't look
at the code carefully a few days ago.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/18866
Hash function is not the only issue, one important difference is: hive will
shuffle before write, and make sure one bucket has only one file. Spark doesn't
shuffle and each write task may write a
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18790
**[Test build #80434 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80434/testReport)**
for PR 18790 at commit
[`4cae897`](https://github.com/apache/spark/commit/4
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18890
**[Test build #80436 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80436/testReport)**
for PR 18890 at commit
[`532529a`](https://github.com/apache/spark/commit/5
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18790
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18890
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80436/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18790
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80434/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18890
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18880
**[Test build #80444 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80444/testReport)**
for PR 18880 at commit
[`7bd2904`](https://github.com/apache/spark/commit/7b
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18709
**[Test build #80445 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80445/testReport)**
for PR 18709 at commit
[`f5a26cc`](https://github.com/apache/spark/commit/f5
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18869
@viirya Could you hold this PR at first? There is a related PR
https://github.com/apache/spark/pull/18818 that is changing the underlying
semantics. We also need to update the description after t
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18869
**[Test build #80435 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80435/testReport)**
for PR 18869 at commit
[`1369fd5`](https://github.com/apache/spark/commit/1
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18869
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80435/
Test PASSed.
---
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/18869
@gatorsmile Sure. Let's wait after #18818. I'll look at it too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18869
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18818
Also add `NULL` in the test case?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enable
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18421
There are still two remaining comments. Could you also address them?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18787
**[Test build #80438 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80438/testReport)**
for PR 18787 at commit
[`23d19df`](https://github.com/apache/spark/commit/2
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18787
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18787
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80438/
Test PASSed.
---
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18421#discussion_r132099286
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -1033,25 +998,126 @@ private[spark] class HiveExternalCatalo
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18421#discussion_r132099901
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala ---
@@ -256,6 +257,222 @@ class StatisticsSuite extends
StatisticsColl
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/18499
thanks, merging to master!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wi
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18421
@mbasmanova Really thank you for your contribution! LGTM except the above
four comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/18499
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/18499
@aosagie do we still need the previous fix for SPARK-21176?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user ash211 commented on the issue:
https://github.com/apache/spark/pull/18789
@srowen sorry for not picking up on this -- thanks for pushing it over the
finish line in your PR!
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/18797
Merged into master and branch-2.2. Thanks for all.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/18797
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/18890
Thanks! Merging to branch-2.2.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18867
**[Test build #80437 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80437/testReport)**
for PR 18867 at commit
[`5fb7403`](https://github.com/apache/spark/commit/5
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18867
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80437/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18867
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/18890
Merged. Could you close the PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/18846
@thide I think DRIVER_HOST_ADDRESS will be used to generate the driver
url. Could you check if this line still works after your change?
https://github.com/apache/spark/blob/b35660dd0e930f4b484a0
501 - 544 of 544 matches
Mail list logo
