Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19344
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18732#discussion_r141830344
--- Diff: python/pyspark/sql/group.py ---
@@ -194,6 +194,28 @@ def pivot(self, pivot_col, values=None):
jgd = self._jgd.pivot(pivot_col,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19344
**[Test build #82311 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82311/testReport)**
for PR 19344 at commit
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18732#discussion_r141829344
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/python/ArrowEvalPythonExec.scala
---
@@ -44,14 +44,17 @@ case class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18732#discussion_r141828817
--- Diff: python/pyspark/sql/group.py ---
@@ -194,6 +194,28 @@ def pivot(self, pivot_col, values=None):
jgd = self._jgd.pivot(pivot_col,
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18732#discussion_r141827443
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala ---
@@ -435,6 +435,29 @@ class RelationalGroupedDataset
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18732#discussion_r141803015
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/AttributeSet.scala
---
@@ -37,6 +37,9 @@ object AttributeSet {
/**
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18732#discussion_r141788690
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/python/ArrowEvalPythonExec.scala
---
@@ -44,14 +44,17 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18732#discussion_r141788272
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/python/FlatMapGroupsInPandasExec.scala
---
@@ -0,0 +1,95 @@
+/*
+ * Licensed to
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18732#discussion_r141804070
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala ---
@@ -47,8 +47,8 @@ import org.apache.spark.sql.types.StructType
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18732#discussion_r141803992
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/object.scala
---
@@ -519,3 +519,18 @@ case class CoGroup(
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18732#discussion_r141803787
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/object.scala
---
@@ -24,9 +24,9 @@ import
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18732#discussion_r141788365
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/python/FlatMapGroupsInPandasExec.scala
---
@@ -0,0 +1,95 @@
+/*
+ * Licensed to
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18732#discussion_r141807573
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/python/FlatMapGroupsInPandasExec.scala
---
@@ -0,0 +1,95 @@
+/*
+ * Licensed to
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18732#discussion_r141804329
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala ---
@@ -435,6 +435,29 @@ class RelationalGroupedDataset
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19229
also cc @jkbradley and @MLnick for final check of the ML change. Thanks.
---
-
To unsubscribe, e-mail:
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19229
ping @gatorsmile Can you take a quick look? Thanks.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18732#discussion_r141820198
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/python/ArrowEvalPythonExec.scala
---
@@ -44,14 +44,17 @@ case class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18732#discussion_r141817634
--- Diff: python/pyspark/sql/group.py ---
@@ -194,6 +194,28 @@ def pivot(self, pivot_col, values=None):
jgd = self._jgd.pivot(pivot_col,
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/18732
Based on the doc of `pandas_udf`, we've already define pandas udf is an
user defined function (UDF) that accepts `Pandas.Series` as input arguments and
outputs a `Pandas.Series` of the same length.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19287
**[Test build #82313 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82313/testReport)**
for PR 19287 at commit
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/19287
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user liancheng commented on the issue:
https://github.com/apache/spark/pull/19386
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19369#discussion_r141808396
--- Diff:
core/src/main/scala/org/apache/spark/storage/BlockReplicationPolicy.scala ---
@@ -85,11 +65,9 @@ object BlockReplicationUtils {
*
Github user ouyangxiaochen commented on the issue:
https://github.com/apache/spark/pull/19380
In fact, there are many scenarios that need to be accurate to milliseconds,
should we try to solve this problem together?
---
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19365
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19365
Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19344
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82309/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19344
**[Test build #82309 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82309/testReport)**
for PR 19344 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19380
This would break compatibility with Spark and other engines like Hive. This
shoudl be closed.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19344
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19389
**[Test build #82310 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82310/testReport)**
for PR 19389 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19290
**[Test build #82312 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82312/testReport)**
for PR 19290 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19344
**[Test build #82311 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82311/testReport)**
for PR 19344 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19389
**[Test build #82307 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82307/testReport)**
for PR 19389 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19290
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19389
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19287
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19344
**[Test build #82309 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82309/testReport)**
for PR 19344 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19389
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19290
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19287
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82306/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19389
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82307/
Test FAILed.
---
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19382#discussion_r141801811
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -1438,39 +1438,44 @@ class HiveDDLSuite
}
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19287
**[Test build #82306 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82306/testReport)**
for PR 19287 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19290
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82308/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19290
**[Test build #82308 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82308/testReport)**
for PR 19290 at commit
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/19368
Thanks @gatorsmile! Since this is a bug, should I create a PR to backport
this fix to branch-2.2 too?
---
-
To unsubscribe,
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19344#discussion_r141797871
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/TPCDSQueryBenchmark.scala
---
@@ -66,24 +64,11 @@ object TPCDSQueryBenchmark
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19344#discussion_r141797330
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/TPCDSQueryBenchmark.scala
---
@@ -66,24 +64,11 @@ object TPCDSQueryBenchmark
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19344#discussion_r141798586
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/TPCDSQueryBenchmark.scala
---
@@ -66,24 +64,11 @@ object TPCDSQueryBenchmark
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19379
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19379
Thanks! Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19368
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19368
Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19368
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19290
I just double checked the newer lintr, lintr@5431140, passes on the top of
the master with the current change.
---
-
To
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19290
**[Test build #82308 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82308/testReport)**
for PR 19290 at commit
301 - 358 of 358 matches
Mail list logo
