Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152191659
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala
---
@@ -0,0 +1,305 @@
+/*
+ *
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19607
**[Test build #84044 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84044/testReport)**
for PR 19607 at commit
Github user gczsjdy commented on a diff in the pull request:
https://github.com/apache/spark/pull/19788#discussion_r152193203
--- Diff: core/src/main/scala/org/apache/spark/MapOutputTracker.scala ---
@@ -812,10 +812,14 @@ private[spark] object MapOutputTracker extends
Logging {
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19778
LGTM pending jenkins
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19737
LGTM pending jenkins
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19753
LGTM with two minor comments.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19607
**[Test build #84044 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84044/testReport)**
for PR 19607 at commit
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/19607
Well, I'd leave the config
`spark.sql.execution.pandas.respectSessionTimeZone` as it is for now to be safe
as @gatorsmile mentioned before.
And as we discussed in dev list, I'll update this to
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19790
cc @cloud-fan @kiszk
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/19790
[SPARK-22569] [SQL] Clean usage of addMutableState and splitExpressions
## What changes were proposed in this pull request?
This PR is to clean the usage of addMutableState and
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19737#discussion_r152185361
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeRowJoiner.scala
---
@@ -88,8 +92,14 @@ object
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19778#discussion_r152186300
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -841,6 +825,26 @@ class
Github user gczsjdy commented on the issue:
https://github.com/apache/spark/pull/19755
I can't find a way to distinguish `reused` and `unreused` subquery. For
example, in the `ReuseSubquery` rule, after seeing the 1st SubqueryExec(with
`unreused` in name), it's buffered. When the
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19389
**[Test build #84051 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84051/testReport)**
for PR 19389 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19778
**[Test build #84052 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84052/testReport)**
for PR 19778 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152192018
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala
---
@@ -0,0 +1,306 @@
+/*
+ *
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/19730
@cloud-fan I see, I will create another PR to fix this global variable
issue.
@gatorsmile I will check other calls.
---
-
To
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19763#discussion_r152193763
--- Diff: core/src/main/scala/org/apache/spark/MapOutputTracker.scala ---
@@ -472,15 +475,66 @@ private[spark] class MapOutputTrackerMaster(
Github user jliwork commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152193847
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala
---
@@ -0,0 +1,306 @@
+/*
+ * Licensed
Github user jliwork commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152193833
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala
---
@@ -0,0 +1,305 @@
+/*
+ * Licensed
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19790
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19790
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84045/
Test FAILed.
---
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19787#discussion_r152195436
--- Diff: python/pyspark/sql/functions.py ---
@@ -2198,12 +2198,9 @@ def udf(f=None, returnType=StringType()):
duplicate invocations may be
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19753#discussion_r152173508
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/VectorIndexer.scala ---
@@ -55,7 +55,7 @@ private[ml] trait VectorIndexerParams extends Params
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19753#discussion_r152172693
--- Diff: python/pyspark/ml/feature.py ---
@@ -2490,7 +2490,8 @@ def setParams(self, inputCols=None, outputCol=None):
@inherit_doc
Github user gczsjdy commented on a diff in the pull request:
https://github.com/apache/spark/pull/19763#discussion_r152185531
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -485,4 +485,13 @@ package object config {
"array in the
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19737#discussion_r152185474
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeRowJoiner.scala
---
@@ -154,7 +164,10 @@ object
Github user jliwork commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152186116
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -296,8 +296,33 @@ class JDBCSuite extends SparkFunSuite
// The
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19776
**[Test build #84047 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84047/testReport)**
for PR 19776 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19778
**[Test build #84050 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84050/testReport)**
for PR 19778 at commit
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r152189670
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -140,6 +140,13 @@ object SQLConf {
.booleanConf
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152191858
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala
---
@@ -0,0 +1,305 @@
+/*
+ *
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19607
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84044/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19776
**[Test build #84053 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84053/testReport)**
for PR 19776 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19607
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19776
**[Test build #84055 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84055/testReport)**
for PR 19776 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19790
**[Test build #84045 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84045/testReport)**
for PR 19790 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19790
LGTM, can you improve the PR description to describe the major change? e.g.
```
1. replace hardcoded type string to ctx.JAVA_BOOLEAN etc.
2. create a default value of the initCode for
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19439
**[Test build #84042 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84042/testReport)**
for PR 19439 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19439
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19439
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84042/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19790
**[Test build #84045 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84045/testReport)**
for PR 19790 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19730
Yeah. We can fix them in this PR.
BTW, could you check all the other calls of `addMutableState` and fix them
too?
---
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19778#discussion_r152190136
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -841,6 +825,26 @@ class CodegenContext {
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19737
**[Test build #84054 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84054/testReport)**
for PR 19737 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17436#discussion_r152192733
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -140,6 +140,13 @@ object SQLConf {
.booleanConf
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19730
I think this is a different issue and should be fixed with another PR.
@kiszk how about we change the test to cast int to long to avoid this issue?
---
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19790#discussion_r152195602
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -205,27 +209,32 @@ case class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19787#discussion_r152198789
--- Diff: python/pyspark/sql/functions.py ---
@@ -2198,12 +2198,9 @@ def udf(f=None, returnType=StringType()):
duplicate invocations may be
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19787#discussion_r152198691
--- Diff: python/pyspark/sql/functions.py ---
@@ -2205,6 +2205,10 @@ def udf(f=None, returnType=StringType()):
rows that do not satisfy the
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19779#discussion_r152198714
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala ---
@@ -841,6 +841,76 @@ class VersionsSuite extends
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19779
The fix looks good to me. You can address the comments left by
@dongjoon-hyun
---
-
To unsubscribe, e-mail:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19787#discussion_r152198181
--- Diff: python/pyspark/sql/functions.py ---
@@ -2198,12 +2198,9 @@ def udf(f=None, returnType=StringType()):
duplicate invocations may be
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19787
**[Test build #84056 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84056/testReport)**
for PR 19787 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19787
Thanks @HyukjinKwon I've revised the doc for pandas_udf too.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/19763#discussion_r152087573
--- Diff: core/src/main/scala/org/apache/spark/MapOutputTracker.scala ---
@@ -472,16 +475,48 @@ private[spark] class MapOutputTrackerMaster(
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/19763#discussion_r152084018
--- Diff: core/src/main/scala/org/apache/spark/MapOutputTracker.scala ---
@@ -472,16 +475,48 @@ private[spark] class MapOutputTrackerMaster(
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/19763#discussion_r152084974
--- Diff: core/src/main/scala/org/apache/spark/MapOutputTracker.scala ---
@@ -472,16 +475,48 @@ private[spark] class MapOutputTrackerMaster(
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19370
**[Test build #84038 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84038/testReport)**
for PR 19370 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19778
LGTM except one minor comment
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19778#discussion_r152101922
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -841,6 +825,26 @@ class
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19786
**[Test build #84021 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84021/testReport)**
for PR 19786 at commit
Github user SimonBin commented on the issue:
https://github.com/apache/spark/pull/18692
Hi, we are very interested in this patch. I wonder if it could detect this
code automatically, without needing to write the explicit join:
```scala
package
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/19786
@vanzin Please help review this.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/19773#discussion_r151990044
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -318,16 +318,28 @@ case class AlterTableChangeColumnCommand(
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19786
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84021/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19786
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19773
**[Test build #84022 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84022/testReport)**
for PR 19773 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19783#discussion_r151979117
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/statsEstimation/FilterEstimationSuite.scala
---
@@ -158,8 +196,8 @@ class
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19786#discussion_r151988844
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -132,15 +132,20 @@ private[history] class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19773
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84022/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19773
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19786#discussion_r151983008
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -132,15 +132,20 @@ private[history] class
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/19773
@jaceklaskowski Thanks for your review and comments, I rebased the branch
and addressed all comments, this patch is now ready for next reviewing.
---
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19746#discussion_r151955287
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/VectorSizeHint.scala ---
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apache Software
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19746#discussion_r151954037
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/VectorSizeHint.scala ---
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apache Software
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19746#discussion_r151956112
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/VectorSizeHint.scala ---
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apache Software
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19746#discussion_r151958073
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/VectorSizeHintSuite.scala ---
@@ -0,0 +1,135 @@
+/*
+ * Licensed to the Apache
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19746#discussion_r151954590
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/VectorSizeHint.scala ---
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apache Software
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19778#discussion_r151958049
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -224,22 +224,55 @@ case class
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19746#discussion_r151956715
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/VectorSizeHintSuite.scala ---
@@ -0,0 +1,135 @@
+/*
+ * Licensed to the Apache
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19781#discussion_r151959078
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala
---
@@ -90,6 +90,10 @@ case class
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19776
**[Test build #84019 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84019/testReport)**
for PR 19776 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19776
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84019/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19776
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r151960214
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
---
@@ -497,7 +497,19 @@ object DataSourceStrategy
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19781#discussion_r151961655
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala
---
@@ -90,6 +90,10 @@ case class BroadcastHashJoinExec(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r151962055
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -296,8 +296,33 @@ class JDBCSuite extends SparkFunSuite
//
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19776
good catch! It's a long-standing bug and I think we should backport it all
the way to 2.0
---
-
To unsubscribe, e-mail:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19763#discussion_r151962620
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -485,4 +485,13 @@ package object config {
"array in the
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19763#discussion_r151962448
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -485,4 +485,13 @@ package object config {
"array in the
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19781#discussion_r151963108
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala
---
@@ -76,7 +76,7 @@ case class
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/19781#discussion_r151963572
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala
---
@@ -76,7 +76,7 @@ case class BroadcastHashJoinExec(
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/10468#discussion_r151965254
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -186,8 +187,26 @@ class JDBCSuite extends SparkFunSuite
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19607#discussion_r151999012
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/python/ArrowPythonRunner.scala
---
@@ -58,6 +59,11 @@ class ArrowPythonRunner(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19763#discussion_r152004301
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -485,4 +485,13 @@ package object config {
"array in the
Github user gczsjdy commented on a diff in the pull request:
https://github.com/apache/spark/pull/19763#discussion_r152005905
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -485,4 +485,13 @@ package object config {
"array in the
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19774#discussion_r152005780
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/describe-table-column.sql ---
@@ -24,6 +24,19 @@ DESC EXTENDED desc_col_table key;
DESC
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19763#discussion_r152007204
--- Diff: core/src/main/scala/org/apache/spark/MapOutputTracker.scala ---
@@ -472,16 +475,45 @@ private[spark] class MapOutputTrackerMaster(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19737#discussion_r152008389
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeRowJoiner.scala
---
@@ -88,7 +112,20 @@ object
201 - 300 of 331 matches
Mail list logo
