[GitHub] spark issue #20277: [SPARK-23090][SQL] polish ColumnVector

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20277 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20316: [SPARK-23149][SQL] polish ColumnarBatch

2018-01-18 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/20316 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20277: [SPARK-23090][SQL] polish ColumnVector

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20277 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86371/ Test FAILed. ---

[GitHub] spark issue #20277: [SPARK-23090][SQL] polish ColumnVector

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20277 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20277: [SPARK-23090][SQL] polish ColumnVector

2018-01-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20277 **[Test build #86371 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86371/testReport)** for PR 20277 at commit

[GitHub] spark issue #20275: [SPARK-23085][ML] API parity for mllib.linalg.Vectors.sp...

2018-01-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20275 **[Test build #86373 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86373/testReport)** for PR 20275 at commit

[GitHub] spark issue #20277: [SPARK-23090][SQL] polish ColumnVector

2018-01-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20277 **[Test build #86372 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86372/testReport)** for PR 20277 at commit

[GitHub] spark issue #20275: [SPARK-23085][ML] API parity for mllib.linalg.Vectors.sp...

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20275 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/25/ Test

[GitHub] spark issue #20275: [SPARK-23085][ML] API parity for mllib.linalg.Vectors.sp...

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20275 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20277: [SPARK-23090][SQL] polish ColumnVector

2018-01-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20277 **[Test build #86371 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86371/testReport)** for PR 20277 at commit

[GitHub] spark issue #20277: [SPARK-23090][SQL] polish ColumnVector

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20277 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20277: [SPARK-23090][SQL] polish ColumnVector

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20277 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/24/ Test

[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...

2018-01-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20025 **[Test build #86370 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86370/testReport)** for PR 20025 at commit

[GitHub] spark issue #20316: [SPARK-23149][SQL] polish ColumnarBatch

2018-01-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20316 **[Test build #86369 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86369/testReport)** for PR 20316 at commit

[GitHub] spark issue #20316: [SPARK-23149][SQL] polish ColumnarBatch

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20316 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/23/ Test

[GitHub] spark pull request #20025: [SPARK-22837][SQL]Session timeout checker does no...

2018-01-18 Thread zuotingbing
Github user zuotingbing commented on a diff in the pull request: https://github.com/apache/spark/pull/20025#discussion_r162528506 --- Diff: sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/session/SessionManager.java --- @@ -79,35 +75,19 @@ public synchronized void

[GitHub] spark issue #20316: [SPARK-23149][SQL] polish ColumnarBatch

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20316 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20324: [SPARK-23091][ML] Incorrect unit test for approxQuantile

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20324 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/22/ Test

[GitHub] spark issue #20324: [SPARK-23091][ML] Incorrect unit test for approxQuantile

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20324 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20087: [SPARK-21786][SQL] The 'spark.sql.parquet.compres...

2018-01-18 Thread fjh100456
Github user fjh100456 commented on a diff in the pull request: https://github.com/apache/spark/pull/20087#discussion_r162528298 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/CompressionCodecSuite.scala --- @@ -0,0 +1,321 @@ +/* + * Licensed to the Apache

[GitHub] spark issue #20324: [SPARK-23091][ML] Incorrect unit test for approxQuantile

2018-01-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20324 **[Test build #86368 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86368/testReport)** for PR 20324 at commit

[GitHub] spark issue #20324: [SPARK-23091][ML] Incorrect unit test for approxQuantile

2018-01-18 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/20324 Retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20316: [SPARK-23149][SQL] polish ColumnarBatch

2018-01-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20316 **[Test build #86367 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86367/testReport)** for PR 20316 at commit

[GitHub] spark issue #20316: [SPARK-23149][SQL] polish ColumnarBatch

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20316 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/21/ Test

[GitHub] spark issue #20316: [SPARK-23149][SQL] polish ColumnarBatch

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20316 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20323: [BUILD][MINOR] Fix java style check issues

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20323 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86363/ Test PASSed. ---

[GitHub] spark issue #20323: [BUILD][MINOR] Fix java style check issues

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20323 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20323: [BUILD][MINOR] Fix java style check issues

2018-01-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20323 **[Test build #86363 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86363/testReport)** for PR 20323 at commit

[GitHub] spark issue #20324: [SPARK-23091][ML] Incorrect unit test for approxQuantile

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20324 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20324: [SPARK-23091][ML] Incorrect unit test for approxQuantile

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20324 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86364/ Test FAILed. ---

[GitHub] spark issue #20324: [SPARK-23091][ML] Incorrect unit test for approxQuantile

2018-01-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20324 **[Test build #86364 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86364/testReport)** for PR 20324 at commit

[GitHub] spark issue #20323: [BUILD][MINOR] Fix java style check issues

2018-01-18 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/20323 @sameeragarwal . Can we turn on Travis CI for that purpose like AppVeyor? I made it already in Apache Spark, but it's not enabled because there is a concern about Travis CI capacity. ---

[GitHub] spark pull request #20297: [SPARK-23020][CORE] Fix races in launcher code, t...

2018-01-18 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20297#discussion_r162525240 --- Diff: launcher/src/main/java/org/apache/spark/launcher/LauncherServer.java --- @@ -331,23 +358,27 @@ protected void handle(Message msg) throws

[GitHub] spark issue #18983: [SPARK-21771][SQL]remove useless hive client in SparkSQL...

2018-01-18 Thread yaooqinn
Github user yaooqinn commented on the issue: https://github.com/apache/spark/pull/18983 besides, redirecting output here only is needed when there is an instance of a CliSessionState, otherwise, it will be done during the SessionState initializing in HiveClientImpl ---

[GitHub] spark pull request #20297: [SPARK-23020][CORE] Fix races in launcher code, t...

2018-01-18 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20297#discussion_r162525142 --- Diff: launcher/src/main/java/org/apache/spark/launcher/LauncherServer.java --- @@ -331,23 +358,27 @@ protected void handle(Message msg) throws

[GitHub] spark issue #20046: [SPARK-22362][SQL] Add unit test for Window Aggregate Fu...

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20046 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86362/ Test PASSed. ---

[GitHub] spark issue #20046: [SPARK-22362][SQL] Add unit test for Window Aggregate Fu...

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20046 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20046: [SPARK-22362][SQL] Add unit test for Window Aggregate Fu...

2018-01-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20046 **[Test build #86362 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86362/testReport)** for PR 20046 at commit

[GitHub] spark pull request #20297: [SPARK-23020][CORE] Fix races in launcher code, t...

2018-01-18 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20297#discussion_r162524725 --- Diff: launcher/src/main/java/org/apache/spark/launcher/LauncherConnection.java --- @@ -95,15 +95,15 @@ protected synchronized void send(Message msg)

[GitHub] spark pull request #20297: [SPARK-23020][CORE] Fix races in launcher code, t...

2018-01-18 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20297#discussion_r162524615 --- Diff: launcher/src/main/java/org/apache/spark/launcher/ChildProcAppHandle.java --- @@ -48,14 +48,16 @@ public synchronized void disconnect() {

[GitHub] spark pull request #20316: [SPARK-23149][SQL] polish ColumnarBatch

2018-01-18 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20316#discussion_r162522356 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedParquetRecordReader.java --- @@ -50,6 +50,9 @@ *

[GitHub] spark pull request #20281: [SPARK-23089][STS] Recreate session log directory...

2018-01-18 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/20281#discussion_r162522303 --- Diff: sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/session/HiveSessionImpl.java --- @@ -223,6 +223,18 @@ private void

[GitHub] spark issue #18983: [SPARK-21771][SQL]remove useless hive client in SparkSQL...

2018-01-18 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/18983 Seems it should be okay to remove all the `metadataHive` things here. --- - To unsubscribe, e-mail:

[GitHub] spark issue #20285: [SPARK-22735][ML][DOC] Added VectorSizeHint docs and exa...

2018-01-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20285 **[Test build #86366 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86366/testReport)** for PR 20285 at commit

[GitHub] spark issue #20285: [SPARK-22735][ML][DOC] Added VectorSizeHint docs and exa...

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20285 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20285: [SPARK-22735][ML][DOC] Added VectorSizeHint docs and exa...

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20285 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86366/ Test PASSed. ---

[GitHub] spark pull request #20087: [SPARK-21786][SQL] The 'spark.sql.parquet.compres...

2018-01-18 Thread fjh100456
Github user fjh100456 commented on a diff in the pull request: https://github.com/apache/spark/pull/20087#discussion_r162520864 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/CompressionCodecSuite.scala --- @@ -0,0 +1,321 @@ +/* + * Licensed to the Apache

[GitHub] spark issue #20091: [SPARK-22465][FOLLOWUP] Update the number of partitions ...

2018-01-18 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/20091 @sujithjay @mridulm @cloud-fan @gatorsmile PTAL --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark pull request #20316: [SPARK-23149][SQL] polish ColumnarBatch

2018-01-18 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/20316#discussion_r162520627 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedParquetRecordReader.java --- @@ -50,6 +50,9 @@ *

[GitHub] spark pull request #20316: [SPARK-23149][SQL] polish ColumnarBatch

2018-01-18 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20316#discussion_r162520019 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedParquetRecordReader.java --- @@ -50,6 +50,9 @@ *

[GitHub] spark issue #20285: [SPARK-22735][ML][DOC] Added VectorSizeHint docs and exa...

2018-01-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20285 **[Test build #86366 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86366/testReport)** for PR 20285 at commit

[GitHub] spark pull request #20087: [SPARK-21786][SQL] The 'spark.sql.parquet.compres...

2018-01-18 Thread fjh100456
Github user fjh100456 commented on a diff in the pull request: https://github.com/apache/spark/pull/20087#discussion_r162519320 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/CompressionCodecSuite.scala --- @@ -0,0 +1,321 @@ +/* + * Licensed to the Apache

[GitHub] spark issue #20285: [SPARK-22735][ML][DOC] Added VectorSizeHint docs and exa...

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20285 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20285: [SPARK-22735][ML][DOC] Added VectorSizeHint docs and exa...

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20285 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/20/ Test

[GitHub] spark pull request #20316: [SPARK-23149][SQL] polish ColumnarBatch

2018-01-18 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20316#discussion_r162519101 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.java --- @@ -49,18 +49,8 @@ * After

[GitHub] spark pull request #20285: [SPARK-22735][ML][DOC] Added VectorSizeHint docs ...

2018-01-18 Thread MrBago
Github user MrBago commented on a diff in the pull request: https://github.com/apache/spark/pull/20285#discussion_r162519014 --- Diff: docs/ml-features.md --- @@ -1283,6 +1283,56 @@ for more details on the API. +## VectorSizeHint + +It can sometimes be

[GitHub] spark issue #20281: [SPARK-23089][STS] Recreate session log directory if it ...

2018-01-18 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/20281 @gatorsmile , do you have further comment? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20316: [SPARK-23149][SQL] polish ColumnarBatch

2018-01-18 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/20316#discussion_r162518569 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedParquetRecordReader.java --- @@ -50,6 +50,9 @@ *

[GitHub] spark pull request #20316: [SPARK-23149][SQL] polish ColumnarBatch

2018-01-18 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20316#discussion_r162518087 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedParquetRecordReader.java --- @@ -50,6 +50,9 @@ *

[GitHub] spark issue #20226: [SPARK-23034][SQL] Override `nodeName` for all *ScanExec...

2018-01-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20226 **[Test build #86353 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86353/testReport)** for PR 20226 at commit

[GitHub] spark issue #20226: [SPARK-23034][SQL] Override `nodeName` for all *ScanExec...

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20226 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86353/ Test FAILed. ---

[GitHub] spark issue #20226: [SPARK-23034][SQL] Override `nodeName` for all *ScanExec...

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20226 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20298: [SPARK-22976][Core]: Cluster mode driver dir removed whi...

2018-01-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20298 **[Test build #86365 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86365/testReport)** for PR 20298 at commit

[GitHub] spark issue #20298: [SPARK-22976][Core]: Cluster mode driver dir removed whi...

2018-01-18 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/20298 LGTM for the fix. @zsxwing would you please take another look? --- - To unsubscribe, e-mail:

[GitHub] spark issue #20298: [SPARK-22976][Core]: Cluster mode driver dir removed whi...

2018-01-18 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/20298 Jenkins, retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20324: [SPARK-23091][ML] Incorrect unit test for approxQuantile

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20324 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/19/ Test

[GitHub] spark issue #20324: [SPARK-23091][ML] Incorrect unit test for approxQuantile

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20324 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20314: [SPARK-23104][K8S][Docs] Changes to Kubernetes scheduler...

2018-01-18 Thread foxish
Github user foxish commented on the issue: https://github.com/apache/spark/pull/20314 @felixcheung @vanzin @rxin this is ready to merge. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #20324: [SPARK-23091][ML] Incorrect unit test for approxQuantile

2018-01-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20324 **[Test build #86364 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86364/testReport)** for PR 20324 at commit

[GitHub] spark pull request #20324: [SPARK-23091][ML] Incorrect unit test for approxQ...

2018-01-18 Thread srowen
GitHub user srowen opened a pull request: https://github.com/apache/spark/pull/20324 [SPARK-23091][ML] Incorrect unit test for approxQuantile ## What changes were proposed in this pull request? Narrow bound on approx quantile test to epsilon from 2*epsilon to match paper

[GitHub] spark pull request #20316: [SPARK-23149][SQL] polish ColumnarBatch

2018-01-18 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20316#discussion_r162514432 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVectorUtils.java --- @@ -192,7 +192,7 @@ private static void

[GitHub] spark pull request #20312: [Docs] change to dataset for java code in structu...

2018-01-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20312 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20312: [Docs] change to dataset for java code in structured-str...

2018-01-18 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/20312 Merged to master/2.3/2.2 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #18092: [SPARK-20640][CORE]Make rpc timeout and retry for shuffl...

2018-01-18 Thread swevrywhere
Github user swevrywhere commented on the issue: https://github.com/apache/spark/pull/18092 Was this included in the new PySpark 2.2.1 release? I didn't see this item number in https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315420=12340470, b ut am hoping that it

[GitHub] spark pull request #17581: [SPARK-20248][ SQL]Spark SQL add limit parameter ...

2018-01-18 Thread shaolinliu
Github user shaolinliu closed the pull request at: https://github.com/apache/spark/pull/17581 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20308: [SPARK-23142][SS][DOCS] Added docs for continuous...

2018-01-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20308 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...

2018-01-18 Thread WeichenXu123
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/20257 Nice, LGTM. Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19340: [SPARK-22119][ML] Add cosine distance to KMeans

2018-01-18 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/19340 > That link also mentions that Matlab allows cosine distance. http://www.mathworks.com/help/stats/kmeans.html?s_tid=gn_loc_drop The link to Matlab doc explicitly describes how it computes

[GitHub] spark issue #20161: [SPARK-21525][streaming] Check error code from superviso...

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20161 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20161: [SPARK-21525][streaming] Check error code from superviso...

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20161 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86360/ Test PASSed. ---

[GitHub] spark issue #20161: [SPARK-21525][streaming] Check error code from superviso...

2018-01-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20161 **[Test build #86360 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86360/testReport)** for PR 20161 at commit

[GitHub] spark issue #20272: [SPARK-23078] [CORE] allow Spark Thrift Server to run in...

2018-01-18 Thread ozzieba
Github user ozzieba commented on the issue: https://github.com/apache/spark/pull/20272 @foxish @felixcheung Now verified my test runs successfully https://github.com/apache-spark-on-k8s/spark-integration/pull/38 ---

[GitHub] spark issue #17899: [SPARK-20636] Add new optimization rule to transpose adj...

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17899 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #17899: [SPARK-20636] Add new optimization rule to transpose adj...

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17899 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86355/ Test PASSed. ---

[GitHub] spark issue #17899: [SPARK-20636] Add new optimization rule to transpose adj...

2018-01-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17899 **[Test build #86355 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86355/testReport)** for PR 17899 at commit

[GitHub] spark issue #20323: [BUILD][MINOR] Fix java style check issues

2018-01-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20323 **[Test build #86363 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86363/testReport)** for PR 20323 at commit

[GitHub] spark issue #20323: [BUILD][MINOR] Fix java style check issues

2018-01-18 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/20323 I keep forgetting why we can't turn on the checks -- was it just a time thing, because it meant a whole other pass over the code with maven? ---

[GitHub] spark issue #20323: [BUILD][MINOR] Fix java style check issues

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20323 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20323: [BUILD][MINOR] Fix java style check issues

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20323 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/18/ Test

[GitHub] spark pull request #20323: [BUILD][MINOR] Fix java style check issues

2018-01-18 Thread sameeragarwal
GitHub user sameeragarwal opened a pull request: https://github.com/apache/spark/pull/20323 [BUILD][MINOR] Fix java style check issues ## What changes were proposed in this pull request? This patch fixes a few recently introduced java style check errors in master and

[GitHub] spark issue #20046: [SPARK-22362][SQL] Add unit test for Window Aggregate Fu...

2018-01-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20046 **[Test build #86362 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86362/testReport)** for PR 20046 at commit

[GitHub] spark issue #18983: [SPARK-21771][SQL]remove useless hive client in SparkSQL...

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18983 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86361/ Test PASSed. ---

[GitHub] spark issue #20046: [SPARK-22362][SQL] Add unit test for Window Aggregate Fu...

2018-01-18 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/20046 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #18983: [SPARK-21771][SQL]remove useless hive client in SparkSQL...

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18983 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #18983: [SPARK-21771][SQL]remove useless hive client in SparkSQL...

2018-01-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18983 **[Test build #86361 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86361/testReport)** for PR 18983 at commit

[GitHub] spark issue #19054: [SPARK-18067] Avoid shuffling child if join keys are sup...

2018-01-18 Thread tejasapatil
Github user tejasapatil commented on the issue: https://github.com/apache/spark/pull/19054 cc @hvanhovell @cloud-fan for review --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20302: [SPARK-23094] Fix invalid character handling in J...

2018-01-18 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20302#discussion_r162495107 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/sources/JsonHadoopFsRelationSuite.scala --- @@ -105,4 +107,36 @@ class

[GitHub] spark issue #18983: [SPARK-21771][SQL]remove useless hive client in SparkSQL...

2018-01-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18983 **[Test build #86361 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86361/testReport)** for PR 18983 at commit

[GitHub] spark issue #20161: [SPARK-21525][streaming] Check error code from superviso...

2018-01-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20161 **[Test build #86360 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86360/testReport)** for PR 20161 at commit

[GitHub] spark issue #18983: [SPARK-21771][SQL]remove useless hive client in SparkSQL...

2018-01-18 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18983 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

<    1   2   3   4   5   6   7   8   9   >