[GitHub] spark pull request #20201: [SPARK-22389][SQL] data source v2 partitioning re...

2018-01-19 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20201#discussion_r162733684 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/Partitioning.java --- @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #20201: [SPARK-22389][SQL] data source v2 partitioning re...

2018-01-19 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20201#discussion_r162733629 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/Partitioning.java --- @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #20201: [SPARK-22389][SQL] data source v2 partitioning re...

2018-01-19 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20201#discussion_r162733463 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/Distribution.java --- @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #20201: [SPARK-22389][SQL] data source v2 partitioning re...

2018-01-19 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20201#discussion_r162733351 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourcePartitioning.scala --- @@ -0,0 +1,49 @@ +/* + *

[GitHub] spark issue #20299: [SPARK-23135][ui] Fix rendering of accumulators in the s...

2018-01-19 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/20299 LGTM. Merging this to master/2.3. Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark pull request #20201: [SPARK-22389][SQL] data source v2 partitioning re...

2018-01-19 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20201#discussion_r162733141 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/ClusteredDistribution.java --- @@ -0,0 +1,34 @@ +/* + * Licensed to the

[GitHub] spark pull request #20201: [SPARK-22389][SQL] data source v2 partitioning re...

2018-01-19 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20201#discussion_r162732939 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataSourceV2Suite.scala --- @@ -95,6 +96,34 @@ class DataSourceV2Suite extends

[GitHub] spark issue #20203: [SPARK-22577] [core] executor page blacklist status shou...

2018-01-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20203 **[Test build #86400 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86400/testReport)** for PR 20203 at commit

[GitHub] spark issue #20091: [SPARK-22465][FOLLOWUP] Update the number of partitions ...

2018-01-19 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/20091 @mridulm Thank you! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20091: [SPARK-22465][FOLLOWUP] Update the number of partitions ...

2018-01-19 Thread mridulm
Github user mridulm commented on the issue: https://github.com/apache/spark/pull/20091 @jiangxb1987 Thanks for clarifying, looks good to me - I will merge it later today evening (assuming someone else does not before :) ) ---

[GitHub] spark issue #20319: [SPARK-22884][ML][TESTS] ML test for StructuredStreaming...

2018-01-19 Thread smurakozi
Github user smurakozi commented on the issue: https://github.com/apache/spark/pull/20319 @jkbradley could you check out this change, please? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #20235: [Spark-22887][ML][TESTS][WIP] ML test for StructuredStre...

2018-01-19 Thread smurakozi
Github user smurakozi commented on the issue: https://github.com/apache/spark/pull/20235 @jkbradley could you check out this change, please? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark pull request #20330: [SPARK-23121][core] Fix for ui becoming unaccessi...

2018-01-19 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20330#discussion_r162721177 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala --- @@ -427,23 +435,21 @@ private[ui] class JobDataSource( val

[GitHub] spark issue #20330: [SPARK-23121][core] Fix for ui becoming unaccessible for...

2018-01-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20330 **[Test build #86399 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86399/testReport)** for PR 20330 at commit

[GitHub] spark pull request #19993: [SPARK-22799][ML] Bucketizer should throw excepti...

2018-01-19 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/19993#discussion_r162719519 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Bucketizer.scala --- @@ -201,9 +184,13 @@ final class Bucketizer @Since("1.4.0")

[GitHub] spark issue #19993: [SPARK-22799][ML] Bucketizer should throw exception if s...

2018-01-19 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/19993 @jkbradley sure no problem, let me know how I can help. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark pull request #19993: [SPARK-22799][ML] Bucketizer should throw excepti...

2018-01-19 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/19993#discussion_r162717263 --- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala --- @@ -166,6 +167,8 @@ private[ml] object Param { @DeveloperApi object

[GitHub] spark pull request #19993: [SPARK-22799][ML] Bucketizer should throw excepti...

2018-01-19 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/19993#discussion_r162717142 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Bucketizer.scala --- @@ -201,9 +184,13 @@ final class Bucketizer @Since("1.4.0")

[GitHub] spark issue #20203: [SPARK-22577] [core] executor page blacklist status shou...

2018-01-19 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20203 btw another way you could test out having a bad host would be something like this (untested): ```scala import org.apache.spark.SparkEnv val hosts = sc.parallelize(1 to 1,

[GitHub] spark pull request #20203: [SPARK-22577] [core] executor page blacklist stat...

2018-01-19 Thread attilapiros
Github user attilapiros commented on a diff in the pull request: https://github.com/apache/spark/pull/20203#discussion_r162716271 --- Diff: core/src/test/scala/org/apache/spark/scheduler/TaskSetBlacklistSuite.scala --- @@ -59,31 +60,55 @@ class TaskSetBlacklistSuite extends

[GitHub] spark pull request #20146: [SPARK-11215][ML] Add multiple columns support to...

2018-01-19 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/20146#discussion_r162715788 --- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala --- @@ -249,6 +249,16 @@ object ParamValidators { def

[GitHub] spark pull request #20203: [SPARK-22577] [core] executor page blacklist stat...

2018-01-19 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/20203#discussion_r162714257 --- Diff: core/src/test/scala/org/apache/spark/scheduler/TaskSetBlacklistSuite.scala --- @@ -59,31 +60,55 @@ class TaskSetBlacklistSuite extends

[GitHub] spark issue #20203: [SPARK-22577] [core] executor page blacklist status shou...

2018-01-19 Thread attilapiros
Github user attilapiros commented on the issue: https://github.com/apache/spark/pull/20203 The node blacklisting is tested by unit tests: - HistoryServerSuite - TaskSetBlacklistSuite - AppStatusListenerSuite And manually with a 2 node cluster:

[GitHub] spark issue #20332: [SPARK-23138][ML][DOC] Multiclass logistic regression su...

2018-01-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20332 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20332: [SPARK-23138][ML][DOC] Multiclass logistic regression su...

2018-01-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20332 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86397/ Test PASSed. ---

[GitHub] spark issue #20332: [SPARK-23138][ML][DOC] Multiclass logistic regression su...

2018-01-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20332 **[Test build #86397 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86397/testReport)** for PR 20332 at commit

[GitHub] spark pull request #20284: [SPARK-23103][core] Ensure correct sort order for...

2018-01-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20284 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20330: [SPARK-23121][core] Fix for ui becoming unaccessi...

2018-01-19 Thread smurakozi
Github user smurakozi commented on a diff in the pull request: https://github.com/apache/spark/pull/20330#discussion_r162712767 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala --- @@ -427,23 +435,21 @@ private[ui] class JobDataSource( val

[GitHub] spark issue #20203: [SPARK-22577] [core] executor page blacklist status shou...

2018-01-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20203 **[Test build #86398 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86398/testReport)** for PR 20203 at commit

[GitHub] spark issue #20284: [SPARK-23103][core] Ensure correct sort order for negati...

2018-01-19 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20284 even though we don't *know* of this causing a bug in 2.3, I still think we should merge it in there just because there may be some case we aren't thinking of, and this is a relatively small, safe

[GitHub] spark pull request #20138: [SPARK-20664][core] Delete stale application data...

2018-01-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20138 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20331: [SPARK-23158] [SQL] Move HadoopFsRelationTest test suite...

2018-01-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20331 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20138: [SPARK-20664][core] Delete stale application data from S...

2018-01-19 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20138 as RC1 failed and RC2 is going to be cut soon, I'm going to merge this to master & 2.3 --- - To unsubscribe, e-mail:

[GitHub] spark issue #20331: [SPARK-23158] [SQL] Move HadoopFsRelationTest test suite...

2018-01-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20331 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86393/ Test FAILed. ---

[GitHub] spark issue #20331: [SPARK-23158] [SQL] Move HadoopFsRelationTest test suite...

2018-01-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20331 **[Test build #86393 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86393/testReport)** for PR 20331 at commit

[GitHub] spark issue #20332: [SPARK-23138][ML][DOC] Multiclass logistic regression su...

2018-01-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20332 **[Test build #86397 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86397/testReport)** for PR 20332 at commit

[GitHub] spark issue #20332: [SPARK-23138][ML][DOC] Multiclass logistic regression su...

2018-01-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20332 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/48/ Test

[GitHub] spark issue #20332: [SPARK-23138][ML][DOC] Multiclass logistic regression su...

2018-01-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20332 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20331: [SPARK-23158] [SQL] Move HadoopFsRelationTest test suite...

2018-01-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20331 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20331: [SPARK-23158] [SQL] Move HadoopFsRelationTest test suite...

2018-01-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20331 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86392/ Test FAILed. ---

[GitHub] spark issue #20331: [SPARK-23158] [SQL] Move HadoopFsRelationTest test suite...

2018-01-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20331 **[Test build #86392 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86392/testReport)** for PR 20331 at commit

[GitHub] spark issue #17123: [SPARK-19781][ML] Handle NULLs as well as NaNs in Bucket...

2018-01-19 Thread WeichenXu123
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/17123 But, pls resolve conflicts first. :) Bucketizer add multiple column support so the code is different now. --- - To

[GitHub] spark issue #19993: [SPARK-22799][ML] Bucketizer should throw exception if s...

2018-01-19 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/19993 Since RC1 for 2.3 failed, it'd be great to get this into 2.3. @mgaido91 do you mind if I send my comments along with a PR to update this PR of yours? I'm rushing because of the time pressure to

[GitHub] spark issue #20332: [SPARK-23138][ML][DOC] Multiclass logistic regression su...

2018-01-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20332 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20332: [SPARK-23138][ML][DOC] Multiclass logistic regression su...

2018-01-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20332 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/47/ Test

[GitHub] spark issue #20332: [SPARK-23138][ML][DOC] Multiclass logistic regression su...

2018-01-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20332 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86396/ Test FAILed. ---

[GitHub] spark issue #20332: [SPARK-23138][ML][DOC] Multiclass logistic regression su...

2018-01-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20332 **[Test build #86396 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86396/testReport)** for PR 20332 at commit

[GitHub] spark issue #20332: [SPARK-23138][ML][DOC] Multiclass logistic regression su...

2018-01-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20332 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #17123: [SPARK-19781][ML] Handle NULLs as well as NaNs in...

2018-01-19 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/17123#discussion_r162703711 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Bucketizer.scala --- @@ -171,23 +176,23 @@ object Bucketizer extends

[GitHub] spark pull request #17123: [SPARK-19781][ML] Handle NULLs as well as NaNs in...

2018-01-19 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/17123#discussion_r162703633 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Bucketizer.scala --- @@ -105,20 +106,21 @@ final class Bucketizer @Since("1.4.0")

[GitHub] spark issue #20332: [SPARK-23138][ML][DOC] Multiclass summary example and us...

2018-01-19 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/20332 @jkbradley @MLnick --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20332: [SPARK-23138][ML][DOC] Multiclass summary example and us...

2018-01-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20332 **[Test build #86396 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86396/testReport)** for PR 20332 at commit

[GitHub] spark pull request #20332: [SPARK-23138][ML][DOC] Multiclass summary example...

2018-01-19 Thread sethah
GitHub user sethah opened a pull request: https://github.com/apache/spark/pull/20332 [SPARK-23138][ML][DOC] Multiclass summary example and user guide ## What changes were proposed in this pull request? User guide and examples are updated to reflect multiclass logistic

[GitHub] spark issue #18983: [SPARK-21771][SQL]remove useless hive client in SparkSQL...

2018-01-19 Thread liufengdb
Github user liufengdb commented on the issue: https://github.com/apache/spark/pull/18983 LGTM! It is only created once though. Frankly, we should completely remove the implementation of `newSession()` method. ---

[GitHub] spark issue #20091: [SPARK-22465][FOLLOWUP] Update the number of partitions ...

2018-01-19 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/20091 @mridulm Great write up! Yeah it's exactly that you described, and I've copied them to the PR description. --- - To

[GitHub] spark pull request #20025: [SPARK-22837][SQL]Session timeout checker does no...

2018-01-19 Thread liufengdb
Github user liufengdb commented on a diff in the pull request: https://github.com/apache/spark/pull/20025#discussion_r162698093 --- Diff: sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/session/SessionManager.java --- @@ -80,7 +76,6 @@ public synchronized void

[GitHub] spark issue #17894: [WIP][SPARK-17134][ML] Use level 2 BLAS operations in Lo...

2018-01-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17894 Build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #17894: [WIP][SPARK-17134][ML] Use level 2 BLAS operations in Lo...

2018-01-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17894 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/46/ Test

[GitHub] spark issue #20328: [SPARK-23000] [TEST] Keep Derby DB Location Unchanged Af...

2018-01-19 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/20328 An late LGTM! :) --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20185: Branch 2.3

2018-01-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20185 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20314: [SPARK-23104][K8S][Docs] Changes to Kubernetes sc...

2018-01-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20314 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20297: [SPARK-23020][CORE] Fix races in launcher code, test.

2018-01-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20297 **[Test build #86395 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86395/testReport)** for PR 20297 at commit

[GitHub] spark issue #20314: [SPARK-23104][K8S][Docs] Changes to Kubernetes scheduler...

2018-01-19 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/20314 Merging to master / 2.3. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20297: [SPARK-23020][CORE] Fix races in launcher code, test.

2018-01-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20297 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/45/ Test

[GitHub] spark issue #20297: [SPARK-23020][CORE] Fix races in launcher code, test.

2018-01-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20297 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20297: [SPARK-23020][CORE] Fix races in launcher code, test.

2018-01-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20297 **[Test build #4067 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4067/testReport)** for PR 20297 at commit

[GitHub] spark issue #20297: [SPARK-23020][CORE] Fix races in launcher code, test.

2018-01-19 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/20297 I kicked an extra couple of builds aside from the one that should auto-trigger. --- - To unsubscribe, e-mail:

[GitHub] spark issue #20297: [SPARK-23020][CORE] Fix races in launcher code, test.

2018-01-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20297 **[Test build #4066 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4066/testReport)** for PR 20297 at commit

[GitHub] spark pull request #20297: [SPARK-23020][CORE] Fix races in launcher code, t...

2018-01-19 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20297#discussion_r162694343 --- Diff: launcher/src/main/java/org/apache/spark/launcher/LauncherServer.java --- @@ -331,23 +358,27 @@ protected void handle(Message msg) throws

[GitHub] spark pull request #20297: [SPARK-23020][CORE] Fix races in launcher code, t...

2018-01-19 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20297#discussion_r162694174 --- Diff: launcher/src/main/java/org/apache/spark/launcher/LauncherServer.java --- @@ -331,23 +358,27 @@ protected void handle(Message msg) throws

[GitHub] spark pull request #20297: [SPARK-23020][CORE] Fix races in launcher code, t...

2018-01-19 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20297#discussion_r162693890 --- Diff: launcher/src/main/java/org/apache/spark/launcher/LauncherConnection.java --- @@ -95,15 +95,15 @@ protected synchronized void send(Message msg)

[GitHub] spark pull request #20297: [SPARK-23020][CORE] Fix races in launcher code, t...

2018-01-19 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20297#discussion_r162693731 --- Diff: launcher/src/main/java/org/apache/spark/launcher/ChildProcAppHandle.java --- @@ -48,14 +48,16 @@ public synchronized void disconnect() {

[GitHub] spark issue #19340: [SPARK-22119][ML] Add cosine distance to KMeans

2018-01-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19340 **[Test build #4065 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4065/testReport)** for PR 19340 at commit

[GitHub] spark issue #20330: [SPARK-23121][core] Fix for ui becoming unaccessible for...

2018-01-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20330 **[Test build #4063 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4063/testReport)** for PR 20330 at commit

[GitHub] spark issue #20324: [SPARK-23091][ML] Incorrect unit test for approxQuantile

2018-01-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20324 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86390/ Test PASSed. ---

[GitHub] spark issue #20324: [SPARK-23091][ML] Incorrect unit test for approxQuantile

2018-01-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20324 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20324: [SPARK-23091][ML] Incorrect unit test for approxQuantile

2018-01-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20324 **[Test build #86390 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86390/testReport)** for PR 20324 at commit

[GitHub] spark issue #20277: [SPARK-23090][SQL] polish ColumnVector

2018-01-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20277 **[Test build #86394 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86394/testReport)** for PR 20277 at commit

[GitHub] spark issue #20277: [SPARK-23090][SQL] polish ColumnVector

2018-01-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20277 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20277: [SPARK-23090][SQL] polish ColumnVector

2018-01-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20277 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/44/ Test

[GitHub] spark issue #20277: [SPARK-23090][SQL] polish ColumnVector

2018-01-19 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20277 retest this please, since the `ColumnarBatch` PR has been merged. --- - To unsubscribe, e-mail:

[GitHub] spark issue #20326: [SPARK-23155][DEPLOY] log.server.url links in SHS

2018-01-19 Thread gerashegalov
Github user gerashegalov commented on the issue: https://github.com/apache/spark/pull/20326 @vanzin do you mind considering this issue? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark pull request #20330: [SPARK-23121][core] Fix for ui becoming unaccessi...

2018-01-19 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20330#discussion_r162687023 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala --- @@ -65,10 +68,13 @@ private[ui] class AllJobsPage(parent: JobsTab, store:

[GitHub] spark pull request #20330: [SPARK-23121][core] Fix for ui becoming unaccessi...

2018-01-19 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20330#discussion_r162687347 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -18,7 +18,7 @@ package org.apache.spark.ui.jobs import

[GitHub] spark pull request #20330: [SPARK-23121][core] Fix for ui becoming unaccessi...

2018-01-19 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20330#discussion_r162687444 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -31,6 +31,7 @@ import org.apache.spark.SparkConf import

[GitHub] spark pull request #20330: [SPARK-23121][core] Fix for ui becoming unaccessi...

2018-01-19 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20330#discussion_r162687232 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/JobPage.scala --- @@ -336,8 +336,14 @@ private[ui] class JobPage(parent: JobsTab, store:

[GitHub] spark pull request #20330: [SPARK-23121][core] Fix for ui becoming unaccessi...

2018-01-19 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20330#discussion_r162687160 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala --- @@ -427,23 +435,21 @@ private[ui] class JobDataSource( val

[GitHub] spark issue #20330: [SPARK-23121][core] Fix for ui becoming unaccessible for...

2018-01-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20330 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20330: [SPARK-23121][core] Fix for ui becoming unaccessible for...

2018-01-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20330 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86389/ Test FAILed. ---

[GitHub] spark issue #20330: [SPARK-23121][core] Fix for ui becoming unaccessible for...

2018-01-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20330 **[Test build #86389 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86389/testReport)** for PR 20330 at commit

[GitHub] spark issue #20331: [SPARK-23158] [SQL] Move HadoopFsRelationTest test suite...

2018-01-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20331 **[Test build #86393 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86393/testReport)** for PR 20331 at commit

[GitHub] spark issue #20331: [SPARK-23158] [SQL] Move HadoopFsRelationTest test suite...

2018-01-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20331 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/43/ Test

[GitHub] spark issue #20331: [SPARK-23158] [SQL] Move HadoopFsRelationTest test suite...

2018-01-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20331 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20331: [SPARK-23158] [SQL] Move HadoopFsRelationTest test suite...

2018-01-19 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20331 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20331: [SPARK-23158] [SQL] Move HadoopFsRelationTest tes...

2018-01-19 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20331#discussion_r162683746 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcHadoopFsRelationSuite.scala --- @@ -82,44 +80,4 @@ class

[GitHub] spark pull request #20331: [SPARK-23158] [SQL] Move HadoopFsRelationTest tes...

2018-01-19 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20331#discussion_r162683705 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcHadoopFsRelationSuite.scala --- @@ -82,44 +80,4 @@ class

[GitHub] spark issue #20331: [SPARK-23158] [SQL] Move HadoopFsRelationTest test suite...

2018-01-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20331 **[Test build #86392 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86392/testReport)** for PR 20331 at commit

[GitHub] spark pull request #20331: [SPARK-23158] [SQL] Move HadoopFsRelationTest tes...

2018-01-19 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20331#discussion_r162683627 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcHadoopFsRelationSuite.scala --- @@ -82,44 +80,4 @@ class

[GitHub] spark issue #20331: [SPARK-23158] [SQL] Move HadoopFsRelationTest test suite...

2018-01-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20331 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/42/ Test

[GitHub] spark issue #20331: [SPARK-23158] [SQL] Move HadoopFsRelationTest test suite...

2018-01-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20331 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

<    1   2   3   4   >