Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20545
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20545
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20545
**[Test build #87246 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87246/testReport)**
for PR 20545 at commit
[`664a62c`](https://github.com/apache/spark/commit/66
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20387
> We've added a resolution rule from UnresolvedRelation to
DataSourceV2Relation that uses our implementation. UnresolvedRelation needs to
pass its TableIdentifier to the v2 relation, which is why
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20545
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/739/
Test
Github user heary-cao commented on the issue:
https://github.com/apache/spark/pull/20516
sure,
Operation environment: IDEA test tool.
test case: test("can bind to a specific port")
Test code:
val maxRetries = portMaxRetries(conf)
println("maxRetries:" + maxRetri
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20525
I think it's better to have the doc change in the same PR, then it's more
clear which patch caused the behavior change.
---
-
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20516
Can you try with SBT(using command line)? Usually we don't trust the test
result of IDE.
---
-
To unsubscribe, e-mail: reviews
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20477
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20477
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20477
**[Test build #87247 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87247/testReport)**
for PR 20477 at commit
[`0cc0600`](https://github.com/apache/spark/commit/0c
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20477
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/740/
Test
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20554
**[Test build #87238 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87238/testReport)**
for PR 20554 at commit
[`3ed2a50`](https://github.com/apache/spark/commit/3
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20554
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87238/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20554
Build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20554
**[Test build #87239 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87239/testReport)**
for PR 20554 at commit
[`05c9d20`](https://github.com/apache/spark/commit/0
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20554
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87239/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20554
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user ivoson commented on a diff in the pull request:
https://github.com/apache/spark/pull/20244#discussion_r167145734
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ---
@@ -2399,6 +2424,121 @@ class DAGSchedulerSuite extends SparkFunSuite wi
GitHub user rekhajoshm opened a pull request:
https://github.com/apache/spark/pull/20556
[SPARK-23367][Build] Include python document style checking
## What changes were proposed in this pull request?
Include python document style checking.
This PR includes the pydocstyle che
Github user squito commented on the issue:
https://github.com/apache/spark/pull/20532
I can see why you want this sometimes, but I'm trying to figure out if its
really valuable for users in general. You could always add a custom listener
to log this info. It would go into separate f
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20556
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20556
**[Test build #87248 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87248/testReport)**
for PR 20556 at commit
[`85ca69d`](https://github.com/apache/spark/commit/85
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20556
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/741/
Test
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20556
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87248/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20556
**[Test build #87248 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87248/testReport)**
for PR 20556 at commit
[`85ca69d`](https://github.com/apache/spark/commit/8
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20556
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20359
Thank you for merging, @cloud-fan .
And thank you again, @HyukjinKwon , @gatorsmile , and @srowen !
---
-
To unsubscrib
GitHub user guoxiaolongzte opened a pull request:
https://github.com/apache/spark/pull/20557
[SPARK-23364][SQL]'desc table' command in spark-sql add column head display
## What changes were proposed in this pull request?
Use 'desc partition_table' command in spark-sql clien
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20557
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20557
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20387#discussion_r167147910
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Relation.scala
---
@@ -17,17 +17,130 @@
package or
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20499
thanks, merging to master/2.3!
Can you send a new PR for 2.2? it conflicts...
---
-
To unsubscribe, e-mail: reviews-un
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20499
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user rekhajoshm commented on a diff in the pull request:
https://github.com/apache/spark/pull/20378#discussion_r167148657
--- Diff: dev/lint-python ---
@@ -83,6 +84,53 @@ else
rm "$PEP8_REPORT_PATH"
fi
+ Python Document Style Checks
+
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/20525
@cloud-fan Actually i had already created the doc pr in the morning using
the same JIRA number. Whenchen, if we want to have both the changes in the same
commit , will we be able to do it when w
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20556
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/742/
Test
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20556
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20556
**[Test build #87249 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87249/testReport)**
for PR 20556 at commit
[`ee14cf7`](https://github.com/apache/spark/commit/ee
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20525
no we can't merge 2 PRs together. Please pick one of your PRs and put all
the changes there, thanks!
---
-
To unsubscribe, e-m
Github user rekhajoshm commented on the issue:
https://github.com/apache/spark/pull/20378
@HyukjinKwon Identifying docstyle failures does not help much as it is not
straightforward to exclude in this version.
---
-
Github user rekhajoshm commented on the issue:
https://github.com/apache/spark/pull/20378
@HyukjinKwon @holdenk @ueshin @viirya @icexelloss @felixcheung @BryanCutler
and @MrBago - This was one of the possible approach that I was running by you.
I have proposed another approach at #205
Github user rekhajoshm closed the pull request at:
https://github.com/apache/spark/pull/20378
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/20525
@cloud-fan @gatorsmile Done.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-m
Github user advancedxy commented on the issue:
https://github.com/apache/spark/pull/20449
@jerryshao @cloud-fan I have updated my code. Do you have any other
concerns?
---
-
To unsubscribe, e-mail: reviews-unsubscr.
Github user dilipbiswal closed the pull request at:
https://github.com/apache/spark/pull/20551
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.or
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20537
LGTM too
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spa
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20525
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/743/
Test
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20525
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20525
**[Test build #87250 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87250/testReport)**
for PR 20525 at commit
[`30e5aa5`](https://github.com/apache/spark/commit/30
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20499
Yup, I should fix the guide for 2.2 anyway :-) Will open a backport tonight
KST.
---
-
To unsubscribe, e-mail: reviews-unsub
Github user rekhajoshm commented on the issue:
https://github.com/apache/spark/pull/20501
Ack. thanks for the update @felixcheung @srowen Closing this.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.o
Github user rekhajoshm closed the pull request at:
https://github.com/apache/spark/pull/20501
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20490
**[Test build #87244 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87244/testReport)**
for PR 20490 at commit
[`e9964ca`](https://github.com/apache/spark/commit/e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20490
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87244/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20490
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20477
**[Test build #87247 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87247/testReport)**
for PR 20477 at commit
[`0cc0600`](https://github.com/apache/spark/commit/0
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20477
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20477
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87247/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20555
**[Test build #87243 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87243/testReport)**
for PR 20555 at commit
[`b26ffce`](https://github.com/apache/spark/commit/b
Github user heary-cao commented on the issue:
https://github.com/apache/spark/pull/20516
I try with mavn(using command line) to test case , it is right. thanks.
Then, whether we add System.setProperty("spark.testing", "true") in
SparkFunSuite to slove the IDE test tool problem. Be
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20555
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87243/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20555
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20516#discussion_r167156814
--- Diff: core/src/test/scala/org/apache/spark/SparkFunSuite.scala ---
@@ -59,6 +59,7 @@ abstract class SparkFunSuite
protected val enableAutoThread
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20525#discussion_r167158260
--- Diff: docs/sql-programming-guide.md ---
@@ -1930,6 +1930,9 @@ working with timestamps in `pandas_udf`s to get the
best performance, see
- Lit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20525#discussion_r167158389
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileFormatWriterSuite.scala
---
@@ -19,6 +19,7 @@ package org.apache.spark.s
Github user heary-cao commented on a diff in the pull request:
https://github.com/apache/spark/pull/20516#discussion_r167158512
--- Diff: core/src/test/scala/org/apache/spark/SparkFunSuite.scala ---
@@ -59,6 +59,7 @@ abstract class SparkFunSuite
protected val enableAutoThread
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20525#discussion_r167158557
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/test/DataFrameReaderWriterSuite.scala
---
@@ -301,7 +301,6 @@ class DataFrameReaderWriterSuite ext
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/20525
@tdas @brkyvz Do we still need the fix for 0-partition DataFrame in
Structured Streaming after this change?
---
-
To unsubscribe
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20449#discussion_r167158719
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/BlockStoreShuffleReader.scala ---
@@ -104,9 +104,16 @@ private[spark] class BlockStoreShuffleReader
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20516#discussion_r167159549
--- Diff: core/src/test/scala/org/apache/spark/SparkFunSuite.scala ---
@@ -59,6 +59,7 @@ abstract class SparkFunSuite
protected val enableAutoThread
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/20525#discussion_r167159534
--- Diff: docs/sql-programming-guide.md ---
@@ -1930,6 +1930,9 @@ working with timestamps in `pandas_udf`s to get the
best performance, see
- L
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20525#discussion_r167159659
--- Diff: docs/sql-programming-guide.md ---
@@ -1930,6 +1930,9 @@ working with timestamps in `pandas_udf`s to get the
best performance, see
- Lit
501 - 573 of 573 matches
Mail list logo