[GitHub] spark pull request #20878: [MINOR][PYTHON] Remove unused codes in schema par...

2018-03-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20878 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20831: [SPARK-23614][SQL] Fix incorrect reuse exchange when cac...

2018-03-22 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20831 thanks, merging to master/2.3! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-ma

[GitHub] spark pull request #20851: [SPARK-23727][SQL] Support for pushing down filte...

2018-03-22 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20851#discussion_r176636849 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -353,6 +353,13 @@ object SQLConf { .booleanConf

[GitHub] spark pull request #20831: [SPARK-23614][SQL] Fix incorrect reuse exchange w...

2018-03-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20831 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20861: [SPARK-23599][SQL] Use RandomUUIDGenerator in Uuid expre...

2018-03-22 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20861 @hvanhovell Ok. But this needs #20817. Since #20817 just adds new class and doesn't change existing code, I think it can be directly merged into 2.3. Should I create a backport PR of it too? Or you c

[GitHub] spark issue #20831: [SPARK-23614][SQL] Fix incorrect reuse exchange when cac...

2018-03-22 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20831 Thanks! @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h..

[GitHub] spark issue #19840: [SPARK-22640][PYSPARK][YARN]switch python exec on execut...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19840 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1718/ Tes

[GitHub] spark issue #19840: [SPARK-22640][PYSPARK][YARN]switch python exec on execut...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19840 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20633: [SPARK-23455][ML] Default Params in ML should be saved s...

2018-03-22 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20633 @jkbradley Thanks for your comments! I've addressed them. Please review it again. Thank you. --- - To unsubscribe, e-mail: review

[GitHub] spark issue #20888: [SPARK-23775][TEST] DataFrameRangeSuite should wait for ...

2018-03-22 Thread gaborgsomogyi
Github user gaborgsomogyi commented on the issue: https://github.com/apache/spark/pull/20888 I mean on my machine the stage ID is zero for long long time here: ``` DataFrameRangeSuite.stageToKill = TaskContext.get().stageId() ``` and after 200 seconds the other t

[GitHub] spark issue #20888: [SPARK-23775][TEST] DataFrameRangeSuite should wait for ...

2018-03-22 Thread gaborgsomogyi
Github user gaborgsomogyi commented on the issue: https://github.com/apache/spark/pull/20888 Uploaded logs for the jira. You're right when you pointed out a second issue with the `stageToKill`. The `onJobStart` tries to cancel the same ID twice. ---

[GitHub] spark issue #20887: [SPARK-23774][SQL] `Cast` to CHAR/VARCHAR should truncat...

2018-03-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20887 **[Test build #88535 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88535/testReport)** for PR 20887 at commit [`c6d12e8`](https://github.com/apache/spark/commit/c

[GitHub] spark issue #20887: [SPARK-23774][SQL] `Cast` to CHAR/VARCHAR should truncat...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20887 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88535/ Test PASSed. ---

[GitHub] spark issue #20887: [SPARK-23774][SQL] `Cast` to CHAR/VARCHAR should truncat...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20887 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20657: [SPARK-23361][yarn] Allow AM to restart after initial to...

2018-03-22 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/20657 Thanks, merging to master branch! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark pull request #20889: [MINOR][DOC] Fix ml-guide markdown typos

2018-03-22 Thread Lemonjing
GitHub user Lemonjing opened a pull request: https://github.com/apache/spark/pull/20889 [MINOR][DOC] Fix ml-guide markdown typos ## What changes were proposed in this pull request? Easy fix in the markdown. ## How was this patch tested? Tested manually

[GitHub] spark issue #20889: [MINOR][DOC] Fix ml-guide markdown typos

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20889 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20889: [MINOR][DOC] Fix ml-guide markdown typos

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20889 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20657: [SPARK-23361][yarn] Allow AM to restart after ini...

2018-03-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20657 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20879: [MINOR][R] Fix R lint failure

2018-03-22 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20879 thanks! those are on me then. are we not running lintr? or these checks are on the newer version only? --- - To unsubscr

[GitHub] spark issue #20888: [SPARK-23775][TEST] DataFrameRangeSuite should wait for ...

2018-03-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20888 **[Test build #88536 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88536/testReport)** for PR 20888 at commit [`42c930d`](https://github.com/apache/spark/commit/4

[GitHub] spark issue #20888: [SPARK-23775][TEST] DataFrameRangeSuite should wait for ...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20888 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20888: [SPARK-23775][TEST] DataFrameRangeSuite should wait for ...

2018-03-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20888 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88536/ Test PASSed. ---

[GitHub] spark pull request #20873: [SPARK-22744][CORE] Cannot get the submit hostnam...

2018-03-22 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/20873#discussion_r176646160 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -776,6 +776,9 @@ object SparkSubmit extends CommandLineUtils with Logging {

[GitHub] spark pull request #20860: [SPARK-23743][SQL] Changed a comparison logic fro...

2018-03-22 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/20860#discussion_r176646535 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/IsolatedClientLoader.scala --- @@ -179,7 +179,7 @@ private[hive] class IsolatedClien

[GitHub] spark issue #20864: [SPARK-23745][SQL]Remove the directories of the “hive....

2018-03-22 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20864 Jenkins, ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: revie

[GitHub] spark issue #20889: [MINOR][DOC] Fix ml-guide markdown typos

2018-03-22 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20889 can you check if we have other typo in the md file? or similar type of typo in other md files? --- - To unsubscribe, e-ma

[GitHub] spark pull request #20873: [SPARK-22744][CORE] Cannot get the submit hostnam...

2018-03-22 Thread LantaoJin
Github user LantaoJin commented on a diff in the pull request: https://github.com/apache/spark/pull/20873#discussion_r176647022 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -776,6 +776,9 @@ object SparkSubmit extends CommandLineUtils with Logging {

[GitHub] spark issue #20864: [SPARK-23745][SQL]Remove the directories of the “hive....

2018-03-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20864 **[Test build #88537 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88537/testReport)** for PR 20864 at commit [`b177bf4`](https://github.com/apache/spark/commit/b1

[GitHub] spark pull request #20873: [SPARK-22744][CORE] Cannot get the submit hostnam...

2018-03-22 Thread LantaoJin
Github user LantaoJin commented on a diff in the pull request: https://github.com/apache/spark/pull/20873#discussion_r176647523 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -776,6 +776,9 @@ object SparkSubmit extends CommandLineUtils with Logging {

[GitHub] spark pull request #20873: [SPARK-22744][CORE] Cannot get the submit hostnam...

2018-03-22 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/20873#discussion_r176647902 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -776,6 +776,9 @@ object SparkSubmit extends CommandLineUtils with Logging {

[GitHub] spark issue #20889: [MINOR][DOC] Fix ml-guide markdown typos

2018-03-22 Thread Lemonjing
Github user Lemonjing commented on the issue: https://github.com/apache/spark/pull/20889 @felixcheung Yes, I read the entire docs of Spark Mlib. There is no problem with other mds (I may not have seen it or other contributors solved it). This error is obvious, and it affects the link

[GitHub] spark pull request #20873: [SPARK-22744][CORE] Cannot get the submit hostnam...

2018-03-22 Thread LantaoJin
Github user LantaoJin closed the pull request at: https://github.com/apache/spark/pull/20873 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20873: [SPARK-22744][CORE] Cannot get the submit hostname of ap...

2018-03-22 Thread LantaoJin
Github user LantaoJin commented on the issue: https://github.com/apache/spark/pull/20873 Close it while found a work around way. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20771: [SPARK-23587][SQL] Add interpreted execution for MapObje...

2018-03-22 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20771 ping @hvanhovell --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...

<    1   2   3   4