Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20937#discussion_r178478627
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -2127,4 +2127,243 @@ class JsonSuite extends
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20937#discussion_r178475983
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/CreateJacksonParser.scala
---
@@ -39,11 +40,36 @@ private[sql] object
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20937#discussion_r178476459
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -361,6 +361,15 @@ class JacksonParser(
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20937#discussion_r178478647
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -2127,4 +2127,243 @@ class JsonSuite extends
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20937#discussion_r178478996
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -2127,4 +2127,243 @@ class JsonSuite extends
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20937#discussion_r178478271
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonDataSource.scala
---
@@ -175,33 +185,43 @@ object
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20937#discussion_r178475654
--- Diff: python/pyspark/sql/readwriter.py ---
@@ -237,6 +237,8 @@ def json(self, path, schema=None,
primitivesAsString=None, prefersDecimal=None,
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20937#discussion_r178477311
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala
---
@@ -107,4 +126,9 @@ private[sql] class JSONOptions(
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20937#discussion_r178476391
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala
---
@@ -86,14 +85,34 @@ private[sql] class JSONOptions(
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20937#discussion_r178478616
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -2127,4 +2127,243 @@ class JsonSuite extends
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1893/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20850
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20850
**[Test build #88801 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88801/testReport)**
for PR 20850 at commit
Github user Lemonjing commented on the issue:
https://github.com/apache/spark/pull/20897
see http://spark.apache.org/docs/latest/ml-features.html#elementwiseproduct
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20697
Kubernetes integration test status success
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/1867/
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20956
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88805/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20956
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20956
**[Test build #88805 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88805/testReport)**
for PR 20956 at commit
Github user Lemonjing commented on a diff in the pull request:
https://github.com/apache/spark/pull/20897#discussion_r178481268
--- Diff: docs/mllib-pmml-model-export.md ---
@@ -7,15 +7,15 @@ displayTitle: PMML model export - RDD-based API
* Table of contents
{:toc}
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20897
**[Test build #88802 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88802/testReport)**
for PR 20897 at commit
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20897#discussion_r178481415
--- Diff: docs/mllib-pmml-model-export.md ---
@@ -7,15 +7,15 @@ displayTitle: PMML model export - RDD-based API
* Table of contents
{:toc}
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20937
@cloud-fan and @gatorsmile, just for doubly sure, you guys are at least
positive on this feature itself, right?
---
-
To
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20897
**[Test build #88803 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88803/testReport)**
for PR 20897 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20897
**[Test build #88802 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88802/testReport)**
for PR 20897 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20897
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20897
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88802/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20897
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88803/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20897
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20897
**[Test build #88803 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88803/testReport)**
for PR 20897 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20897
**[Test build #88804 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88804/testReport)**
for PR 20897 at commit
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20916#discussion_r178483438
--- Diff:
core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala ---
@@ -106,6 +106,9 @@ class SparkSubmitSuite
// Necessary to make
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20897
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88804/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20897
**[Test build #88804 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88804/testReport)**
for PR 20897 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20897
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20897
@felixcheung, does this look good to you too?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
GitHub user zhengruifeng opened a pull request:
https://github.com/apache/spark/pull/20956
[SPARK-23841][ML] NodeIdCache should unpersist the last cached
nodeIdsForInstances
## What changes were proposed in this pull request?
unpersist the last cached nodeIdsForInstances in
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20956
**[Test build #88805 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88805/testReport)**
for PR 20956 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20956
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20956
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1894/
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20345
ping
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20850#discussion_r178469520
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/GenerateColumnAccessor.scala
---
@@ -212,11 +210,11 @@ object
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20886#discussion_r178470268
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -298,15 +302,28 @@ class SessionCatalog(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20886#discussion_r178470264
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -298,15 +302,28 @@ class SessionCatalog(
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20886
This is a behavior change, we need to make it configurable and also
document it in the migration guide.
---
-
To
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20697
**[Test build #88798 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88798/testReport)**
for PR 20697 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20697
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20697
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88798/
Test PASSed.
---
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20930#discussion_r178470893
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -794,6 +794,19 @@ private[spark] class TaskSetManager(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20795#discussion_r178471847
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -1072,8 +1072,17 @@ class SessionCatalog(
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20886
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20886
**[Test build #88799 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88799/testReport)**
for PR 20886 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20886#discussion_r178470143
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -103,6 +103,60 @@ class InMemoryCatalogedDDLSuite
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20850#discussion_r178470952
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/UnsafeArrayWriter.java
---
@@ -32,141 +30,123 @@
*/
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20795#discussion_r178471806
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -1072,8 +1072,17 @@ class SessionCatalog(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20795#discussion_r178471822
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -1072,8 +1072,17 @@ class SessionCatalog(
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/20886#discussion_r178472405
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -298,15 +302,28 @@ class SessionCatalog(
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20886
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1892/
101 - 157 of 157 matches
Mail list logo
