[GitHub] spark pull request #21302: [SPARK-23852][SQL] Upgrade to Parquet 1.8.3

2018-05-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21302#discussion_r187762385 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala --- @@ -602,6 +602,16 @@ class

[GitHub] spark issue #21309: [SPARK-23907] Removes regr_* functions in functions.scal...

2018-05-11 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/21309 Better compile time error. Plus a lot of people are already using these. On Fri, May 11, 2018 at 7:35 PM Hyukjin Kwon wrote: > Yup, then why not just

[GitHub] spark pull request #21246: [SPARK-23901][SQL] Add masking functions

2018-05-11 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/21246#discussion_r187759378 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/maskExpressions.scala --- @@ -0,0 +1,569 @@ +/* + * Licensed to the

[GitHub] spark issue #21301: [SPARK-24228][SQL] Fix Java lint errors

2018-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21301 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21306: [SPARK-24252][SQL] Add DataSourceV2 mix-in for catalog s...

2018-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21306 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21306: [SPARK-24252][SQL] Add DataSourceV2 mix-in for catalog s...

2018-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21306 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90532/ Test PASSed. ---

[GitHub] spark issue #21301: [SPARK-24228][SQL] Fix Java lint errors

2018-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21301 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3165/

[GitHub] spark issue #21302: [SPARK-23852][SQL] Upgrade to Parquet 1.8.3

2018-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21302 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90536/ Test FAILed. ---

[GitHub] spark issue #21302: [SPARK-23852][SQL] Upgrade to Parquet 1.8.3

2018-05-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21302 **[Test build #90536 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90536/testReport)** for PR 21302 at commit

[GitHub] spark issue #21302: [SPARK-23852][SQL] Upgrade to Parquet 1.8.3

2018-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21302 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21309: [SPARK-23907] Removes regr_* functions in functions.scal...

2018-05-11 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21309 Thing is, I am a bit confused when to add it to other APIs. I thought if it's expected to be less commonly used, it shouldn't be added at the first place. We have UDFs. I have been a

[GitHub] spark issue #21309: [SPARK-23907] Removes regr_* functions in functions.scal...

2018-05-11 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21309 I am asking this to use the same judgement for when to add it. --- - To unsubscribe, e-mail:

[GitHub] spark pull request #21296: [SPARK-24244][SQL] Passing only required columns ...

2018-05-11 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21296#discussion_r187762615 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/UnivocityParser.scala --- @@ -73,11 +64,24 @@ class UnivocityParser(

[GitHub] spark issue #21309: [SPARK-23907] Removes regr_* functions in functions.scal...

2018-05-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21309 **[Test build #90537 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90537/testReport)** for PR 21309 at commit

[GitHub] spark issue #21309: [SPARK-23907] Removes regr_* functions in functions.scal...

2018-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21309 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90537/ Test PASSed. ---

[GitHub] spark issue #21309: [SPARK-23907] Removes regr_* functions in functions.scal...

2018-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21309 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21309: [SPARK-23907] Removes regr_* functions in functions.scal...

2018-05-11 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21309 Just had a short talk with Reynold. LGTM too. thanks for bearing with me. --- - To unsubscribe, e-mail:

[GitHub] spark issue #21301: [SPARK-24228][SQL] Fix Java lint errors

2018-05-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21301 **[Test build #90538 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90538/testReport)** for PR 21301 at commit

[GitHub] spark issue #21305: [SPARK-24251][SQL] Add AppendData logical plan.

2018-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21305 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90535/ Test PASSed. ---

[GitHub] spark issue #21305: [SPARK-24251][SQL] Add AppendData logical plan.

2018-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21305 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21305: [SPARK-24251][SQL] Add AppendData logical plan.

2018-05-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21305 **[Test build #90535 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90535/testReport)** for PR 21305 at commit

[GitHub] spark pull request #21288: [SPARK-24206][SQL] Improve FilterPushdownBenchmar...

2018-05-11 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/21288#discussion_r187764083 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/FilterPushdownBenchmark.scala --- @@ -32,14 +32,14 @@ import org.apache.spark.util.{Benchmark,

[GitHub] spark issue #21301: [SPARK-24228][SQL] Fix Java lint errors

2018-05-11 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/21301 @dongjoon-hyun thanks, done --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21306: [SPARK-24252][SQL] Add DataSourceV2 mix-in for catalog s...

2018-05-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21306 **[Test build #90532 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90532/testReport)** for PR 21306 at commit

[GitHub] spark issue #21309: [SPARK-23907] Removes regr_* functions in functions.scal...

2018-05-11 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21309 Yup, then why not just deprecate other functions in other APIs for 3.0.0, and promote the usage of expr? --- - To

[GitHub] spark issue #21304: Fix typo in UDF type match error message

2018-05-11 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21304 It's okay but mind quickly checking other typos around this place while we are here? --- - To unsubscribe, e-mail:

[GitHub] spark pull request #21298: [SPARK-24198][SparkR][SQL] Adding slice function ...

2018-05-11 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/21298#discussion_r187763906 --- Diff: R/pkg/R/functions.R --- @@ -3138,6 +3139,23 @@ setMethod("size", column(jc) }) +#' @details +#'

[GitHub] spark issue #21301: [SPARK-24228][SQL] Fix Java lint errors

2018-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21301 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90538/ Test PASSed. ---

[GitHub] spark issue #21301: [SPARK-24228][SQL] Fix Java lint errors

2018-05-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21301 **[Test build #90538 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90538/testReport)** for PR 21301 at commit

[GitHub] spark issue #21301: [SPARK-24228][SQL] Fix Java lint errors

2018-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21301 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21309: [SPARK-23907] Removes regr_* functions in functions.scal...

2018-05-11 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21309 Merged to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #21309: [SPARK-23907] Removes regr_* functions in functio...

2018-05-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21309 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21298: [SPARK-24198][SparkR][SQL] Adding slice function to Spar...

2018-05-11 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21298 lgtm too except that the nit. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #21309: [SPARK-23907] Removes regr_* functions in functions.scal...

2018-05-11 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21309 @rxin, how about splitting up this file by the group or something, or deprecating all the functions that can be called via expr for 3.0.0? To me, it looked a bit odd when some functions exist

[GitHub] spark issue #21296: [SPARK-24244][SQL] Passing only required columns to the ...

2018-05-11 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21296 Can we update the migration guide then? I want to see if the note makes sense. --- - To unsubscribe, e-mail:

[GitHub] spark issue #21308: SPARK-24253: Add DeleteSupport mix-in for DataSourceV2.

2018-05-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21308 **[Test build #90534 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90534/testReport)** for PR 21308 at commit

[GitHub] spark issue #21308: SPARK-24253: Add DeleteSupport mix-in for DataSourceV2.

2018-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21308 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90534/ Test PASSed. ---

[GitHub] spark issue #21309: [SPARK-23907] Removes regr_* functions in functions.scal...

2018-05-11 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/21309 Adding it to sql would allow it to be available everywhere (through expr) right? On Fri, May 11, 2018 at 7:30 PM Hyukjin Kwon wrote: > Thing is, I am

[GitHub] spark pull request #21054: [SPARK-23907][SQL] Add regr_* functions

2018-05-11 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21054#discussion_r187761743 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -775,6 +775,178 @@ object functions { */ def

[GitHub] spark issue #21308: SPARK-24253: Add DeleteSupport mix-in for DataSourceV2.

2018-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21308 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

2018-05-11 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/21054 There is not a single function that can’t be called by expr. It mainly adds some type safety. On Fri, May 11, 2018 at 7:18 PM Hyukjin Kwon wrote:

[GitHub] spark issue #21309: [SPARK-23907] Removes regr_* functions in functions.scal...

2018-05-11 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/21309 Btw it’s been always the case that the less commonly used functions are not part of this file. There is just a lot of overhead to maintaining all of them. I’m not even sure if the

[GitHub] spark pull request #21309: [SPARK-23907] Removes regr_* functions in functio...

2018-05-11 Thread rxin
GitHub user rxin opened a pull request: https://github.com/apache/spark/pull/21309 [SPARK-23907] Removes regr_* functions in functions.scala ## What changes were proposed in this pull request? This patch removes the various regr_* functions in functions.scala. They are so

[GitHub] spark issue #21309: [SPARK-23907] Removes regr_* functions in functions.scal...

2018-05-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21309 **[Test build #90537 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90537/testReport)** for PR 21309 at commit

[GitHub] spark issue #21309: [SPARK-23907] Removes regr_* functions in functions.scal...

2018-05-11 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/21309 cc @gatorsmile @mgaido91 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21276: [SPARK-24216][SQL] Spark TypedAggregateExpression uses g...

2018-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21276 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90525/ Test PASSed. ---

[GitHub] spark issue #21276: [SPARK-24216][SQL] Spark TypedAggregateExpression uses g...

2018-05-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21276 **[Test build #90525 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90525/testReport)** for PR 21276 at commit

[GitHub] spark issue #21276: [SPARK-24216][SQL] Spark TypedAggregateExpression uses g...

2018-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21276 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21309: [SPARK-23907] Removes regr_* functions in functions.scal...

2018-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21309 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21309: [SPARK-23907] Removes regr_* functions in functions.scal...

2018-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21309 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3164/

[GitHub] spark issue #21278: [SPARKR] Require Java 8 for SparkR

2018-05-11 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/21278 Merging this to master and branch-2.3 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21302: [SPARK-23852][SQL] Upgrade to Parquet 1.8.3

2018-05-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21302 **[Test build #90527 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90527/testReport)** for PR 21302 at commit

[GitHub] spark issue #21302: [SPARK-23852][SQL] Upgrade to Parquet 1.8.3

2018-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21302 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21302: [SPARK-23852][SQL] Upgrade to Parquet 1.8.3

2018-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21302 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90527/ Test PASSed. ---

[GitHub] spark issue #21301: [SPARK-24228][SQL] Fix Java lint errors

2018-05-11 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/21301 @kiszk . Could you run for all? ``` ~/PR-21301:PR-21301$ dev/lint-java exec: curl --progress-bar -L https://downloads.typesafe.com/zinc/0.3.15/zinc-0.3.15.tgz

[GitHub] spark pull request #21278: [SPARKR] Require Java 8 for SparkR

2018-05-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21278 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21303: [BUILD] Close stale PRs

2018-05-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21303 **[Test build #90526 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90526/testReport)** for PR 21303 at commit

[GitHub] spark issue #21303: [BUILD] Close stale PRs

2018-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21303 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21303: [BUILD] Close stale PRs

2018-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21303 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90526/ Test PASSed. ---

[GitHub] spark issue #21291: [SPARK-24242][SQL] RangeExec should have correct outputO...

2018-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21291 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21291: [SPARK-24242][SQL] RangeExec should have correct outputO...

2018-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21291 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3129/

[GitHub] spark issue #21291: [SPARK-24242][SQL] RangeExec should have correct outputO...

2018-05-11 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/21291 retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #21276: [SPARK-24216][SQL] Spark TypedAggregateExpression...

2018-05-11 Thread fangshil
Github user fangshil commented on a diff in the pull request: https://github.com/apache/spark/pull/21276#discussion_r187540911 --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala --- @@ -2715,6 +2715,66 @@ private[spark] object Utils extends Logging {

[GitHub] spark issue #21291: [SPARK-24242][SQL] RangeExec should have correct outputO...

2018-05-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21291 **[Test build #90499 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90499/testReport)** for PR 21291 at commit

[GitHub] spark pull request #21291: [SPARK-24242][SQL] RangeExec should have correct ...

2018-05-11 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21291#discussion_r187529583 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -2767,7 +2767,12 @@ class Dataset[T] private[sql]( * @since 1.6.0

[GitHub] spark issue #21118: SPARK-23325: Use InternalRow when reading with DataSourc...

2018-05-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21118 **[Test build #90494 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90494/testReport)** for PR 21118 at commit

[GitHub] spark issue #21291: [SPARK-24242][SQL] RangeExec should have correct outputO...

2018-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21291 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90496/ Test FAILed. ---

[GitHub] spark issue #21291: [SPARK-24242][SQL] RangeExec should have correct outputO...

2018-05-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21291 **[Test build #90495 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90495/testReport)** for PR 21291 at commit

[GitHub] spark issue #21118: SPARK-23325: Use InternalRow when reading with DataSourc...

2018-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21118 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90494/ Test FAILed. ---

[GitHub] spark issue #21291: [SPARK-24242][SQL] RangeExec should have correct outputO...

2018-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21291 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21255: [SPARK-24186][R][SQL]change reverse and concat to collec...

2018-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21255 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90493/ Test FAILed. ---

[GitHub] spark issue #21291: [SPARK-24242][SQL] RangeExec should have correct outputO...

2018-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21291 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21255: [SPARK-24186][R][SQL]change reverse and concat to collec...

2018-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21255 Build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #21255: [SPARK-24186][R][SQL]change reverse and concat to collec...

2018-05-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21255 **[Test build #90493 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90493/testReport)** for PR 21255 at commit

[GitHub] spark issue #21291: [SPARK-24242][SQL] RangeExec should have correct outputO...

2018-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21291 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90495/ Test FAILed. ---

[GitHub] spark issue #21129: [SPARK-7132][ML] Add fit with validation set to spark.ml...

2018-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21129 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21129: [SPARK-7132][ML] Add fit with validation set to spark.ml...

2018-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21129 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90492/ Test FAILed. ---

[GitHub] spark issue #21291: [SPARK-24242][SQL] RangeExec should have correct outputO...

2018-05-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21291 **[Test build #90496 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90496/testReport)** for PR 21291 at commit

[GitHub] spark issue #21118: SPARK-23325: Use InternalRow when reading with DataSourc...

2018-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21118 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21129: [SPARK-7132][ML] Add fit with validation set to spark.ml...

2018-05-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21129 **[Test build #90492 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90492/testReport)** for PR 21129 at commit

[GitHub] spark issue #21286: [SPARK-24238][SQL] HadoopFsRelation can't append the sam...

2018-05-11 Thread zheh12
Github user zheh12 commented on the issue: https://github.com/apache/spark/pull/21286 I think the Hadoop design does not allow two jobs to share the same output folder. Hadoop has a related patch that can partially solve this problem. You can configure the parameters to not

[GitHub] spark issue #21291: [SPARK-24242][SQL] RangeExec should have correct outputO...

2018-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21291 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21291: [SPARK-24242][SQL] RangeExec should have correct outputO...

2018-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21291 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3130/

[GitHub] spark issue #21276: [SPARK-24216][SQL] Spark TypedAggregateExpression uses g...

2018-05-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21276 **[Test build #90498 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90498/testReport)** for PR 21276 at commit

[GitHub] spark issue #21276: [SPARK-24216][SQL] Spark TypedAggregateExpression uses g...

2018-05-11 Thread fangshil
Github user fangshil commented on the issue: https://github.com/apache/spark/pull/21276 made a few changes: since getSimpleName is a method of Class, it makes sense for Utils.getSimpleName to takes a Class param Utils.getSimpleName will try to use the Class's getSimpleName

[GitHub] spark issue #21291: [SPARK-24242][SQL] RangeExec should have correct outputO...

2018-05-11 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/21291 retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21243: [SPARK-24182][yarn] Improve error message when client AM...

2018-05-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21243 **[Test build #90501 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90501/testReport)** for PR 21243 at commit

[GitHub] spark issue #21129: [SPARK-7132][ML] Add fit with validation set to spark.ml...

2018-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21129 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3133/

[GitHub] spark pull request #21291: [SPARK-24242][SQL] RangeExec should have correct ...

2018-05-11 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/21291#discussion_r187565401 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -2767,7 +2767,12 @@ class Dataset[T] private[sql]( * @since 1.6.0

[GitHub] spark issue #21291: [SPARK-24242][SQL] RangeExec should have correct outputO...

2018-05-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21291 **[Test build #90499 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90499/testReport)** for PR 21291 at commit

[GitHub] spark issue #21293: [SPARK-24237][SS] Continuous shuffle dependency and map ...

2018-05-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21293 **[Test build #90505 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90505/testReport)** for PR 21293 at commit

[GitHub] spark pull request #21106: [SPARK-23711][SQL][WIP] Add fallback logic for Un...

2018-05-11 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21106#discussion_r187528270 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/InterpretedUnsafeProjection.scala --- @@ -87,12 +87,11 @@ class

[GitHub] spark pull request #21276: [SPARK-24216][SQL] Spark TypedAggregateExpression...

2018-05-11 Thread fangshil
Github user fangshil commented on a diff in the pull request: https://github.com/apache/spark/pull/21276#discussion_r187540472 --- Diff: core/src/test/scala/org/apache/spark/util/UtilsSuite.scala --- @@ -1168,6 +1168,35 @@ class UtilsSuite extends SparkFunSuite with

[GitHub] spark pull request #21276: [SPARK-24216][SQL] Spark TypedAggregateExpression...

2018-05-11 Thread fangshil
Github user fangshil commented on a diff in the pull request: https://github.com/apache/spark/pull/21276#discussion_r187540452 --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala --- @@ -2715,6 +2715,66 @@ private[spark] object Utils extends Logging {

[GitHub] spark issue #21291: [SPARK-24242][SQL] RangeExec should have correct outputO...

2018-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21291 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21291: [SPARK-24242][SQL] RangeExec should have correct outputO...

2018-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21291 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3131/

[GitHub] spark issue #21216: [SPARK-24149][YARN] Retrieve all federated namespaces to...

2018-05-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21216 **[Test build #90504 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90504/testReport)** for PR 21216 at commit

[GitHub] spark issue #21216: [SPARK-24149][YARN] Retrieve all federated namespaces to...

2018-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21216 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21216: [SPARK-24149][YARN] Retrieve all federated namespaces to...

2018-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21216 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90504/ Test PASSed. ---

[GitHub] spark pull request #21293: [SPARK-24237][SS] Continuous shuffle dependency a...

2018-05-11 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/21293#discussion_r187598365 --- Diff: core/src/main/scala/org/apache/spark/SparkEnv.scala --- @@ -227,6 +228,7 @@ object SparkEnv extends Logging {

  1   2   3   4   5   >