[GitHub] spark issue #21023: [SPARK-23949] makes && supports the function of predicat...

2018-07-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21023 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #18544: [SPARK-21318][SQL]Improve exception message throw...

2018-07-11 Thread stanzhai
Github user stanzhai commented on a diff in the pull request: https://github.com/apache/spark/pull/18544#discussion_r201579348 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala --- @@ -129,14 +129,14 @@ private[sql] class HiveSessionCatalog(

[GitHub] spark issue #18544: [SPARK-21318][SQL]Improve exception message thrown by `l...

2018-07-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18544 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92840/ Test FAILed. ---

[GitHub] spark issue #21657: [SPARK-24676][SQL] Project required data from CSV parsed...

2018-07-11 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21657 Please let me do one pass within few days. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20057: [SPARK-22880][SQL] Add cascadeTruncate option to JDBC da...

2018-07-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20057 **[Test build #92841 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92841/testReport)** for PR 20057 at commit

[GitHub] spark issue #20057: [SPARK-22880][SQL] Add cascadeTruncate option to JDBC da...

2018-07-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20057 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #18544: [SPARK-21318][SQL]Improve exception message thrown by `l...

2018-07-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18544 **[Test build #92840 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92840/testReport)** for PR 18544 at commit

[GitHub] spark issue #21744: [SPARK-24697][SS] Fix the reported start offsets in stre...

2018-07-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21744 **[Test build #92838 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92838/testReport)** for PR 21744 at commit

[GitHub] spark issue #20057: [SPARK-22880][SQL] Add cascadeTruncate option to JDBC da...

2018-07-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20057 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92841/ Test FAILed. ---

[GitHub] spark issue #21469: [SPARK-24441][SS] Expose total estimated size of states ...

2018-07-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21469 **[Test build #92839 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92839/testReport)** for PR 21469 at commit

[GitHub] spark issue #21469: [SPARK-24441][SS] Expose total estimated size of states ...

2018-07-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21469 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92839/ Test FAILed. ---

[GitHub] spark issue #21469: [SPARK-24441][SS] Expose total estimated size of states ...

2018-07-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21469 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21556: [SPARK-24549][SQL] Support Decimal type push down to the...

2018-07-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21556 **[Test build #92837 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92837/testReport)** for PR 21556 at commit

[GitHub] spark issue #18544: [SPARK-21318][SQL]Improve exception message thrown by `l...

2018-07-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18544 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21608: [SPARK-24626] [SQL] Improve location size calculation in...

2018-07-11 Thread Achuth17
Github user Achuth17 commented on the issue: https://github.com/apache/spark/pull/21608 @maropu regarding tests, since I didn't make any changes to `inMemoryFileIndex` isn't it better if I added tests in StatisticsCollectionSuite/StatisticsSuite? Also, since we just

[GitHub] spark pull request #21645: [SPARK-24537][R]Add array_remove / array_zip / ma...

2018-07-11 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/21645#discussion_r201574700 --- Diff: R/pkg/R/functions.R --- @@ -3120,6 +3147,24 @@ setMethod("arrays_overlap", column(jc) }) +#'

[GitHub] spark pull request #21645: [SPARK-24537][R]Add array_remove / array_zip / ma...

2018-07-11 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/21645#discussion_r201574780 --- Diff: R/pkg/R/functions.R --- @@ -3071,6 +3085,19 @@ setMethod("array_position", column(jc) }) +#'

[GitHub] spark pull request #21645: [SPARK-24537][R]Add array_remove / array_zip / ma...

2018-07-11 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/21645#discussion_r201574237 --- Diff: R/pkg/R/functions.R --- @@ -3120,6 +3147,24 @@ setMethod("arrays_overlap", column(jc) }) +#'

[GitHub] spark pull request #21742: [SPARK-24768][SQL] Have a built-in AVRO data sour...

2018-07-11 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21742#discussion_r201574655 --- Diff: external/avro/src/main/scala/org/apache/spark/sql/avro/package.scala --- @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #21742: [SPARK-24768][SQL] Have a built-in AVRO data sour...

2018-07-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21742#discussion_r201578320 --- Diff: external/avro/src/test/scala/org/apache/spark/sql/avro/AvroReadBenchmark.scala --- @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache

[GitHub] spark issue #18544: [SPARK-21318][SQL]Improve exception message thrown by `l...

2018-07-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18544 **[Test build #92840 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92840/testReport)** for PR 18544 at commit

[GitHub] spark issue #18544: [SPARK-21318][SQL]Improve exception message thrown by `l...

2018-07-11 Thread stanzhai
Github user stanzhai commented on the issue: https://github.com/apache/spark/pull/18544 cc @gatorsmile Addressed. Review this please. Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #21447: [SPARK-24339][SQL]Add project for transform/map/reduce s...

2018-07-11 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21447 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21678: [SPARK-23461][R]vignettes should include model predictio...

2018-07-11 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/21678 merged to master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #21678: [SPARK-23461][R]vignettes should include model pr...

2018-07-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21678 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21744: [SPARK-24697][SS] Fix the reported start offsets in stre...

2018-07-11 Thread tdas
Github user tdas commented on the issue: https://github.com/apache/spark/pull/21744 @arunmahadevan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21657: [SPARK-24676][SQL] Project required data from CSV parsed...

2018-07-11 Thread MaxGekk
Github user MaxGekk commented on the issue: https://github.com/apache/spark/pull/21657 @HyukjinKwon @gatorsmile Would you mind to merge the PR? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #21447: [SPARK-24339][SQL]Add project for transform/map/reduce s...

2018-07-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21447 **[Test build #92842 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92842/testReport)** for PR 21447 at commit

[GitHub] spark pull request #21742: [SPARK-24768][SQL] Have a built-in AVRO data sour...

2018-07-11 Thread gengliangwang
Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/21742#discussion_r201573634 --- Diff: external/avro/src/main/scala/org/apache/spark/sql/avro/package.scala --- @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software

[GitHub] spark issue #20057: [SPARK-22880][SQL] Add cascadeTruncate option to JDBC da...

2018-07-11 Thread danielvdende
Github user danielvdende commented on the issue: https://github.com/apache/spark/pull/20057 @dongjoon-hyun @gatorsmile Any update, guys? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #20057: [SPARK-22880][SQL] Add cascadeTruncate option to JDBC da...

2018-07-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20057 **[Test build #92841 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92841/testReport)** for PR 20057 at commit

[GitHub] spark issue #21447: [SPARK-24339][SQL]Add project for transform/map/reduce s...

2018-07-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21447 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21447: [SPARK-24339][SQL]Add project for transform/map/reduce s...

2018-07-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21447 **[Test build #92842 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92842/testReport)** for PR 21447 at commit

[GitHub] spark issue #21447: [SPARK-24339][SQL]Add project for transform/map/reduce s...

2018-07-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21447 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92842/ Test FAILed. ---

[GitHub] spark pull request #21657: [SPARK-24676][SQL] Project required data from CSV...

2018-07-11 Thread MaxGekk
Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/21657#discussion_r201582494 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/UnivocityParser.scala --- @@ -38,24 +38,28 @@ class UnivocityParser(

[GitHub] spark issue #21556: [SPARK-24549][SQL] Support Decimal type push down to the...

2018-07-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21556 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21744: [SPARK-24697][SS] Fix the reported start offsets in stre...

2018-07-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21744 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21744: [SPARK-24697][SS] Fix the reported start offsets in stre...

2018-07-11 Thread tdas
Github user tdas commented on the issue: https://github.com/apache/spark/pull/21744 jenkins retest this --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21744: [SPARK-24697][SS] Fix the reported start offsets in stre...

2018-07-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21744 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92838/ Test FAILed. ---

[GitHub] spark issue #21556: [SPARK-24549][SQL] Support Decimal type push down to the...

2018-07-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21556 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92837/ Test FAILed. ---

[GitHub] spark pull request #21739: [SPARK-22187][SS] Update unsaferow format for sav...

2018-07-11 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21739#discussion_r201597291 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/FlatMapGroupsWithStateExecHelper.scala --- @@ -0,0 +1,225 @@ +/* + *

[GitHub] spark pull request #21746: [WIP][SPARK-24699] [SS]Make watermarks work with ...

2018-07-11 Thread tdas
GitHub user tdas opened a pull request: https://github.com/apache/spark/pull/21746 [WIP][SPARK-24699] [SS]Make watermarks work with Trigger.Once by saving updated watermark to commit log ## What changes were proposed in this pull request? Streaming queries with watermarks

[GitHub] spark issue #21676: [SPARK-24699][SS][WIP] Watermark / Append mode should wo...

2018-07-11 Thread tdas
Github user tdas commented on the issue: https://github.com/apache/spark/pull/21676 Here is my solution based on my suggestion - https://github.com/apache/spark/pull/21746 I stole your unit test from this PR :) Thank you! I will add you as a co-author in that PR. ---

[GitHub] spark issue #21704: [WIP][SPARK-24734][SQL] Fix containsNull of Concat for a...

2018-07-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21704 **[Test build #92855 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92855/testReport)** for PR 21704 at commit

[GitHub] spark issue #21744: [SPARK-24697][SS] Fix the reported start offsets in stre...

2018-07-11 Thread arunmahadevan
Github user arunmahadevan commented on the issue: https://github.com/apache/spark/pull/21744 @tdas logically this is similar to https://github.com/apache/spark/pull/21673. Yes it makes the control flow better and LGTM. Overall the progress reporter is still tightly coupled

[GitHub] spark issue #21556: [SPARK-24549][SQL] Support Decimal type push down to the...

2018-07-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21556 **[Test build #92843 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92843/testReport)** for PR 21556 at commit

[GitHub] spark issue #21556: [SPARK-24549][SQL] Support Decimal type push down to the...

2018-07-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21556 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/836/

[GitHub] spark issue #21556: [SPARK-24549][SQL] Support Decimal type push down to the...

2018-07-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21556 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21698: [SPARK-23243][Core] Fix RDD.repartition() data correctne...

2018-07-11 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/21698 For `zip`, it's hard to define what result is "corrected", given the fact that RDD is unordered. I think sample should be similar. `repartition` is special because we may change the

[GitHub] spark pull request #21742: [SPARK-24768][SQL] Have a built-in AVRO data sour...

2018-07-11 Thread gengliangwang
Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/21742#discussion_r201602440 --- Diff: external/avro/src/main/scala/org/apache/spark/sql/avro/package.scala --- @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software

[GitHub] spark issue #21745: [SPARK-24781][SQL] Using a reference from Dataset in Fil...

2018-07-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21745 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21608: [SPARK-24626] [SQL] Improve location size calculation in...

2018-07-11 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21608 I think it's ok to put tests in `CommandUtilsSuite`. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #21746: [WIP][SPARK-24699] [SS]Make watermarks work with Trigger...

2018-07-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21746 **[Test build #92852 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92852/testReport)** for PR 21746 at commit

[GitHub] spark issue #21746: [WIP][SPARK-24699] [SS]Make watermarks work with Trigger...

2018-07-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21746 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/843/

[GitHub] spark issue #21746: [WIP][SPARK-24699] [SS]Make watermarks work with Trigger...

2018-07-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21746 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21739: [SPARK-22187][SS] Update unsaferow format for saved stat...

2018-07-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21739 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92853/ Test FAILed. ---

[GitHub] spark issue #21739: [SPARK-22187][SS] Update unsaferow format for saved stat...

2018-07-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21739 **[Test build #92853 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92853/testReport)** for PR 21739 at commit

[GitHub] spark issue #21739: [SPARK-22187][SS] Update unsaferow format for saved stat...

2018-07-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21739 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21742: [SPARK-24768][SQL] Have a built-in AVRO data source impl...

2018-07-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21742 **[Test build #92854 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92854/testReport)** for PR 21742 at commit

[GitHub] spark issue #21742: [SPARK-24768][SQL] Have a built-in AVRO data source impl...

2018-07-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21742 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21742: [SPARK-24768][SQL] Have a built-in AVRO data source impl...

2018-07-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21742 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/845/

[GitHub] spark issue #21747: [SPARK-24165][SQL][branch-2.3] Fixing conditional expres...

2018-07-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21747 **[Test build #92856 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92856/testReport)** for PR 21747 at commit

[GitHub] spark issue #21260: [SPARK-23529][K8s] Support mounting volumes

2018-07-11 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/21260 @felixcheung volumes will be supported by the pod template. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #21673: [SPARK-24697][SS] Fix the reported start offsets in stre...

2018-07-11 Thread arunmahadevan
Github user arunmahadevan commented on the issue: https://github.com/apache/spark/pull/21673 @tdas Closing this in favor of #21744 . --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #21673: [SPARK-24697][SS] Fix the reported start offsets ...

2018-07-11 Thread arunmahadevan
Github user arunmahadevan closed the pull request at: https://github.com/apache/spark/pull/21673 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21556: [SPARK-24549][SQL] Support Decimal type push down to the...

2018-07-11 Thread wangyum
Github user wangyum commented on the issue: https://github.com/apache/spark/pull/21556 retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21744: [SPARK-24697][SS] Fix the reported start offsets in stre...

2018-07-11 Thread tdas
Github user tdas commented on the issue: https://github.com/apache/spark/pull/21744 @arunmahadevan I agree that this can be refactored later. I was trying to do that, and then realized that it does not make sense to do that in the same PR as this bug fix. thank you for reviewing.

[GitHub] spark pull request #21742: [SPARK-24768][SQL] Have a built-in AVRO data sour...

2018-07-11 Thread gengliangwang
Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/21742#discussion_r201596017 --- Diff: external/avro/src/main/scala/org/apache/spark/sql/avro/package.scala --- @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software

[GitHub] spark issue #21742: [SPARK-24768][SQL] Have a built-in AVRO data source impl...

2018-07-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21742 **[Test build #92848 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92848/testReport)** for PR 21742 at commit

[GitHub] spark issue #21742: [SPARK-24768][SQL] Have a built-in AVRO data source impl...

2018-07-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21742 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21742: [SPARK-24768][SQL] Have a built-in AVRO data source impl...

2018-07-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21742 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/840/

[GitHub] spark pull request #21745: [SPARK-24781][SQL] Using a reference from Dataset...

2018-07-11 Thread viirya
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/21745 [SPARK-24781][SQL] Using a reference from Dataset in Filter/Sort might not work ## What changes were proposed in this pull request? When we use a reference from Dataset in filter or sort,

[GitHub] spark issue #21698: [SPARK-23243][Core] Fix RDD.repartition() data correctne...

2018-07-11 Thread mridulm
Github user mridulm commented on the issue: https://github.com/apache/spark/pull/21698 @cloud-fan We should not look at a particular stage in isolation, but rather what happens when there are failures in the middle of a job with multiple shuffle stages - and zip is one of the

[GitHub] spark issue #21746: [WIP][SPARK-24699] [SS]Make watermarks work with Trigger...

2018-07-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21746 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92852/ Test FAILed. ---

[GitHub] spark issue #21746: [WIP][SPARK-24699] [SS]Make watermarks work with Trigger...

2018-07-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21746 **[Test build #92852 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92852/testReport)** for PR 21746 at commit

[GitHub] spark pull request #21742: [SPARK-24768][SQL] Have a built-in AVRO data sour...

2018-07-11 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21742#discussion_r201626863 --- Diff: external/avro/src/test/resources/benchmarkSchema.avsc --- @@ -0,0 +1,35 @@ +{ --- End diff -- Seems missed to delete it.

[GitHub] spark issue #21739: [SPARK-22187][SS] Update unsaferow format for saved stat...

2018-07-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21739 **[Test build #92853 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92853/testReport)** for PR 21739 at commit

[GitHub] spark issue #19410: [SPARK-22184][CORE][GRAPHX] GraphX fails in case of insu...

2018-07-11 Thread EthanRock
Github user EthanRock commented on the issue: https://github.com/apache/spark/pull/19410 I have tried to set graph's storage level to StorageLevel.MEMORY_AND_DISK in my case and the error still happens. --- - To

[GitHub] spark issue #21568: [SPARK-24562][TESTS] Support different configs for same ...

2018-07-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21568 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/847/

[GitHub] spark issue #21568: [SPARK-24562][TESTS] Support different configs for same ...

2018-07-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21568 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21744: [SPARK-24697][SS] Fix the reported start offsets in stre...

2018-07-11 Thread tdas
Github user tdas commented on the issue: https://github.com/apache/spark/pull/21744 jenkins retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #21742: [SPARK-24768][SQL] Have a built-in AVRO data sour...

2018-07-11 Thread gengliangwang
Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/21742#discussion_r201595614 --- Diff: external/avro/src/main/scala/org/apache/spark/sql/avro/package.scala --- @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software

[GitHub] spark issue #21740: [SPARK-18230][MLLib]Throw a better exception, if the use...

2018-07-11 Thread shahidki31
Github user shahidki31 commented on the issue: https://github.com/apache/spark/pull/21740 @jianran please refer the PR, https://github.com/apache/spark/pull/15809. In this PR, I am checking if the 'userFeatures.lookup(user)', is empty or not. ---

[GitHub] spark pull request #21742: [SPARK-24768][SQL] Have a built-in AVRO data sour...

2018-07-11 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21742#discussion_r201599624 --- Diff: external/avro/src/main/scala/org/apache/spark/sql/avro/package.scala --- @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #21742: [SPARK-24768][SQL] Have a built-in AVRO data sour...

2018-07-11 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21742#discussion_r201602246 --- Diff: external/avro/src/main/scala/org/apache/spark/sql/avro/package.scala --- @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #21742: [SPARK-24768][SQL] Have a built-in AVRO data sour...

2018-07-11 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21742#discussion_r201603635 --- Diff: external/avro/src/main/scala/org/apache/spark/sql/avro/package.scala --- @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #21061: [SPARK-23914][SQL] Add array_union function

2018-07-11 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21061#discussion_r201620967 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -3261,3 +3261,322 @@ case class

[GitHub] spark issue #21745: [SPARK-24781][SQL] Using a reference from Dataset in Fil...

2018-07-11 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/21745 cc @ueshin @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21061: [SPARK-23914][SQL] Add array_union function

2018-07-11 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/21061 Few minor comments. otherwise LGTM. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #21739: [SPARK-22187][SS] Update unsaferow format for saved stat...

2018-07-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21739 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/844/

[GitHub] spark issue #21739: [SPARK-22187][SS] Update unsaferow format for saved stat...

2018-07-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21739 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21744: [SPARK-24697][SS] Fix the reported start offsets in stre...

2018-07-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21744 **[Test build #92844 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92844/testReport)** for PR 21744 at commit

[GitHub] spark issue #21744: [SPARK-24697][SS] Fix the reported start offsets in stre...

2018-07-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21744 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21744: [SPARK-24697][SS] Fix the reported start offsets in stre...

2018-07-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21744 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/837/

[GitHub] spark issue #21739: [SPARK-22187][SS] Update unsaferow format for saved stat...

2018-07-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21739 **[Test build #92845 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92845/testReport)** for PR 21739 at commit

[GitHub] spark issue #21596: [SPARK-24601] Bump Jackson version

2018-07-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21596 **[Test build #92847 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92847/testReport)** for PR 21596 at commit

[GitHub] spark issue #21596: [SPARK-24601] Bump Jackson version

2018-07-11 Thread Fokko
Github user Fokko commented on the issue: https://github.com/apache/spark/pull/21596 Rebased onto master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21739: [SPARK-22187][SS] Update unsaferow format for saved stat...

2018-07-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21739 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21739: [SPARK-22187][SS] Update unsaferow format for saved stat...

2018-07-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21739 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/839/

[GitHub] spark issue #20795: [SPARK-23486]cache the function name from the external c...

2018-07-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20795 **[Test build #92849 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92849/testReport)** for PR 20795 at commit

  1   2   3   4   5   6   7   >