Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21657
Please let me do one pass within few days.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20057
**[Test build #92841 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92841/testReport)**
for PR 20057 at commit
[`bc75051`](https://github.com/apache/spark/commit/b
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20057
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20057
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92841/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21469
**[Test build #92839 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92839/testReport)**
for PR 21469 at commit
[`c4a6d11`](https://github.com/apache/spark/commit/c
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21469
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92839/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21469
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21744
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92838/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92837/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21744
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user tdas commented on the issue:
https://github.com/apache/spark/pull/21744
jenkins retest this
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21447
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@s
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21447
**[Test build #92842 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92842/testReport)**
for PR 21447 at commit
[`3997ceb`](https://github.com/apache/spark/commit/39
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21447
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21447
**[Test build #92842 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92842/testReport)**
for PR 21447 at commit
[`3997ceb`](https://github.com/apache/spark/commit/3
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21447
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92842/
Test FAILed.
---
Github user arunmahadevan commented on the issue:
https://github.com/apache/spark/pull/21744
@tdas logically this is similar to
https://github.com/apache/spark/pull/21673. Yes it makes the control flow
better and LGTM.
Overall the progress reporter is still tightly coupled wi
Github user arunmahadevan closed the pull request at:
https://github.com/apache/spark/pull/21673
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.
Github user arunmahadevan commented on the issue:
https://github.com/apache/spark/pull/21673
@tdas Closing this in favor of #21744 .
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional c
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/21556
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21556
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/836/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21556
**[Test build #92843 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92843/testReport)**
for PR 21556 at commit
[`16528f3`](https://github.com/apache/spark/commit/16
Github user tdas commented on the issue:
https://github.com/apache/spark/pull/21744
jenkins retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: revie
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/21742#discussion_r201595614
--- Diff:
external/avro/src/main/scala/org/apache/spark/sql/avro/package.scala ---
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Fo
Github user tdas commented on the issue:
https://github.com/apache/spark/pull/21744
@arunmahadevan I agree that this can be refactored later. I was trying to
do that, and then realized that it does not make sense to do that in the same
PR as this bug fix. thank you for reviewing.
--
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/21742#discussion_r201596017
--- Diff:
external/avro/src/main/scala/org/apache/spark/sql/avro/package.scala ---
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Fo
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21744
**[Test build #92844 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92844/testReport)**
for PR 21744 at commit
[`81e8955`](https://github.com/apache/spark/commit/81
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21744
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21744
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/837/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21739
**[Test build #92845 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92845/testReport)**
for PR 21739 at commit
[`05e3acf`](https://github.com/apache/spark/commit/05
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21739
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21739
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/838/
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/21739#discussion_r201597291
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/FlatMapGroupsWithStateExecHelper.scala
---
@@ -0,0 +1,225 @@
+/*
+ *
Github user shahidki31 commented on the issue:
https://github.com/apache/spark/pull/21740
@jianran please refer the PR, https://github.com/apache/spark/pull/15809.
In this PR, I am checking if the 'userFeatures.lookup(user)', is empty or not.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21739
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21739
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/839/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21596
**[Test build #92847 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92847/testReport)**
for PR 21596 at commit
[`4fcf9b7`](https://github.com/apache/spark/commit/4f
Github user Fokko commented on the issue:
https://github.com/apache/spark/pull/21596
Rebased onto master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h..
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21739
**[Test build #92846 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92846/testReport)**
for PR 21739 at commit
[`dcf9616`](https://github.com/apache/spark/commit/dc
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21742#discussion_r201599624
--- Diff:
external/avro/src/main/scala/org/apache/spark/sql/avro/package.scala ---
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foun
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21742
**[Test build #92848 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92848/testReport)**
for PR 21742 at commit
[`7a45457`](https://github.com/apache/spark/commit/7a
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21742
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21742
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/840/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20795
**[Test build #92849 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92849/testReport)**
for PR 20795 at commit
[`8dceda9`](https://github.com/apache/spark/commit/8d
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21742#discussion_r201602246
--- Diff:
external/avro/src/main/scala/org/apache/spark/sql/avro/package.scala ---
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foun
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21698
For `zip`, it's hard to define what result is "corrected", given the fact
that RDD is unordered. I think sample should be similar.
`repartition` is special because we may change the number
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/21742#discussion_r201602440
--- Diff:
external/avro/src/main/scala/org/apache/spark/sql/avro/package.scala ---
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Fo
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21742#discussion_r201603635
--- Diff:
external/avro/src/main/scala/org/apache/spark/sql/avro/package.scala ---
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foun
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/21061
@viirya Do you have any other comments on this? Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For add
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21736
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21736
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/841/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21736
**[Test build #92850 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92850/testReport)**
for PR 21736 at commit
[`6eacd6c`](https://github.com/apache/spark/commit/6e
Github user mridulm commented on the issue:
https://github.com/apache/spark/pull/21698
@cloud-fan We should not look at a particular stage in isolation, but
rather what happens when there are failures in the middle of a job with
multiple shuffle stages - and zip is one of the internal
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/21745
[SPARK-24781][SQL] Using a reference from Dataset in Filter/Sort might not
work
## What changes were proposed in this pull request?
When we use a reference from Dataset in filter or sort, w
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21745
**[Test build #92851 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92851/testReport)**
for PR 21745 at commit
[`97837a4`](https://github.com/apache/spark/commit/97
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21745
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/842/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21745
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21608
I think it's ok to put tests in `CommandUtilsSuite`.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additi
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21061#discussion_r201618980
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java
---
@@ -463,14 +463,27 @@ private static UnsafeArrayData
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21061#discussion_r201620967
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -3261,3 +3261,322 @@ case class ArrayDisti
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21745
cc @ueshin @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21061
Few minor comments. otherwise LGTM.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21745#discussion_r201622249
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1163,7 +1163,8 @@ class Analyzer(
case p:
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21745#discussion_r201621224
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/plans/LogicalPlanSuite.scala
---
@@ -119,4 +119,16 @@ class LogicalPlanSuite extends Spa
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21745#discussion_r201619815
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1163,7 +1163,8 @@ class Analyzer(
case p:
GitHub user tdas opened a pull request:
https://github.com/apache/spark/pull/21746
[WIP][SPARK-24699] [SS]Make watermarks work with Trigger.Once by saving
updated watermark to commit log
## What changes were proposed in this pull request?
Streaming queries with watermarks d
Github user tdas commented on the issue:
https://github.com/apache/spark/pull/21676
Here is my solution based on my suggestion -
https://github.com/apache/spark/pull/21746
I stole your unit test from this PR :) Thank you! I will add you as a
co-author in that PR.
---
--
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21746
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/843/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21746
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21746
**[Test build #92852 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92852/testReport)**
for PR 21746 at commit
[`7e54a89`](https://github.com/apache/spark/commit/7e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21746
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92852/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21746
**[Test build #92852 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92852/testReport)**
for PR 21746 at commit
[`7e54a89`](https://github.com/apache/spark/commit/7
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21746
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21742#discussion_r201626863
--- Diff: external/avro/src/test/resources/benchmarkSchema.avsc ---
@@ -0,0 +1,35 @@
+{
--- End diff --
Seems missed to delete it.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21739
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21739
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/844/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21739
**[Test build #92853 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92853/testReport)**
for PR 21739 at commit
[`3abb5e2`](https://github.com/apache/spark/commit/3a
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21739
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21739
**[Test build #92853 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92853/testReport)**
for PR 21739 at commit
[`3abb5e2`](https://github.com/apache/spark/commit/3
601 - 681 of 681 matches
Mail list logo
