Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/7#discussion_r214529571
--- Diff: python/pyspark/sql/functions.py ---
@@ -1669,20 +1669,36 @@ def repeat(col, n):
return
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22295#discussion_r214530177
--- Diff: python/pyspark/sql/session.py ---
@@ -252,6 +252,16 @@ def newSession(self):
"""
return self.__class__(self._sc,
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/22274
interesting. maybe something to do with newer R release - I scanned through
the rel note though but didn't find what might be related.
---
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22291
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22314
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22315
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22314
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22315
**[Test build #95587 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95587/testReport)**
for PR 22315 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22314
**[Test build #95588 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95588/testReport)**
for PR 22314 at commit
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22315
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22315
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/22291
merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22314
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/22314
LGTM.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22314
**[Test build #95588 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95588/testReport)**
for PR 22314 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22314
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95588/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22314
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22270
@ueshin Opened (https://github.com/apache/spark/pull/22314) and
(https://github.com/apache/spark/pull/22315). Thank you.
---
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22274#discussion_r214530330
--- Diff: R/pkg/tests/fulltests/test_sparkSQL.R ---
@@ -3633,7 +3633,8 @@ test_that("catalog APIs, currentDatabase,
setCurrentDatabase, listDatabases",
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/22274
maybe also your laptop's system time zone? could you also check that?
---
-
To unsubscribe, e-mail:
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22274
@felixcheung From system preference -
Time zone : Pacific Daylight Time
closest city :Cupertino, CA, United States
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22314
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22314
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22274
@felixcheung or perhaps something changed in `testthat` ?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22315
**[Test build #95589 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95589/testReport)**
for PR 22315 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22315
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95587/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22315
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22298#discussion_r214530079
--- Diff: examples/src/main/python/worker_memory_check.py ---
@@ -0,0 +1,47 @@
+#
--- End diff --
shouldn't this be in python tests
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22315
**[Test build #95586 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95586/testReport)**
for PR 22315 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22314
**[Test build #95585 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95585/testReport)**
for PR 22314 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22192
**[Test build #95584 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95584/testReport)**
for PR 22192 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22192
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22192
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95584/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22315
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95586/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22315
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22314
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22314
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95585/
Test FAILed.
---
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22274
@felixcheung Yeah... it may be a newer change. Actually i am new to R as
well. Here is the test i did -
```
00:15:22-dbiswal~/mygit/apache/spark/bin (SPARK-25308)$ ./sparkR
R
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22315#discussion_r214532578
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala
---
@@ -383,10 +383,13 @@ class
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22315#discussion_r214532569
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1464,17 +1464,28 @@ case class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22315
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22315
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22315
**[Test build #95587 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95587/testReport)**
for PR 22315 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22308
@sadhen I mean is this just a copy of the 2.10 jar? what's in the jar?
@felixcheung in this case there's a test specifically testing loading of a
jar file, so it has to have a jar file to load.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22310
@sadhen we use Maven though, not SBT. (SBT works through a plugin). But my
point is the path `.../repl/...` which doesn't reflect the class's path. Scala
and Java convention has always put code in a
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/22298#discussion_r214543937
--- Diff: examples/src/main/python/worker_memory_check.py ---
@@ -0,0 +1,47 @@
+#
--- End diff --
That might be a good place for it. But
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22218#discussion_r214544279
--- Diff:
core/src/main/scala/org/apache/spark/executor/ExecutorSource.scala ---
@@ -73,6 +76,28 @@ class ExecutorSource(threadPool: ThreadPoolExecutor,
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22179
Tests are great of course; those three might be hard to test. The first and
last one don't have info on the reproduction. The second one looks possibly
reproducible though as it shows the custom
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22316
Yup I prefer this way
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22316#discussion_r214544896
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala ---
@@ -406,6 +407,15 @@ class RelationalGroupedDataset
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22316
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22316
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22315
Thank you
LGTM except one comment.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22315#discussion_r214542052
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1464,17 +1464,27 @@ case class
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22315
**[Test build #95589 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95589/testReport)**
for PR 22315 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22315
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95589/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22315
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user MaxGekk closed the pull request at:
https://github.com/apache/spark/pull/22030
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
GitHub user MaxGekk opened a pull request:
https://github.com/apache/spark/pull/22316
[SPARK-25048][SQL] Pivoting by multiple columns in Scala/Java
## What changes were proposed in this pull request?
In the PR, I propose to extend implementation of existing method:
```
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/22030
Please, review this PR https://github.com/apache/spark/pull/22316
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22316
**[Test build #95590 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95590/testReport)**
for PR 22316 at commit
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21912
cc @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21638#discussion_r214581248
--- Diff:
core/src/main/scala/org/apache/spark/input/PortableDataStream.scala ---
@@ -47,7 +47,7 @@ private[spark] abstract class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22319#discussion_r214581204
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala
---
@@ -129,3 +135,11 @@ case class UserDefinedFunction
Github user LucaCanali commented on a diff in the pull request:
https://github.com/apache/spark/pull/22218#discussion_r214549896
--- Diff:
core/src/main/scala/org/apache/spark/executor/ExecutorSource.scala ---
@@ -73,6 +76,28 @@ class ExecutorSource(threadPool: ThreadPoolExecutor,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22315
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22315
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22315
**[Test build #95593 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95593/testReport)**
for PR 22315 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22315
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95593/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22315
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/7#discussion_r214561410
--- Diff: python/pyspark/sql/functions.py ---
@@ -1669,20 +1669,33 @@ def repeat(col, n):
return
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/7#discussion_r214561362
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2546,15 +2546,39 @@ object functions {
def soundex(e: Column):
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22218#discussion_r214561269
--- Diff:
core/src/main/scala/org/apache/spark/executor/ExecutorSource.scala ---
@@ -73,6 +75,29 @@ class ExecutorSource(threadPool: ThreadPoolExecutor,
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22198
ping
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/7#discussion_r214562760
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala
---
@@ -229,36 +229,58 @@ case class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/7#discussion_r214562895
--- Diff: sql/core/src/test/resources/sql-tests/inputs/string-functions.sql
---
@@ -46,4 +46,10 @@ FROM (
encode(string(id + 2), 'utf-8')
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22300
@kiszk ping, could you do that?
https://github.com/apache/spark/pull/22300#issuecomment-417706754
---
-
To unsubscribe, e-mail:
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22315#discussion_r214564677
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1464,17 +1464,35 @@ case class
Github user jinxing64 commented on the issue:
https://github.com/apache/spark/pull/21330
If this feature is interested, could you please help start the review
@jiangxb1987
Thanks a lot.
---
-
To unsubscribe,
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22316#discussion_r214566503
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFramePivotSuite.scala ---
@@ -308,4 +308,27 @@ class DataFramePivotSuite extends QueryTest with
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22317
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22317
**[Test build #95594 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95594/testReport)**
for PR 22317 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22317
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95594/
Test PASSed.
---
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22319#discussion_r214577826
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala
---
@@ -41,12 +41,18 @@ import
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22319#discussion_r214581734
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala
---
@@ -129,3 +135,11 @@ case class UserDefinedFunction
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22319
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22319
**[Test build #95600 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95600/testReport)**
for PR 22319 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22319
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95599/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22319
**[Test build #95599 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95599/testReport)**
for PR 22319 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22319
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21638#discussion_r214581076
--- Diff:
core/src/main/scala/org/apache/spark/input/PortableDataStream.scala ---
@@ -47,7 +47,7 @@ private[spark] abstract class
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22319
**[Test build #95599 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95599/testReport)**
for PR 22319 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21638
@bomeng Could you submit a follow-up PR to add a test case?
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22319
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22314#discussion_r214581948
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1047,7 +1047,8 @@ trait
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22314#discussion_r214582048
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1047,7 +1047,8 @@ trait
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22298#discussion_r214550394
--- Diff: examples/src/main/python/worker_memory_check.py ---
@@ -0,0 +1,47 @@
+#
--- End diff --
I think the concern here is shipping
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22317
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22317
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95591/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22317
**[Test build #95591 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95591/testReport)**
for PR 22317 at commit
1 - 100 of 195 matches
Mail list logo