Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22426#discussion_r217892075
--- Diff: project/MimaExcludes.scala ---
@@ -1202,6 +1206,7 @@ object MimaExcludes {
}
def excludes(version: String) = version
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22413#discussion_r217893030
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataSourceV2Suite.scala
---
@@ -385,6 +400,9 @@ class SimpleDataSourceV2 extends
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22429
**[Test build #96093 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96093/testReport)**
for PR 22429 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22413
**[Test build #96096 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96096/testReport)**
for PR 22413 at commit
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22413#discussion_r217893695
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -241,10 +241,12 @@ final class DataFrameWriter[T]
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22429
**[Test build #96097 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96097/testReport)**
for PR 22429 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22413
@MaxGekk . I made a write-path test case PR to you. Could you review that,
https://github.com/MaxGekk/spark-1/pull/8 ?
---
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/22429
@rednaxelafx Please, take a look at the PR.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22413
**[Test build #96098 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96098/testReport)**
for PR 22413 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22431
**[Test build #96099 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96099/testReport)**
for PR 22431 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22431
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22431
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22431
**[Test build #96099 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96099/testReport)**
for PR 22431 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22431
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22431
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96099/
Test PASSed.
---
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22430
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20433
@maropu We need a new SQLConf in Parser. See my example in
https://github.com/apache/spark/pull/21922
---
-
To unsubscribe,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22430
**[Test build #96100 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96100/testReport)**
for PR 22430 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22427
cc @rdblue
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22396#discussion_r217897114
--- Diff: docs/sql-programming-guide.md ---
@@ -1898,6 +1898,7 @@ working with timestamps in `pandas_udf`s to get the
best performance, see
-
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22396#discussion_r217897208
--- Diff: docs/sql-programming-guide.md ---
@@ -1898,6 +1898,7 @@ working with timestamps in `pandas_udf`s to get the
best performance, see
- Since
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20433
ok
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22417
cc: @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22429
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96093/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22429
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22430
nit. Could you make the title shorter like `[SPARK-25439][TEST][SQL] Fix
TPCH customer.c_nationkey datatype to BIGINT`?
---
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22430
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19538
@ambauma could you close it? we can't, directly
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22425#discussion_r217895205
--- Diff: dev/tox.ini ---
@@ -14,6 +14,8 @@
# limitations under the License.
[pycodestyle]
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22431
cc @dbtsai
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22425#discussion_r217895197
--- Diff: dev/tox.ini ---
@@ -14,6 +14,8 @@
# limitations under the License.
[pycodestyle]
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/22431
[SPARK-24418][FOLLOWUP][DOC] Update docs to show Scala 2.11.12
## What changes were proposed in this pull request?
This PR updates Scala version in docs.
-
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22413
**[Test build #96096 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96096/testReport)**
for PR 22413 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22426
**[Test build #96095 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96095/testReport)**
for PR 22426 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22413
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96096/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22413
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22426
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22426
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96095/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22355
Build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22426
Thanks! Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22355
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22355
**[Test build #96101 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96101/testReport)**
for PR 22355 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22417
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22426
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22355
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22355
**[Test build #96102 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96102/testReport)**
for PR 22355 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22355
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22355
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22355
**[Test build #96103 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96103/testReport)**
for PR 22355 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22355
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22413
**[Test build #96098 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96098/testReport)**
for PR 22413 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22413
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22427
Just a question; I'm not familiar with both internal logics though, these
parameters (`Memory buffer for writing` and `Compression chunk size`) are
internally treated in the same manner? Also, they
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22413
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96098/
Test PASSed.
---
Github user nikunjb commented on the issue:
https://github.com/apache/spark/pull/22424
@dongjoon-hyun @tdas Can you please help review this PR?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user nikunjb commented on the issue:
https://github.com/apache/spark/pull/22423
@dongjoon-hyun @tdas Can you please help review this PR?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22414#discussion_r217898513
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/TimeWindow.scala
---
@@ -35,6 +35,10 @@ case class TimeWindow(
with
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22414
Please write the current behaviour (you described above) in the PR
description?
Also, can you format the PR description, too? you don't need the link to
the jira.
```
â¦alues should
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22413
Thank you, @MaxGekk . Merged to master/2.4/2.3.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22413
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22429
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96097/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22429
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22429
**[Test build #96097 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96097/testReport)**
for PR 22429 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22427
Thank you for review, @maropu .
1. Yes. It's the same. The first one limits the memory usage for write
operation. The second one limits the memory usage for compression operation.
2.
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22427
Thanks for the explanation! The change looks good to me.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22418
Could you review this test case PR, @gatorsmile , @cloud-fan , @maropu ,
@HyukjinKwon ?
---
-
To unsubscribe, e-mail:
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22427
Thank you, @maropu !
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22427
Merged to master/2.4.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22427
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22430
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22430
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96100/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22430
**[Test build #96100 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96100/testReport)**
for PR 22430 at commit
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22010#discussion_r217900574
--- Diff: core/src/main/scala/org/apache/spark/rdd/MapPartitionsRDD.scala
---
@@ -35,16 +35,24 @@ import org.apache.spark.{Partition, TaskContext}
*
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22010#discussion_r217900563
--- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
@@ -396,7 +396,26 @@ abstract class RDD[T: ClassTag](
* Return a new RDD containing
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21515#discussion_r217900617
--- Diff: dev/create-release/do-release-docker.sh ---
@@ -0,0 +1,143 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22430
Thanks! Merged to master/2.4
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/22432
[SPARK-22713][CORE][TEST][FOLLOWUP] Fix flaky ExternalAppendOnlyMapSuite
due to timeout
## What changes were proposed in this pull request?
SPARK-22713 uses `eventually` with the
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22430
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22432
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22432
**[Test build #96104 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96104/testReport)**
for PR 22432 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22432
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22432
cc @eyalfa @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22355
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22430
This is a pure test only PR. Backporting to 2.3 is optional.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22355
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96103/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22355
**[Test build #96103 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96103/testReport)**
for PR 22355 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22430
@gatorsmile . We need a backport to 2.3, too.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22355
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96102/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22355
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22355
**[Test build #96102 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96102/testReport)**
for PR 22355 at commit
Github user ambauma closed the pull request at:
https://github.com/apache/spark/pull/19538
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22426
+1, LGTM.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/22010#discussion_r217901185
--- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
@@ -396,7 +396,26 @@ abstract class RDD[T: ClassTag](
* Return a new RDD containing
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/20433
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22427
Could you review this, @gatorsmile , @cloud-fan , @dbtsai , @maropu and
@wangyum ?
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22427
**[Test build #96092 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96092/testReport)**
for PR 22427 at commit
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/22427
[SPARK-25438][SQL][TEST] Fix FilterPushdownBenchmark to use the same memory
assumption
## What changes were proposed in this pull request?
This PR aims to fix three things in
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22418
Could you review this please, @cloud-fan ?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20556
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96085/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20556
Build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
1 - 100 of 202 matches
Mail list logo
