[GitHub] spark issue #22615: [SPARK-25016][BUILD][CORE] Remove support for Hadoop 2.6

2018-10-02 Thread wangyum
Github user wangyum commented on the issue: https://github.com/apache/spark/pull/22615 We can simplery this: https://github.com/apache/spark/blob/7ad18ee9f26e75dbe038c6034700f9cd4c0e2baa/resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala#L273-L295 t

[GitHub] spark issue #22616: [SPARK-25586][Core] Remove outer objects from logdebug s...

2018-10-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22616 **[Test build #96875 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96875/testReport)** for PR 22616 at commit [`cc8926d`](https://github.com/apache/spark/commit/c

[GitHub] spark issue #22616: [SPARK-25586][Core] Remove outer objects from logdebug s...

2018-10-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22616 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22616: [SPARK-25586][Core] Remove outer objects from logdebug s...

2018-10-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22616 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96875/ Test PASSed. ---

[GitHub] spark issue #22613: [SPARK-25583][DOC][BRANCH-2.3]Add history-server related...

2018-10-02 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22613 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@s

[GitHub] spark issue #22613: [SPARK-25583][DOC][BRANCH-2.3]Add history-server related...

2018-10-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22613 **[Test build #96884 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96884/testReport)** for PR 22613 at commit [`f0947a3`](https://github.com/apache/spark/commit/f0

[GitHub] spark pull request #22611: [SPARK-25595] Ignore corrupt Avro files if flag I...

2018-10-02 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22611#discussion_r222166498 --- Diff: external/avro/src/main/scala/org/apache/spark/sql/avro/AvroFileFormat.scala --- @@ -100,6 +77,50 @@ private[avro] class AvroFileFormat extends

[GitHub] spark pull request #22611: [SPARK-25595] Ignore corrupt Avro files if flag I...

2018-10-02 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22611#discussion_r222166950 --- Diff: external/avro/src/main/scala/org/apache/spark/sql/avro/AvroFileFormat.scala --- @@ -100,6 +77,50 @@ private[avro] class AvroFileFormat extends

[GitHub] spark pull request #22611: [SPARK-25595] Ignore corrupt Avro files if flag I...

2018-10-02 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22611#discussion_r222167036 --- Diff: external/avro/src/main/scala/org/apache/spark/sql/avro/AvroFileFormat.scala --- @@ -100,6 +77,50 @@ private[avro] class AvroFileFormat extends

[GitHub] spark pull request #22611: [SPARK-25595] Ignore corrupt Avro files if flag I...

2018-10-02 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22611#discussion_r222167078 --- Diff: external/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala --- @@ -342,6 +342,53 @@ class AvroSuite extends QueryTest with Shared

[GitHub] spark issue #22613: [SPARK-25583][DOC][BRANCH-2.3]Add history-server related...

2018-10-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22613 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22613: [SPARK-25583][DOC][BRANCH-2.3]Add history-server related...

2018-10-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22613 **[Test build #96884 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96884/testReport)** for PR 22613 at commit [`f0947a3`](https://github.com/apache/spark/commit/f

[GitHub] spark issue #22500: [SPARK-25488][TEST] Refactor MiscBenchmark to use main m...

2018-10-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22500 **[Test build #96877 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96877/testReport)** for PR 22500 at commit [`f7a14e3`](https://github.com/apache/spark/commit/f

[GitHub] spark issue #22613: [SPARK-25583][DOC][BRANCH-2.3]Add history-server related...

2018-10-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22613 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96884/ Test PASSed. ---

[GitHub] spark issue #22500: [SPARK-25488][TEST] Refactor MiscBenchmark to use main m...

2018-10-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22500 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96877/ Test PASSed. ---

[GitHub] spark issue #22500: [SPARK-25488][TEST] Refactor MiscBenchmark to use main m...

2018-10-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22500 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22488: [SPARK-25479][TEST] Refactor DatasetBenchmark to use mai...

2018-10-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22488 **[Test build #96879 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96879/testReport)** for PR 22488 at commit [`d2d0a3e`](https://github.com/apache/spark/commit/d

[GitHub] spark issue #22488: [SPARK-25479][TEST] Refactor DatasetBenchmark to use mai...

2018-10-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22488 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96879/ Test PASSed. ---

[GitHub] spark issue #22491: [SPARK-25483][TEST] Refactor UnsafeArrayDataBenchmark to...

2018-10-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22491 **[Test build #96878 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96878/testReport)** for PR 22491 at commit [`5c819fb`](https://github.com/apache/spark/commit/5

[GitHub] spark issue #22488: [SPARK-25479][TEST] Refactor DatasetBenchmark to use mai...

2018-10-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22488 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22491: [SPARK-25483][TEST] Refactor UnsafeArrayDataBenchmark to...

2018-10-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22491 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22491: [SPARK-25483][TEST] Refactor UnsafeArrayDataBenchmark to...

2018-10-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22491 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96878/ Test PASSed. ---

[GitHub] spark issue #22616: [SPARK-25586][Core] Remove outer objects from logdebug s...

2018-10-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22616 **[Test build #96876 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96876/testReport)** for PR 22616 at commit [`2723b47`](https://github.com/apache/spark/commit/2

[GitHub] spark issue #22616: [SPARK-25586][Core] Remove outer objects from logdebug s...

2018-10-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22616 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22616: [SPARK-25586][Core] Remove outer objects from logdebug s...

2018-10-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22616 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96876/ Test PASSed. ---

[GitHub] spark pull request #22611: [SPARK-25595] Ignore corrupt Avro files if flag I...

2018-10-02 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22611#discussion_r222169458 --- Diff: external/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala --- @@ -342,6 +342,53 @@ class AvroSuite extends QueryTest with Shared

[GitHub] spark pull request #22611: [SPARK-25595] Ignore corrupt Avro files if flag I...

2018-10-02 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22611#discussion_r222169616 --- Diff: external/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala --- @@ -342,6 +342,53 @@ class AvroSuite extends QueryTest with Shared

[GitHub] spark issue #22610: [WIP][SPARK-25461][PySpark][SQL] Print warning when retu...

2018-10-02 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22610 > he only other idea I have is to provide an option to raise an error if the type needs to be cast. Actually sounds good to me. I think the problem is we are not quite clear abo

[GitHub] spark pull request #22610: [WIP][SPARK-25461][PySpark][SQL] Print warning wh...

2018-10-02 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22610#discussion_r222173421 --- Diff: python/pyspark/worker.py --- @@ -84,13 +84,36 @@ def wrap_scalar_pandas_udf(f, return_type): arrow_return_type = to_arrow_type(return_

[GitHub] spark pull request #22610: [WIP][SPARK-25461][PySpark][SQL] Print warning wh...

2018-10-02 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/22610#discussion_r222173904 --- Diff: python/pyspark/worker.py --- @@ -84,13 +84,36 @@ def wrap_scalar_pandas_udf(f, return_type): arrow_return_type = to_arrow_type(return_type)

[GitHub] spark issue #22488: [SPARK-25479][TEST] Refactor DatasetBenchmark to use mai...

2018-10-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22488 **[Test build #96880 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96880/testReport)** for PR 22488 at commit [`27c6493`](https://github.com/apache/spark/commit/2

[GitHub] spark issue #22488: [SPARK-25479][TEST] Refactor DatasetBenchmark to use mai...

2018-10-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22488 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96880/ Test PASSed. ---

[GitHub] spark issue #22488: [SPARK-25479][TEST] Refactor DatasetBenchmark to use mai...

2018-10-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22488 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22500: [SPARK-25488][TEST] Refactor MiscBenchmark to use main m...

2018-10-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22500 **[Test build #96882 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96882/testReport)** for PR 22500 at commit [`c791249`](https://github.com/apache/spark/commit/c

[GitHub] spark issue #22500: [SPARK-25488][TEST] Refactor MiscBenchmark to use main m...

2018-10-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22500 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22339: [SPARK-17159][STREAM] Significant speed up for running s...

2018-10-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22339 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3647/

[GitHub] spark issue #22500: [SPARK-25488][TEST] Refactor MiscBenchmark to use main m...

2018-10-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22500 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96882/ Test FAILed. ---

[GitHub] spark issue #22339: [SPARK-17159][STREAM] Significant speed up for running s...

2018-10-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22339 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22339: [SPARK-17159][STREAM] Significant speed up for running s...

2018-10-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22339 **[Test build #96885 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96885/testReport)** for PR 22339 at commit [`542872c`](https://github.com/apache/spark/commit/54

[GitHub] spark issue #22339: [SPARK-17159][STREAM] Significant speed up for running s...

2018-10-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22339 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3648/

[GitHub] spark issue #22339: [SPARK-17159][STREAM] Significant speed up for running s...

2018-10-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22339 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22339: [SPARK-17159][STREAM] Significant speed up for running s...

2018-10-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22339 **[Test build #96886 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96886/testReport)** for PR 22339 at commit [`dab9bf3`](https://github.com/apache/spark/commit/da

[GitHub] spark issue #22339: [SPARK-17159][STREAM] Significant speed up for running s...

2018-10-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22339 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96886/ Test FAILed. ---

[GitHub] spark issue #22339: [SPARK-17159][STREAM] Significant speed up for running s...

2018-10-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22339 **[Test build #96886 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96886/testReport)** for PR 22339 at commit [`dab9bf3`](https://github.com/apache/spark/commit/d

[GitHub] spark issue #22339: [SPARK-17159][STREAM] Significant speed up for running s...

2018-10-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22339 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22339: [SPARK-17159][STREAM] Significant speed up for running s...

2018-10-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22339 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3649/

[GitHub] spark issue #22339: [SPARK-17159][STREAM] Significant speed up for running s...

2018-10-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22339 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22339: [SPARK-17159][STREAM] Significant speed up for running s...

2018-10-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22339 **[Test build #96887 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96887/testReport)** for PR 22339 at commit [`d91c815`](https://github.com/apache/spark/commit/d9

[GitHub] spark issue #22619: [SQL][MINOR] Make use of TypeCoercion.findTightestCommon...

2018-10-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22619 **[Test build #96881 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96881/testReport)** for PR 22619 at commit [`d4e0bdb`](https://github.com/apache/spark/commit/d

[GitHub] spark issue #22619: [SQL][MINOR] Make use of TypeCoercion.findTightestCommon...

2018-10-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22619 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96881/ Test PASSed. ---

[GitHub] spark issue #22619: [SQL][MINOR] Make use of TypeCoercion.findTightestCommon...

2018-10-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22619 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22619: [SQL][MINOR] Make use of TypeCoercion.findTightestCommon...

2018-10-02 Thread dilipbiswal
Github user dilipbiswal commented on the issue: https://github.com/apache/spark/pull/22619 cc @HyukjinKwon @MaxGekk --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22500: [SPARK-25488][TEST] Refactor MiscBenchmark to use main m...

2018-10-02 Thread wangyum
Github user wangyum commented on the issue: https://github.com/apache/spark/pull/22500 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h.

[GitHub] spark issue #22500: [SPARK-25488][TEST] Refactor MiscBenchmark to use main m...

2018-10-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22500 **[Test build #96888 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96888/testReport)** for PR 22500 at commit [`c791249`](https://github.com/apache/spark/commit/c7

[GitHub] spark issue #22500: [SPARK-25488][TEST] Refactor MiscBenchmark to use main m...

2018-10-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22500 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22500: [SPARK-25488][TEST] Refactor MiscBenchmark to use main m...

2018-10-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22500 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3650/

[GitHub] spark issue #22491: [SPARK-25483][TEST] Refactor UnsafeArrayDataBenchmark to...

2018-10-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22491 **[Test build #96883 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96883/testReport)** for PR 22491 at commit [`4b69423`](https://github.com/apache/spark/commit/4

[GitHub] spark issue #22491: [SPARK-25483][TEST] Refactor UnsafeArrayDataBenchmark to...

2018-10-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22491 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22491: [SPARK-25483][TEST] Refactor UnsafeArrayDataBenchmark to...

2018-10-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22491 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96883/ Test PASSed. ---

[GitHub] spark pull request #22527: [SPARK-17952][SQL] Nested Java beans support in c...

2018-10-02 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/22527#discussion_r222185482 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala --- @@ -1098,16 +1098,24 @@ object SQLContext { data: Iterator[_],

[GitHub] spark pull request #22527: [SPARK-17952][SQL] Nested Java beans support in c...

2018-10-02 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/22527#discussion_r222183494 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala --- @@ -1098,16 +1098,24 @@ object SQLContext { data: Iterator[_],

[GitHub] spark issue #22339: [SPARK-17159][STREAM] Significant speed up for running s...

2018-10-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22339 **[Test build #96885 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96885/testReport)** for PR 22339 at commit [`542872c`](https://github.com/apache/spark/commit/5

[GitHub] spark issue #22339: [SPARK-17159][STREAM] Significant speed up for running s...

2018-10-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22339 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96885/ Test PASSed. ---

[GitHub] spark issue #22339: [SPARK-17159][STREAM] Significant speed up for running s...

2018-10-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22339 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark pull request #22614: [SPARK-25561][SQL] HiveClient.getPartitionsByFilt...

2018-10-02 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/22614#discussion_r222190138 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala --- @@ -746,34 +746,20 @@ private[client] class Shim_v0_13 extends Shim

[GitHub] spark issue #22619: [SQL][MINOR] Make use of TypeCoercion.findTightestCommon...

2018-10-02 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/22619 Any behavior change? Test cases? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark issue #22339: [SPARK-17159][STREAM] Significant speed up for running s...

2018-10-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22339 **[Test build #96887 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96887/testReport)** for PR 22339 at commit [`d91c815`](https://github.com/apache/spark/commit/d

[GitHub] spark issue #22339: [SPARK-17159][STREAM] Significant speed up for running s...

2018-10-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22339 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22619: [SQL][MINOR] Make use of TypeCoercion.findTightestCommon...

2018-10-02 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/22619 Maybe this is related to #22448. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mai

[GitHub] spark issue #22339: [SPARK-17159][STREAM] Significant speed up for running s...

2018-10-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22339 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96887/ Test PASSed. ---

[GitHub] spark issue #22619: [SQL][MINOR] Make use of TypeCoercion.findTightestCommon...

2018-10-02 Thread dilipbiswal
Github user dilipbiswal commented on the issue: https://github.com/apache/spark/pull/22619 @gatorsmile There should not be any behaviour change. I was thinking that existing test cases should suffice. Basically we used to duplicate the code of TypeCoercion.findTightestCommonType in he

[GitHub] spark issue #22448: [SPARK-25417][SQL] Improve findTightestCommonType to coe...

2018-10-02 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22448 > Do you know the reason for it ? Because there was a behaviour change IIRC when I looked into that code before. --- --

[GitHub] spark issue #22619: [SQL][MINOR] Make use of TypeCoercion.findTightestCommon...

2018-10-02 Thread dilipbiswal
Github user dilipbiswal commented on the issue: https://github.com/apache/spark/pull/22619 @ueshin > Maybe this is related to #22448. Yeah.. Actually @MaxGekk had pointed me to the presence of duplicate code in one of his comment. I was trying to address it in here. --- ---

[GitHub] spark pull request #22619: [SQL][MINOR] Make use of TypeCoercion.findTightes...

2018-10-02 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22619#discussion_r222194957 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVInferSchema.scala --- @@ -172,51 +172,35 @@ private[csv] object CSV

[GitHub] spark pull request #22619: [SQL][MINOR] Make use of TypeCoercion.findTightes...

2018-10-02 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/22619#discussion_r222195632 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVInferSchema.scala --- @@ -172,51 +172,35 @@ private[csv] object CSV

[GitHub] spark issue #22448: [SPARK-25417][SQL] Improve findTightestCommonType to coe...

2018-10-02 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22448 Looks now we are able to deduplicate it now. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additiona

[GitHub] spark issue #22448: [SPARK-25417][SQL] Improve findTightestCommonType to coe...

2018-10-02 Thread dilipbiswal
Github user dilipbiswal commented on the issue: https://github.com/apache/spark/pull/22448 @HyukjinKwon Thanks for checking it out. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional co

[GitHub] spark pull request #22619: [SQL][MINOR] Make use of TypeCoercion.findTightes...

2018-10-02 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22619#discussion_r222197242 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVInferSchema.scala --- @@ -172,51 +172,35 @@ private[csv] object CSV

[GitHub] spark pull request #22619: [SQL][MINOR] Make use of TypeCoercion.findTightes...

2018-10-02 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22619#discussion_r222197363 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVInferSchema.scala --- @@ -172,51 +172,35 @@ private[csv] object CSV

[GitHub] spark issue #22619: [SQL][MINOR] Make use of TypeCoercion.findTightestCommon...

2018-10-02 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22619 Looks okay - I checked a case one by one but it needs another look. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.a

[GitHub] spark issue #22619: [SQL][MINOR] Make use of TypeCoercion.findTightestCommon...

2018-10-02 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22619 Let's just file a JIRA @dilipbiswal BTW. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional co

[GitHub] spark issue #22619: [SQL][MINOR] Make use of TypeCoercion.findTightestCommon...

2018-10-02 Thread dilipbiswal
Github user dilipbiswal commented on the issue: https://github.com/apache/spark/pull/22619 @HyukjinKwon Okay. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: review

[GitHub] spark pull request #22619: [SQL][MINOR] Make use of TypeCoercion.findTightes...

2018-10-02 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/22619#discussion_r222198257 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVInferSchema.scala --- @@ -172,51 +172,35 @@ private[csv] object CSVInfer

[GitHub] spark pull request #22619: [SQL][MINOR] Make use of TypeCoercion.findTightes...

2018-10-02 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/22619#discussion_r222198383 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVInferSchema.scala --- @@ -172,51 +172,35 @@ private[csv] object CSVInfer

[GitHub] spark pull request #22619: [SQL][MINOR] Make use of TypeCoercion.findTightes...

2018-10-02 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/22619#discussion_r222198591 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVInferSchema.scala --- @@ -172,51 +172,35 @@ private[csv] object CSV

[GitHub] spark pull request #22619: [SQL][MINOR] Make use of TypeCoercion.findTightes...

2018-10-02 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/22619#discussion_r222198784 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVInferSchema.scala --- @@ -172,51 +172,35 @@ private[csv] object CSV

[GitHub] spark pull request #22619: [SQL][MINOR] Make use of TypeCoercion.findTightes...

2018-10-02 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/22619#discussion_r222199535 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVInferSchema.scala --- @@ -172,51 +172,35 @@ private[csv] object CSV

[GitHub] spark pull request #22619: [SQL][MINOR] Make use of TypeCoercion.findTightes...

2018-10-02 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/22619#discussion_r00361 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVInferSchema.scala --- @@ -172,51 +172,35 @@ private[csv] object CSVInfer

[GitHub] spark pull request #22619: [SQL][MINOR] Make use of TypeCoercion.findTightes...

2018-10-02 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22619#discussion_r00750 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVInferSchema.scala --- @@ -172,51 +172,35 @@ private[csv] object CSV

<    1   2   3   4   5