Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22237
thanks, merging to master!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21860
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97970/
Test PASSed.
---
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22754#discussion_r227729436
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -495,8 +495,8 @@ package object config {
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22749
LGTM except 2 minor comments
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22814
**[Test build #97973 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97973/testReport)**
for PR 22814 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22814
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22814
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22730
adding @cloud-fan since accumulator version 2 was added by you.
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22749
**[Test build #97967 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97967/testReport)**
for PR 22749 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22749
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22237
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22804
**[Test build #97972 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97972/testReport)**
for PR 22804 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22749
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22749
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22512
**[Test build #97974 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97974/testReport)**
for PR 22512 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22512
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22512
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21860
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21860
**[Test build #97970 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97970/testReport)**
for PR 21860 at commit
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22807#discussion_r227784077
--- Diff: python/pyspark/sql/tests.py ---
@@ -4961,6 +4961,31 @@ def foofoo(x, y):
).collect
)
+def
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22814
**[Test build #97973 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97973/testReport)**
for PR 22814 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22144
Adding it as a known issue sounds reasonable to me as well.
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22598
**[Test build #97976 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97976/testReport)**
for PR 22598 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22749#discussion_r227742062
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/ScalaReflectionSuite.scala
---
@@ -351,11 +347,15 @@ class ScalaReflectionSuite
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22749#discussion_r227745900
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/ScalaReflectionSuite.scala
---
@@ -351,11 +347,15 @@ class ScalaReflectionSuite extends
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22794
Thanks @mgaido91 Changed to `sqlContext.sessionState.catalog` to obtain
table names now.
---
-
To unsubscribe, e-mail:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22749#discussion_r227796616
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/ScalaReflectionSuite.scala
---
@@ -280,59 +281,59 @@ class ScalaReflectionSuite extends
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22144
@tgravescs yes, I didn't say it was normal or good, but that it's not
forbidden. Ex: no more Java 7 support in Spark 2.3. The point was: if this
change were on purpose, then no it's not a
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22812
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22812
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97965/
Test PASSed.
---
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22749#discussion_r227739775
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoder.scala
---
@@ -212,21 +181,90 @@ object ExpressionEncoder
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22749#discussion_r227783724
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/ScalaReflectionSuite.scala
---
@@ -280,59 +281,59 @@ class ScalaReflectionSuite
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19788
**[Test build #97975 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97975/testReport)**
for PR 19788 at commit
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/22144
while I'm ok with not blocking 2.4 for this as well, not for many of the
reasons stated though. Note the jira was filed a Major not a blocker. Based on
the information we have, the impact on the
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22794
cc @gatorsmile @srowen @dongjoon-hyun
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22749
**[Test build #97971 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97971/testReport)**
for PR 22749 at commit
Github user bsikander commented on the issue:
https://github.com/apache/spark/pull/21816
@srowen Can you have another look?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22814
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97973/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22814
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
GitHub user gengliangwang opened a pull request:
https://github.com/apache/spark/pull/22814
[WIP][SPARK-25819][SQL] Support parse mode option for the function
`from_avro`
## What changes were proposed in this pull request?
Current the function `from_avro` throws exception
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/22814#discussion_r227755767
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -60,9 +60,11 @@ trait
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22749
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97969/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22749
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22749
**[Test build #97969 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97969/testReport)**
for PR 22749 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22804
**[Test build #97972 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97972/testReport)**
for PR 22804 at commit
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22749#discussion_r227797378
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/ScalaReflectionSuite.scala
---
@@ -280,59 +281,59 @@ class ScalaReflectionSuite extends
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22749
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97967/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22237
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97966/
Test PASSed.
---
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22237
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22754#discussion_r227780781
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -495,8 +495,8 @@ package object config {
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22804
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22804
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97972/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22814
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22814
**[Test build #97978 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97978/testReport)**
for PR 22814 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22814
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21642
**[Test build #4393 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4393/testReport)**
for PR 21642 at commit
Github user rvesse commented on a diff in the pull request:
https://github.com/apache/spark/pull/22805#discussion_r227833846
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/backend/docker/DockerForDesktopBackend.scala
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22730
Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19433
**[Test build #97977 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97977/testReport)**
for PR 19433 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19433
Build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19433
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97977/
Test FAILed.
---
Github user rvesse commented on a diff in the pull request:
https://github.com/apache/spark/pull/22805#discussion_r227835021
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/backend/docker/DockerForDesktopBackend.scala
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22512
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22512
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97974/
Test FAILed.
---
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22794
cc @srinathshankar
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22794#discussion_r227872504
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkGetTablesOperation.scala
---
@@ -0,0 +1,121 @@
+/*
+
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22815
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22815
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/22795#discussion_r227875311
--- Diff: python/pyspark/sql/functions.py ---
@@ -3023,6 +3023,42 @@ def pandas_udf(f=None, returnType=None,
functionType=None):
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22730
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22749
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22749
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97971/
Test PASSed.
---
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22144
@tgravescs please quote my full comment instead of part of it.
> After all, this is a bug and a regression from previous releases, like
other 1000 we've fixed before.
The point I
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22504
**[Test build #4394 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4394/testReport)**
for PR 22504 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22794#discussion_r227869218
--- Diff:
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala
---
@@ -644,6 +644,47 @@ class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22794
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/22813
IIUC it's not expected to share the SPARK_WORK_DIR with any other usage.
---
-
To unsubscribe, e-mail:
Github user squito commented on the issue:
https://github.com/apache/spark/pull/22504
known test failure addressed here:
https://github.com/apache/spark/pull/22808
---
-
To unsubscribe, e-mail:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22749#discussion_r227867735
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/ScalaReflectionSuite.scala
---
@@ -280,59 +281,59 @@ class ScalaReflectionSuite
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22723
I don't think that's necessarily true. This forces the default to be the
minimum, which is a behavior change and not obviously what the user wants.
---
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18390
If the label-specific metrics are already exposed in the multiclass metrics
output, why do we need this too?
---
-
To
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22815
**[Test build #97981 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97981/testReport)**
for PR 22815 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22729
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22729
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22794
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22794
**[Test build #97980 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97980/testReport)**
for PR 22794 at commit
Github user rvesse commented on the issue:
https://github.com/apache/spark/pull/22805
@ifilonenko I have done the generalisation today since it was fairly
trivial and it actually resolves a number of concerns about the first pass
implementation
@skonto I have restored the
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22794
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22794
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97980/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22794
**[Test build #97980 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97980/testReport)**
for PR 22794 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22730
A late LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/22144
@cloud-fan
I agree with you that most issues do not have to block a release but I
don't agree with most of your criteria for making that decision. I've already
talked about the other
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22729#discussion_r227818211
--- Diff: project/MimaExcludes.scala ---
@@ -55,9 +59,12 @@ object MimaExcludes {
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22729
**[Test build #97979 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97979/testReport)**
for PR 22729 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21816
**[Test build #4392 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4392/testReport)**
for PR 21816 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22749
**[Test build #97971 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97971/testReport)**
for PR 22749 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22794#discussion_r227872346
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkGetTablesOperation.scala
---
@@ -0,0 +1,121 @@
+/*
+
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22814
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22814
**[Test build #97978 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97978/testReport)**
for PR 22814 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22814
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97978/
Test FAILed.
---
1 - 100 of 395 matches
Mail list logo
