Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23127
**[Test build #99275 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99275/testReport)**
for PR 23127 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23124
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/23123
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23138
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23088#discussion_r236236422
--- Diff: core/src/main/scala/org/apache/spark/status/AppStatusStore.scala
---
@@ -222,29 +223,20 @@ private[spark] class AppStatusStore(
val
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23138
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99272/
Test PASSed.
---
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/21412
Agree, this PR should be closed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23144
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/23124#discussion_r236275822
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -546,33 +546,29 @@ case class
Github user chermenin closed the pull request at:
https://github.com/apache/spark/pull/21412
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21688
**[Test build #4442 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4442/testReport)**
for PR 21688 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23126
Is there a simple test case you can add to cover that too? that would
really prove this change.
---
-
To unsubscribe, e-mail:
Github user juliuszsompolski commented on the issue:
https://github.com/apache/spark/pull/23127
@cloud-fan @rednaxelafx
Actually, the input to a codegen stage can be an internal row so I can't
make the inputRDD be `RDD[UnsafeRow], but the output needs to be UnsafeRow.
Doing it
Github user KyleLi1985 commented on the issue:
https://github.com/apache/spark/pull/23126
Ok, I will do it later
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23142
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99268/
Test PASSed.
---
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23130#discussion_r236226380
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
---
@@ -388,7 +388,7 @@ case class FileSourceScanExec(
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23139
**[Test build #99270 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99270/testReport)**
for PR 23139 at commit
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/23130#discussion_r236233074
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
---
@@ -388,7 +388,7 @@ case class FileSourceScanExec(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/23143#discussion_r236267692
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoder.scala
---
@@ -251,19 +251,15 @@ case class
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/21688
Test this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user KyleLi1985 commented on the issue:
https://github.com/apache/spark/pull/23126
Um, the unit test in spark indeed cover both case. But there is function
closeToZero to handle accuracy problem, so..
---
-
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23127
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/23123
Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23138
**[Test build #99272 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99272/testReport)**
for PR 23138 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23143
**[Test build #99273 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99273/testReport)**
for PR 23143 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23144
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23144
**[Test build #99274 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99274/testReport)**
for PR 23144 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23127
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23139
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23139
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99270/
Test PASSed.
---
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22991#discussion_r236230624
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala ---
@@ -209,6 +215,9 @@ final class OneVsRestModel private[ml] (
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22163
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99271/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22163
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user KyleLi1985 commented on the issue:
https://github.com/apache/spark/pull/23126
It would be better, update the commit
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/23124#discussion_r236282401
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ArrayBasedMapBuilder.scala
---
@@ -0,0 +1,118 @@
+/*
+ * Licensed to
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23126
**[Test build #4441 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4441/testReport)**
for PR 23126 at commit
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/23143#discussion_r236295606
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoder.scala
---
@@ -251,19 +251,15 @@ case class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23145
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23117
Hey @shaneknapp, have you found some time to take a look for this?
---
-
To unsubscribe, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23055
Let me get this in in few days if there are no more comments.
---
-
To unsubscribe, e-mail:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/23138#discussion_r236334056
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/SetOperationSuite.scala
---
@@ -196,4 +196,31 @@ class SetOperationSuite
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23143
**[Test build #99277 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99277/testReport)**
for PR 23143 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23145
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23145
It's okay but mind taking another look the documentation and fix other
typos while we are here? I'm pretty sure there are more.
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/23055
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23055
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user kjmrknsn commented on the issue:
https://github.com/apache/spark/pull/23145
OK, I'll check the whole documentation later. Thanks.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23146
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23146
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/23127#discussion_r236332511
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -406,14 +415,62 @@ trait BlockingOperatorWithCodegen
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/23141
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
GitHub user kjmrknsn opened a pull request:
https://github.com/apache/spark/pull/23145
[MINOR][Docs] "a R interpreter" -> "an R interpreter"
## What changes were proposed in this pull request?
This PR changes the phrase of `a R interpreter` to `an R interpreter` on
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23145
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23055
**[Test build #99278 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99278/testReport)**
for PR 23055 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22939
Hey @felixcheung, have you found some time to take a look for this please?
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23055
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
GitHub user elfausto opened a pull request:
https://github.com/apache/spark/pull/23146
[SPARK-26173] [MLlib] Prior regularization for Logistic Regression
Implementation of
[SPARK-26173](https://issues.apache.org/jira/browse/SPARK-26173).
Unit tests have been added to the
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23141
**[Test build #99279 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99279/testReport)**
for PR 23141 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23146
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23141
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/23127#discussion_r236332786
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -406,14 +415,62 @@ trait BlockingOperatorWithCodegen
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23124
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23124
**[Test build #99276 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99276/testReport)**
for PR 23124 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23143
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23143
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23141
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/23127#discussion_r236333530
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -406,14 +415,62 @@ trait BlockingOperatorWithCodegen
Github user markpavey commented on a diff in the pull request:
https://github.com/apache/spark/pull/23102#discussion_r236340228
--- Diff: core/src/main/scala/org/apache/spark/deploy/DependencyUtils.scala
---
@@ -65,7 +65,7 @@ private[deploy] object DependencyUtils extends Logging
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23127
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23127
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23127
**[Test build #99286 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99286/testReport)**
for PR 23127 at commit
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/21688
+1 , going to merge to master
There are a few followup jiras on this.
1) make the timeline visualization better:
https://issues.apache.org/jira/browse/SPARK-26130
2) improve
Github user squito commented on the issue:
https://github.com/apache/spark/pull/23058
lgtm
I looked more into the lifecycle of the buffers and when they get
`disposed`, and it looks fine to me. (In fact I think there is no need for the
`dispose` in the first place, as
Github user squito commented on the issue:
https://github.com/apache/spark/pull/23109
lte review, but lgtm anyway
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21688
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user shahidki31 commented on a diff in the pull request:
https://github.com/apache/spark/pull/23088#discussion_r236409557
--- Diff: core/src/main/scala/org/apache/spark/status/AppStatusStore.scala
---
@@ -222,29 +223,20 @@ private[spark] class AppStatusStore(
val
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23088
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user squito commented on the issue:
https://github.com/apache/spark/pull/23111
wow, thats great! glad there is a big speedup.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user shahidki31 commented on a diff in the pull request:
https://github.com/apache/spark/pull/23088#discussion_r236409661
--- Diff: core/src/main/scala/org/apache/spark/status/AppStatusStore.scala
---
@@ -222,29 +223,20 @@ private[spark] class AppStatusStore(
val
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23088
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/23100#discussion_r236410306
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/OneHotEncoder.scala ---
@@ -17,126 +17,512 @@
package org.apache.spark.ml.feature
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/23100#discussion_r236410750
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/OneHotEncoder.scala ---
@@ -17,126 +17,512 @@
package org.apache.spark.ml.feature
GitHub user koeninger opened a pull request:
https://github.com/apache/spark/pull/23148
[SPARK-26177] Automated formatting for Scala code
## What changes were proposed in this pull request?
Add a maven plugin and wrapper script at ./dev/scalafmt to use scalafmt to
format
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23148
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99288/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23148
**[Test build #99288 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99288/testReport)**
for PR 23148 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23148
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23141
**[Test build #99279 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99279/testReport)**
for PR 23141 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23141
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99279/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23141
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/23088#discussion_r236398604
--- Diff:
core/src/test/scala/org/apache/spark/status/AppStatusStoreSuite.scala ---
@@ -95,10 +123,18 @@ class AppStatusStoreSuite extends SparkFunSuite {
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23088#discussion_r236405278
--- Diff: core/src/main/scala/org/apache/spark/status/AppStatusStore.scala
---
@@ -222,29 +223,20 @@ private[spark] class AppStatusStore(
val
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23055
**[Test build #99278 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99278/testReport)**
for PR 23055 at commit
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/23088#discussion_r236405732
--- Diff: core/src/main/scala/org/apache/spark/status/AppStatusStore.scala
---
@@ -222,29 +223,20 @@ private[spark] class AppStatusStore(
val
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23055
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99278/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23055
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23088
**[Test build #99287 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99287/testReport)**
for PR 23088 at commit
Github user squito commented on the issue:
https://github.com/apache/spark/pull/23111
we might need to be careful that this doesn't un-intentionally overload the
jenkins workers so that we end up hitting more timeouts from too many things
running concurrently (I dunno how isolated
Github user shahidki31 commented on a diff in the pull request:
https://github.com/apache/spark/pull/23088#discussion_r236409746
--- Diff:
core/src/test/scala/org/apache/spark/status/AppStatusStoreSuite.scala ---
@@ -95,10 +123,18 @@ class AppStatusStoreSuite extends SparkFunSuite
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23088
**[Test build #99289 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99289/testReport)**
for PR 23088 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23088
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
201 - 300 of 496 matches
Mail list logo
