[GitHub] [spark] maropu commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value
maropu commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value URL: https://github.com/apache/spark/pull/27024#issuecomment-569395977 Yea, I think this behaivour is weird, but we just follow the hive behviour; https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala#L948-L950 We are planning to support ansi-compatible type coercion, so I think this issue will be resolved if that supported. cc: @gengliangwang @cloud-fan This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] 07ARB edited a comment on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value
07ARB edited a comment on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value URL: https://github.com/apache/spark/pull/27024#issuecomment-569395593 yes , we need to discuss whether we need to handle or not. but what i feel, we should show error message, so that end user will get some meaningful information. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] 07ARB commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value
07ARB commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value URL: https://github.com/apache/spark/pull/27024#issuecomment-569395593 yes , we need to discuss whether we need to handle or not. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] maropu commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value
maropu commented on issue #27024: [SPARK-29854]lpad and rpad built in function
should throw Error or Exception for invalid length value
URL: https://github.com/apache/spark/pull/27024#issuecomment-569395503
But, there are many functions having the same behaivour? e.g.,
```
scala> sql("SELECT substring_index('www.apache.org', '.', 'Must be
integer')").show()
++
|substring_index(www.apache.org, ., CAST(Must be integer AS INT))|
++
|null|
++
```
Actually, implicit casts do so.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value
SparkQA commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value URL: https://github.com/apache/spark/pull/27024#issuecomment-569395415 **[Test build #115885 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115885/testReport)** for PR 27024 at commit [`2793ac6`](https://github.com/apache/spark/commit/2793ac6cf38f32ce8a7b12a6edcc23a65ff3cff3). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27027: [SPARK-30370][SQL] Update SqlBase.g4 to combine namespace and database tokens.
AmplabJenkins removed a comment on issue #27027: [SPARK-30370][SQL] Update SqlBase.g4 to combine namespace and database tokens. URL: https://github.com/apache/spark/pull/27027#issuecomment-569395268 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27027: [SPARK-30370][SQL] Update SqlBase.g4 to combine namespace and database tokens.
AmplabJenkins removed a comment on issue #27027: [SPARK-30370][SQL] Update SqlBase.g4 to combine namespace and database tokens. URL: https://github.com/apache/spark/pull/27027#issuecomment-569395270 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115881/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27027: [SPARK-30370][SQL] Update SqlBase.g4 to combine namespace and database tokens.
SparkQA removed a comment on issue #27027: [SPARK-30370][SQL] Update SqlBase.g4 to combine namespace and database tokens. URL: https://github.com/apache/spark/pull/27027#issuecomment-569381488 **[Test build #115881 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115881/testReport)** for PR 27027 at commit [`0931abd`](https://github.com/apache/spark/commit/0931abd526332c6093ddecb866eb92a66534e3c8). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27027: [SPARK-30370][SQL] Update SqlBase.g4 to combine namespace and database tokens.
AmplabJenkins commented on issue #27027: [SPARK-30370][SQL] Update SqlBase.g4 to combine namespace and database tokens. URL: https://github.com/apache/spark/pull/27027#issuecomment-569395268 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27027: [SPARK-30370][SQL] Update SqlBase.g4 to combine namespace and database tokens.
AmplabJenkins commented on issue #27027: [SPARK-30370][SQL] Update SqlBase.g4 to combine namespace and database tokens. URL: https://github.com/apache/spark/pull/27027#issuecomment-569395270 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115881/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27027: [SPARK-30370][SQL] Update SqlBase.g4 to combine namespace and database tokens.
SparkQA commented on issue #27027: [SPARK-30370][SQL] Update SqlBase.g4 to combine namespace and database tokens. URL: https://github.com/apache/spark/pull/27027#issuecomment-569395194 **[Test build #115881 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115881/testReport)** for PR 27027 at commit [`0931abd`](https://github.com/apache/spark/commit/0931abd526332c6093ddecb866eb92a66534e3c8). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value
AmplabJenkins removed a comment on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value URL: https://github.com/apache/spark/pull/27024#issuecomment-569395028 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20675/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value
AmplabJenkins removed a comment on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value URL: https://github.com/apache/spark/pull/27024#issuecomment-569395026 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value
AmplabJenkins commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value URL: https://github.com/apache/spark/pull/27024#issuecomment-569395026 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value
AmplabJenkins commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value URL: https://github.com/apache/spark/pull/27024#issuecomment-569395028 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20675/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] 07ARB commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value
07ARB commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value URL: https://github.com/apache/spark/pull/27024#issuecomment-569395064 @maropu , Thank you This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value
AmplabJenkins removed a comment on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value URL: https://github.com/apache/spark/pull/27024#issuecomment-569246559 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] maropu commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value
maropu commented on issue #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value URL: https://github.com/apache/spark/pull/27024#issuecomment-569394962 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] gatorsmile commented on a change in pull request #26361: [SPARK-29630][SQL] Disallow creating a permanent view that references a temporary view in an expression
gatorsmile commented on a change in pull request #26361: [SPARK-29630][SQL] Disallow creating a permanent view that references a temporary view in an expression URL: https://github.com/apache/spark/pull/26361#discussion_r361781389 ## File path: sql/core/src/test/resources/sql-tests/results/postgreSQL/create_view.sql.out ## @@ -803,61 +806,77 @@ Not allowed to create a permanent view `temporal4` by referencing a temporary vi -- !query 71 -CREATE TABLE tbl1 ( a int, b int) using parquet +CREATE VIEW temporal5 AS SELECT * FROM t1 WHERE num IN (SELECT num FROM t1 WHERE EXISTS (SELECT 1 FROM tt)) -- !query 71 schema struct<> -- !query 71 output - +org.apache.spark.sql.AnalysisException +Not allowed to create a permanent view `temporal5` by referencing a temporary view `tt`; Review comment: Permanent views can also reference to tables. There exists a general issue in our existing error messages. We do not have a message reference book. When users hit the unclear error messages, what they can do is to read the source code or try different options until it works. This is not natural to end users who have zero background about Spark SQL. We need to correct them one by one. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26589: [SPARK-29947][SQL] Improve ResolveRelations performance
SparkQA commented on issue #26589: [SPARK-29947][SQL] Improve ResolveRelations performance URL: https://github.com/apache/spark/pull/26589#issuecomment-569393423 **[Test build #115884 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115884/testReport)** for PR 26589 at commit [`07e6b7f`](https://github.com/apache/spark/commit/07e6b7f7529f07a73dae9baede5e2046a18e35bc). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26589: [SPARK-29947][SQL] Improve ResolveRelations performance
AmplabJenkins commented on issue #26589: [SPARK-29947][SQL] Improve ResolveRelations performance URL: https://github.com/apache/spark/pull/26589#issuecomment-569392890 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20674/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26589: [SPARK-29947][SQL] Improve ResolveRelations performance
AmplabJenkins commented on issue #26589: [SPARK-29947][SQL] Improve ResolveRelations performance URL: https://github.com/apache/spark/pull/26589#issuecomment-569392885 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26589: [SPARK-29947][SQL] Improve ResolveRelations performance
AmplabJenkins removed a comment on issue #26589: [SPARK-29947][SQL] Improve ResolveRelations performance URL: https://github.com/apache/spark/pull/26589#issuecomment-569392890 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20674/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26589: [SPARK-29947][SQL] Improve ResolveRelations performance
AmplabJenkins removed a comment on issue #26589: [SPARK-29947][SQL] Improve ResolveRelations performance URL: https://github.com/apache/spark/pull/26589#issuecomment-569392885 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] wangyum commented on a change in pull request #26589: [SPARK-29947][SQL] Improve ResolveRelations performance
wangyum commented on a change in pull request #26589: [SPARK-29947][SQL]
Improve ResolveRelations performance
URL: https://github.com/apache/spark/pull/26589#discussion_r361780484
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##
@@ -847,21 +847,32 @@ class Analyzer(
case _ => plan
}
-def apply(plan: LogicalPlan): LogicalPlan =
ResolveTempViews(plan).resolveOperatorsUp {
- case i @ InsertIntoStatement(table, _, _, _, _) if i.query.resolved =>
-val relation = table match {
- case u @ UnresolvedRelation(SessionCatalogAndIdentifier(catalog,
ident)) =>
-lookupRelation(catalog, ident, recurse = false).getOrElse(u)
- case other => other
-}
+def apply(plan: LogicalPlan): LogicalPlan = {
+ var logicalPlans = Map.empty[UnresolvedRelation, LogicalPlan]
Review comment:
Added comment to doc:
https://github.com/apache/spark/blob/07e6b7f7529f07a73dae9baede5e2046a18e35bc/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala#L94-L96
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] wangyum commented on a change in pull request #26589: [SPARK-29947][SQL] Improve ResolveRelations performance
wangyum commented on a change in pull request #26589: [SPARK-29947][SQL]
Improve ResolveRelations performance
URL: https://github.com/apache/spark/pull/26589#discussion_r361780484
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##
@@ -847,21 +847,32 @@ class Analyzer(
case _ => plan
}
-def apply(plan: LogicalPlan): LogicalPlan =
ResolveTempViews(plan).resolveOperatorsUp {
- case i @ InsertIntoStatement(table, _, _, _, _) if i.query.resolved =>
-val relation = table match {
- case u @ UnresolvedRelation(SessionCatalogAndIdentifier(catalog,
ident)) =>
-lookupRelation(catalog, ident, recurse = false).getOrElse(u)
- case other => other
-}
+def apply(plan: LogicalPlan): LogicalPlan = {
+ var logicalPlans = Map.empty[UnresolvedRelation, LogicalPlan]
Review comment:
Add comment to doc:
https://github.com/apache/spark/blob/07e6b7f7529f07a73dae9baede5e2046a18e35bc/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala#L94-L96
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] 07ARB commented on issue #26477: [SPARK-29776][SQL] rpad and lpad should return NULL when padstring parameter is empty
07ARB commented on issue #26477: [SPARK-29776][SQL] rpad and lpad should return NULL when padstring parameter is empty URL: https://github.com/apache/spark/pull/26477#issuecomment-569389259 Thank you all, for such a good discussion, If we are not finding strong reason to change old behaviours, then we can close this PR. One more issue related to Lpad/Rpad, please review https://github.com/apache/spark/pull/27024 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec
AmplabJenkins removed a comment on issue #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec URL: https://github.com/apache/spark/pull/27019#issuecomment-569389142 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115878/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec
AmplabJenkins removed a comment on issue #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec URL: https://github.com/apache/spark/pull/27019#issuecomment-569389139 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec
AmplabJenkins commented on issue #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec URL: https://github.com/apache/spark/pull/27019#issuecomment-569389139 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec
AmplabJenkins commented on issue #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec URL: https://github.com/apache/spark/pull/27019#issuecomment-569389142 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115878/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27008: [SPARK-30353][SQL] Add IsNotNull check in SimplifyBinaryComparison optimization
AmplabJenkins removed a comment on issue #27008: [SPARK-30353][SQL] Add IsNotNull check in SimplifyBinaryComparison optimization URL: https://github.com/apache/spark/pull/27008#issuecomment-569389011 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27008: [SPARK-30353][SQL] Add IsNotNull check in SimplifyBinaryComparison optimization
AmplabJenkins removed a comment on issue #27008: [SPARK-30353][SQL] Add IsNotNull check in SimplifyBinaryComparison optimization URL: https://github.com/apache/spark/pull/27008#issuecomment-569389014 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20673/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec
SparkQA removed a comment on issue #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec URL: https://github.com/apache/spark/pull/27019#issuecomment-569375684 **[Test build #115878 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115878/testReport)** for PR 27019 at commit [`e449d3c`](https://github.com/apache/spark/commit/e449d3c8ca24d4ec1da2080ebb37ca2307e2ca76). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec
SparkQA commented on issue #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec URL: https://github.com/apache/spark/pull/27019#issuecomment-569389028 **[Test build #115878 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115878/testReport)** for PR 27019 at commit [`e449d3c`](https://github.com/apache/spark/commit/e449d3c8ca24d4ec1da2080ebb37ca2307e2ca76). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27008: [SPARK-30353][SQL] Add IsNotNull check in SimplifyBinaryComparison optimization
AmplabJenkins commented on issue #27008: [SPARK-30353][SQL] Add IsNotNull check in SimplifyBinaryComparison optimization URL: https://github.com/apache/spark/pull/27008#issuecomment-569389011 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27008: [SPARK-30353][SQL] Add IsNotNull check in SimplifyBinaryComparison optimization
AmplabJenkins commented on issue #27008: [SPARK-30353][SQL] Add IsNotNull check in SimplifyBinaryComparison optimization URL: https://github.com/apache/spark/pull/27008#issuecomment-569389014 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20673/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27008: [SPARK-30353][SQL] Add IsNotNull check in SimplifyBinaryComparison optimization
SparkQA commented on issue #27008: [SPARK-30353][SQL] Add IsNotNull check in SimplifyBinaryComparison optimization URL: https://github.com/apache/spark/pull/27008#issuecomment-569388903 **[Test build #115883 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115883/testReport)** for PR 27008 at commit [`9b0d268`](https://github.com/apache/spark/commit/9b0d268911a61f9476cce0d550447c0e33026502). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] maropu commented on issue #27008: [SPARK-30353][SQL] Add IsNotNull check in SimplifyBinaryComparison optimization
maropu commented on issue #27008: [SPARK-30353][SQL] Add IsNotNull check in SimplifyBinaryComparison optimization URL: https://github.com/apache/spark/pull/27008#issuecomment-569388734 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #25399: [SPARK-28670][SQL] create function should thrown Exception if the resource is not found
SparkQA commented on issue #25399: [SPARK-28670][SQL] create function should thrown Exception if the resource is not found URL: https://github.com/apache/spark/pull/25399#issuecomment-569387825 **[Test build #115882 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115882/testReport)** for PR 25399 at commit [`d78ecad`](https://github.com/apache/spark/commit/d78ecad94b67fdd1ebfe28eb1abaab6836a7d1ab). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] maropu closed pull request #25399: [SPARK-28670][SQL] create function should thrown Exception if the resource is not found
maropu closed pull request #25399: [SPARK-28670][SQL] create function should thrown Exception if the resource is not found URL: https://github.com/apache/spark/pull/25399 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] maropu commented on issue #25399: [SPARK-28670][SQL] create function should thrown Exception if the resource is not found
maropu commented on issue #25399: [SPARK-28670][SQL] create function should thrown Exception if the resource is not found URL: https://github.com/apache/spark/pull/25399#issuecomment-569387875 Thanks! Merged to master. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] sandeep-katta opened a new pull request #25399: [SPARK-28670][SQL] create function should thrown Exception if the resource is not found
sandeep-katta opened a new pull request #25399: [SPARK-28670][SQL] create function should thrown Exception if the resource is not found URL: https://github.com/apache/spark/pull/25399 ## What changes were proposed in this pull request? Create temporary or permanent function it should throw AnalysisException if the resource is not found. Need to keep behavior consistent across permanent and temporary functions. ## How was this patch tested? Added UT and also tested manually **Before Fix** If the UDF resource is not present then on creation of temporary function it throws AnalysisException where as for permanent function it does not throw. Permanent funtcion throws AnalysisException only after select operation is performed. **After Fix** For temporary and permanent function check for the resource, if the UDF resource is not found then throw AnalysisException  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27025: [SPARK-26560][SQL] Spark should be able to run Hive UDF using jar regardless of current thread context classloader
AmplabJenkins removed a comment on issue #27025: [SPARK-26560][SQL] Spark should be able to run Hive UDF using jar regardless of current thread context classloader URL: https://github.com/apache/spark/pull/27025#issuecomment-569387153 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27025: [SPARK-26560][SQL] Spark should be able to run Hive UDF using jar regardless of current thread context classloader
AmplabJenkins removed a comment on issue #27025: [SPARK-26560][SQL] Spark should be able to run Hive UDF using jar regardless of current thread context classloader URL: https://github.com/apache/spark/pull/27025#issuecomment-569387154 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115880/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27025: [SPARK-26560][SQL] Spark should be able to run Hive UDF using jar regardless of current thread context classloader
AmplabJenkins commented on issue #27025: [SPARK-26560][SQL] Spark should be able to run Hive UDF using jar regardless of current thread context classloader URL: https://github.com/apache/spark/pull/27025#issuecomment-569387153 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27025: [SPARK-26560][SQL] Spark should be able to run Hive UDF using jar regardless of current thread context classloader
AmplabJenkins commented on issue #27025: [SPARK-26560][SQL] Spark should be able to run Hive UDF using jar regardless of current thread context classloader URL: https://github.com/apache/spark/pull/27025#issuecomment-569387154 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115880/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27025: [SPARK-26560][SQL] Spark should be able to run Hive UDF using jar regardless of current thread context classloader
SparkQA commented on issue #27025: [SPARK-26560][SQL] Spark should be able to run Hive UDF using jar regardless of current thread context classloader URL: https://github.com/apache/spark/pull/27025#issuecomment-569387082 **[Test build #115880 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115880/testReport)** for PR 27025 at commit [`b801ac5`](https://github.com/apache/spark/commit/b801ac57c04d6d8384f735b79dfaefa5bee77ba2). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27025: [SPARK-26560][SQL] Spark should be able to run Hive UDF using jar regardless of current thread context classloader
SparkQA removed a comment on issue #27025: [SPARK-26560][SQL] Spark should be able to run Hive UDF using jar regardless of current thread context classloader URL: https://github.com/apache/spark/pull/27025#issuecomment-569379417 **[Test build #115880 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115880/testReport)** for PR 27025 at commit [`b801ac5`](https://github.com/apache/spark/commit/b801ac57c04d6d8384f735b79dfaefa5bee77ba2). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] imback82 commented on a change in pull request #26361: [SPARK-29630][SQL] Disallow creating a permanent view that references a temporary view in an expression
imback82 commented on a change in pull request #26361: [SPARK-29630][SQL] Disallow creating a permanent view that references a temporary view in an expression URL: https://github.com/apache/spark/pull/26361#discussion_r361776820 ## File path: sql/core/src/test/resources/sql-tests/results/postgreSQL/create_view.sql.out ## @@ -803,61 +806,77 @@ Not allowed to create a permanent view `temporal4` by referencing a temporary vi -- !query 71 -CREATE TABLE tbl1 ( a int, b int) using parquet +CREATE VIEW temporal5 AS SELECT * FROM t1 WHERE num IN (SELECT num FROM t1 WHERE EXISTS (SELECT 1 FROM tt)) -- !query 71 schema struct<> -- !query 71 output - +org.apache.spark.sql.AnalysisException +Not allowed to create a permanent view `temporal5` by referencing a temporary view `tt`; Review comment: We can add something like `Create a temporary view to reference temporary views; a permanent view can only reference permanent views`, but sounds a bit redundant with the error message? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] 07ARB removed a comment on issue #26477: [SPARK-29776][SQL] rpad and lpad should return NULL when padstring parameter is empty
07ARB removed a comment on issue #26477: [SPARK-29776][SQL] rpad and lpad should return NULL when padstring parameter is empty URL: https://github.com/apache/spark/pull/26477#issuecomment-569385621 @srowen, it's ok, if not require then we can close this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] 07ARB commented on issue #26477: [SPARK-29776][SQL] rpad and lpad should return NULL when padstring parameter is empty
07ARB commented on issue #26477: [SPARK-29776][SQL] rpad and lpad should return NULL when padstring parameter is empty URL: https://github.com/apache/spark/pull/26477#issuecomment-569385621 @srowen, it's ok, if not require then we can close this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26956: [SPARK-30312][SQL] Preserve path attributes including permission when truncate table
AmplabJenkins removed a comment on issue #26956: [SPARK-30312][SQL] Preserve path attributes including permission when truncate table URL: https://github.com/apache/spark/pull/26956#issuecomment-569384825 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115875/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #26956: [SPARK-30312][SQL] Preserve path attributes including permission when truncate table
SparkQA removed a comment on issue #26956: [SPARK-30312][SQL] Preserve path attributes including permission when truncate table URL: https://github.com/apache/spark/pull/26956#issuecomment-569370722 **[Test build #115875 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115875/testReport)** for PR 26956 at commit [`2c3f1fb`](https://github.com/apache/spark/commit/2c3f1fb2f2d7150e99a7beda572c09f23cdc0eef). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26956: [SPARK-30312][SQL] Preserve path attributes including permission when truncate table
AmplabJenkins commented on issue #26956: [SPARK-30312][SQL] Preserve path attributes including permission when truncate table URL: https://github.com/apache/spark/pull/26956#issuecomment-569384824 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26956: [SPARK-30312][SQL] Preserve path attributes including permission when truncate table
AmplabJenkins commented on issue #26956: [SPARK-30312][SQL] Preserve path attributes including permission when truncate table URL: https://github.com/apache/spark/pull/26956#issuecomment-569384825 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115875/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26956: [SPARK-30312][SQL] Preserve path attributes including permission when truncate table
AmplabJenkins removed a comment on issue #26956: [SPARK-30312][SQL] Preserve path attributes including permission when truncate table URL: https://github.com/apache/spark/pull/26956#issuecomment-569384824 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
AmplabJenkins removed a comment on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset URL: https://github.com/apache/spark/pull/27017#issuecomment-569384695 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115879/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26956: [SPARK-30312][SQL] Preserve path attributes including permission when truncate table
SparkQA commented on issue #26956: [SPARK-30312][SQL] Preserve path attributes including permission when truncate table URL: https://github.com/apache/spark/pull/26956#issuecomment-569384744 **[Test build #115875 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115875/testReport)** for PR 26956 at commit [`2c3f1fb`](https://github.com/apache/spark/commit/2c3f1fb2f2d7150e99a7beda572c09f23cdc0eef). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
AmplabJenkins removed a comment on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset URL: https://github.com/apache/spark/pull/27017#issuecomment-569384694 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
AmplabJenkins commented on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset URL: https://github.com/apache/spark/pull/27017#issuecomment-569384694 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
AmplabJenkins commented on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset URL: https://github.com/apache/spark/pull/27017#issuecomment-569384695 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115879/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
SparkQA removed a comment on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset URL: https://github.com/apache/spark/pull/27017#issuecomment-569375679 **[Test build #115879 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115879/testReport)** for PR 27017 at commit [`77c09e8`](https://github.com/apache/spark/commit/77c09e8db7e8846659a61ee984d46dc9994d5e99). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
SparkQA commented on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset URL: https://github.com/apache/spark/pull/27017#issuecomment-569384580 **[Test build #115879 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115879/testReport)** for PR 27017 at commit [`77c09e8`](https://github.com/apache/spark/commit/77c09e8db7e8846659a61ee984d46dc9994d5e99). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
AmplabJenkins removed a comment on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset URL: https://github.com/apache/spark/pull/27017#issuecomment-569383687 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115877/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
AmplabJenkins commented on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset URL: https://github.com/apache/spark/pull/27017#issuecomment-569383687 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115877/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
AmplabJenkins commented on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset URL: https://github.com/apache/spark/pull/27017#issuecomment-569383683 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
AmplabJenkins removed a comment on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset URL: https://github.com/apache/spark/pull/27017#issuecomment-569383683 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
SparkQA commented on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset URL: https://github.com/apache/spark/pull/27017#issuecomment-569383597 **[Test build #115877 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115877/testReport)** for PR 27017 at commit [`d12dd45`](https://github.com/apache/spark/commit/d12dd455a0d3107e341eeb99d718d4cbec6ba5dc). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
SparkQA removed a comment on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset URL: https://github.com/apache/spark/pull/27017#issuecomment-569374481 **[Test build #115877 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115877/testReport)** for PR 27017 at commit [`d12dd45`](https://github.com/apache/spark/commit/d12dd455a0d3107e341eeb99d718d4cbec6ba5dc). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
AmplabJenkins removed a comment on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset URL: https://github.com/apache/spark/pull/27017#issuecomment-569382206 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115876/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
AmplabJenkins removed a comment on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset URL: https://github.com/apache/spark/pull/27017#issuecomment-569382204 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
AmplabJenkins commented on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset URL: https://github.com/apache/spark/pull/27017#issuecomment-569382206 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115876/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
AmplabJenkins commented on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset URL: https://github.com/apache/spark/pull/27017#issuecomment-569382204 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
SparkQA removed a comment on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset URL: https://github.com/apache/spark/pull/27017#issuecomment-569373851 **[Test build #115876 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115876/testReport)** for PR 27017 at commit [`d12dd45`](https://github.com/apache/spark/commit/d12dd455a0d3107e341eeb99d718d4cbec6ba5dc). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset
SparkQA commented on issue #27017: [SPARK-30359][CORE] Don't clear executorsPendingToRemove at the beginning of CoarseGrainedSchedulerBackend.reset URL: https://github.com/apache/spark/pull/27017#issuecomment-569382080 **[Test build #115876 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115876/testReport)** for PR 27017 at commit [`d12dd45`](https://github.com/apache/spark/commit/d12dd455a0d3107e341eeb99d718d4cbec6ba5dc). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26993: [WIP][SPARK-30338][SQL] Avoid unnecessary InternalRow copies in ParquetRowConverter
AmplabJenkins removed a comment on issue #26993: [WIP][SPARK-30338][SQL] Avoid unnecessary InternalRow copies in ParquetRowConverter URL: https://github.com/apache/spark/pull/26993#issuecomment-569382064 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115874/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26993: [WIP][SPARK-30338][SQL] Avoid unnecessary InternalRow copies in ParquetRowConverter
AmplabJenkins removed a comment on issue #26993: [WIP][SPARK-30338][SQL] Avoid unnecessary InternalRow copies in ParquetRowConverter URL: https://github.com/apache/spark/pull/26993#issuecomment-569382062 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26993: [WIP][SPARK-30338][SQL] Avoid unnecessary InternalRow copies in ParquetRowConverter
AmplabJenkins commented on issue #26993: [WIP][SPARK-30338][SQL] Avoid unnecessary InternalRow copies in ParquetRowConverter URL: https://github.com/apache/spark/pull/26993#issuecomment-569382064 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115874/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26993: [WIP][SPARK-30338][SQL] Avoid unnecessary InternalRow copies in ParquetRowConverter
AmplabJenkins commented on issue #26993: [WIP][SPARK-30338][SQL] Avoid unnecessary InternalRow copies in ParquetRowConverter URL: https://github.com/apache/spark/pull/26993#issuecomment-569382062 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #26993: [WIP][SPARK-30338][SQL] Avoid unnecessary InternalRow copies in ParquetRowConverter
SparkQA removed a comment on issue #26993: [WIP][SPARK-30338][SQL] Avoid unnecessary InternalRow copies in ParquetRowConverter URL: https://github.com/apache/spark/pull/26993#issuecomment-569365987 **[Test build #115874 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115874/testReport)** for PR 26993 at commit [`fffe72b`](https://github.com/apache/spark/commit/fffe72b435c8f9f2d4cd0a0742fd7bfd247eabf7). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26993: [WIP][SPARK-30338][SQL] Avoid unnecessary InternalRow copies in ParquetRowConverter
SparkQA commented on issue #26993: [WIP][SPARK-30338][SQL] Avoid unnecessary InternalRow copies in ParquetRowConverter URL: https://github.com/apache/spark/pull/26993#issuecomment-569381961 **[Test build #115874 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115874/testReport)** for PR 26993 at commit [`fffe72b`](https://github.com/apache/spark/commit/fffe72b435c8f9f2d4cd0a0742fd7bfd247eabf7). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27027: [SPARK-30370][SQL] Update SqlBase.g4 to combine namespace and database tokens.
AmplabJenkins removed a comment on issue #27027: [SPARK-30370][SQL] Update SqlBase.g4 to combine namespace and database tokens. URL: https://github.com/apache/spark/pull/27027#issuecomment-569381595 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20672/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27027: [SPARK-30370][SQL] Update SqlBase.g4 to combine namespace and database tokens.
AmplabJenkins removed a comment on issue #27027: [SPARK-30370][SQL] Update SqlBase.g4 to combine namespace and database tokens. URL: https://github.com/apache/spark/pull/27027#issuecomment-569381593 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27027: [SPARK-30370][SQL] Update SqlBase.g4 to combine namespace and database tokens.
AmplabJenkins commented on issue #27027: [SPARK-30370][SQL] Update SqlBase.g4 to combine namespace and database tokens. URL: https://github.com/apache/spark/pull/27027#issuecomment-569381595 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20672/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27027: [SPARK-30370][SQL] Update SqlBase.g4 to combine namespace and database tokens.
AmplabJenkins commented on issue #27027: [SPARK-30370][SQL] Update SqlBase.g4 to combine namespace and database tokens. URL: https://github.com/apache/spark/pull/27027#issuecomment-569381593 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27027: [SPARK-30370][SQL] Update SqlBase.g4 to combine namespace and database tokens.
SparkQA commented on issue #27027: [SPARK-30370][SQL] Update SqlBase.g4 to combine namespace and database tokens. URL: https://github.com/apache/spark/pull/27027#issuecomment-569381488 **[Test build #115881 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115881/testReport)** for PR 27027 at commit [`0931abd`](https://github.com/apache/spark/commit/0931abd526332c6093ddecb866eb92a66534e3c8). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] imback82 commented on a change in pull request #27027: [SPARK-30370][SQL] Update SqlBase.g4 to combine namespace and database tokens.
imback82 commented on a change in pull request #27027: [SPARK-30370][SQL] Update SqlBase.g4 to combine namespace and database tokens. URL: https://github.com/apache/spark/pull/27027#discussion_r361773827 ## File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ## @@ -95,15 +95,15 @@ statement : query #statementDefault | ctes? dmlStatementNoWith #dmlStatement | USE NAMESPACE? multipartIdentifier #use Review comment: Should commands like `USE NAMESPACE` and `SHOW CURRENT NAMESPACE ` utilize `namespace`? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] imback82 commented on a change in pull request #26847: [SPARK-30214][SQL] A new framework to resolve v2 commands
imback82 commented on a change in pull request #26847: [SPARK-30214][SQL] A new framework to resolve v2 commands URL: https://github.com/apache/spark/pull/26847#discussion_r361773790 ## File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ## @@ -212,6 +212,9 @@ statement | (DESC | DESCRIBE) TABLE? option=(EXTENDED | FORMATTED)? multipartIdentifier partitionSpec? describeColName? #describeTable | (DESC | DESCRIBE) QUERY? query #describeQuery +| COMMENT ON (database | NAMESPACE) multipartIdentifier IS Review comment: I created https://github.com/apache/spark/pull/27027 for this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] imback82 opened a new pull request #27027: [SPARK-30370][SQL] Update SqlBase.g4 to combine namespace and database tokens.
imback82 opened a new pull request #27027: [SPARK-30370][SQL] Update SqlBase.g4 to combine namespace and database tokens. URL: https://github.com/apache/spark/pull/27027 ### What changes were proposed in this pull request? In `SqlBase.g4`, `database` is defined as ``` database : DATABASE | SCHEMA ; ``` and it is being used as `(database | NAMESPACE)` in many places. This PR proposes to define the following and use it as discussed in https://github.com/apache/spark/pull/26847/files#r359754778: ``` namespace : NAMESPACE | DATABASE | SCHEMA; ``` ### Why are the changes needed? To simplify the grammar. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? There is no change in the actual grammar, so the existing tests should be sufficient. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27025: [SPARK-26560][SQL] Spark should be able to run Hive UDF using jar regardless of current thread context classloader
SparkQA commented on issue #27025: [SPARK-26560][SQL] Spark should be able to run Hive UDF using jar regardless of current thread context classloader URL: https://github.com/apache/spark/pull/27025#issuecomment-569379417 **[Test build #115880 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115880/testReport)** for PR 27025 at commit [`b801ac5`](https://github.com/apache/spark/commit/b801ac57c04d6d8384f735b79dfaefa5bee77ba2). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] imback82 commented on a change in pull request #26847: [SPARK-30214][SQL] A new framework to resolve v2 commands
imback82 commented on a change in pull request #26847: [SPARK-30214][SQL] A
new framework to resolve v2 commands
URL: https://github.com/apache/spark/pull/26847#discussion_r361772691
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##
@@ -720,6 +722,14 @@ class Analyzer(
}
}
+ case class ResolveNamespace(catalogManager: CatalogManager)
+extends Rule[LogicalPlan] with LookupCatalog {
+def apply(plan: LogicalPlan): LogicalPlan = plan resolveOperators {
+ case UnresolvedNamespace(CatalogAndNamespace(catalog, ns)) =>
+ResolvedNamespace(catalog.asNamespaceCatalog, ns)
Review comment:
I have a question. We have the following in `ResolveSessionCatalog.scala`:
```scala
case ShowTablesStatement(Some(CatalogAndNamespace(catalog, ns)), pattern)
if isSessionCatalog(catalog) =>
```
Do we plan to add these statements here and not resolve
`UnresolvedNamespace` and let `ResolveSessionCatalog` handle them?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27025: [SPARK-26560][SQL] Spark should be able to run Hive UDF using jar regardless of current thread context classloader
AmplabJenkins removed a comment on issue #27025: [SPARK-26560][SQL] Spark should be able to run Hive UDF using jar regardless of current thread context classloader URL: https://github.com/apache/spark/pull/27025#issuecomment-569378971 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20671/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27025: [SPARK-26560][SQL] Spark should be able to run Hive UDF using jar regardless of current thread context classloader
AmplabJenkins removed a comment on issue #27025: [SPARK-26560][SQL] Spark should be able to run Hive UDF using jar regardless of current thread context classloader URL: https://github.com/apache/spark/pull/27025#issuecomment-569378969 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27025: [SPARK-26560][SQL] Spark should be able to run Hive UDF using jar regardless of current thread context classloader
AmplabJenkins commented on issue #27025: [SPARK-26560][SQL] Spark should be able to run Hive UDF using jar regardless of current thread context classloader URL: https://github.com/apache/spark/pull/27025#issuecomment-569378971 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20671/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27025: [SPARK-26560][SQL] Spark should be able to run Hive UDF using jar regardless of current thread context classloader
AmplabJenkins commented on issue #27025: [SPARK-26560][SQL] Spark should be able to run Hive UDF using jar regardless of current thread context classloader URL: https://github.com/apache/spark/pull/27025#issuecomment-569378969 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26956: [SPARK-30312][SQL] Preserve path attributes including permission when truncate table
AmplabJenkins removed a comment on issue #26956: [SPARK-30312][SQL] Preserve path attributes including permission when truncate table URL: https://github.com/apache/spark/pull/26956#issuecomment-569377367 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115873/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26956: [SPARK-30312][SQL] Preserve path attributes including permission when truncate table
AmplabJenkins removed a comment on issue #26956: [SPARK-30312][SQL] Preserve path attributes including permission when truncate table URL: https://github.com/apache/spark/pull/26956#issuecomment-569377366 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26956: [SPARK-30312][SQL] Preserve path attributes including permission when truncate table
AmplabJenkins commented on issue #26956: [SPARK-30312][SQL] Preserve path attributes including permission when truncate table URL: https://github.com/apache/spark/pull/26956#issuecomment-569377366 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26956: [SPARK-30312][SQL] Preserve path attributes including permission when truncate table
AmplabJenkins commented on issue #26956: [SPARK-30312][SQL] Preserve path attributes including permission when truncate table URL: https://github.com/apache/spark/pull/26956#issuecomment-569377367 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115873/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
