[GitHub] [spark] AmplabJenkins commented on pull request #28348: [MINOR][SQL][DOCS] Remove two leading spaces from sql tables

2020-04-25 Thread GitBox
AmplabJenkins commented on pull request #28348: URL: https://github.com/apache/spark/pull/28348#issuecomment-619465113 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28348: [MINOR][SQL][DOCS] Remove two leading spaces from sql tables

2020-04-25 Thread GitBox
SparkQA commented on pull request #28348: URL: https://github.com/apache/spark/pull/28348#issuecomment-619465000 **[Test build #121824 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121824/testReport)** for PR 28348 at commit

[GitHub] [spark] huaxingao opened a new pull request #28348: [MINOR][SQL][DOCS] Remove two leading spaces from sql tables

2020-04-25 Thread GitBox
huaxingao opened a new pull request #28348: URL: https://github.com/apache/spark/pull/28348 ### What changes were proposed in this pull request? Remove two leading spaces from sql tables. ### Why are the changes needed? Follow the format of other references such as

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27617: [SPARK-30865][SQL] Refactor DateTimeUtils

2020-04-25 Thread GitBox
AmplabJenkins removed a comment on pull request #27617: URL: https://github.com/apache/spark/pull/27617#issuecomment-619464488 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #27617: [SPARK-30865][SQL] Refactor DateTimeUtils

2020-04-25 Thread GitBox
AmplabJenkins commented on pull request #27617: URL: https://github.com/apache/spark/pull/27617#issuecomment-619464488 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #27617: [SPARK-30865][SQL] Refactor DateTimeUtils

2020-04-25 Thread GitBox
SparkQA removed a comment on pull request #27617: URL: https://github.com/apache/spark/pull/27617#issuecomment-619436923 **[Test build #121814 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121814/testReport)** for PR 27617 at commit

[GitHub] [spark] SparkQA commented on pull request #27617: [SPARK-30865][SQL] Refactor DateTimeUtils

2020-04-25 Thread GitBox
SparkQA commented on pull request #27617: URL: https://github.com/apache/spark/pull/27617#issuecomment-619464325 **[Test build #121814 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121814/testReport)** for PR 27617 at commit

[GitHub] [spark] TJX2014 edited a comment on pull request #28347: [SPARK-31400][ML]The catalogString doesn't distinguish Vectors in ml and mllib

2020-04-25 Thread GitBox
TJX2014 edited a comment on pull request #28347: URL: https://github.com/apache/spark/pull/28347#issuecomment-619463082 @srowen Could you please help me review this again, thanks anyway :-) https://github.com/apache/spark/pull/28291

[GitHub] [spark] TJX2014 edited a comment on pull request #28347: [SPARK-31400][ML]The catalogString doesn't distinguish Vectors in ml and mllib

2020-04-25 Thread GitBox
TJX2014 edited a comment on pull request #28347: URL: https://github.com/apache/spark/pull/28347#issuecomment-619463082 @srowen Could you please help me review this again, thanks anyway :-) former link: https://github.com/apache/spark/pull/28291

[GitHub] [spark] imback82 edited a comment on pull request #26921: [SPARK-30282][SQL] Migrate SHOW TBLPROPERTIES to new framework

2020-04-25 Thread GitBox
imback82 edited a comment on pull request #26921: URL: https://github.com/apache/spark/pull/26921#issuecomment-619438548 `UnresolvedTable` is used for `SHOW TBLPROPERTIES` and `COMMENT ON TABLE`, so only those should be affected. @cloud-fan can correct me if I am wrong here. Since

[GitHub] [spark] TJX2014 edited a comment on pull request #28347: [SPARK-31400][ML]The catalogString doesn't distinguish Vectors in ml and mllib

2020-04-25 Thread GitBox
TJX2014 edited a comment on pull request #28347: URL: https://github.com/apache/spark/pull/28347#issuecomment-619463082 @srowen Could you help me review this again, thanks anyway :-) https://github.com/apache/spark/pull/28291

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28347: [SPARK-31400][ML]The catalogString doesn't distinguish Vectors in ml and mllib

2020-04-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28347: URL: https://github.com/apache/spark/pull/28347#issuecomment-619463078 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] [spark] AmplabJenkins commented on pull request #28347: [SPARK-31400][ML]The catalogString doesn't distinguish Vectors in ml and mllib

2020-04-25 Thread GitBox
AmplabJenkins commented on pull request #28347: URL: https://github.com/apache/spark/pull/28347#issuecomment-619463170 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA commented on pull request #28109: [SPARK-31524][SQL][followup] Add metric to the split task number for skew optimization

2020-04-25 Thread GitBox
SparkQA commented on pull request #28109: URL: https://github.com/apache/spark/pull/28109#issuecomment-619463130 **[Test build #121823 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121823/testReport)** for PR 28109 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28347: [SPARK-31400][ML]The catalogString doesn't distinguish Vectors in ml and mllib

2020-04-25 Thread GitBox
AmplabJenkins commented on pull request #28347: URL: https://github.com/apache/spark/pull/28347#issuecomment-619463078 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] TJX2014 commented on pull request #28347: [SPARK-31400][ML]The catalogString doesn't distinguish Vectors in ml and mllib

2020-04-25 Thread GitBox
TJX2014 commented on pull request #28347: URL: https://github.com/apache/spark/pull/28347#issuecomment-619463082 @srowen Could you help me review this again, thanks anyway :-) [https://github.com/apache/spark/pull/28291](the former link)

[GitHub] [spark] turboFei commented on pull request #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative task

2020-04-25 Thread GitBox
turboFei commented on pull request #26339: URL: https://github.com/apache/spark/pull/26339#issuecomment-619462822 thanks a lot @venkata91 will address it. This is an automated message from the Apache Git Service. To respond

[GitHub] [spark] TJX2014 opened a new pull request #28347: [SPARK-31400][ML]The catalogString doesn't distinguish Vectors in ml and mllib

2020-04-25 Thread GitBox
TJX2014 opened a new pull request #28347: URL: https://github.com/apache/spark/pull/28347 # What changes were proposed in this pull request? 1.Add class info output in org.apache.spark.ml.util.SchemaUtils#checkColumnType to distinct Vectors in ml and mllib 2.Add unit test Why

[GitHub] [spark] AmplabJenkins commented on pull request #28109: [SPARK-31524][SQL][followup] Add metric to the split task number for skew optimization

2020-04-25 Thread GitBox
AmplabJenkins commented on pull request #28109: URL: https://github.com/apache/spark/pull/28109#issuecomment-619462567 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28109: [SPARK-31524][SQL][followup] Add metric to the split task number for skew optimization

2020-04-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28109: URL: https://github.com/apache/spark/pull/28109#issuecomment-619462567 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] maropu commented on a change in pull request #28324: [SPARK-31552][SQL] Fix ClassCastException in ScalaReflection arrayClassFor

2020-04-25 Thread GitBox
maropu commented on a change in pull request #28324: URL: https://github.com/apache/spark/pull/28324#discussion_r415180813 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala ## @@ -126,6 +126,9 @@ object ScalaReflection extends

[GitHub] [spark] maropu commented on pull request #28324: [SPARK-31552][SQL] Fix ClassCastException in ScalaReflection arrayClassFor

2020-04-25 Thread GitBox
maropu commented on pull request #28324: URL: https://github.com/apache/spark/pull/28324#issuecomment-619461718 late LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] maropu commented on a change in pull request #28330: [SPARK-31377][SQL][TEST] Added unit tests to 'number of output rows metric' for some joins in SQLMetricSuite

2020-04-25 Thread GitBox
maropu commented on a change in pull request #28330: URL: https://github.com/apache/spark/pull/28330#discussion_r415179658 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala ## @@ -341,6 +341,62 @@ class SQLMetricsSuite extends

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28346: [SPARK-31400][ML]The catalogString doesn't distinguish Vectors in ml and mllib

2020-04-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28346: URL: https://github.com/apache/spark/pull/28346#issuecomment-619459832 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28123: [SPARK-31350][SQL] Coalesce bucketed tables for join if applicable

2020-04-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28123: URL: https://github.com/apache/spark/pull/28123#issuecomment-619460390 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #28123: [SPARK-31350][SQL] Coalesce bucketed tables for join if applicable

2020-04-25 Thread GitBox
SparkQA removed a comment on pull request #28123: URL: https://github.com/apache/spark/pull/28123#issuecomment-619434985 **[Test build #121812 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121812/testReport)** for PR 28123 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28330: [SPARK-31377][SQL][TEST] Added unit tests to 'number of output rows metric' for some joins in SQLMetricSuite

2020-04-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28330: URL: https://github.com/apache/spark/pull/28330#issuecomment-619208168 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28330: [SPARK-31377][SQL][TEST] Added unit tests to 'number of output rows metric' for some joins in SQLMetricSuite

2020-04-25 Thread GitBox
AmplabJenkins commented on pull request #28330: URL: https://github.com/apache/spark/pull/28330#issuecomment-619461222 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28330: [SPARK-31377][SQL][TEST] Added unit tests to 'number of output rows metric' for some joins in SQLMetricSuite

2020-04-25 Thread GitBox
SparkQA commented on pull request #28330: URL: https://github.com/apache/spark/pull/28330#issuecomment-619461110 **[Test build #121822 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121822/testReport)** for PR 28330 at commit

[GitHub] [spark] maropu commented on a change in pull request #28330: [SPARK-31377][SQL][TEST] Added unit tests to 'number of output rows metric' for some joins in SQLMetricSuite

2020-04-25 Thread GitBox
maropu commented on a change in pull request #28330: URL: https://github.com/apache/spark/pull/28330#discussion_r415178719 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala ## @@ -341,6 +341,62 @@ class SQLMetricsSuite extends

[GitHub] [spark] maropu commented on a change in pull request #28330: [SPARK-31377][SQL][TEST] Added unit tests to 'number of output rows metric' for some joins in SQLMetricSuite

2020-04-25 Thread GitBox
maropu commented on a change in pull request #28330: URL: https://github.com/apache/spark/pull/28330#discussion_r415178596 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala ## @@ -341,6 +341,62 @@ class SQLMetricsSuite extends

[GitHub] [spark] maropu commented on a change in pull request #28330: [SPARK-31377][SQL][TEST] Added unit tests to 'number of output rows metric' for some joins in SQLMetricSuite

2020-04-25 Thread GitBox
maropu commented on a change in pull request #28330: URL: https://github.com/apache/spark/pull/28330#discussion_r415178386 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala ## @@ -341,6 +341,62 @@ class SQLMetricsSuite extends

[GitHub] [spark] maropu commented on pull request #28330: [SPARK-31377][SQL][TEST] Added unit tests to 'number of output rows metric' for some joins in SQLMetricSuite

2020-04-25 Thread GitBox
maropu commented on pull request #28330: URL: https://github.com/apache/spark/pull/28330#issuecomment-619460604 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28123: [SPARK-31350][SQL] Coalesce bucketed tables for join if applicable

2020-04-25 Thread GitBox
AmplabJenkins commented on pull request #28123: URL: https://github.com/apache/spark/pull/28123#issuecomment-619460579 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28123: [SPARK-31350][SQL] Coalesce bucketed tables for join if applicable

2020-04-25 Thread GitBox
SparkQA commented on pull request #28123: URL: https://github.com/apache/spark/pull/28123#issuecomment-619460514 **[Test build #121821 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121821/testReport)** for PR 28123 at commit

[GitHub] [spark] maropu commented on pull request #28123: [SPARK-31350][SQL] Coalesce bucketed tables for join if applicable

2020-04-25 Thread GitBox
maropu commented on pull request #28123: URL: https://github.com/apache/spark/pull/28123#issuecomment-619460458 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] AmplabJenkins commented on pull request #28123: [SPARK-31350][SQL] Coalesce bucketed tables for join if applicable

2020-04-25 Thread GitBox
AmplabJenkins commented on pull request #28123: URL: https://github.com/apache/spark/pull/28123#issuecomment-619460390 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] maropu commented on a change in pull request #28332: [SPARK-31556][SQL][DOCS] Document LIKE clause in SQL Reference

2020-04-25 Thread GitBox
maropu commented on a change in pull request #28332: URL: https://github.com/apache/spark/pull/28332#discussion_r415177676 ## File path: docs/sql-ref-syntax-qry-select-like.md ## @@ -0,0 +1,120 @@ +--- +layout: global +title: LIKE Predicate +displayTitle: LIKE Predicate

[GitHub] [spark] SparkQA commented on pull request #28123: [SPARK-31350][SQL] Coalesce bucketed tables for join if applicable

2020-04-25 Thread GitBox
SparkQA commented on pull request #28123: URL: https://github.com/apache/spark/pull/28123#issuecomment-619460303 **[Test build #121812 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121812/testReport)** for PR 28123 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28346: [SPARK-31400][ML]The catalogString doesn't distinguish Vectors in ml and mllib

2020-04-25 Thread GitBox
AmplabJenkins commented on pull request #28346: URL: https://github.com/apache/spark/pull/28346#issuecomment-619459933 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28346: [SPARK-31400][ML]The catalogString doesn't distinguish Vectors in ml and mllib

2020-04-25 Thread GitBox
AmplabJenkins commented on pull request #28346: URL: https://github.com/apache/spark/pull/28346#issuecomment-619459832 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] TJX2014 opened a new pull request #28346: [SPARK-31400][ML]The catalogString doesn't distinguish Vectors in ml and mllib

2020-04-25 Thread GitBox
TJX2014 opened a new pull request #28346: URL: https://github.com/apache/spark/pull/28346 #27872 # What changes were proposed in this pull request? 1.Add class info output in org.apache.spark.ml.util.SchemaUtils#checkColumnType to distinct Vectors in ml and mllib 2.Add unit test

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28332: [SPARK-31556][SQL][DOCS] Document LIKE clause in SQL Reference

2020-04-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28332: URL: https://github.com/apache/spark/pull/28332#issuecomment-619458822 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28332: [SPARK-31556][SQL][DOCS] Document LIKE clause in SQL Reference

2020-04-25 Thread GitBox
AmplabJenkins commented on pull request #28332: URL: https://github.com/apache/spark/pull/28332#issuecomment-619458822 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28332: [SPARK-31556][SQL][DOCS] Document LIKE clause in SQL Reference

2020-04-25 Thread GitBox
SparkQA removed a comment on pull request #28332: URL: https://github.com/apache/spark/pull/28332#issuecomment-619457824 **[Test build #121820 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121820/testReport)** for PR 28332 at commit

[GitHub] [spark] SparkQA commented on pull request #28332: [SPARK-31556][SQL][DOCS] Document LIKE clause in SQL Reference

2020-04-25 Thread GitBox
SparkQA commented on pull request #28332: URL: https://github.com/apache/spark/pull/28332#issuecomment-619458777 **[Test build #121820 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121820/testReport)** for PR 28332 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28332: [SPARK-31556][SQL][DOCS] Document LIKE clause in SQL Reference

2020-04-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28332: URL: https://github.com/apache/spark/pull/28332#issuecomment-619457945 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28332: [SPARK-31556][SQL][DOCS] Document LIKE clause in SQL Reference

2020-04-25 Thread GitBox
AmplabJenkins commented on pull request #28332: URL: https://github.com/apache/spark/pull/28332#issuecomment-619457945 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28332: [SPARK-31556][SQL][DOCS] Document LIKE clause in SQL Reference

2020-04-25 Thread GitBox
SparkQA commented on pull request #28332: URL: https://github.com/apache/spark/pull/28332#issuecomment-619457824 **[Test build #121820 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121820/testReport)** for PR 28332 at commit

[GitHub] [spark] huaxingao commented on a change in pull request #28332: [SPARK-31556][SQL][DOCS] Document LIKE clause in SQL Reference

2020-04-25 Thread GitBox
huaxingao commented on a change in pull request #28332: URL: https://github.com/apache/spark/pull/28332#discussion_r415173038 ## File path: docs/sql-ref-syntax-qry-select-like.md ## @@ -0,0 +1,120 @@ +--- +layout: global +title: LIKE Predicate +displayTitle: LIKE Predicate

[GitHub] [spark] venkata91 commented on a change in pull request #26339: [SPARK-27194][SPARK-29302][SQL] Fix the issue that for dynamic partition overwrite a task would conflict with its speculative t

2020-04-25 Thread GitBox
venkata91 commented on a change in pull request #26339: URL: https://github.com/apache/spark/pull/26339#discussion_r415169284 ## File path: core/src/main/scala/org/apache/spark/internal/io/HadoopMapReduceCommitProtocol.scala ## @@ -236,13 +267,25 @@ class

[GitHub] [spark] maropu commented on pull request #28332: [SPARK-31556][SQL][DOCS] Document LIKE clause in SQL Reference

2020-04-25 Thread GitBox
maropu commented on pull request #28332: URL: https://github.com/apache/spark/pull/28332#issuecomment-619455981 Looks fine. This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] maropu commented on a change in pull request #28332: [SPARK-31556][SQL][DOCS] Document LIKE clause in SQL Reference

2020-04-25 Thread GitBox
maropu commented on a change in pull request #28332: URL: https://github.com/apache/spark/pull/28332#discussion_r415169803 ## File path: docs/sql-ref-syntax-qry-select-like.md ## @@ -0,0 +1,113 @@ +--- +layout: global +title: LIKE Predicate +displayTitle: LIKE Predicate

[GitHub] [spark] maropu commented on a change in pull request #28332: [SPARK-31556][SQL][DOCS] Document LIKE clause in SQL Reference

2020-04-25 Thread GitBox
maropu commented on a change in pull request #28332: URL: https://github.com/apache/spark/pull/28332#discussion_r415169589 ## File path: docs/sql-ref-syntax-qry-select-like.md ## @@ -0,0 +1,113 @@ +--- +layout: global +title: LIKE Predicate +displayTitle: LIKE Predicate

[GitHub] [spark] SparkQA removed a comment on pull request #28345: [SPARK-31557][SQL] Legacy time parser should return Gregorian days rather than Julian days

2020-04-25 Thread GitBox
SparkQA removed a comment on pull request #28345: URL: https://github.com/apache/spark/pull/28345#issuecomment-619423893 **[Test build #121810 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121810/testReport)** for PR 28345 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28345: [SPARK-31557][SQL] Legacy time parser should return Gregorian days rather than Julian days

2020-04-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28345: URL: https://github.com/apache/spark/pull/28345#issuecomment-619454245 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28345: [SPARK-31557][SQL] Legacy time parser should return Gregorian days rather than Julian days

2020-04-25 Thread GitBox
AmplabJenkins commented on pull request #28345: URL: https://github.com/apache/spark/pull/28345#issuecomment-619454245 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28345: [SPARK-31557][SQL] Legacy time parser should return Gregorian days rather than Julian days

2020-04-25 Thread GitBox
SparkQA commented on pull request #28345: URL: https://github.com/apache/spark/pull/28345#issuecomment-619454084 **[Test build #121810 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121810/testReport)** for PR 28345 at commit

[GitHub] [spark] huaxingao commented on a change in pull request #28332: [SPARK-31556][SQL][DOCS] Document LIKE clause in SQL Reference

2020-04-25 Thread GitBox
huaxingao commented on a change in pull request #28332: URL: https://github.com/apache/spark/pull/28332#discussion_r415166246 ## File path: docs/sql-ref-syntax-qry-select-like.md ## @@ -0,0 +1,113 @@ +--- +layout: global +title: LIKE Predicate +displayTitle: LIKE Predicate

[GitHub] [spark] huaxingao commented on a change in pull request #28332: [SPARK-31556][SQL][DOCS] Document LIKE clause in SQL Reference

2020-04-25 Thread GitBox
huaxingao commented on a change in pull request #28332: URL: https://github.com/apache/spark/pull/28332#discussion_r415165624 ## File path: docs/sql-ref-syntax-qry-select-like.md ## @@ -0,0 +1,113 @@ +--- +layout: global +title: LIKE Predicate +displayTitle: LIKE Predicate

[GitHub] [spark] SparkQA commented on pull request #28332: [SPARK-31556][SQL][DOCS] Document LIKE clause in SQL Reference

2020-04-25 Thread GitBox
SparkQA commented on pull request #28332: URL: https://github.com/apache/spark/pull/28332#issuecomment-619452746 **[Test build #121819 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121819/testReport)** for PR 28332 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28332: [SPARK-31556][SQL][DOCS] Document LIKE clause in SQL Reference

2020-04-25 Thread GitBox
AmplabJenkins commented on pull request #28332: URL: https://github.com/apache/spark/pull/28332#issuecomment-619452781 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28332: [SPARK-31556][SQL][DOCS] Document LIKE clause in SQL Reference

2020-04-25 Thread GitBox
SparkQA removed a comment on pull request #28332: URL: https://github.com/apache/spark/pull/28332#issuecomment-619451453 **[Test build #121819 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121819/testReport)** for PR 28332 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28332: [SPARK-31556][SQL][DOCS] Document LIKE clause in SQL Reference

2020-04-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28332: URL: https://github.com/apache/spark/pull/28332#issuecomment-619452781 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28341: [SPARK-31552][SQL][2.4] Fix ClassCastException in ScalaReflection arrayClassFor

2020-04-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28341: URL: https://github.com/apache/spark/pull/28341#issuecomment-619452184 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #28341: [SPARK-31552][SQL][2.4] Fix ClassCastException in ScalaReflection arrayClassFor

2020-04-25 Thread GitBox
SparkQA removed a comment on pull request #28341: URL: https://github.com/apache/spark/pull/28341#issuecomment-619429687 **[Test build #121811 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121811/testReport)** for PR 28341 at commit

[GitHub] [spark] maropu commented on a change in pull request #28332: [SPARK-31556][SQL][DOCS] Document LIKE clause in SQL Reference

2020-04-25 Thread GitBox
maropu commented on a change in pull request #28332: URL: https://github.com/apache/spark/pull/28332#discussion_r415163243 ## File path: docs/sql-ref-syntax-qry-select-like.md ## @@ -0,0 +1,113 @@ +--- +layout: global +title: LIKE Predicate +displayTitle: LIKE Predicate

[GitHub] [spark] AmplabJenkins commented on pull request #28341: [SPARK-31552][SQL][2.4] Fix ClassCastException in ScalaReflection arrayClassFor

2020-04-25 Thread GitBox
AmplabJenkins commented on pull request #28341: URL: https://github.com/apache/spark/pull/28341#issuecomment-619452184 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] maropu commented on a change in pull request #28332: [SPARK-31556][SQL][DOCS] Document LIKE clause in SQL Reference

2020-04-25 Thread GitBox
maropu commented on a change in pull request #28332: URL: https://github.com/apache/spark/pull/28332#discussion_r415163243 ## File path: docs/sql-ref-syntax-qry-select-like.md ## @@ -0,0 +1,113 @@ +--- +layout: global +title: LIKE Predicate +displayTitle: LIKE Predicate

[GitHub] [spark] SparkQA commented on pull request #28341: [SPARK-31552][SQL][2.4] Fix ClassCastException in ScalaReflection arrayClassFor

2020-04-25 Thread GitBox
SparkQA commented on pull request #28341: URL: https://github.com/apache/spark/pull/28341#issuecomment-619452024 **[Test build #121811 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121811/testReport)** for PR 28341 at commit

[GitHub] [spark] huaxingao commented on a change in pull request #28332: [SPARK-31556][SQL][DOCS] Document LIKE clause in SQL Reference

2020-04-25 Thread GitBox
huaxingao commented on a change in pull request #28332: URL: https://github.com/apache/spark/pull/28332#discussion_r415162543 ## File path: docs/sql-ref-syntax-qry-select-like.md ## @@ -0,0 +1,113 @@ +--- +layout: global +title: LIKE Predicate +displayTitle: LIKE Predicate

[GitHub] [spark] SparkQA commented on pull request #28332: [SPARK-31556][SQL][DOCS] Document LIKE clause in SQL Reference

2020-04-25 Thread GitBox
SparkQA commented on pull request #28332: URL: https://github.com/apache/spark/pull/28332#issuecomment-619451453 **[Test build #121819 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121819/testReport)** for PR 28332 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28332: [SPARK-31556][SQL][DOCS] Document LIKE clause in SQL Reference

2020-04-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28332: URL: https://github.com/apache/spark/pull/28332#issuecomment-619450894 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] maropu commented on a change in pull request #28342: [SPARK-31562][SQL] Update ExpressionDescription for substring, current_date, and current_timestamp

2020-04-25 Thread GitBox
maropu commented on a change in pull request #28342: URL: https://github.com/apache/spark/pull/28342#discussion_r415161264 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -83,26 +93,44 @@ case class

[GitHub] [spark] maropu commented on pull request #28342: [SPARK-31562][SQL] Update ExpressionDescription for substring, current_date, and current_timestamp

2020-04-25 Thread GitBox
maropu commented on pull request #28342: URL: https://github.com/apache/spark/pull/28342#issuecomment-619450993 cc: @HyukjinKwon @cloud-fan This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] AmplabJenkins commented on pull request #28332: [SPARK-31556][SQL][DOCS] Document LIKE clause in SQL Reference

2020-04-25 Thread GitBox
AmplabJenkins commented on pull request #28332: URL: https://github.com/apache/spark/pull/28332#issuecomment-619450894 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] imback82 commented on a change in pull request #26921: [SPARK-30282][SQL] Migrate SHOW TBLPROPERTIES to new framework

2020-04-25 Thread GitBox
imback82 commented on a change in pull request #26921: URL: https://github.com/apache/spark/pull/26921#discussion_r415153569 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ## @@ -900,22 +900,15 @@ case class

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28261: [SPARK-31489][SQL][test-hive1.2] Fix pushing down filters with `java.time.LocalDate` values in ORC

2020-04-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28261: URL: https://github.com/apache/spark/pull/28261#issuecomment-619446008 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28261: [SPARK-31489][SQL][test-hive1.2] Fix pushing down filters with `java.time.LocalDate` values in ORC

2020-04-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28261: URL: https://github.com/apache/spark/pull/28261#issuecomment-619446006 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28261: [SPARK-31489][SQL][test-hive1.2] Fix pushing down filters with `java.time.LocalDate` values in ORC

2020-04-25 Thread GitBox
AmplabJenkins commented on pull request #28261: URL: https://github.com/apache/spark/pull/28261#issuecomment-619446006 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28261: [SPARK-31489][SQL][test-hive1.2] Fix pushing down filters with `java.time.LocalDate` values in ORC

2020-04-25 Thread GitBox
SparkQA removed a comment on pull request #28261: URL: https://github.com/apache/spark/pull/28261#issuecomment-619435971 **[Test build #121813 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121813/testReport)** for PR 28261 at commit

[GitHub] [spark] SparkQA commented on pull request #28261: [SPARK-31489][SQL][test-hive1.2] Fix pushing down filters with `java.time.LocalDate` values in ORC

2020-04-25 Thread GitBox
SparkQA commented on pull request #28261: URL: https://github.com/apache/spark/pull/28261#issuecomment-619445980 **[Test build #121813 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121813/testReport)** for PR 28261 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28328: [SPARK-31553][SQL] Fix isInCollection for collection sizes above the optimisation threshold

2020-04-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28328: URL: https://github.com/apache/spark/pull/28328#issuecomment-619443222 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] dongjoon-hyun commented on pull request #28215: [SPARK-31272][SQL] Support DB2 Kerberos login in JDBC connector

2020-04-25 Thread GitBox
dongjoon-hyun commented on pull request #28215: URL: https://github.com/apache/spark/pull/28215#issuecomment-619445001 Hi, Guys. Currently, all the other suites including DB2IntegrationSuite passed . Only `DB2KrbIntegrationSuite` fails. This PR seems to need more verification. Although

[GitHub] [spark] AmplabJenkins commented on pull request #28328: [SPARK-31553][SQL] Fix isInCollection for collection sizes above the optimisation threshold

2020-04-25 Thread GitBox
AmplabJenkins commented on pull request #28328: URL: https://github.com/apache/spark/pull/28328#issuecomment-619443222 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28328: [SPARK-31553][SQL] Fix isInCollection for collection sizes above the optimisation threshold

2020-04-25 Thread GitBox
SparkQA commented on pull request #28328: URL: https://github.com/apache/spark/pull/28328#issuecomment-619443113 **[Test build #121818 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121818/testReport)** for PR 28328 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28318: [SPARK-31535][SQL] Fix nested CTE substitution

2020-04-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28318: URL: https://github.com/apache/spark/pull/28318#issuecomment-619442396 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28318: [SPARK-31535][SQL] Fix nested CTE substitution

2020-04-25 Thread GitBox
AmplabJenkins commented on pull request #28318: URL: https://github.com/apache/spark/pull/28318#issuecomment-619442396 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28318: [SPARK-31535][SQL] Fix nested CTE substitution

2020-04-25 Thread GitBox
SparkQA commented on pull request #28318: URL: https://github.com/apache/spark/pull/28318#issuecomment-619442248 **[Test build #121817 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121817/testReport)** for PR 28318 at commit

[GitHub] [spark] dongjoon-hyun commented on pull request #28318: [SPARK-31535][SQL] Fix nested CTE substitution

2020-04-25 Thread GitBox
dongjoon-hyun commented on pull request #28318: URL: https://github.com/apache/spark/pull/28318#issuecomment-619441849 Retest this please. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #28317: [SPARK-31534][WEBUI] Text for tooltip should be escaped.

2020-04-25 Thread GitBox
dongjoon-hyun edited a comment on pull request #28317: URL: https://github.com/apache/spark/pull/28317#issuecomment-619438678 @sarutak . I've been digging the following error message, but didn't find a clue. Do you have any idea about this ERROR message in your new test case? It's not a

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28328: [SPARK-31553][SQL] Fix isInCollection for collection sizes above the optimisation threshold

2020-04-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28328: URL: https://github.com/apache/spark/pull/28328#issuecomment-619440409 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on pull request #28345: [SPARK-31557][SQL] Legacy time parser should return Gregorian days rather than Julian days

2020-04-25 Thread GitBox
SparkQA commented on pull request #28345: URL: https://github.com/apache/spark/pull/28345#issuecomment-619440546 **[Test build #121816 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121816/testReport)** for PR 28345 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28345: [SPARK-31557][SQL] Legacy time parser should return Gregorian days rather than Julian days

2020-04-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28345: URL: https://github.com/apache/spark/pull/28345#issuecomment-619424014 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] [spark] SparkQA removed a comment on pull request #28328: [SPARK-31553][SQL] Fix isInCollection for collection sizes above the optimisation threshold

2020-04-25 Thread GitBox
SparkQA removed a comment on pull request #28328: URL: https://github.com/apache/spark/pull/28328#issuecomment-619439652 **[Test build #121815 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121815/testReport)** for PR 28328 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28328: [SPARK-31553][SQL] Fix isInCollection for collection sizes above the optimisation threshold

2020-04-25 Thread GitBox
AmplabJenkins removed a comment on pull request #28328: URL: https://github.com/apache/spark/pull/28328#issuecomment-619440406 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA commented on pull request #28328: [SPARK-31553][SQL] Fix isInCollection for collection sizes above the optimisation threshold

2020-04-25 Thread GitBox
SparkQA commented on pull request #28328: URL: https://github.com/apache/spark/pull/28328#issuecomment-619440402 **[Test build #121815 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121815/testReport)** for PR 28328 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28328: [SPARK-31553][SQL] Fix isInCollection for collection sizes above the optimisation threshold

2020-04-25 Thread GitBox
AmplabJenkins commented on pull request #28328: URL: https://github.com/apache/spark/pull/28328#issuecomment-619440406 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] dongjoon-hyun commented on pull request #28333: [SPARK-31558][UI] Code clean up in spark-sql-viz.js

2020-04-25 Thread GitBox
dongjoon-hyun commented on pull request #28333: URL: https://github.com/apache/spark/pull/28333#issuecomment-619440309 +1, late LGTM. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] bersprockets commented on a change in pull request #28345: [SPARK-31557][SQL] Legacy time parser should return Gregorian days rather than Julian days

2020-04-25 Thread GitBox
bersprockets commented on a change in pull request #28345: URL: https://github.com/apache/spark/pull/28345#discussion_r415143105 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateFormatter.scala ## @@ -67,7 +67,8 @@ trait LegacyDateFormatter

<    1   2   3   4   >