[GitHub] [spark] AmplabJenkins removed a comment on pull request #28294: [SPARK-31519][SQL] Cast in having aggregate expressions returns the wrong result

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28294: URL: https://github.com/apache/spark/pull/28294#issuecomment-619853727 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28365: [SPARK-31571][R] overhaul stop/message/warning calls to be more translation-friendly/canonical

2020-04-27 Thread GitBox
HyukjinKwon commented on a change in pull request #28365: URL: https://github.com/apache/spark/pull/28365#discussion_r415655186 ## File path: R/pkg/R/utils.R ## @@ -369,8 +371,9 @@ varargsToStrEnv <- function(...) { } if (length(ignoredNames) != 0) { -warning(paste0

[GitHub] [spark] SparkQA removed a comment on pull request #28294: [SPARK-31519][SQL] Cast in having aggregate expressions returns the wrong result

2020-04-27 Thread GitBox
SparkQA removed a comment on pull request #28294: URL: https://github.com/apache/spark/pull/28294#issuecomment-619783728 **[Test build #121884 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121884/testReport)** for PR 28294 at commit [`d4ac6d7`](https://gi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28294: [SPARK-31519][SQL] Cast in having aggregate expressions returns the wrong result

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28294: URL: https://github.com/apache/spark/pull/28294#issuecomment-619853722 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins commented on pull request #28294: [SPARK-31519][SQL] Cast in having aggregate expressions returns the wrong result

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28294: URL: https://github.com/apache/spark/pull/28294#issuecomment-619853722 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28294: [SPARK-31519][SQL] Cast in having aggregate expressions returns the wrong result

2020-04-27 Thread GitBox
SparkQA commented on pull request #28294: URL: https://github.com/apache/spark/pull/28294#issuecomment-619853417 **[Test build #121884 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121884/testReport)** for PR 28294 at commit [`d4ac6d7`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28109: [SPARK-31524][SQL][followup] Add metric to the split task number for skew optimization

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28109: URL: https://github.com/apache/spark/pull/28109#issuecomment-619852268 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121

[GitHub] [spark] SparkQA removed a comment on pull request #28109: [SPARK-31524][SQL][followup] Add metric to the split task number for skew optimization

2020-04-27 Thread GitBox
SparkQA removed a comment on pull request #28109: URL: https://github.com/apache/spark/pull/28109#issuecomment-619851103 **[Test build #121895 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121895/testReport)** for PR 28109 at commit [`2e512b4`](https://gi

[GitHub] [spark] AmplabJenkins commented on pull request #28109: [SPARK-31524][SQL][followup] Add metric to the split task number for skew optimization

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28109: URL: https://github.com/apache/spark/pull/28109#issuecomment-619852256 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28109: [SPARK-31524][SQL][followup] Add metric to the split task number for skew optimization

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28109: URL: https://github.com/apache/spark/pull/28109#issuecomment-619852256 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] SparkQA commented on pull request #28109: [SPARK-31524][SQL][followup] Add metric to the split task number for skew optimization

2020-04-27 Thread GitBox
SparkQA commented on pull request #28109: URL: https://github.com/apache/spark/pull/28109#issuecomment-619852234 **[Test build #121895 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121895/testReport)** for PR 28109 at commit [`2e512b4`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28367: [SPARK-31573][R] apply fixed=TRUE as appropriate to regex usage in R

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28367: URL: https://github.com/apache/spark/pull/28367#issuecomment-619851725 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28109: [SPARK-31524][SQL][followup] Add metric to the split task number for skew optimization

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28109: URL: https://github.com/apache/spark/pull/28109#issuecomment-619851779 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28109: [SPARK-31524][SQL][followup] Add metric to the split task number for skew optimization

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28109: URL: https://github.com/apache/spark/pull/28109#issuecomment-619851779 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #28367: [SPARK-31573][R] apply fixed=TRUE as appropriate to regex usage in R

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28367: URL: https://github.com/apache/spark/pull/28367#issuecomment-619851725 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28109: [SPARK-31524][SQL][followup] Add metric to the split task number for skew optimization

2020-04-27 Thread GitBox
SparkQA commented on pull request #28109: URL: https://github.com/apache/spark/pull/28109#issuecomment-619851103 **[Test build #121895 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121895/testReport)** for PR 28109 at commit [`2e512b4`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #28367: [SPARK-31573][R] apply fixed=TRUE as appropriate to regex usage in R

2020-04-27 Thread GitBox
SparkQA commented on pull request #28367: URL: https://github.com/apache/spark/pull/28367#issuecomment-619851054 **[Test build #121894 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121894/testReport)** for PR 28367 at commit [`8676253`](https://github.com

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28367: [SPARK-31573][R] apply fixed=TRUE as appropriate to regex usage in R

2020-04-27 Thread GitBox
HyukjinKwon commented on a change in pull request #28367: URL: https://github.com/apache/spark/pull/28367#discussion_r415651442 ## File path: R/pkg/R/sparkR.R ## @@ -606,7 +606,7 @@ getClientModeSparkSubmitOpts <- function(submitOps, sparkEnvirMap) { # process only if --o

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28367: [SPARK-31573][R] apply fixed=TRUE as appropriate to regex usage in R

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28367: URL: https://github.com/apache/spark/pull/28367#issuecomment-619823651 Can one of the admins verify this patch? This is an automated message from the Apache Git Service.

[GitHub] [spark] HyukjinKwon commented on pull request #28367: [SPARK-31573][R] apply fixed=TRUE as appropriate to regex usage in R

2020-04-27 Thread GitBox
HyukjinKwon commented on pull request #28367: URL: https://github.com/apache/spark/pull/28367#issuecomment-619849863 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [spark] SparkQA removed a comment on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

2020-04-27 Thread GitBox
SparkQA removed a comment on pull request #28362: URL: https://github.com/apache/spark/pull/28362#issuecomment-619819692 **[Test build #121892 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121892/testReport)** for PR 28362 at commit [`6ad2085`](https://gi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28362: URL: https://github.com/apache/spark/pull/28362#issuecomment-619848709 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28362: URL: https://github.com/apache/spark/pull/28362#issuecomment-619848709 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

2020-04-27 Thread GitBox
SparkQA commented on pull request #28362: URL: https://github.com/apache/spark/pull/28362#issuecomment-619848483 **[Test build #121892 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121892/testReport)** for PR 28362 at commit [`6ad2085`](https://github.co

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #28215: [SPARK-31272][SQL] Support DB2 Kerberos login in JDBC connector

2020-04-27 Thread GitBox
gaborgsomogyi commented on a change in pull request #28215: URL: https://github.com/apache/spark/pull/28215#discussion_r415647618 ## File path: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/DB2KrbIntegrationSuite.scala ## @@ -0,0 +1,89 @@ +/* + * L

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28109: [SPARK-31524][SQL][followup] Add metric to the split task number for skew optimization

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28109: URL: https://github.com/apache/spark/pull/28109#issuecomment-619847107 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28109: [SPARK-31524][SQL][followup] Add metric to the split task number for skew optimization

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28109: URL: https://github.com/apache/spark/pull/28109#issuecomment-619847107 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28109: [SPARK-31524][SQL][followup] Add metric to the split task number for skew optimization

2020-04-27 Thread GitBox
SparkQA commented on pull request #28109: URL: https://github.com/apache/spark/pull/28109#issuecomment-619846231 **[Test build #121893 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121893/testReport)** for PR 28109 at commit [`2a26813`](https://github.com

[GitHub] [spark] cloud-fan commented on a change in pull request #28109: [SPARK-31524][SQL][followup] Add metric to the split task number for skew optimization

2020-04-27 Thread GitBox
cloud-fan commented on a change in pull request #28109: URL: https://github.com/apache/spark/pull/28109#discussion_r415645175 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/CustomShuffleReaderExec.scala ## @@ -121,12 +122,22 @@ case class CustomS

[GitHub] [spark] maropu commented on a change in pull request #28215: [SPARK-31272][SQL] Support DB2 Kerberos login in JDBC connector

2020-04-27 Thread GitBox
maropu commented on a change in pull request #28215: URL: https://github.com/apache/spark/pull/28215#discussion_r415642664 ## File path: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/DB2KrbIntegrationSuite.scala ## @@ -0,0 +1,89 @@ +/* + * Licensed

[GitHub] [spark] maropu commented on pull request #28322: [SPARK-31550][SQL][DOCS] Set nondeterministic configurations with general meanings in sql configuration doc

2020-04-27 Thread GitBox
maropu commented on pull request #28322: URL: https://github.com/apache/spark/pull/28322#issuecomment-619835884 late LGTM, thanks for the update, @yaooqinn This is an automated message from the Apache Git Service. To respond

[GitHub] [spark] HeartSaVioR edited a comment on pull request #28326: [SPARK-27340][SS] Alias on TimeWindow expression cause watermark metadata lost

2020-04-27 Thread GitBox
HeartSaVioR edited a comment on pull request #28326: URL: https://github.com/apache/spark/pull/28326#issuecomment-619831846 > Each Attribute/Alias has its own metadata and can easily be hidden by the outer-most Alias. Yeah I see the concern - I'm not sure the column metadata was cons

[GitHub] [spark] HeartSaVioR commented on pull request #28326: [SPARK-27340][SS] Alias on TimeWindow expression cause watermark metadata lost

2020-04-27 Thread GitBox
HeartSaVioR commented on pull request #28326: URL: https://github.com/apache/spark/pull/28326#issuecomment-619831846 > Each Attribute/Alias has its own metadata and can easily be hidden by the outer-most Alias. Yeah I see the concern - I'm not sure the column metadata was considered

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28361: [SPARK-31572][SQL][CORE] Improve task logs at executor side

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28361: URL: https://github.com/apache/spark/pull/28361#issuecomment-619823033 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28367: [SPARK-31573][R] apply fixed=TRUE as appropriate to regex usage in R

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28367: URL: https://github.com/apache/spark/pull/28367#issuecomment-619823119 Can one of the admins verify this patch? This is an automated message from the Apache Git Service.

[GitHub] [spark] AmplabJenkins commented on pull request #28367: [SPARK-31573][R] apply fixed=TRUE as appropriate to regex usage in R

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28367: URL: https://github.com/apache/spark/pull/28367#issuecomment-619823651 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To resp

[GitHub] [spark] SparkQA removed a comment on pull request #28361: [SPARK-31572][SQL][CORE] Improve task logs at executor side

2020-04-27 Thread GitBox
SparkQA removed a comment on pull request #28361: URL: https://github.com/apache/spark/pull/28361#issuecomment-619816052 **[Test build #121890 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121890/testReport)** for PR 28361 at commit [`5099431`](https://gi

[GitHub] [spark] AmplabJenkins commented on pull request #28367: [SPARK-31573][R] apply fixed=TRUE as appropriate to regex usage in R

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28367: URL: https://github.com/apache/spark/pull/28367#issuecomment-619823119 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To resp

[GitHub] [spark] SparkQA commented on pull request #28361: [SPARK-31572][SQL][CORE] Improve task logs at executor side

2020-04-27 Thread GitBox
SparkQA commented on pull request #28361: URL: https://github.com/apache/spark/pull/28361#issuecomment-619822977 **[Test build #121890 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121890/testReport)** for PR 28361 at commit [`5099431`](https://github.co

[GitHub] [spark] AmplabJenkins commented on pull request #28361: [SPARK-31572][SQL][CORE] Improve task logs at executor side

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28361: URL: https://github.com/apache/spark/pull/28361#issuecomment-619823023 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28361: [SPARK-31572][SQL][CORE] Improve task logs at executor side

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28361: URL: https://github.com/apache/spark/pull/28361#issuecomment-619823023 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] MichaelChirico opened a new pull request #28367: [SPARK-31573][R] apply fixed=TRUE as appropriate to regex usage in R

2020-04-27 Thread GitBox
MichaelChirico opened a new pull request #28367: URL: https://github.com/apache/spark/pull/28367 ### What changes were proposed in this pull request? For regex functions in base R (`gsub`, `grep`, `grepl`, `strsplit`, `gregexpr`), supplying the `fixed=TRUE` option will be

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28366: [WIP][SPARK-31365][SQL] Enable nested predicate pushdown per data sources

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28366: URL: https://github.com/apache/spark/pull/28366#issuecomment-619820342 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28362: URL: https://github.com/apache/spark/pull/28362#issuecomment-619820262 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28362: URL: https://github.com/apache/spark/pull/28362#issuecomment-619820262 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28366: [WIP][SPARK-31365][SQL] Enable nested predicate pushdown per data sources

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28366: URL: https://github.com/apache/spark/pull/28366#issuecomment-619820342 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

2020-04-27 Thread GitBox
SparkQA commented on pull request #28362: URL: https://github.com/apache/spark/pull/28362#issuecomment-619819692 **[Test build #121892 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121892/testReport)** for PR 28362 at commit [`6ad2085`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #28366: [WIP][SPARK-31365][SQL] Enable nested predicate pushdown per data sources

2020-04-27 Thread GitBox
SparkQA commented on pull request #28366: URL: https://github.com/apache/spark/pull/28366#issuecomment-619819648 **[Test build #121891 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121891/testReport)** for PR 28366 at commit [`6feaaa4`](https://github.com

[GitHub] [spark] HeartSaVioR commented on pull request #27664: [SPARK-30915][SS] CompactibleFileStreamLog: Avoid reading the metadata log file when finding the latest batch ID

2020-04-27 Thread GitBox
HeartSaVioR commented on pull request #27664: URL: https://github.com/apache/spark/pull/27664#issuecomment-619819838 I'm sorry, but I think the name of the method should represent the thing what it does. That's why the boolean parameters have been considered as code smell and even we encou

[GitHub] [spark] viirya opened a new pull request #28366: [WIP][SPARK-31365][SQL] Enable nested predicate pushdown per data sources

2020-04-27 Thread GitBox
viirya opened a new pull request #28366: URL: https://github.com/apache/spark/pull/28366 ### What changes were proposed in this pull request? This patch proposes to replace `NESTED_PREDICATE_PUSHDOWN_ENABLED` with `NESTED_PREDICATE_PUSHDOWN_V1_SOURCE_LIST` which can confi

[GitHub] [spark] AmplabJenkins commented on pull request #28361: [SPARK-31572][SQL][CORE] Improve task logs at executor side

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28361: URL: https://github.com/apache/spark/pull/28361#issuecomment-619816621 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28361: [SPARK-31572][SQL][CORE] Improve task logs at executor side

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28361: URL: https://github.com/apache/spark/pull/28361#issuecomment-619816621 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] MichaelChirico commented on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

2020-04-27 Thread GitBox
MichaelChirico commented on pull request #28362: URL: https://github.com/apache/spark/pull/28362#issuecomment-619816774 @HyukjinKwon just merged vs master, ready to merge when you are 👍 This is an automated message from the

[GitHub] [spark] AmplabJenkins commented on pull request #28365: [SPARK-31571][R] overhaul stop/message/warning calls to be more translation-friendly/canonical

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28365: URL: https://github.com/apache/spark/pull/28365#issuecomment-619816305 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To resp

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28365: [SPARK-31571][R] overhaul stop/message/warning calls to be more translation-friendly/canonical

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28365: URL: https://github.com/apache/spark/pull/28365#issuecomment-619815746 Can one of the admins verify this patch? This is an automated message from the Apache Git Service.

[GitHub] [spark] gengliangwang commented on pull request #28317: [SPARK-31534][WEBUI] Text for tooltip should be escaped.

2020-04-27 Thread GitBox
gengliangwang commented on pull request #28317: URL: https://github.com/apache/spark/pull/28317#issuecomment-619816236 Late LGTM, nice catch! This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [spark] SparkQA commented on pull request #28361: [SPARK-31572][SQL][CORE] Improve task logs at executor side

2020-04-27 Thread GitBox
SparkQA commented on pull request #28361: URL: https://github.com/apache/spark/pull/28361#issuecomment-619816052 **[Test build #121890 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121890/testReport)** for PR 28361 at commit [`5099431`](https://github.com

[GitHub] [spark] AmplabJenkins commented on pull request #28365: [SPARK-31571][R] overhaul stop/message/warning calls to be more translation-friendly/canonical

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28365: URL: https://github.com/apache/spark/pull/28365#issuecomment-619815746 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To resp

[GitHub] [spark] AmplabJenkins commented on pull request #26141: [SPARK-29492][SQL]Reset HiveSession's SessionState conf's ClassLoader when sync mode

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #26141: URL: https://github.com/apache/spark/pull/26141#issuecomment-619815689 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #26141: [SPARK-29492][SQL]Reset HiveSession's SessionState conf's ClassLoader when sync mode

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #26141: URL: https://github.com/apache/spark/pull/26141#issuecomment-619815689 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #26141: [SPARK-29492][SQL]Reset HiveSession's SessionState conf's ClassLoader when sync mode

2020-04-27 Thread GitBox
SparkQA removed a comment on pull request #26141: URL: https://github.com/apache/spark/pull/26141#issuecomment-619791847 **[Test build #121885 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121885/testReport)** for PR 26141 at commit [`1478de5`](https://gi

[GitHub] [spark] SparkQA commented on pull request #26141: [SPARK-29492][SQL]Reset HiveSession's SessionState conf's ClassLoader when sync mode

2020-04-27 Thread GitBox
SparkQA commented on pull request #26141: URL: https://github.com/apache/spark/pull/26141#issuecomment-619815367 **[Test build #121885 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121885/testReport)** for PR 26141 at commit [`1478de5`](https://github.co

[GitHub] [spark] MichaelChirico commented on a change in pull request #28365: [SPARK-31571][R] overhaul stop/message/warning calls to be more translation-friendly/canonical

2020-04-27 Thread GitBox
MichaelChirico commented on a change in pull request #28365: URL: https://github.com/apache/spark/pull/28365#discussion_r415607129 ## File path: R/pkg/R/client.R ## @@ -102,10 +102,17 @@ checkJavaVersion <- function() { javaVersionNum <- as.integer(versions[1]) } if

[GitHub] [spark] Ngone51 commented on pull request #28361: [SPARK-31572][SQL][CORE] Improve task logs at executor side

2020-04-27 Thread GitBox
Ngone51 commented on pull request #28361: URL: https://github.com/apache/spark/pull/28361#issuecomment-619814450 cc @cloud-fan @gatorsmile @jiangxb1987 This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] Ngone51 commented on pull request #28361: [SPARK-31572][SQL][CORE] Improve task logs at executor side

2020-04-27 Thread GitBox
Ngone51 commented on pull request #28361: URL: https://github.com/apache/spark/pull/28361#issuecomment-619814328 retest this please. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28364: [SPARK-31529][SQL][3.0] Remove extra whitespaces in formatted explain

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28364: URL: https://github.com/apache/spark/pull/28364#issuecomment-619813086 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] MichaelChirico opened a new pull request #28365: [SPARK-31571][R] overhaul stop/message/warning calls to be more translation-friendly/canonical

2020-04-27 Thread GitBox
MichaelChirico opened a new pull request #28365: URL: https://github.com/apache/spark/pull/28365 ### What changes were proposed in this pull request? Internal usages like `{stop,warning,message}({paste,paste0,sprintf}` and `{stop,warning,message}(some_literal_string_as_va

[GitHub] [spark] AmplabJenkins commented on pull request #28364: [SPARK-31529][SQL][3.0] Remove extra whitespaces in formatted explain

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28364: URL: https://github.com/apache/spark/pull/28364#issuecomment-619813086 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] MichaelChirico commented on a change in pull request #28365: [SPARK-31571][R] overhaul stop/message/warning calls to be more translation-friendly/canonical

2020-04-27 Thread GitBox
MichaelChirico commented on a change in pull request #28365: URL: https://github.com/apache/spark/pull/28365#discussion_r415605354 ## File path: R/pkg/R/DataFrame.R ## @@ -431,7 +431,7 @@ setMethod("coltypes", if (is.null(type)) { specialtype

[GitHub] [spark] SparkQA commented on pull request #28364: [SPARK-31529][SQL][3.0] Remove extra whitespaces in formatted explain

2020-04-27 Thread GitBox
SparkQA commented on pull request #28364: URL: https://github.com/apache/spark/pull/28364#issuecomment-619812417 **[Test build #121888 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121888/testReport)** for PR 28364 at commit [`d993c39`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

2020-04-27 Thread GitBox
SparkQA commented on pull request #28362: URL: https://github.com/apache/spark/pull/28362#issuecomment-619812405 **[Test build #121889 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121889/testReport)** for PR 28362 at commit [`e8c20cf`](https://github.com

[GitHub] [spark] gaborgsomogyi commented on pull request #28215: [SPARK-31272][SQL] Support DB2 Kerberos login in JDBC connector

2020-04-27 Thread GitBox
gaborgsomogyi commented on pull request #28215: URL: https://github.com/apache/spark/pull/28215#issuecomment-619811920 That said maybe my environment is just a lucky one and would be good to take a look at the logs from test side and from container side as well. --

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #28215: [SPARK-31272][SQL] Support DB2 Kerberos login in JDBC connector

2020-04-27 Thread GitBox
gaborgsomogyi commented on a change in pull request #28215: URL: https://github.com/apache/spark/pull/28215#discussion_r415601863 ## File path: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/DB2KrbIntegrationSuite.scala ## @@ -0,0 +1,89 @@ +/* + * L

[GitHub] [spark] Ngone51 opened a new pull request #28364: [SPARK-31529][SQL][3.0] Remove extra whitespaces in formatted explain

2020-04-27 Thread GitBox
Ngone51 opened a new pull request #28364: URL: https://github.com/apache/spark/pull/28364 ### What changes were proposed in this pull request? Remove all the extra whitespaces in the formatted explain. ### Why are the changes needed? The number of extra w

[GitHub] [spark] Ngone51 commented on pull request #28364: [SPARK-31529][SQL][3.0] Remove extra whitespaces in formatted explain

2020-04-27 Thread GitBox
Ngone51 commented on pull request #28364: URL: https://github.com/apache/spark/pull/28364#issuecomment-619810378 cc @cloud-fan This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [spark] gaborgsomogyi commented on pull request #28215: [SPARK-31272][SQL] Support DB2 Kerberos login in JDBC connector

2020-04-27 Thread GitBox
gaborgsomogyi commented on pull request #28215: URL: https://github.com/apache/spark/pull/28215#issuecomment-619809840 @dongjoon-hyun here is my environment (just checked the latest master and still works): * MacBook Pro * macOS Catalina 10.15.3 (19D76) * openjdk version "1.8.0_242

[GitHub] [spark] AmplabJenkins commented on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28362: URL: https://github.com/apache/spark/pull/28362#issuecomment-619809487 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] HyukjinKwon commented on pull request #28322: [SPARK-31550][SQL][DOCS] Set nondeterministic configurations with general meanings in sql configuration doc

2020-04-27 Thread GitBox
HyukjinKwon commented on pull request #28322: URL: https://github.com/apache/spark/pull/28322#issuecomment-619809750 Merged to master and branch-3.0. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28362: URL: https://github.com/apache/spark/pull/28362#issuecomment-619809487 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28362: URL: https://github.com/apache/spark/pull/28362#issuecomment-619792192 Can one of the admins verify this patch? This is an automated message from the Apache Git Service.

[GitHub] [spark] HyukjinKwon commented on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

2020-04-27 Thread GitBox
HyukjinKwon commented on pull request #28362: URL: https://github.com/apache/spark/pull/28362#issuecomment-619808938 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [spark] HyukjinKwon commented on pull request #28350: [SPARK-31568][R][DOCS] Add detail about func/key in gapply to documentation

2020-04-27 Thread GitBox
HyukjinKwon commented on pull request #28350: URL: https://github.com/apache/spark/pull/28350#issuecomment-619808224 Merged to master, branch-3.0 and branch-2.4. This is an automated message from the Apache Git Service. To re

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27617: [SPARK-30865][SQL] Refactor DateTimeUtils

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #27617: URL: https://github.com/apache/spark/pull/27617#issuecomment-619801995 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #27617: [SPARK-30865][SQL] Refactor DateTimeUtils

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #27617: URL: https://github.com/apache/spark/pull/27617#issuecomment-619801995 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #27617: [SPARK-30865][SQL] Refactor DateTimeUtils

2020-04-27 Thread GitBox
SparkQA commented on pull request #27617: URL: https://github.com/apache/spark/pull/27617#issuecomment-619800492 **[Test build #121887 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121887/testReport)** for PR 27617 at commit [`70a057f`](https://github.com

[GitHub] [spark] MaxGekk commented on pull request #27617: [SPARK-30865][SQL] Refactor DateTimeUtils

2020-04-27 Thread GitBox
MaxGekk commented on pull request #27617: URL: https://github.com/apache/spark/pull/27617#issuecomment-619798145 jenkins, retest this, please This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [spark] HeartSaVioR commented on pull request #28363: [SPARK-27188][SS] FileStreamSink: provide a new option to have retention on output files

2020-04-27 Thread GitBox
HeartSaVioR commented on pull request #28363: URL: https://github.com/apache/spark/pull/28363#issuecomment-619796653 cc. @tdas @zsxwing @jose-torres @gaborgsomogyi This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28363: [SPARK-27188][SS] FileStreamSink: provide a new option to have retention on output files

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28363: URL: https://github.com/apache/spark/pull/28363#issuecomment-619796828 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28363: [SPARK-27188][SS] FileStreamSink: provide a new option to have retention on output files

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28363: URL: https://github.com/apache/spark/pull/28363#issuecomment-619796828 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28363: [SPARK-27188][SS] FileStreamSink: provide a new option to have retention on output files

2020-04-27 Thread GitBox
SparkQA commented on pull request #28363: URL: https://github.com/apache/spark/pull/28363#issuecomment-619796131 **[Test build #121886 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121886/testReport)** for PR 28363 at commit [`31603b4`](https://github.com

[GitHub] [spark] cloud-fan commented on pull request #28328: [SPARK-31553][SQL] Fix isInCollection for collection sizes above the optimisation threshold

2020-04-27 Thread GitBox
cloud-fan commented on pull request #28328: URL: https://github.com/apache/spark/pull/28328#issuecomment-619795854 A `In` with many values is slow to analyze, as the type coercion rules or `In.resolved` are very slow. This i

[GitHub] [spark] Ngone51 commented on pull request #28315: [SPARK-31529][SQL] Remove extra whitespaces in formatted explain

2020-04-27 Thread GitBox
Ngone51 commented on pull request #28315: URL: https://github.com/apache/spark/pull/28315#issuecomment-619794371 Sure, thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] cloud-fan commented on pull request #28315: [SPARK-31529][SQL] Remove extra whitespaces in formatted explain

2020-04-27 Thread GitBox
cloud-fan commented on pull request #28315: URL: https://github.com/apache/spark/pull/28315#issuecomment-619794108 @Ngone51 can you send a PR for 3.0 if there is something we need to fix? This is an automated message from the

[GitHub] [spark] cloud-fan commented on pull request #28315: [SPARK-31529][SQL] Remove extra whitespaces in formatted explain

2020-04-27 Thread GitBox
cloud-fan commented on pull request #28315: URL: https://github.com/apache/spark/pull/28315#issuecomment-619793759 thanks, merging to master! This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [spark] viirya commented on pull request #28328: [SPARK-31553][SQL] Fix isInCollection for collection sizes above the optimisation threshold

2020-04-27 Thread GitBox
viirya commented on pull request #28328: URL: https://github.com/apache/spark/pull/28328#issuecomment-619793314 > Actually this PR shows we still need `InSet`, to make the analyzer fast... What that means? We optimize `In` with `InSet` in optimizer, right? --

[GitHub] [spark] AmplabJenkins removed a comment on pull request #26141: [SPARK-29492][SQL]Reset HiveSession's SessionState conf's ClassLoader when sync mode

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #26141: URL: https://github.com/apache/spark/pull/26141#issuecomment-619792483 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] HeartSaVioR commented on pull request #28363: [SPARK-27188][SS] FileStreamSink: provide a new option to have retention on output files

2020-04-27 Thread GitBox
HeartSaVioR commented on pull request #28363: URL: https://github.com/apache/spark/pull/28363#issuecomment-619793100 This PR is just a revival of #24128 as the problem definition and the solution can be still applied. This i

[GitHub] [spark] AmplabJenkins commented on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

2020-04-27 Thread GitBox
AmplabJenkins commented on pull request #28362: URL: https://github.com/apache/spark/pull/28362#issuecomment-619792192 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To resp

[GitHub] [spark] gaborgsomogyi commented on pull request #28336: [SPARK-31559][YARN] Re-obtain tokens at the startup of AM for yarn cluster mode if principal and keytab are available

2020-04-27 Thread GitBox
gaborgsomogyi commented on pull request #28336: URL: https://github.com/apache/spark/pull/28336#issuecomment-619792253 I've tested it and works fine. The change is technically correct however the main question is whether an active `SparkContext` is a requirement to run a Spark application

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

2020-04-27 Thread GitBox
AmplabJenkins removed a comment on pull request #28362: URL: https://github.com/apache/spark/pull/28362#issuecomment-619791572 Can one of the admins verify this patch? This is an automated message from the Apache Git Service.

<    4   5   6   7   8   9   10   >