[GitHub] [spark] dongjoon-hyun commented on pull request #28516: [SPARK-31692][SQL] Pass hadoop confs specifed via Spark confs to URLStreamHandlerfactory

2020-05-14 Thread GitBox
dongjoon-hyun commented on pull request #28516: URL: https://github.com/apache/spark/pull/28516#issuecomment-628415251 I added you to the Apache Spark contributor group and assigned you SPARK-31692. Thank you so much again.

[GitHub] [spark] karuppayya commented on pull request #28516: [SPARK-31692][SQL] Pass hadoop confs specifed via Spark confs to URLStreamHandlerfactory

2020-05-14 Thread GitBox
karuppayya commented on pull request #28516: URL: https://github.com/apache/spark/pull/28516#issuecomment-628419677 Thanks @dongjoon-hyun , I will create a PR against 2.4 as well This is an automated message from the Apache

[GitHub] [spark] liupc commented on a change in pull request #27968: [SPARK-31202][CORE]Improve SizeEstimator for AppendOnlyMap

2020-05-14 Thread GitBox
liupc commented on a change in pull request #27968: URL: https://github.com/apache/spark/pull/27968#discussion_r424930338 ## File path: core/src/main/scala/org/apache/spark/util/SizeEstimator.scala ## @@ -290,6 +306,88 @@ object SizeEstimator extends Logging { size }

[GitHub] [spark] liupc commented on a change in pull request #27968: [SPARK-31202][CORE]Improve SizeEstimator for AppendOnlyMap

2020-05-14 Thread GitBox
liupc commented on a change in pull request #27968: URL: https://github.com/apache/spark/pull/27968#discussion_r424929368 ## File path: core/src/main/scala/org/apache/spark/util/SizeEstimator.scala ## @@ -290,6 +306,88 @@ object SizeEstimator extends Logging { size }

[GitHub] [spark] dongjoon-hyun commented on pull request #28516: [SPARK-31692][SQL] Pass hadoop confs specifed via Spark confs to URLStreamHandlerfactory

2020-05-14 Thread GitBox
dongjoon-hyun commented on pull request #28516: URL: https://github.com/apache/spark/pull/28516#issuecomment-628413739 BTW, there is a conflict on branch-2.4. Could you make a backporting PR against `branch-2.4`, please?

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28526: [SPARK-31405][SQL][3.0] Fail by default when reading/writing legacy datetime values from/to Parquet/Avro files

2020-05-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28526: URL: https://github.com/apache/spark/pull/28526#issuecomment-628421094 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28526: [SPARK-31405][SQL][3.0] Fail by default when reading/writing legacy datetime values from/to Parquet/Avro files

2020-05-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28526: URL: https://github.com/apache/spark/pull/28526#issuecomment-628428190 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on pull request #28526: [SPARK-31405][SQL][3.0] Fail by default when reading/writing legacy datetime values from/to Parquet/Avro files

2020-05-14 Thread GitBox
SparkQA commented on pull request #28526: URL: https://github.com/apache/spark/pull/28526#issuecomment-628428174 **[Test build #122607 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122607/testReport)** for PR 28526 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28526: [SPARK-31405][SQL][3.0] Fail by default when reading/writing legacy datetime values from/to Parquet/Avro files

2020-05-14 Thread GitBox
AmplabJenkins commented on pull request #28526: URL: https://github.com/apache/spark/pull/28526#issuecomment-628428184 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28523: [SPARK-31706][SQL] add back the support of streaming update mode

2020-05-14 Thread GitBox
AmplabJenkins commented on pull request #28523: URL: https://github.com/apache/spark/pull/28523#issuecomment-628433449 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28496: [SPARK-31620][SQL] Fix reference binding failure in case of an final agg contains subquery

2020-05-14 Thread GitBox
SparkQA commented on pull request #28496: URL: https://github.com/apache/spark/pull/28496#issuecomment-628433288 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] SparkQA commented on pull request #28523: [SPARK-31706][SQL] add back the support of streaming update mode

2020-05-14 Thread GitBox
SparkQA commented on pull request #28523: URL: https://github.com/apache/spark/pull/28523#issuecomment-628433291 **[Test build #122606 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122606/testReport)** for PR 28523 at commit

[GitHub] [spark] HyukjinKwon commented on pull request #28526: [SPARK-31405][SQL][3.0] Fail by default when reading/writing legacy datetime values from/to Parquet/Avro files

2020-05-14 Thread GitBox
HyukjinKwon commented on pull request #28526: URL: https://github.com/apache/spark/pull/28526#issuecomment-628455770 Many .. ```diff diff --cc external/avro/src/main/scala/org/apache/spark/sql/avro/AvroDeserializer.scala index 27206edb287,1d18594fd34..000 ---

[GitHub] [spark] dongjoon-hyun commented on pull request #28516: [SPARK-31692][SQL] Pass hadoop confs specifed via Spark confs to URLStreamHandlerfactory

2020-05-14 Thread GitBox
dongjoon-hyun commented on pull request #28516: URL: https://github.com/apache/spark/pull/28516#issuecomment-628409906 Thanks. Please put the description in the PR description. It will be perfect. This is an automated

[GitHub] [spark] karuppayya commented on pull request #28516: [SPARK-31692][SQL] Pass hadoop confs specifed via Spark confs to URLStreamHandlerfactory

2020-05-14 Thread GitBox
karuppayya commented on pull request #28516: URL: https://github.com/apache/spark/pull/28516#issuecomment-628413225 Thanks @dongjoon-hyun for updating the PR description This is an automated message from the Apache Git

[GitHub] [spark] SparkQA commented on pull request #28526: [SPARK-31405][SQL][3.0] Fail by default when reading/writing legacy datetime values from/to Parquet/Avro files

2020-05-14 Thread GitBox
SparkQA commented on pull request #28526: URL: https://github.com/apache/spark/pull/28526#issuecomment-628423769 **[Test build #122607 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122607/testReport)** for PR 28526 at commit

[GitHub] [spark] SparkQA commented on pull request #27604: [SPARK-30849][CORE][SHUFFLE]Fix application failed due to failed to get MapStatuses broadcast block

2020-05-14 Thread GitBox
SparkQA commented on pull request #27604: URL: https://github.com/apache/spark/pull/27604#issuecomment-628431045 **[Test build #122608 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122608/testReport)** for PR 27604 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #27604: [SPARK-30849][CORE][SHUFFLE]Fix application failed due to failed to get MapStatuses broadcast block

2020-05-14 Thread GitBox
AmplabJenkins commented on pull request #27604: URL: https://github.com/apache/spark/pull/27604#issuecomment-628431062 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27604: [SPARK-30849][CORE][SHUFFLE]Fix application failed due to failed to get MapStatuses broadcast block

2020-05-14 Thread GitBox
AmplabJenkins removed a comment on pull request #27604: URL: https://github.com/apache/spark/pull/27604#issuecomment-628431062 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #27604: [SPARK-30849][CORE][SHUFFLE]Fix application failed due to failed to get MapStatuses broadcast block

2020-05-14 Thread GitBox
SparkQA removed a comment on pull request #27604: URL: https://github.com/apache/spark/pull/27604#issuecomment-628430129 **[Test build #122608 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122608/testReport)** for PR 27604 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27604: [SPARK-30849][CORE][SHUFFLE]Fix application failed due to failed to get MapStatuses broadcast block

2020-05-14 Thread GitBox
AmplabJenkins removed a comment on pull request #27604: URL: https://github.com/apache/spark/pull/27604#issuecomment-628430650 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] dongjoon-hyun closed pull request #28516: [SPARK-31692][SQL] Pass hadoop confs specifed via Spark confs to URLStreamHandlerfactory

2020-05-14 Thread GitBox
dongjoon-hyun closed pull request #28516: URL: https://github.com/apache/spark/pull/28516 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] cloud-fan opened a new pull request #28526: [SPARK-31405][SQL][3.0] Fail by default when reading/writing legacy datetime values from/to Parquet/Avro files

2020-05-14 Thread GitBox
cloud-fan opened a new pull request #28526: URL: https://github.com/apache/spark/pull/28526 ### What changes were proposed in this pull request? When reading/writing datetime values that before the rebase switch day, from/to Avro/Parquet files, fail by default and ask users

[GitHub] [spark] AmplabJenkins commented on pull request #28526: [SPARK-31405][SQL][3.0] Fail by default when reading/writing legacy datetime values from/to Parquet/Avro files

2020-05-14 Thread GitBox
AmplabJenkins commented on pull request #28526: URL: https://github.com/apache/spark/pull/28526#issuecomment-628421094 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] liupc commented on pull request #27604: [SPARK-30849][CORE][SHUFFLE]Fix application failed due to failed to get MapStatuses broadcast block

2020-05-14 Thread GitBox
liupc commented on pull request #27604: URL: https://github.com/apache/spark/pull/27604#issuecomment-628429857 > The `getStatus` method could throw a `MetadataFetchFailedException` now, you should move every method call of it into a `try...catch` block. Done, thanks for review

[GitHub] [spark] SparkQA removed a comment on pull request #28523: [SPARK-31706][SQL] add back the support of streaming update mode

2020-05-14 Thread GitBox
SparkQA removed a comment on pull request #28523: URL: https://github.com/apache/spark/pull/28523#issuecomment-628404724 **[Test build #122606 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122606/testReport)** for PR 28523 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28496: [SPARK-31620][SQL] Fix reference binding failure in case of an final agg contains subquery

2020-05-14 Thread GitBox
SparkQA removed a comment on pull request #28496: URL: https://github.com/apache/spark/pull/28496#issuecomment-628365999 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28523: [SPARK-31706][SQL] add back the support of streaming update mode

2020-05-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28523: URL: https://github.com/apache/spark/pull/28523#issuecomment-628433449 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28496: [SPARK-31620][SQL] Fix reference binding failure in case of an final agg contains subquery

2020-05-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28496: URL: https://github.com/apache/spark/pull/28496#issuecomment-628433782 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28496: [SPARK-31620][SQL] Fix reference binding failure in case of an final agg contains subquery

2020-05-14 Thread GitBox
AmplabJenkins commented on pull request #28496: URL: https://github.com/apache/spark/pull/28496#issuecomment-628433782 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28496: [SPARK-31620][SQL] Fix reference binding failure in case of an final agg contains subquery

2020-05-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28496: URL: https://github.com/apache/spark/pull/28496#issuecomment-628434072 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28523: [SPARK-31706][SQL] add back the support of streaming update mode

2020-05-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28523: URL: https://github.com/apache/spark/pull/28523#issuecomment-628433464 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on pull request #28496: [SPARK-31620][SQL] Fix reference binding failure in case of an final agg contains subquery

2020-05-14 Thread GitBox
AmplabJenkins commented on pull request #28496: URL: https://github.com/apache/spark/pull/28496#issuecomment-628434062 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] cloud-fan commented on pull request #28526: [SPARK-31405][SQL][3.0] Fail by default when reading/writing legacy datetime values from/to Parquet/Avro files

2020-05-14 Thread GitBox
cloud-fan commented on pull request #28526: URL: https://github.com/apache/spark/pull/28526#issuecomment-628469946 Yea, all the conflicts are caused by the different name of `DateTimeUtils.toMillis` in 3.0 This is an

[GitHub] [spark] cloud-fan commented on pull request #28526: [SPARK-31405][SQL][3.0] Fail by default when reading/writing legacy datetime values from/to Parquet/Avro files

2020-05-14 Thread GitBox
cloud-fan commented on pull request #28526: URL: https://github.com/apache/spark/pull/28526#issuecomment-628421014 cc @HyukjinKwon @MaxGekk This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] AmplabJenkins commented on pull request #27604: [SPARK-30849][CORE][SHUFFLE]Fix application failed due to failed to get MapStatuses broadcast block

2020-05-14 Thread GitBox
AmplabJenkins commented on pull request #27604: URL: https://github.com/apache/spark/pull/27604#issuecomment-628430650 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #27604: [SPARK-30849][CORE][SHUFFLE]Fix application failed due to failed to get MapStatuses broadcast block

2020-05-14 Thread GitBox
SparkQA commented on pull request #27604: URL: https://github.com/apache/spark/pull/27604#issuecomment-628430129 **[Test build #122608 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122608/testReport)** for PR 27604 at commit

[GitHub] [spark] dongjoon-hyun commented on pull request #28516: [SPARK-31692][SQL] Pass hadoop confs specifed via Spark confs to URLStreamHandlerfactory

2020-05-14 Thread GitBox
dongjoon-hyun commented on pull request #28516: URL: https://github.com/apache/spark/pull/28516#issuecomment-628412136 I updated the PR description with yours, @karuppayya . This is an automated message from the Apache Git

[GitHub] [spark] SparkQA removed a comment on pull request #28526: [SPARK-31405][SQL][3.0] Fail by default when reading/writing legacy datetime values from/to Parquet/Avro files

2020-05-14 Thread GitBox
SparkQA removed a comment on pull request #28526: URL: https://github.com/apache/spark/pull/28526#issuecomment-628423769 **[Test build #122607 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122607/testReport)** for PR 28526 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28526: [SPARK-31405][SQL][3.0] Fail by default when reading/writing legacy datetime values from/to Parquet/Avro files

2020-05-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28526: URL: https://github.com/apache/spark/pull/28526#issuecomment-628428184 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27604: [SPARK-30849][CORE][SHUFFLE]Fix application failed due to failed to get MapStatuses broadcast block

2020-05-14 Thread GitBox
AmplabJenkins removed a comment on pull request #27604: URL: https://github.com/apache/spark/pull/27604#issuecomment-628431073 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on pull request #28529: [SPARK-31692][SQL] Pass hadoop confs specifed via Spark confs to URLStreamHandlerfactory

2020-05-14 Thread GitBox
AmplabJenkins commented on pull request #28529: URL: https://github.com/apache/spark/pull/28529#issuecomment-628846232 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28529: [SPARK-31692][SQL] Pass hadoop confs specifed via Spark confs to URLStreamHandlerfactory

2020-05-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28529: URL: https://github.com/apache/spark/pull/28529#issuecomment-628846232 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] MaxGekk commented on pull request #28531: [SPARK-31712][SQL][TESTS] Check casting timestamps before the epoch to Byte/Short/Int/Long types

2020-05-14 Thread GitBox
MaxGekk commented on pull request #28531: URL: https://github.com/apache/spark/pull/28531#issuecomment-628863049 @tgravescs Probably, you are interested in the tests too. This is an automated message from the Apache Git

[GitHub] [spark] SparkQA commented on pull request #27617: [SPARK-30865][SQL] Refactor DateTimeUtils

2020-05-14 Thread GitBox
SparkQA commented on pull request #27617: URL: https://github.com/apache/spark/pull/27617#issuecomment-628870942 **[Test build #122633 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122633/testReport)** for PR 27617 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28527: [SPARK-31709][SQL] Proper base path for database/table location when it is a relative path

2020-05-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28527: URL: https://github.com/apache/spark/pull/28527#issuecomment-628869927 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] prakharjain09 commented on a change in pull request #28482: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned [w/ test fix]

2020-05-14 Thread GitBox
prakharjain09 commented on a change in pull request #28482: URL: https://github.com/apache/spark/pull/28482#discussion_r425335576 ## File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ## @@ -1829,7 +1901,63 @@ private[spark] class BlockManager(

[GitHub] [spark] prakharjain09 commented on a change in pull request #28482: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned [w/ test fix]

2020-05-14 Thread GitBox
prakharjain09 commented on a change in pull request #28482: URL: https://github.com/apache/spark/pull/28482#discussion_r425335363 ## File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ## @@ -1641,6 +1653,10 @@ private[spark] class BlockManager(

[GitHub] [spark] SparkQA commented on pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

2020-05-14 Thread GitBox
SparkQA commented on pull request #28370: URL: https://github.com/apache/spark/pull/28370#issuecomment-628834326 **[Test build #122629 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122629/testReport)** for PR 28370 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

2020-05-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28370: URL: https://github.com/apache/spark/pull/28370#issuecomment-628834824 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

2020-05-14 Thread GitBox
AmplabJenkins commented on pull request #28370: URL: https://github.com/apache/spark/pull/28370#issuecomment-628834824 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] MaxGekk opened a new pull request #28531: [SPARK-31712][SQL][TESTS] Check casting timestamps before the epoch to Byte/Short/Int/Long types

2020-05-14 Thread GitBox
MaxGekk opened a new pull request #28531: URL: https://github.com/apache/spark/pull/28531 ### What changes were proposed in this pull request? Added tests to check casting timestamps before 1970-01-01 00:00:00Z to ByteType, ShortType, IntegerType and LongType in ansi and non-ansi modes.

[GitHub] [spark] MaxGekk commented on pull request #28531: [SPARK-31712][SQL][TESTS] Check casting timestamps before the epoch to Byte/Short/Int/Long types

2020-05-14 Thread GitBox
MaxGekk commented on pull request #28531: URL: https://github.com/apache/spark/pull/28531#issuecomment-628862225 @hvanhovell @HyukjinKwon @cloud-fan Please, review the tests. This is an automated message from the Apache Git

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28527: [SPARK-31709][SQL] Proper base path for database/table location when it is a relative path

2020-05-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28527: URL: https://github.com/apache/spark/pull/28527#issuecomment-628869915 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28527: [SPARK-31709][SQL] Proper base path for database/table location when it is a relative path

2020-05-14 Thread GitBox
AmplabJenkins commented on pull request #28527: URL: https://github.com/apache/spark/pull/28527#issuecomment-628869915 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28531: [SPARK-31712][SQL][TESTS] Check casting timestamps before the epoch to Byte/Short/Int/Long types

2020-05-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28531: URL: https://github.com/apache/spark/pull/28531#issuecomment-628893166 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28531: [SPARK-31712][SQL][TESTS] Check casting timestamps before the epoch to Byte/Short/Int/Long types

2020-05-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28531: URL: https://github.com/apache/spark/pull/28531#issuecomment-628893160 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28534: [SPARK-31710][SQL]Fix timestamp and long convert not compatible with hive issue

2020-05-14 Thread GitBox
AmplabJenkins commented on pull request #28534: URL: https://github.com/apache/spark/pull/28534#issuecomment-628971659 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28532: [SPARK-31713][INFRA] Make test-dependencies.sh detect version string correctly

2020-05-14 Thread GitBox
dongjoon-hyun commented on a change in pull request #28532: URL: https://github.com/apache/spark/pull/28532#discussion_r425520837 ## File path: dev/test-dependencies.sh ## @@ -47,7 +47,7 @@ OLD_VERSION=$($MVN -q \ -Dexec.executable="echo" \

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28532: [SPARK-31713][INFRA] Make test-dependencies.sh detect version string correctly

2020-05-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28532: URL: https://github.com/apache/spark/pull/28532#issuecomment-628979168 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] dongjoon-hyun commented on pull request #28155: [SPARK-31387] Handle unknown operation/session ID in HiveThriftServer2Listener

2020-05-14 Thread GitBox
dongjoon-hyun commented on pull request #28155: URL: https://github.com/apache/spark/pull/28155#issuecomment-628979422 FYI, two JDK11 jobs are recovered. I'm looking at the other failures like https://github.com/apache/spark/pull/28532 . -

[GitHub] [spark] AmplabJenkins commented on pull request #28532: [SPARK-31713][INFRA] Make test-dependencies.sh detect version string correctly

2020-05-14 Thread GitBox
AmplabJenkins commented on pull request #28532: URL: https://github.com/apache/spark/pull/28532#issuecomment-628979168 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #27983: [SPARK-15694][SQL]Implement ScriptTransformation in sql/core

2020-05-14 Thread GitBox
AmplabJenkins commented on pull request #27983: URL: https://github.com/apache/spark/pull/27983#issuecomment-628981493 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28532: [SPARK-31713][INFRA] Make test-dependencies.sh detect version string correctly

2020-05-14 Thread GitBox
SparkQA commented on pull request #28532: URL: https://github.com/apache/spark/pull/28532#issuecomment-628981549 **[Test build #122636 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122636/testReport)** for PR 28532 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28532: [SPARK-31713][INFRA] Make test-dependencies.sh detect version string correctly

2020-05-14 Thread GitBox
AmplabJenkins commented on pull request #28532: URL: https://github.com/apache/spark/pull/28532#issuecomment-628981562 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27983: [SPARK-15694][SQL]Implement ScriptTransformation in sql/core

2020-05-14 Thread GitBox
AmplabJenkins removed a comment on pull request #27983: URL: https://github.com/apache/spark/pull/27983#issuecomment-628981493 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28532: [SPARK-31713][INFRA] Make test-dependencies.sh detect version string correctly

2020-05-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28532: URL: https://github.com/apache/spark/pull/28532#issuecomment-628981569 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on pull request #28532: [SPARK-31713][INFRA] Make test-dependencies.sh detect version string correctly

2020-05-14 Thread GitBox
SparkQA removed a comment on pull request #28532: URL: https://github.com/apache/spark/pull/28532#issuecomment-628978788 **[Test build #122636 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122636/testReport)** for PR 28532 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28532: [SPARK-31713][INFRA] Make test-dependencies.sh detect version string correctly

2020-05-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28532: URL: https://github.com/apache/spark/pull/28532#issuecomment-628981562 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] yaooqinn commented on pull request #28527: [SPARK-31709][SQL] Proper base path for database/table location when it is a relative path

2020-05-14 Thread GitBox
yaooqinn commented on pull request #28527: URL: https://github.com/apache/spark/pull/28527#issuecomment-628984492 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28532: [SPARK-31713][INFRA] Make test-dependencies.sh detect version string correctly

2020-05-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28532: URL: https://github.com/apache/spark/pull/28532#issuecomment-628983749 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28532: [SPARK-31713][INFRA] Make test-dependencies.sh detect version string correctly

2020-05-14 Thread GitBox
AmplabJenkins commented on pull request #28532: URL: https://github.com/apache/spark/pull/28532#issuecomment-628986016 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28527: [SPARK-31709][SQL] Proper base path for database/table location when it is a relative path

2020-05-14 Thread GitBox
AmplabJenkins commented on pull request #28527: URL: https://github.com/apache/spark/pull/28527#issuecomment-628986145 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] dongjoon-hyun commented on pull request #28532: [SPARK-31713][INFRA] Make test-dependencies.sh detect version string correctly

2020-05-14 Thread GitBox
dongjoon-hyun commented on pull request #28532: URL: https://github.com/apache/spark/pull/28532#issuecomment-628986227 `amp-jenkins-worker-05` has the corrupted Maven repo. Last two runs are assigned into the same machine. -

[GitHub] [spark] SparkQA removed a comment on pull request #28532: [SPARK-31713][INFRA] Make test-dependencies.sh detect version string correctly

2020-05-14 Thread GitBox
SparkQA removed a comment on pull request #28532: URL: https://github.com/apache/spark/pull/28532#issuecomment-628983386 **[Test build #122638 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122638/testReport)** for PR 28532 at commit

[GitHub] [spark] SparkQA commented on pull request #27617: [SPARK-30865][SQL] Refactor DateTimeUtils

2020-05-14 Thread GitBox
SparkQA commented on pull request #27617: URL: https://github.com/apache/spark/pull/27617#issuecomment-628986525 **[Test build #122633 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122633/testReport)** for PR 27617 at commit

[GitHub] [spark] dongjoon-hyun commented on pull request #28532: [SPARK-31713][INFRA] Make test-dependencies.sh detect version string correctly

2020-05-14 Thread GitBox
dongjoon-hyun commented on pull request #28532: URL: https://github.com/apache/spark/pull/28532#issuecomment-628986472 @srowen . If you don't mind, this passed already on `amp-jenkins-worker-03` with a fallback situation. Can we merge this?

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28532: [SPARK-31713][INFRA] Make test-dependencies.sh detect version string correctly

2020-05-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28532: URL: https://github.com/apache/spark/pull/28532#issuecomment-628986016 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28527: [SPARK-31709][SQL] Proper base path for database/table location when it is a relative path

2020-05-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28527: URL: https://github.com/apache/spark/pull/28527#issuecomment-628986145 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28525: [SPARK-27562][Shuffle] Complete the verification mechanism for shuffle transmitted data

2020-05-14 Thread GitBox
SparkQA commented on pull request #28525: URL: https://github.com/apache/spark/pull/28525#issuecomment-628988241 **[Test build #122640 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122640/testReport)** for PR 28525 at commit

[GitHub] [spark] HyukjinKwon commented on pull request #28532: [SPARK-31713][INFRA] Make test-dependencies.sh detect version string correctly

2020-05-14 Thread GitBox
HyukjinKwon commented on pull request #28532: URL: https://github.com/apache/spark/pull/28532#issuecomment-628989301 Should we clean that specific correct corrupted one in `.m2`, @shaneknapp? This is an automated message

[GitHub] [spark] dongjoon-hyun closed pull request #28532: [SPARK-31713][INFRA] Make test-dependencies.sh detect version string correctly

2020-05-14 Thread GitBox
dongjoon-hyun closed pull request #28532: URL: https://github.com/apache/spark/pull/28532 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] HyukjinKwon commented on pull request #28532: [SPARK-31713][INFRA] Make test-dependencies.sh detect version string correctly

2020-05-14 Thread GitBox
HyukjinKwon commented on pull request #28532: URL: https://github.com/apache/spark/pull/28532#issuecomment-628989662 Shall we file a JIRA and assign @shaneknapp? I think he asked this before :-). This is an automated

[GitHub] [spark] dongjoon-hyun commented on pull request #28532: [SPARK-31713][INFRA] Make test-dependencies.sh detect version string correctly

2020-05-14 Thread GitBox
dongjoon-hyun commented on pull request #28532: URL: https://github.com/apache/spark/pull/28532#issuecomment-628989816 I left a comment on the existing JIRA. But, new JIRA sounds good. -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28525: [SPARK-27562][Shuffle] Complete the verification mechanism for shuffle transmitted data

2020-05-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28525: URL: https://github.com/apache/spark/pull/28525#issuecomment-628991401 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #28525: [SPARK-27562][Shuffle] Complete the verification mechanism for shuffle transmitted data

2020-05-14 Thread GitBox
SparkQA removed a comment on pull request #28525: URL: https://github.com/apache/spark/pull/28525#issuecomment-628988241 **[Test build #122640 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122640/testReport)** for PR 28525 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28525: [SPARK-27562][Shuffle] Complete the verification mechanism for shuffle transmitted data

2020-05-14 Thread GitBox
AmplabJenkins commented on pull request #28525: URL: https://github.com/apache/spark/pull/28525#issuecomment-628991401 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28525: [SPARK-27562][Shuffle] Complete the verification mechanism for shuffle transmitted data

2020-05-14 Thread GitBox
SparkQA commented on pull request #28525: URL: https://github.com/apache/spark/pull/28525#issuecomment-628991391 **[Test build #122640 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122640/testReport)** for PR 28525 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28525: [SPARK-27562][Shuffle] Complete the verification mechanism for shuffle transmitted data

2020-05-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28525: URL: https://github.com/apache/spark/pull/28525#issuecomment-628993378 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28525: [SPARK-27562][Shuffle] Complete the verification mechanism for shuffle transmitted data

2020-05-14 Thread GitBox
AmplabJenkins commented on pull request #28525: URL: https://github.com/apache/spark/pull/28525#issuecomment-628993378 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28525: [SPARK-27562][Shuffle] Complete the verification mechanism for shuffle transmitted data

2020-05-14 Thread GitBox
SparkQA commented on pull request #28525: URL: https://github.com/apache/spark/pull/28525#issuecomment-628995389 **[Test build #122641 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122641/testReport)** for PR 28525 at commit

[GitHub] [spark] HeartSaVioR commented on a change in pull request #28517: [SPARK-31707][SQL] Revert SPARK-30098 Use default datasource as provider for CREATE TABLE syntax

2020-05-14 Thread GitBox
HeartSaVioR commented on a change in pull request #28517: URL: https://github.com/apache/spark/pull/28517#discussion_r425540192 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/DDLParserSuite.scala ## @@ -2195,22 +2195,4 @@ class DDLParserSuite

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28496: [SPARK-31620][SQL] Fix reference binding failure in case of an final agg contains subquery

2020-05-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28496: URL: https://github.com/apache/spark/pull/28496#issuecomment-628738076 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] Ngone51 commented on pull request #28496: [SPARK-31620][SQL] Fix reference binding failure in case of an final agg contains subquery

2020-05-14 Thread GitBox
Ngone51 commented on pull request #28496: URL: https://github.com/apache/spark/pull/28496#issuecomment-629001780 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] AmplabJenkins commented on pull request #28496: [SPARK-31620][SQL] Fix reference binding failure in case of an final agg contains subquery

2020-05-14 Thread GitBox
AmplabJenkins commented on pull request #28496: URL: https://github.com/apache/spark/pull/28496#issuecomment-629003873 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28496: [SPARK-31620][SQL] Fix reference binding failure in case of an final agg contains subquery

2020-05-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28496: URL: https://github.com/apache/spark/pull/28496#issuecomment-629003873 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] xuanyuanking commented on pull request #28501: [SPARK-31663][SQL] Grouping sets with having clause returns the wrong result

2020-05-14 Thread GitBox
xuanyuanking commented on pull request #28501: URL: https://github.com/apache/spark/pull/28501#issuecomment-629004304 @holdenk Thanks for notifying, I'll address all the comments today. Yep, if it can be merged before cutting 2.4.6, let's put it in 2.4.7.

[GitHub] [spark] dongjoon-hyun opened a new pull request #28536: [WIP][SPARK-XXX][SQL] Use a fallback version in HiveExternalCatalogVersionsSuite

2020-05-14 Thread GitBox
dongjoon-hyun opened a new pull request #28536: URL: https://github.com/apache/spark/pull/28536 … ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change?

[GitHub] [spark] AmplabJenkins commented on pull request #28536: [WIP][SPARK-XXX][SQL] Use a fallback version in HiveExternalCatalogVersionsSuite

2020-05-14 Thread GitBox
AmplabJenkins commented on pull request #28536: URL: https://github.com/apache/spark/pull/28536#issuecomment-629007660 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28531: [SPARK-31712][SQL][TESTS] Check casting timestamps before the epoch to Byte/Short/Int/Long types

2020-05-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28531: URL: https://github.com/apache/spark/pull/28531#issuecomment-629007220 This is an automated message from the Apache Git Service. To respond to the message, please log on

  1   2   3   4   5   6   >