[GitHub] [spark] AmplabJenkins commented on pull request #28621: [SPARK-31803][ML] Make sure instance weight is not negative

2020-05-22 Thread GitBox
AmplabJenkins commented on pull request #28621: URL: https://github.com/apache/spark/pull/28621#issuecomment-632997369 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28621: [SPARK-31803][ML] Make sure instance weight is not negative

2020-05-22 Thread GitBox
AmplabJenkins removed a comment on pull request #28621: URL: https://github.com/apache/spark/pull/28621#issuecomment-632997369 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28621: [SPARK-31803][ML] Make sure instance weight is not negative

2020-05-22 Thread GitBox
SparkQA commented on pull request #28621: URL: https://github.com/apache/spark/pull/28621#issuecomment-632997228 **[Test build #123027 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123027/testReport)** for PR 28621 at commit [`4ba0b1d`](https://github.com

[GitHub] [spark] huaxingao opened a new pull request #28621: [SPARK-31803][ML] Make sure instance weight is not negative

2020-05-22 Thread GitBox
huaxingao opened a new pull request #28621: URL: https://github.com/apache/spark/pull/28621 ### What changes were proposed in this pull request? In the algorithms that support instance weight, add checks to make sure instance weight is not negative. ### Why are the cha

[GitHub] [spark] SparkQA commented on pull request #28600: [SPARK-31761][SQL] cast integer to Long to avoid IntegerOverflow for IntegralDivide operator

2020-05-22 Thread GitBox
SparkQA commented on pull request #28600: URL: https://github.com/apache/spark/pull/28600#issuecomment-632995506 **[Test build #123026 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123026/testReport)** for PR 28600 at commit [`3a1a061`](https://github.com

[GitHub] [spark] maropu commented on a change in pull request #28600: [SPARK-31761][SQL] cast integer to Long to avoid IntegerOverflow for IntegralDivide operator

2020-05-22 Thread GitBox
maropu commented on a change in pull request #28600: URL: https://github.com/apache/spark/pull/28600#discussion_r429519921 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercionSuite.scala ## @@ -1559,6 +1559,30 @@ class TypeCoercionSuite

[GitHub] [spark] AmplabJenkins commented on pull request #28600: [SPARK-31761][SQL] cast integer to Long to avoid IntegerOverflow for IntegralDivide operator

2020-05-22 Thread GitBox
AmplabJenkins commented on pull request #28600: URL: https://github.com/apache/spark/pull/28600#issuecomment-632994832 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28600: [SPARK-31761][SQL] cast integer to Long to avoid IntegerOverflow for IntegralDivide operator

2020-05-22 Thread GitBox
AmplabJenkins removed a comment on pull request #28600: URL: https://github.com/apache/spark/pull/28600#issuecomment-632994832 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] sandeep-katta commented on a change in pull request #28600: [SPARK-31761][SQL] cast integer to Long to avoid IntegerOverflow for IntegralDivide operator

2020-05-22 Thread GitBox
sandeep-katta commented on a change in pull request #28600: URL: https://github.com/apache/spark/pull/28600#discussion_r429519637 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala ## @@ -684,6 +685,24 @@ object TypeCoercion {

[GitHub] [spark] viirya commented on a change in pull request #26422: [SPARK-29786][SQL] Fix MetaException when dropping a partition not exists on HDFS

2020-05-22 Thread GitBox
viirya commented on a change in pull request #26422: URL: https://github.com/apache/spark/pull/26422#discussion_r429517900 ## File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala ## @@ -638,6 +644,17 @@ private[hive] class HiveClientImpl(

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28620: [SPARK-31802][SQL] Format Java date-time types in `Row.jsonValue` directly

2020-05-22 Thread GitBox
AmplabJenkins removed a comment on pull request #28620: URL: https://github.com/apache/spark/pull/28620#issuecomment-632990441 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28620: [SPARK-31802][SQL] Format Java date-time types in `Row.jsonValue` directly

2020-05-22 Thread GitBox
AmplabJenkins commented on pull request #28620: URL: https://github.com/apache/spark/pull/28620#issuecomment-632990441 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28620: [SPARK-31802][SQL] Format Java date-time types in `Row.jsonValue` directly

2020-05-22 Thread GitBox
SparkQA commented on pull request #28620: URL: https://github.com/apache/spark/pull/28620#issuecomment-632990317 **[Test build #123025 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123025/testReport)** for PR 28620 at commit [`1dac0ef`](https://github.com

[GitHub] [spark] MaxGekk commented on pull request #28620: [SPARK-31802][SQL] Format Java date-time types in `Row.jsonValue` directly

2020-05-22 Thread GitBox
MaxGekk commented on pull request #28620: URL: https://github.com/apache/spark/pull/28620#issuecomment-632989799 @cloud-fan @HyukjinKwon @hvanhovell Please, review this PR. This is an automated message from the Apache Git Ser

[GitHub] [spark] MaxGekk opened a new pull request #28620: [SPARK-31802][SQL] Format Java date-time types in `Row.jsonValue` directly

2020-05-22 Thread GitBox
MaxGekk opened a new pull request #28620: URL: https://github.com/apache/spark/pull/28620 ### What changes were proposed in this pull request? Use `format()` methods for Java date-time types in `Row.jsonValue`. The PR https://github.com/apache/spark/pull/28582 added the methods to avoid

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27006: [SPARK-30352][SQL] DataSourceV2: Add CURRENT_CATALOG function

2020-05-22 Thread GitBox
AmplabJenkins removed a comment on pull request #27006: URL: https://github.com/apache/spark/pull/27006#issuecomment-632989057 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #27006: [SPARK-30352][SQL] DataSourceV2: Add CURRENT_CATALOG function

2020-05-22 Thread GitBox
AmplabJenkins commented on pull request #27006: URL: https://github.com/apache/spark/pull/27006#issuecomment-632989057 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #27006: [SPARK-30352][SQL] DataSourceV2: Add CURRENT_CATALOG function

2020-05-22 Thread GitBox
SparkQA commented on pull request #27006: URL: https://github.com/apache/spark/pull/27006#issuecomment-632988959 **[Test build #123024 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123024/testReport)** for PR 27006 at commit [`f951b5e`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27006: [SPARK-30352][SQL] DataSourceV2: Add CURRENT_CATALOG function

2020-05-22 Thread GitBox
AmplabJenkins removed a comment on pull request #27006: URL: https://github.com/apache/spark/pull/27006#issuecomment-632889226 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123

[GitHub] [spark] yaooqinn commented on pull request #27006: [SPARK-30352][SQL] DataSourceV2: Add CURRENT_CATALOG function

2020-05-22 Thread GitBox
yaooqinn commented on pull request #27006: URL: https://github.com/apache/spark/pull/27006#issuecomment-632988407 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28619: [WIP][SPARK-21040][CORE] Speculate tasks which are running on decommission executors

2020-05-22 Thread GitBox
AmplabJenkins removed a comment on pull request #28619: URL: https://github.com/apache/spark/pull/28619#issuecomment-632985431 Can one of the admins verify this patch? This is an automated message from the Apache Git Service.

[GitHub] [spark] AmplabJenkins commented on pull request #28619: [WIP][SPARK-21040][CORE] Speculate tasks which are running on decommission executors

2020-05-22 Thread GitBox
AmplabJenkins commented on pull request #28619: URL: https://github.com/apache/spark/pull/28619#issuecomment-632985525 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To resp

[GitHub] [spark] AmplabJenkins commented on pull request #28619: [WIP][SPARK-21040][CORE] Speculate tasks which are running on decommission executors

2020-05-22 Thread GitBox
AmplabJenkins commented on pull request #28619: URL: https://github.com/apache/spark/pull/28619#issuecomment-632985431 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To resp

[GitHub] [spark] prakharjain09 commented on pull request #28619: [WIP][SPARK-21040][CORE] Speculate tasks which are running on decommission executors

2020-05-22 Thread GitBox
prakharjain09 commented on pull request #28619: URL: https://github.com/apache/spark/pull/28619#issuecomment-632985151 I am adding more UTs for this change. So added WIP in title. @holdenk Please give some feedback on the actual logic. ---

[GitHub] [spark] prakharjain09 opened a new pull request #28619: [WIP][SPARK-21040][CORE] Speculate tasks which are running on decommission executors

2020-05-22 Thread GitBox
prakharjain09 opened a new pull request #28619: URL: https://github.com/apache/spark/pull/28619 ### What changes were proposed in this pull request? This PR adds functionality to consider the running tasks on decommission executors based on some config. In spark-on-cloud , we sometime

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28603: [SPARK-31788][CORE][PYTHON] Fix UnionRDD of PairRDDs

2020-05-22 Thread GitBox
AmplabJenkins removed a comment on pull request #28603: URL: https://github.com/apache/spark/pull/28603#issuecomment-632975557 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28603: [SPARK-31788][CORE][PYTHON] Fix UnionRDD of PairRDDs

2020-05-22 Thread GitBox
AmplabJenkins commented on pull request #28603: URL: https://github.com/apache/spark/pull/28603#issuecomment-632975557 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #28603: [SPARK-31788][CORE][PYTHON] Fix UnionRDD of PairRDDs

2020-05-22 Thread GitBox
SparkQA removed a comment on pull request #28603: URL: https://github.com/apache/spark/pull/28603#issuecomment-632971926 **[Test build #123023 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123023/testReport)** for PR 28603 at commit [`c65be0d`](https://gi

[GitHub] [spark] SparkQA commented on pull request #28603: [SPARK-31788][CORE][PYTHON] Fix UnionRDD of PairRDDs

2020-05-22 Thread GitBox
SparkQA commented on pull request #28603: URL: https://github.com/apache/spark/pull/28603#issuecomment-632975404 **[Test build #123023 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123023/testReport)** for PR 28603 at commit [`c65be0d`](https://github.co

[GitHub] [spark] AmplabJenkins commented on pull request #28603: [SPARK-31788][CORE][PYTHON] Fix UnionRDD of PairRDDs

2020-05-22 Thread GitBox
AmplabJenkins commented on pull request #28603: URL: https://github.com/apache/spark/pull/28603#issuecomment-632972088 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28603: [SPARK-31788][CORE][PYTHON] Fix UnionRDD of PairRDDs

2020-05-22 Thread GitBox
AmplabJenkins removed a comment on pull request #28603: URL: https://github.com/apache/spark/pull/28603#issuecomment-632972088 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28603: [SPARK-31788][CORE][PYTHON] Fix UnionRDD of PairRDDs

2020-05-22 Thread GitBox
SparkQA commented on pull request #28603: URL: https://github.com/apache/spark/pull/28603#issuecomment-632971926 **[Test build #123023 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123023/testReport)** for PR 28603 at commit [`c65be0d`](https://github.com

[GitHub] [spark] HyukjinKwon commented on pull request #28603: [SPARK-31788][CORE] Fix UnionRDD of PairRDDs

2020-05-22 Thread GitBox
HyukjinKwon commented on pull request #28603: URL: https://github.com/apache/spark/pull/28603#issuecomment-632971649 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28603: [SPARK-31788][CORE] Fix UnionRDD of PairRDDs

2020-05-22 Thread GitBox
AmplabJenkins removed a comment on pull request #28603: URL: https://github.com/apache/spark/pull/28603#issuecomment-632402291 Can one of the admins verify this patch? This is an automated message from the Apache Git Service.

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28618: [SPARK-31801][WIP][API][SHUFFLE] Register map output metadata

2020-05-22 Thread GitBox
AmplabJenkins removed a comment on pull request #28618: URL: https://github.com/apache/spark/pull/28618#issuecomment-632965792 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123

[GitHub] [spark] SparkQA removed a comment on pull request #28618: [SPARK-31801][WIP][API][SHUFFLE] Register map output metadata

2020-05-22 Thread GitBox
SparkQA removed a comment on pull request #28618: URL: https://github.com/apache/spark/pull/28618#issuecomment-632965454 **[Test build #123022 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123022/testReport)** for PR 28618 at commit [`98821b9`](https://gi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28618: [SPARK-31801][WIP][API][SHUFFLE] Register map output metadata

2020-05-22 Thread GitBox
AmplabJenkins removed a comment on pull request #28618: URL: https://github.com/apache/spark/pull/28618#issuecomment-632965788 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] SparkQA commented on pull request #28618: [SPARK-31801][WIP][API][SHUFFLE] Register map output metadata

2020-05-22 Thread GitBox
SparkQA commented on pull request #28618: URL: https://github.com/apache/spark/pull/28618#issuecomment-632965784 **[Test build #123022 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123022/testReport)** for PR 28618 at commit [`98821b9`](https://github.co

[GitHub] [spark] AmplabJenkins commented on pull request #28618: [SPARK-31801][WIP][API][SHUFFLE] Register map output metadata

2020-05-22 Thread GitBox
AmplabJenkins commented on pull request #28618: URL: https://github.com/apache/spark/pull/28618#issuecomment-632965788 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28618: [SPARK-31801][WIP][API][SHUFFLE] Register map output metadata

2020-05-22 Thread GitBox
AmplabJenkins removed a comment on pull request #28618: URL: https://github.com/apache/spark/pull/28618#issuecomment-632965590 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28618: [SPARK-31801][WIP][API][SHUFFLE] Register map output metadata

2020-05-22 Thread GitBox
AmplabJenkins commented on pull request #28618: URL: https://github.com/apache/spark/pull/28618#issuecomment-632965590 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28618: [SPARK-31801][WIP][API][SHUFFLE] Register map output metadata

2020-05-22 Thread GitBox
SparkQA commented on pull request #28618: URL: https://github.com/apache/spark/pull/28618#issuecomment-632965454 **[Test build #123022 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123022/testReport)** for PR 28618 at commit [`98821b9`](https://github.com

[GitHub] [spark] mccheah opened a new pull request #28618: [WIP][SPARK-31801][API][SHUFFLE] Register map output metadata

2020-05-22 Thread GitBox
mccheah opened a new pull request #28618: URL: https://github.com/apache/spark/pull/28618 ### What changes were proposed in this pull request? Adds a `ShuffleOutputTracker` API that can be used for managing shuffle metadata on the driver. Accepts map output metadata returned by the m

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28617: [SPARK-31694][SQL][WIP] Add SupportsPartitions Catalog APIs on DataSourceV2

2020-05-22 Thread GitBox
AmplabJenkins removed a comment on pull request #28617: URL: https://github.com/apache/spark/pull/28617#issuecomment-632962034 Can one of the admins verify this patch? This is an automated message from the Apache Git Service.

[GitHub] [spark] AmplabJenkins commented on pull request #28617: [SPARK-31694][SQL][WIP] Add SupportsPartitions Catalog APIs on DataSourceV2

2020-05-22 Thread GitBox
AmplabJenkins commented on pull request #28617: URL: https://github.com/apache/spark/pull/28617#issuecomment-632962217 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To resp

[GitHub] [spark] AmplabJenkins commented on pull request #28617: [SPARK-31694][SQL][WIP] Add SupportsPartitions Catalog APIs on DataSourceV2

2020-05-22 Thread GitBox
AmplabJenkins commented on pull request #28617: URL: https://github.com/apache/spark/pull/28617#issuecomment-632962034 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To resp

[GitHub] [spark] holdenk commented on pull request #28614: [SPARK-31791][CORE][TEST] Improve cache block migration test reliability

2020-05-22 Thread GitBox
holdenk commented on pull request #28614: URL: https://github.com/apache/spark/pull/28614#issuecomment-632961876 Merged to master. This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [spark] stczwd opened a new pull request #28617: [SPARK-32694][SQL][WIP] Add SupportsPartitions Catalog APIs on DataSourceV2

2020-05-22 Thread GitBox
stczwd opened a new pull request #28617: URL: https://github.com/apache/spark/pull/28617 ### What changes were proposed in this pull request? There are no partition Commands, such as AlterTableAddPartition supported in DatasourceV2, it is widely used in mysql or hive or other datasources

[GitHub] [spark] asfgit closed pull request #28614: [SPARK-31791][CORE][TEST] Improve cache block migration test reliability

2020-05-22 Thread GitBox
asfgit closed pull request #28614: URL: https://github.com/apache/spark/pull/28614 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28610: [SPARK-31793][SQL] Reduce the memory usage in file scan location metadata

2020-05-22 Thread GitBox
AmplabJenkins removed a comment on pull request #28610: URL: https://github.com/apache/spark/pull/28610#issuecomment-632957704 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28610: [SPARK-31793][SQL] Reduce the memory usage in file scan location metadata

2020-05-22 Thread GitBox
AmplabJenkins commented on pull request #28610: URL: https://github.com/apache/spark/pull/28610#issuecomment-632957704 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #28610: [SPARK-31793][SQL] Reduce the memory usage in file scan location metadata

2020-05-22 Thread GitBox
SparkQA removed a comment on pull request #28610: URL: https://github.com/apache/spark/pull/28610#issuecomment-632930084 **[Test build #123021 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123021/testReport)** for PR 28610 at commit [`9d736ef`](https://gi

[GitHub] [spark] SparkQA commented on pull request #28610: [SPARK-31793][SQL] Reduce the memory usage in file scan location metadata

2020-05-22 Thread GitBox
SparkQA commented on pull request #28610: URL: https://github.com/apache/spark/pull/28610#issuecomment-632957362 **[Test build #123021 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123021/testReport)** for PR 28610 at commit [`9d736ef`](https://github.co

[GitHub] [spark] HyukjinKwon edited a comment on pull request #28523: [SPARK-31706][SQL] add back the support of streaming update mode

2020-05-22 Thread GitBox
HyukjinKwon edited a comment on pull request #28523: URL: https://github.com/apache/spark/pull/28523#issuecomment-632953003 @rdblue Looks it became the different proposal as you and other people discussed and suggested there, which you didn't technically vote for. It seems reviewed properl

[GitHub] [spark] AmplabJenkins commented on pull request #26422: [SPARK-29786][SQL] Fix MetaException when dropping a partition not exists on HDFS

2020-05-22 Thread GitBox
AmplabJenkins commented on pull request #26422: URL: https://github.com/apache/spark/pull/26422#issuecomment-632955271 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To resp

[GitHub] [spark] github-actions[bot] closed pull request #27213: [SPARK-30516][SQL] involve partition filters in the statistic estimation of FileScan

2020-05-22 Thread GitBox
github-actions[bot] closed pull request #27213: URL: https://github.com/apache/spark/pull/27213 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [spark] github-actions[bot] closed pull request #26503: [SPARK-29880][CORE][YARN] Handle submit exception when submit to federation cluster

2020-05-22 Thread GitBox
github-actions[bot] closed pull request #26503: URL: https://github.com/apache/spark/pull/26503 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [spark] HyukjinKwon commented on pull request #28523: [SPARK-31706][SQL] add back the support of streaming update mode

2020-05-22 Thread GitBox
HyukjinKwon commented on pull request #28523: URL: https://github.com/apache/spark/pull/28523#issuecomment-632953003 Looks it became the different proposal as you and other people discussed and suggested there, which you didn't technically vote for. It seems reviewed properly by other comm

[GitHub] [spark] maropu commented on a change in pull request #28600: [SPARK-31761][SQL] cast integer to Long to avoid IntegerOverflow for IntegralDivide operator

2020-05-22 Thread GitBox
maropu commented on a change in pull request #28600: URL: https://github.com/apache/spark/pull/28600#discussion_r429495426 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala ## @@ -3495,6 +3495,14 @@ class SQLQuerySuite extends QueryTest with Shared

[GitHub] [spark] maropu commented on a change in pull request #28600: [SPARK-31761][SQL] cast integer to Long to avoid IntegerOverflow for IntegralDivide operator

2020-05-22 Thread GitBox
maropu commented on a change in pull request #28600: URL: https://github.com/apache/spark/pull/28600#discussion_r429495362 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala ## @@ -684,6 +685,24 @@ object TypeCoercion { }

[GitHub] [spark] HeartSaVioR commented on pull request #27664: [SPARK-30915][SS] CompactibleFileStreamLog: Avoid reading the metadata log file when finding the latest batch ID

2020-05-22 Thread GitBox
HeartSaVioR commented on pull request #27664: URL: https://github.com/apache/spark/pull/27664#issuecomment-632952595 Thanks all for reviewing and merging! This is an automated message from the Apache Git Service. To respond t

[GitHub] [spark] maropu commented on a change in pull request #28600: [SPARK-31761][SQL] cast integer to Long to avoid IntegerOverflow for IntegralDivide operator

2020-05-22 Thread GitBox
maropu commented on a change in pull request #28600: URL: https://github.com/apache/spark/pull/28600#discussion_r429492387 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala ## @@ -684,6 +685,24 @@ object TypeCoercion { }

[GitHub] [spark] huaxingao commented on pull request #28608: [SPARK-31612][SQL][DOCS][FOLLOW-UP] Fix a few issues in SQL ref

2020-05-22 Thread GitBox
huaxingao commented on pull request #28608: URL: https://github.com/apache/spark/pull/28608#issuecomment-632947089 Thanks @maropu @srowen This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [spark] maropu commented on a change in pull request #28600: [SPARK-31761][SQL] cast integer to Long to avoid IntegerOverflow for IntegralDivide operator

2020-05-22 Thread GitBox
maropu commented on a change in pull request #28600: URL: https://github.com/apache/spark/pull/28600#discussion_r429492032 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala ## @@ -684,6 +685,24 @@ object TypeCoercion { }

[GitHub] [spark] maropu commented on a change in pull request #28600: [SPARK-31761][SQL] cast integer to Long to avoid IntegerOverflow for IntegralDivide operator

2020-05-22 Thread GitBox
maropu commented on a change in pull request #28600: URL: https://github.com/apache/spark/pull/28600#discussion_r429491977 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala ## @@ -684,6 +685,24 @@ object TypeCoercion { }

[GitHub] [spark] maropu closed pull request #28604: [SPARK-29854][SQL][TESTS] Add tests to check lpad/rpad throw an exception for invalid length input

2020-05-22 Thread GitBox
maropu closed pull request #28604: URL: https://github.com/apache/spark/pull/28604 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [spark] maropu commented on pull request #28604: [SPARK-29854][SQL][TESTS] Add tests to check lpad/rpad throw an exception for invalid length input

2020-05-22 Thread GitBox
maropu commented on pull request #28604: URL: https://github.com/apache/spark/pull/28604#issuecomment-632946339 Thanks, all! Merged to master/3.0. This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [spark] maropu closed pull request #27024: [SPARK-29854]lpad and rpad built in function should throw Error or Exception for invalid length value

2020-05-22 Thread GitBox
maropu closed pull request #27024: URL: https://github.com/apache/spark/pull/27024 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [spark] asfgit closed pull request #27664: [SPARK-30915][SS] CompactibleFileStreamLog: Avoid reading the metadata log file when finding the latest batch ID

2020-05-22 Thread GitBox
asfgit closed pull request #27664: URL: https://github.com/apache/spark/pull/27664 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [spark] maropu commented on pull request #28608: [SPARK-31612][SQL][DOCS][FOLLOW-UP] Fix a few issues in SQL ref

2020-05-22 Thread GitBox
maropu commented on pull request #28608: URL: https://github.com/apache/spark/pull/28608#issuecomment-632945396 Merged to master/3.0. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] zsxwing commented on pull request #27664: [SPARK-30915][SS] CompactibleFileStreamLog: Avoid reading the metadata log file when finding the latest batch ID

2020-05-22 Thread GitBox
zsxwing commented on pull request #27664: URL: https://github.com/apache/spark/pull/27664#issuecomment-632945403 Thanks! Merging to master. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] maropu closed pull request #28608: [SPARK-31612][SQL][DOCS][FOLLOW-UP] Fix a few issues in SQL ref

2020-05-22 Thread GitBox
maropu closed pull request #28608: URL: https://github.com/apache/spark/pull/28608 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [spark] jiangxb1987 commented on pull request #26503: [SPARK-29880][CORE][YARN] Handle submit exception when submit to federation cluster

2020-05-22 Thread GitBox
jiangxb1987 commented on pull request #26503: URL: https://github.com/apache/spark/pull/26503#issuecomment-632938069 @caneGuy I'll merge this PR after you addressed Vanzin's comments. This is an automated message from the Apa

[GitHub] [spark] AmplabJenkins commented on pull request #28616: [SPARK-31798][SHUFFLE][API] Shuffle Writer API changes to return custom map output metadata

2020-05-22 Thread GitBox
AmplabJenkins commented on pull request #28616: URL: https://github.com/apache/spark/pull/28616#issuecomment-632936256 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond t

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28616: [SPARK-31798][SHUFFLE][API] Shuffle Writer API changes to return custom map output metadata

2020-05-22 Thread GitBox
AmplabJenkins removed a comment on pull request #28616: URL: https://github.com/apache/spark/pull/28616#issuecomment-632936256 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] SparkQA removed a comment on pull request #28616: [SPARK-31798][SHUFFLE][API] Shuffle Writer API changes to return custom map output metadata

2020-05-22 Thread GitBox
SparkQA removed a comment on pull request #28616: URL: https://github.com/apache/spark/pull/28616#issuecomment-632893338 **[Test build #123020 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123020/testReport)** for PR 28616 at commit [`6ecd3ad`](https://gi

[GitHub] [spark] skambha commented on pull request #27627: [WIP][SPARK-28067][SQL] Fix incorrect results for decimal aggregate sum by returning null on decimal overflow

2020-05-22 Thread GitBox
skambha commented on pull request #27627: URL: https://github.com/apache/spark/pull/27627#issuecomment-632935982 Hi @cloud-fan, I have posted some comments on the https://github.com/skambha/spark/pull/1 This is an automated

[GitHub] [spark] SparkQA commented on pull request #28616: [SPARK-31798][SHUFFLE][API] Shuffle Writer API changes to return custom map output metadata

2020-05-22 Thread GitBox
SparkQA commented on pull request #28616: URL: https://github.com/apache/spark/pull/28616#issuecomment-632935966 **[Test build #123020 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123020/testReport)** for PR 28616 at commit [`6ecd3ad`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28610: [SPARK-31793][SQL] Reduce the memory usage in file scan location metadata

2020-05-22 Thread GitBox
AmplabJenkins removed a comment on pull request #28610: URL: https://github.com/apache/spark/pull/28610#issuecomment-632930383 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28610: [SPARK-31793][SQL] Reduce the memory usage in file scan location metadata

2020-05-22 Thread GitBox
AmplabJenkins commented on pull request #28610: URL: https://github.com/apache/spark/pull/28610#issuecomment-632930383 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28601: [SPARK-31786][K8S][BUILD] Upgrade kubernetes-client to 4.9.2

2020-05-22 Thread GitBox
AmplabJenkins removed a comment on pull request #28601: URL: https://github.com/apache/spark/pull/28601#issuecomment-632930187 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28601: [SPARK-31786][K8S][BUILD] Upgrade kubernetes-client to 4.9.2

2020-05-22 Thread GitBox
AmplabJenkins commented on pull request #28601: URL: https://github.com/apache/spark/pull/28601#issuecomment-632930187 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28610: [SPARK-31793][SQL] Reduce the memory usage in file scan location metadata

2020-05-22 Thread GitBox
SparkQA commented on pull request #28610: URL: https://github.com/apache/spark/pull/28610#issuecomment-632930084 **[Test build #123021 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123021/testReport)** for PR 28610 at commit [`9d736ef`](https://github.com

[GitHub] [spark] SparkQA removed a comment on pull request #28601: [SPARK-31786][K8S][BUILD] Upgrade kubernetes-client to 4.9.2

2020-05-22 Thread GitBox
SparkQA removed a comment on pull request #28601: URL: https://github.com/apache/spark/pull/28601#issuecomment-632862106 **[Test build #123017 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123017/testReport)** for PR 28601 at commit [`4327940`](https://gi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28610: [SPARK-31793][SQL] Reduce the memory usage in file scan location metadata

2020-05-22 Thread GitBox
AmplabJenkins removed a comment on pull request #28610: URL: https://github.com/apache/spark/pull/28610#issuecomment-632929644 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28610: [SPARK-31793][SQL] Reduce the memory usage in file scan location metadata

2020-05-22 Thread GitBox
AmplabJenkins commented on pull request #28610: URL: https://github.com/apache/spark/pull/28610#issuecomment-632929644 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28601: [SPARK-31786][K8S][BUILD] Upgrade kubernetes-client to 4.9.2

2020-05-22 Thread GitBox
SparkQA commented on pull request #28601: URL: https://github.com/apache/spark/pull/28601#issuecomment-632929676 **[Test build #123017 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123017/testReport)** for PR 28601 at commit [`4327940`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #28610: [SPARK-31793][SQL] Reduce the memory usage in file scan location metadata

2020-05-22 Thread GitBox
SparkQA removed a comment on pull request #28610: URL: https://github.com/apache/spark/pull/28610#issuecomment-632862111 **[Test build #123016 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123016/testReport)** for PR 28610 at commit [`0a089ad`](https://gi

[GitHub] [spark] SparkQA commented on pull request #28610: [SPARK-31793][SQL] Reduce the memory usage in file scan location metadata

2020-05-22 Thread GitBox
SparkQA commented on pull request #28610: URL: https://github.com/apache/spark/pull/28610#issuecomment-632929206 **[Test build #123016 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123016/testReport)** for PR 28610 at commit [`0a089ad`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28610: [SPARK-31793][SQL] Reduce the memory usage in file scan location metadata

2020-05-22 Thread GitBox
AmplabJenkins removed a comment on pull request #28610: URL: https://github.com/apache/spark/pull/28610#issuecomment-632925412 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28610: [SPARK-31793][SQL] Reduce the memory usage in file scan location metadata

2020-05-22 Thread GitBox
AmplabJenkins removed a comment on pull request #28610: URL: https://github.com/apache/spark/pull/28610#issuecomment-632925404 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins commented on pull request #28610: [SPARK-31793][SQL] Reduce the memory usage in file scan location metadata

2020-05-22 Thread GitBox
AmplabJenkins commented on pull request #28610: URL: https://github.com/apache/spark/pull/28610#issuecomment-632925404 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #28610: [SPARK-31793][SQL] Reduce the memory usage in file scan location metadata

2020-05-22 Thread GitBox
SparkQA removed a comment on pull request #28610: URL: https://github.com/apache/spark/pull/28610#issuecomment-632879997 **[Test build #123018 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123018/testReport)** for PR 28610 at commit [`4fe6be1`](https://gi

[GitHub] [spark] SparkQA commented on pull request #28610: [SPARK-31793][SQL] Reduce the memory usage in file scan location metadata

2020-05-22 Thread GitBox
SparkQA commented on pull request #28610: URL: https://github.com/apache/spark/pull/28610#issuecomment-632925032 **[Test build #123018 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123018/testReport)** for PR 28610 at commit [`4fe6be1`](https://github.co

[GitHub] [spark] turboFei commented on pull request #26339: [SPARK-27194][SPARK-29302][SQL] For dynamic partition overwrite operation, fix speculation task conflict issue and FileAlreadyExistsExceptio

2020-05-22 Thread GitBox
turboFei commented on pull request #26339: URL: https://github.com/apache/spark/pull/26339#issuecomment-632923671 have sent an email into that email thread, thanks a lot @Ngone51 This is an automated message from the Apache

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28613: [SPARK-31755][SQL][FOLLOWUP] Update date-time, CSV and JSON benchmark results

2020-05-22 Thread GitBox
AmplabJenkins removed a comment on pull request #28613: URL: https://github.com/apache/spark/pull/28613#issuecomment-632920630 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28613: [SPARK-31755][SQL][FOLLOWUP] Update date-time, CSV and JSON benchmark results

2020-05-22 Thread GitBox
AmplabJenkins commented on pull request #28613: URL: https://github.com/apache/spark/pull/28613#issuecomment-632920630 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28613: [SPARK-31755][SQL][FOLLOWUP] Update date-time, CSV and JSON benchmark results

2020-05-22 Thread GitBox
SparkQA commented on pull request #28613: URL: https://github.com/apache/spark/pull/28613#issuecomment-632920089 **[Test build #123011 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123011/testReport)** for PR 28613 at commit [`117b3d0`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #28613: [SPARK-31755][SQL][FOLLOWUP] Update date-time, CSV and JSON benchmark results

2020-05-22 Thread GitBox
SparkQA removed a comment on pull request #28613: URL: https://github.com/apache/spark/pull/28613#issuecomment-632787264 **[Test build #123011 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123011/testReport)** for PR 28613 at commit [`117b3d0`](https://gi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28592: [SPARK-31771][SQL] Disable Narrow TextStyle for datetime pattern 'G/M/L/E/u/Q/q'

2020-05-22 Thread GitBox
AmplabJenkins removed a comment on pull request #28592: URL: https://github.com/apache/spark/pull/28592#issuecomment-632914986 This is an automated message from the Apache Git Service. To respond to the message, please log on

  1   2   3   4   5   6   7   >