[GitHub] [spark] SparkQA removed a comment on pull request #28710: [SPARK-31893][ML] Add a generic ClassificationSummary trait

2020-06-15 Thread GitBox
SparkQA removed a comment on pull request #28710: URL: https://github.com/apache/spark/pull/28710#issuecomment-643991785 **[Test build #124045 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124045/testReport)** for PR 28710 at commit

[GitHub] [spark] SparkQA commented on pull request #28710: [SPARK-31893][ML] Add a generic ClassificationSummary trait

2020-06-15 Thread GitBox
SparkQA commented on pull request #28710: URL: https://github.com/apache/spark/pull/28710#issuecomment-644076601 **[Test build #124045 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124045/testReport)** for PR 28710 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28834: [SPARK-31994][k8s] Docker image should use `https` urls for only deb.debian.org mirrors.

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28834: URL: https://github.com/apache/spark/pull/28834#issuecomment-644074175 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28834: [SPARK-31994][k8s] Docker image should use `https` urls for only deb.debian.org mirrors.

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28834: URL: https://github.com/apache/spark/pull/28834#issuecomment-644074165 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28834: [SPARK-31994][k8s] Docker image should use `https` urls for only deb.debian.org mirrors.

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28834: URL: https://github.com/apache/spark/pull/28834#issuecomment-644074165 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28834: [SPARK-31994][k8s] Docker image should use `https` urls for only deb.debian.org mirrors.

2020-06-15 Thread GitBox
SparkQA commented on pull request #28834: URL: https://github.com/apache/spark/pull/28834#issuecomment-644074146 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/28669/

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for void column datatype

2020-06-15 Thread GitBox
HyukjinKwon commented on a change in pull request #28833: URL: https://github.com/apache/spark/pull/28833#discussion_r440111404 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/NullType.scala ## @@ -32,6 +32,11 @@ class NullType private() extends DataType {

[GitHub] [spark] HyukjinKwon commented on pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for void column datatype

2020-06-15 Thread GitBox
HyukjinKwon commented on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-644071006 cc @maropu, @cloud-fan, @dongjoon-hyun, @hvanhovell, @gatorsmile FYI This is an automated message from the

[GitHub] [spark] WangGuangxin commented on a change in pull request #28780: [SPARK-31952][SQL]Fix incorrect memory spill metric when doing Aggregate

2020-06-15 Thread GitBox
WangGuangxin commented on a change in pull request #28780: URL: https://github.com/apache/spark/pull/28780#discussion_r440108353 ## File path: core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java ## @@ -104,11 +104,13 @@ public static

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28412: [SPARK-31608][CORE][WEBUI] Add a new type of KVStore to make loading UI faster

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28412: URL: https://github.com/apache/spark/pull/28412#issuecomment-644070471 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28412: [SPARK-31608][CORE][WEBUI] Add a new type of KVStore to make loading UI faster

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28412: URL: https://github.com/apache/spark/pull/28412#issuecomment-644070471 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] attilapiros commented on a change in pull request #28619: [SPARK-21040][CORE] Speculate tasks which are running on decommission executors

2020-06-15 Thread GitBox
attilapiros commented on a change in pull request #28619: URL: https://github.com/apache/spark/pull/28619#discussion_r440107393 ## File path: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ## @@ -1042,7 +1046,19 @@ private[spark] class TaskSetManager(

[GitHub] [spark] SparkQA commented on pull request #28412: [SPARK-31608][CORE][WEBUI] Add a new type of KVStore to make loading UI faster

2020-06-15 Thread GitBox
SparkQA commented on pull request #28412: URL: https://github.com/apache/spark/pull/28412#issuecomment-644070017 **[Test build #124053 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124053/testReport)** for PR 28412 at commit

[GitHub] [spark] HyukjinKwon commented on pull request #28412: [SPARK-31608][CORE][WEBUI] Add a new type of KVStore to make loading UI faster

2020-06-15 Thread GitBox
HyukjinKwon commented on pull request #28412: URL: https://github.com/apache/spark/pull/28412#issuecomment-644069380 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28832: [SPARK-31959][SQL][TESTS][FOLLOWUP] Adopt the test "SPARK-31959: JST -> HKT at Asia/Hong_Kong in 1945" to outdated tzdb

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28832: URL: https://github.com/apache/spark/pull/28832#issuecomment-644064207 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28832: [SPARK-31959][SQL][TESTS][FOLLOWUP] Adopt the test "SPARK-31959: JST -> HKT at Asia/Hong_Kong in 1945" to outdated tzdb

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28832: URL: https://github.com/apache/spark/pull/28832#issuecomment-644064207 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28832: [SPARK-31959][SQL][TESTS][FOLLOWUP] Adopt the test "SPARK-31959: JST -> HKT at Asia/Hong_Kong in 1945" to outdated tzdb

2020-06-15 Thread GitBox
SparkQA commented on pull request #28832: URL: https://github.com/apache/spark/pull/28832#issuecomment-644063697 **[Test build #124052 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124052/testReport)** for PR 28832 at commit

[GitHub] [spark] SparkQA commented on pull request #28834: [SPARK-31994][k8s] Docker image should use `https` urls for only deb.debian.org mirrors.

2020-06-15 Thread GitBox
SparkQA commented on pull request #28834: URL: https://github.com/apache/spark/pull/28834#issuecomment-644062357 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/28669/

[GitHub] [spark] MaxGekk commented on pull request #28832: [SPARK-31959][SQL][TESTS][FOLLOWUP] Adopt the test "SPARK-31959: JST -> HKT at Asia/Hong_Kong in 1945" to outdated tzdb

2020-06-15 Thread GitBox
MaxGekk commented on pull request #28832: URL: https://github.com/apache/spark/pull/28832#issuecomment-644061874 jenkins, retest this, please This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] MaxGekk commented on pull request #28832: [SPARK-31959][SQL][TESTS][FOLLOWUP] Adopt the test "SPARK-31959: JST -> HKT at Asia/Hong_Kong in 1945" to outdated tzdb

2020-06-15 Thread GitBox
MaxGekk commented on pull request #28832: URL: https://github.com/apache/spark/pull/28832#issuecomment-644061746 The issue https://github.com/apache/spark/pull/28832#issuecomment-644050559 is fixed by https://github.com/apache/spark/pull/28816

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28645: [SPARK-31826][SQL] Support composed type of case class for typed Scala UDF

2020-06-15 Thread GitBox
HyukjinKwon commented on a change in pull request #28645: URL: https://github.com/apache/spark/pull/28645#discussion_r440098735 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -2847,6 +2848,45 @@ class Analyzer( }

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28834: [SPARK-31994][k8s] Docker image should use `https` urls for only deb.debian.org mirrors.

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28834: URL: https://github.com/apache/spark/pull/28834#issuecomment-644051683 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #28834: [SPARK-31994][k8s] Docker image should use `https` urls for only deb.debian.org mirrors.

2020-06-15 Thread GitBox
SparkQA removed a comment on pull request #28834: URL: https://github.com/apache/spark/pull/28834#issuecomment-644040838 **[Test build #124050 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124050/testReport)** for PR 28834 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28834: [SPARK-31994][k8s] Docker image should use `https` urls for only deb.debian.org mirrors.

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28834: URL: https://github.com/apache/spark/pull/28834#issuecomment-644051683 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28834: [SPARK-31994][k8s] Docker image should use `https` urls for only deb.debian.org mirrors.

2020-06-15 Thread GitBox
SparkQA commented on pull request #28834: URL: https://github.com/apache/spark/pull/28834#issuecomment-644051449 **[Test build #124050 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124050/testReport)** for PR 28834 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28832: [SPARK-31959][SQL][TESTS][FOLLOWUP] Adopt the test "SPARK-31959: JST -> HKT at Asia/Hong_Kong in 1945" to outdated tzdb

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28832: URL: https://github.com/apache/spark/pull/28832#issuecomment-644050695 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] attilapiros commented on a change in pull request #28619: [SPARK-21040][CORE] Speculate tasks which are running on decommission executors

2020-06-15 Thread GitBox
attilapiros commented on a change in pull request #28619: URL: https://github.com/apache/spark/pull/28619#discussion_r440087128 ## File path: core/src/main/scala/org/apache/spark/internal/config/package.scala ## @@ -1842,6 +1842,17 @@ package object config {

[GitHub] [spark] attilapiros commented on a change in pull request #28619: [SPARK-21040][CORE] Speculate tasks which are running on decommission executors

2020-06-15 Thread GitBox
attilapiros commented on a change in pull request #28619: URL: https://github.com/apache/spark/pull/28619#discussion_r440087518 ## File path: core/src/main/scala/org/apache/spark/internal/config/package.scala ## @@ -1842,6 +1842,17 @@ package object config {

[GitHub] [spark] AmplabJenkins commented on pull request #28832: [SPARK-31959][SQL][TESTS][FOLLOWUP] Adopt the test "SPARK-31959: JST -> HKT at Asia/Hong_Kong in 1945" to outdated tzdb

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28832: URL: https://github.com/apache/spark/pull/28832#issuecomment-644050687 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28832: [SPARK-31959][SQL][TESTS][FOLLOWUP] Adopt the test "SPARK-31959: JST -> HKT at Asia/Hong_Kong in 1945" to outdated tzdb

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28832: URL: https://github.com/apache/spark/pull/28832#issuecomment-644050687 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #28832: [SPARK-31959][SQL][TESTS][FOLLOWUP] Adopt the test "SPARK-31959: JST -> HKT at Asia/Hong_Kong in 1945" to outdated tzdb

2020-06-15 Thread GitBox
SparkQA removed a comment on pull request #28832: URL: https://github.com/apache/spark/pull/28832#issuecomment-643995546 **[Test build #124047 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124047/testReport)** for PR 28832 at commit

[GitHub] [spark] SparkQA commented on pull request #28832: [SPARK-31959][SQL][TESTS][FOLLOWUP] Adopt the test "SPARK-31959: JST -> HKT at Asia/Hong_Kong in 1945" to outdated tzdb

2020-06-15 Thread GitBox
SparkQA commented on pull request #28832: URL: https://github.com/apache/spark/pull/28832#issuecomment-644050559 **[Test build #124047 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124047/testReport)** for PR 28832 at commit

[GitHub] [spark] LantaoJin commented on a change in pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for void column datatype

2020-06-15 Thread GitBox
LantaoJin commented on a change in pull request #28833: URL: https://github.com/apache/spark/pull/28833#discussion_r440082623 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala ## @@ -2211,6 +2211,7 @@ class AstBuilder(conf:

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28781: [SPARK-31953][SS] Add Spark Structured Streaming History Server Support

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28781: URL: https://github.com/apache/spark/pull/28781#issuecomment-644041498 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28781: [SPARK-31953][SS] Add Spark Structured Streaming History Server Support

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28781: URL: https://github.com/apache/spark/pull/28781#issuecomment-644041498 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28834: [SPARK-31994][k8s] Docker image should use `https` urls for only deb.debian.org mirrors.

2020-06-15 Thread GitBox
SparkQA commented on pull request #28834: URL: https://github.com/apache/spark/pull/28834#issuecomment-644040838 **[Test build #124050 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124050/testReport)** for PR 28834 at commit

[GitHub] [spark] SparkQA commented on pull request #28781: [SPARK-31953][SS] Add Spark Structured Streaming History Server Support

2020-06-15 Thread GitBox
SparkQA commented on pull request #28781: URL: https://github.com/apache/spark/pull/28781#issuecomment-644040894 **[Test build #124051 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124051/testReport)** for PR 28781 at commit

[GitHub] [spark] ScrapCodes opened a new pull request #28834: SPARK-31994 Docker image should use `https` urls for only deb.debian.org mirrors.

2020-06-15 Thread GitBox
ScrapCodes opened a new pull request #28834: URL: https://github.com/apache/spark/pull/28834 ### What changes were proposed in this pull request? At the moment, we switch to `https` urls for all the debian mirrors, but turns out some of the mirrors do not support. In this patch, we

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28821: [SPARK-31981][SQL] Keep TimestampType when taking an average of a Timestamp

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28821: URL: https://github.com/apache/spark/pull/28821#issuecomment-644037848 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28821: [SPARK-31981][SQL] Keep TimestampType when taking an average of a Timestamp

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28821: URL: https://github.com/apache/spark/pull/28821#issuecomment-644037848 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28821: [SPARK-31981][SQL] Keep TimestampType when taking an average of a Timestamp

2020-06-15 Thread GitBox
SparkQA commented on pull request #28821: URL: https://github.com/apache/spark/pull/28821#issuecomment-644037334 **[Test build #124049 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124049/testReport)** for PR 28821 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28707: [SPARK-31894][SS] Introduce UnsafeRow format validation for streaming state store

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28707: URL: https://github.com/apache/spark/pull/28707#issuecomment-644028150 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28707: [SPARK-31894][SS] Introduce UnsafeRow format validation for streaming state store

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28707: URL: https://github.com/apache/spark/pull/28707#issuecomment-644028139 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #28707: [SPARK-31894][SS] Introduce UnsafeRow format validation for streaming state store

2020-06-15 Thread GitBox
SparkQA removed a comment on pull request #28707: URL: https://github.com/apache/spark/pull/28707#issuecomment-644003732 **[Test build #124048 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124048/testReport)** for PR 28707 at commit

[GitHub] [spark] SparkQA commented on pull request #28707: [SPARK-31894][SS] Introduce UnsafeRow format validation for streaming state store

2020-06-15 Thread GitBox
SparkQA commented on pull request #28707: URL: https://github.com/apache/spark/pull/28707#issuecomment-644028023 **[Test build #124048 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124048/testReport)** for PR 28707 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28707: [SPARK-31894][SS] Introduce UnsafeRow format validation for streaming state store

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28707: URL: https://github.com/apache/spark/pull/28707#issuecomment-644028139 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28831: [SPARK-31993][SQL] Don't split code blocks in generated code for 'concat_ws' for mixed string/array types of columns

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28831: URL: https://github.com/apache/spark/pull/28831#issuecomment-644026190 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28831: [SPARK-31993][SQL] Don't split code blocks in generated code for 'concat_ws' for mixed string/array types of columns

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28831: URL: https://github.com/apache/spark/pull/28831#issuecomment-644026181 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28831: [SPARK-31993][SQL] Don't split code blocks in generated code for 'concat_ws' for mixed string/array types of columns

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28831: URL: https://github.com/apache/spark/pull/28831#issuecomment-644026181 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28831: [SPARK-31993][SQL] Don't split code blocks in generated code for 'concat_ws' for mixed string/array types of columns

2020-06-15 Thread GitBox
SparkQA removed a comment on pull request #28831: URL: https://github.com/apache/spark/pull/28831#issuecomment-643980234 **[Test build #124043 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124043/testReport)** for PR 28831 at commit

[GitHub] [spark] SparkQA commented on pull request #28831: [SPARK-31993][SQL] Don't split code blocks in generated code for 'concat_ws' for mixed string/array types of columns

2020-06-15 Thread GitBox
SparkQA commented on pull request #28831: URL: https://github.com/apache/spark/pull/28831#issuecomment-644025890 **[Test build #124043 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124043/testReport)** for PR 28831 at commit

[GitHub] [spark] ulysses-you commented on pull request #28778: [SPARK-31949][SQL] Add spark.default.parallelism in SQLConf for isolated across session

2020-06-15 Thread GitBox
ulysses-you commented on pull request #28778: URL: https://github.com/apache/spark/pull/28778#issuecomment-644024234 Any new thought ? @maropu @cloud-fan Also cc @HyukjinKwon @dongjoon-hyun @viirya This is an

[GitHub] [spark] ulysses-you commented on a change in pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for void column datatype

2020-06-15 Thread GitBox
ulysses-you commented on a change in pull request #28833: URL: https://github.com/apache/spark/pull/28833#discussion_r440055230 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala ## @@ -2211,6 +2211,7 @@ class AstBuilder(conf:

[GitHub] [spark] ulysses-you commented on a change in pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for void column datatype

2020-06-15 Thread GitBox
ulysses-you commented on a change in pull request #28833: URL: https://github.com/apache/spark/pull/28833#discussion_r440055230 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala ## @@ -2211,6 +2211,7 @@ class AstBuilder(conf:

[GitHub] [spark] xuanyuanking commented on pull request #28707: [SPARK-31894][SS] Introduce UnsafeRow format validation for streaming state store

2020-06-15 Thread GitBox
xuanyuanking commented on pull request #28707: URL: https://github.com/apache/spark/pull/28707#issuecomment-644020172 ``` Sorry my comment was edited so you may be missed the content, but it is also a sort of pointing out for "pinpointing" - do you think your approach works with other

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28707: [SPARK-31894][SS] Introduce UnsafeRow format validation for streaming state store

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28707: URL: https://github.com/apache/spark/pull/28707#issuecomment-644004386 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28707: [SPARK-31894][SS] Introduce UnsafeRow format validation for streaming state store

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28707: URL: https://github.com/apache/spark/pull/28707#issuecomment-644004386 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28707: [SPARK-31894][SS] Introduce UnsafeRow format validation for streaming state store

2020-06-15 Thread GitBox
SparkQA commented on pull request #28707: URL: https://github.com/apache/spark/pull/28707#issuecomment-644003732 **[Test build #124048 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124048/testReport)** for PR 28707 at commit

[GitHub] [spark] Ngone51 commented on a change in pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-15 Thread GitBox
Ngone51 commented on a change in pull request #28708: URL: https://github.com/apache/spark/pull/28708#discussion_r439991757 ## File path: core/src/main/scala/org/apache/spark/internal/config/package.scala ## @@ -420,6 +420,21 @@ package object config { .booleanConf

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for void column datatype

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-643996171 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for void column datatype

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-643996171 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28832: [SPARK-31959][SQL][TESTS][FOLLOWUP] Adopt the test "SPARK-31959: JST -> HKT at Asia/Hong_Kong in 1945" to outdated tzdb

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28832: URL: https://github.com/apache/spark/pull/28832#issuecomment-643992242 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28832: [SPARK-31959][SQL][TESTS][FOLLOWUP] Adopt the test "SPARK-31959: JST -> HKT at Asia/Hong_Kong in 1945" to outdated tzdb

2020-06-15 Thread GitBox
SparkQA commented on pull request #28832: URL: https://github.com/apache/spark/pull/28832#issuecomment-643995546 **[Test build #124047 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124047/testReport)** for PR 28832 at commit

[GitHub] [spark] SparkQA commented on pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for void column datatype

2020-06-15 Thread GitBox
SparkQA commented on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-643995551 **[Test build #124046 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124046/testReport)** for PR 28833 at commit

[GitHub] [spark] LantaoJin opened a new pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for void column datatype

2020-06-15 Thread GitBox
LantaoJin opened a new pull request #28833: URL: https://github.com/apache/spark/pull/28833 ## What changes were proposed in this pull request? Spark-sql do not support for void column datatype of view Create a HIVE view: >hive> create table bad as select 1 x, null z from

[GitHub] [spark] LantaoJin commented on pull request #17953: [SPARK-20680][SQL] Spark-sql do not support for void column datatype …

2020-06-15 Thread GitBox
LantaoJin commented on pull request #17953: URL: https://github.com/apache/spark/pull/17953#issuecomment-643995024 I open a new one #28833 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] HyukjinKwon commented on pull request #28642: [SPARK-31809][SQL] Infer IsNotNull for non null intolerant child of null intolerant in join condition

2020-06-15 Thread GitBox
HyukjinKwon commented on pull request #28642: URL: https://github.com/apache/spark/pull/28642#issuecomment-643994833 cc @cloud-fan FYI This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] MaxGekk commented on pull request #28809: [SPARK-31959][SQL][3.0] Fix Gregorian-Julian micros rebasing while switching standard time zone offset

2020-06-15 Thread GitBox
MaxGekk commented on pull request #28809: URL: https://github.com/apache/spark/pull/28809#issuecomment-643993758 I will cherry-pick https://github.com/apache/spark/pull/28832 here when it will be merged to master. This is

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28710: [SPARK-31893][ML] Add a generic ClassificationSummary trait

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28710: URL: https://github.com/apache/spark/pull/28710#issuecomment-643992323 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] MaxGekk commented on pull request #28832: [SPARK-31959][SQL][TESTS][FOLLOWUP] Adopt the test "SPARK-31959: JST -> HKT at Asia/Hong_Kong in 1945" to outdated tzdb

2020-06-15 Thread GitBox
MaxGekk commented on pull request #28832: URL: https://github.com/apache/spark/pull/28832#issuecomment-643992252 @HyukjinKwon @cloud-fan @dongjoon-hyun Please, review this PR. This is an automated message from the Apache Git

[GitHub] [spark] AmplabJenkins commented on pull request #28832: [SPARK-31959][SQL][TESTS][FOLLOWUP] Adopt the test "SPARK-31959: JST -> HKT at Asia/Hong_Kong in 1945" to outdated tzdb

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28832: URL: https://github.com/apache/spark/pull/28832#issuecomment-643992242 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28710: [SPARK-31893][ML] Add a generic ClassificationSummary trait

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28710: URL: https://github.com/apache/spark/pull/28710#issuecomment-643992323 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28710: [SPARK-31893][ML] Add a generic ClassificationSummary trait

2020-06-15 Thread GitBox
SparkQA commented on pull request #28710: URL: https://github.com/apache/spark/pull/28710#issuecomment-643991785 **[Test build #124045 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124045/testReport)** for PR 28710 at commit

[GitHub] [spark] MaxGekk opened a new pull request #28832: [SPARK-31959][SQL][TESTS][FOLLOWUP] Adopt the test "SPARK-31959: JST -> HKT at Asia/Hong_Kong in 1945" to outdated tzdb

2020-06-15 Thread GitBox
MaxGekk opened a new pull request #28832: URL: https://github.com/apache/spark/pull/28832 ### What changes were proposed in this pull request? Old JDK can have outdated time zone database in which `Asia/Hong_Kong` doesn't have timestamp overlapping in 1946 at all. This PR changes the

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28642: [SPARK-31809][SQL] Infer IsNotNull for non null intolerant child of null intolerant in join condition

2020-06-15 Thread GitBox
HyukjinKwon commented on a change in pull request #28642: URL: https://github.com/apache/spark/pull/28642#discussion_r440020133 ## File path: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala ## @@ -1039,7 +1039,7 @@ class JoinSuite extends QueryTest with

[GitHub] [spark] LantaoJin commented on pull request #17953: [SPARK-20680][SQL] Spark-sql do not support for void column datatype …

2020-06-15 Thread GitBox
LantaoJin commented on pull request #17953: URL: https://github.com/apache/spark/pull/17953#issuecomment-643989911 Emmm. How to reopen it? This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28826: [SPARK-31988][SQL] Schema pruning may discard attribute metadata

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28826: URL: https://github.com/apache/spark/pull/28826#issuecomment-643988572 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] huaxingao commented on a change in pull request #28710: [SPARK-31893][ML] Add a generic ClassificationSummary trait

2020-06-15 Thread GitBox
huaxingao commented on a change in pull request #28710: URL: https://github.com/apache/spark/pull/28710#discussion_r440017358 ## File path: project/MimaExcludes.scala ## @@ -39,18 +39,44 @@ object MimaExcludes { // [SPARK-31077] Remove ChiSqSelector dependency on

[GitHub] [spark] AmplabJenkins commented on pull request #28826: [SPARK-31988][SQL] Schema pruning may discard attribute metadata

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28826: URL: https://github.com/apache/spark/pull/28826#issuecomment-643988572 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28826: [SPARK-31988][SQL] Schema pruning may discard attribute metadata

2020-06-15 Thread GitBox
SparkQA commented on pull request #28826: URL: https://github.com/apache/spark/pull/28826#issuecomment-643987758 **[Test build #124044 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124044/testReport)** for PR 28826 at commit

[GitHub] [spark] HyukjinKwon commented on pull request #28826: [SPARK-31988][SQL] Schema pruning may discard attribute metadata

2020-06-15 Thread GitBox
HyukjinKwon commented on pull request #28826: URL: https://github.com/apache/spark/pull/28826#issuecomment-643987366 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28830: [SPARK-31990][SS] Use toSet.toSeq in Dataset.dropDuplicates

2020-06-15 Thread GitBox
HyukjinKwon commented on a change in pull request #28830: URL: https://github.com/apache/spark/pull/28830#discussion_r440013368 ## File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ## @@ -2541,7 +2541,9 @@ class Dataset[T] private[sql]( def

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28831: [SPARK-31993][SQL] Don't split code blocks in generated code for 'concat_ws' for mixed string/array types of columns

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28831: URL: https://github.com/apache/spark/pull/28831#issuecomment-643977050 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28831: [SPARK-31993][SQL] Don't split code blocks in generated code for 'concat_ws' for mixed string/array types of columns

2020-06-15 Thread GitBox
SparkQA commented on pull request #28831: URL: https://github.com/apache/spark/pull/28831#issuecomment-643980234 **[Test build #124043 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124043/testReport)** for PR 28831 at commit

[GitHub] [spark] HeartSaVioR commented on pull request #28831: [SPARK-31993][SQL] Don't split code blocks in generated code for 'concat_ws' for mixed string/array types of columns

2020-06-15 Thread GitBox
HeartSaVioR commented on pull request #28831: URL: https://github.com/apache/spark/pull/28831#issuecomment-643978420 There might be still a chance to compose these all parts into one and pass to splitExpressionsWithCurrentInputs, but it requires rewrite of code because there're two

[GitHub] [spark] AmplabJenkins commented on pull request #28831: [SPARK-31993][SQL] Don't split code blocks in generated code for 'concat_ws' for mixed string/array types of columns

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28831: URL: https://github.com/apache/spark/pull/28831#issuecomment-643977050 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] HeartSaVioR opened a new pull request #28831: [SPARK-31993][SQL] Don't split code blocks in generated code for 'concat_ws' for mixed string/array types of columns

2020-06-15 Thread GitBox
HeartSaVioR opened a new pull request #28831: URL: https://github.com/apache/spark/pull/28831 ### What changes were proposed in this pull request? This patch fixes the code generation logic for mixed string/array types of columns in `concat_ws` to not split methods, because

[GitHub] [spark] zhengruifeng commented on a change in pull request #28710: [SPARK-31893][ML] Add a generic ClassificationSummary trait

2020-06-15 Thread GitBox
zhengruifeng commented on a change in pull request #28710: URL: https://github.com/apache/spark/pull/28710#discussion_r43029 ## File path: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala ## @@ -1396,239 +1393,34 @@ object

[GitHub] [spark] SparkQA commented on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

2020-06-15 Thread GitBox
SparkQA commented on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-643969029 **[Test build #124042 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124042/testReport)** for PR 28593 at commit

[GitHub] [spark] cloud-fan commented on pull request #28816: [SPARK-31986][SQL] Fix Julian-Gregorian micros rebasing of overlapping local timestamps

2020-06-15 Thread GitBox
cloud-fan commented on pull request #28816: URL: https://github.com/apache/spark/pull/28816#issuecomment-643967758 let's wait until https://github.com/apache/spark/pull/28809 is merged This is an automated message from the

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28807: [SPARK-26905][SQL] Follow the SQL:2016 reserved keywords

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28807: URL: https://github.com/apache/spark/pull/28807#issuecomment-643966139 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28828: [SPARK-24634][SS][FOLLOWUP] Rename the variable from "numLateInputs" to "numRowsDroppedByWatermark"

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28828: URL: https://github.com/apache/spark/pull/28828#issuecomment-643965873 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28807: [SPARK-26905][SQL] Follow the SQL:2016 reserved keywords

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28807: URL: https://github.com/apache/spark/pull/28807#issuecomment-643966139 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-643965980 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

2020-06-15 Thread GitBox
AmplabJenkins removed a comment on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-643965980 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28828: [SPARK-24634][SS][FOLLOWUP] Rename the variable from "numLateInputs" to "numRowsDroppedByWatermark"

2020-06-15 Thread GitBox
AmplabJenkins commented on pull request #28828: URL: https://github.com/apache/spark/pull/28828#issuecomment-643965873 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28828: [SPARK-24634][SS][FOLLOWUP] Rename the variable from "numLateInputs" to "numRowsDroppedByWatermark"

2020-06-15 Thread GitBox
SparkQA commented on pull request #28828: URL: https://github.com/apache/spark/pull/28828#issuecomment-643965274 **[Test build #124040 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124040/testReport)** for PR 28828 at commit

[GitHub] [spark] cloud-fan commented on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

2020-06-15 Thread GitBox
cloud-fan commented on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-643965087 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] SparkQA commented on pull request #28807: [SPARK-26905][SQL] Follow the SQL:2016 reserved keywords

2020-06-15 Thread GitBox
SparkQA commented on pull request #28807: URL: https://github.com/apache/spark/pull/28807#issuecomment-643965298 **[Test build #124041 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124041/testReport)** for PR 28807 at commit

[GitHub] [spark] cloud-fan commented on pull request #28807: [SPARK-26905][SQL] Follow the SQL:2016 reserved keywords

2020-06-15 Thread GitBox
cloud-fan commented on pull request #28807: URL: https://github.com/apache/spark/pull/28807#issuecomment-643964961 retest this please This is an automated message from the Apache Git Service. To respond to the message,

<    1   2   3   4   5   6   7   8   >