[GitHub] [spark] AmplabJenkins commented on pull request #28960: [SPARK-32140][ML][PySpark] Add training summary to FMClassificationModel

2020-07-13 Thread GitBox
AmplabJenkins commented on pull request #28960: URL: https://github.com/apache/spark/pull/28960#issuecomment-658006936 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29086: [SPARK-32292][SPARK-32252][INFRA] Run the relevant tests only in GitHub Actions

2020-07-13 Thread GitBox
HyukjinKwon commented on a change in pull request #29086: URL: https://github.com/apache/spark/pull/29086#discussion_r454144037 ## File path: dev/run-tests.py ## @@ -589,43 +627,74 @@ def main(): # /home/jenkins/anaconda2/envs/py36/bin os.environ["PATH"] = "/h

[GitHub] [spark] jiangxb1987 commented on a change in pull request #29015: [SPARK-32215] Expose a (protected) /workers/kill endpoint on the MasterWebUI

2020-07-13 Thread GitBox
jiangxb1987 commented on a change in pull request #29015: URL: https://github.com/apache/spark/pull/29015#discussion_r454137251 ## File path: core/src/main/scala/org/apache/spark/deploy/master/Master.scala ## @@ -863,7 +872,29 @@ private[deploy] class Master( true } -

[GitHub] [spark] AmplabJenkins commented on pull request #28960: [SPARK-32140][ML][PySpark] Add training summary to FMClassificationModel

2020-07-13 Thread GitBox
AmplabJenkins commented on pull request #28960: URL: https://github.com/apache/spark/pull/28960#issuecomment-658004084 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28960: [SPARK-32140][ML][PySpark] Add training summary to FMClassificationModel

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #28960: URL: https://github.com/apache/spark/pull/28960#issuecomment-658004084 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28960: [SPARK-32140][ML][PySpark] Add training summary to FMClassificationModel

2020-07-13 Thread GitBox
SparkQA commented on pull request #28960: URL: https://github.com/apache/spark/pull/28960#issuecomment-658003670 **[Test build #125809 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125809/testReport)** for PR 28960 at commit [`0767117`](https://github.com

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29088: [SPARK-32289][SQL] Some characters are garbled when opening csv files with Excel

2020-07-13 Thread GitBox
HyukjinKwon commented on a change in pull request #29088: URL: https://github.com/apache/spark/pull/29088#discussion_r454139593 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/CSVOptions.scala ## @@ -135,6 +135,8 @@ class CSVOptions( val positive

[GitHub] [spark] izchen edited a comment on pull request #29028: [SPARK-32212][CORE]RDD.takeOrdered can choose to merge intermediate r…

2020-07-13 Thread GitBox
izchen edited a comment on pull request #29028: URL: https://github.com/apache/spark/pull/29028#issuecomment-657111204 > I'd rather not expose yet another config for this. Are there any heuristics that can select this more intelligently? Thank you very much for code review. Th

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28917: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #28917: URL: https://github.com/apache/spark/pull/28917#issuecomment-658001379 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28917: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

2020-07-13 Thread GitBox
AmplabJenkins commented on pull request #28917: URL: https://github.com/apache/spark/pull/28917#issuecomment-658001379 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28917: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

2020-07-13 Thread GitBox
SparkQA commented on pull request #28917: URL: https://github.com/apache/spark/pull/28917#issuecomment-658000826 **[Test build #125808 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125808/testReport)** for PR 28917 at commit [`ec0d8d0`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-658000513 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins commented on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-07-13 Thread GitBox
AmplabJenkins commented on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-658000513 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] beliefer commented on pull request #28917: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

2020-07-13 Thread GitBox
beliefer commented on pull request #28917: URL: https://github.com/apache/spark/pull/28917#issuecomment-658000356 cc @jiangxb1987 This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29088: [SPARK-32289][SQL] Some characters are garbled when opening csv files with Excel

2020-07-13 Thread GitBox
HyukjinKwon commented on a change in pull request #29088: URL: https://github.com/apache/spark/pull/29088#discussion_r454135608 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala ## @@ -2353,6 +2355,53 @@ abstract class CSVSuite

[GitHub] [spark] beliefer edited a comment on pull request #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec

2020-07-13 Thread GitBox
beliefer edited a comment on pull request #27019: URL: https://github.com/apache/spark/pull/27019#issuecomment-657998428 @maropu I'm sorry! Because the change of https://github.com/apache/spark/pull/27428, each filter clause will be converted to be normal plan. It seems we not need this PR

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29088: [SPARK-32289][SQL] Some characters are garbled when opening csv files with Excel

2020-07-13 Thread GitBox
HyukjinKwon commented on a change in pull request #29088: URL: https://github.com/apache/spark/pull/29088#discussion_r454134455 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CsvOutputWriter.scala ## @@ -39,6 +39,10 @@ class CsvOutputWrite

[GitHub] [spark] beliefer commented on pull request #27019: [SPARK-30027][SQL] Support codegen for aggregate filters in HashAggregateExec

2020-07-13 Thread GitBox
beliefer commented on pull request #27019: URL: https://github.com/apache/spark/pull/27019#issuecomment-657998428 @maropu I'm sorry! Because the change of https://github.com/apache/spark/pull/27428, each filter clause will be converted to be normal plan. So we not need this PR again. ---

[GitHub] [spark] viirya commented on a change in pull request #29086: [SPARK-32292][SPARK-32252][INFRA] Run the relevant tests only in GitHub Actions

2020-07-13 Thread GitBox
viirya commented on a change in pull request #29086: URL: https://github.com/apache/spark/pull/29086#discussion_r454132901 ## File path: dev/run-tests.py ## @@ -589,43 +627,74 @@ def main(): # /home/jenkins/anaconda2/envs/py36/bin os.environ["PATH"] = "/home/a

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29088: [SPARK-32289][SQL] Some characters are garbled when opening csv files with Excel

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #29088: URL: https://github.com/apache/spark/pull/29088#issuecomment-657996178 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29088: [SPARK-32289][SQL] Some characters are garbled when opening csv files with Excel

2020-07-13 Thread GitBox
AmplabJenkins commented on pull request #29088: URL: https://github.com/apache/spark/pull/29088#issuecomment-657996178 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29088: [SPARK-32289][SQL] Some characters are garbled when opening csv files with Excel

2020-07-13 Thread GitBox
SparkQA commented on pull request #29088: URL: https://github.com/apache/spark/pull/29088#issuecomment-657995711 **[Test build #125807 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125807/testReport)** for PR 29088 at commit [`6111a0a`](https://github.com

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29088: [SPARK-32289][SQL] Some characters are garbled when opening csv files with Excel

2020-07-13 Thread GitBox
HyukjinKwon commented on a change in pull request #29088: URL: https://github.com/apache/spark/pull/29088#discussion_r454129942 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala ## @@ -2353,6 +2355,53 @@ abstract class CSVSuite

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28898: [SPARK-32059][SQL] Allow nested schema pruning thru window/sort/filter plans

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #28898: URL: https://github.com/apache/spark/pull/28898#issuecomment-657994219 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28898: [SPARK-32059][SQL] Allow nested schema pruning thru window/sort/filter plans

2020-07-13 Thread GitBox
AmplabJenkins commented on pull request #28898: URL: https://github.com/apache/spark/pull/28898#issuecomment-657994219 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] HyukjinKwon commented on pull request #29088: [SPARK-32289][SQL] Some characters are garbled when opening csv files with Excel

2020-07-13 Thread GitBox
HyukjinKwon commented on pull request #29088: URL: https://github.com/apache/spark/pull/29088#issuecomment-657994072 retest this please This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [spark] SparkQA removed a comment on pull request #28898: [SPARK-32059][SQL] Allow nested schema pruning thru window/sort/filter plans

2020-07-13 Thread GitBox
SparkQA removed a comment on pull request #28898: URL: https://github.com/apache/spark/pull/28898#issuecomment-657904652 **[Test build #125795 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125795/testReport)** for PR 28898 at commit [`2637974`](https://gi

[GitHub] [spark] SparkQA commented on pull request #28898: [SPARK-32059][SQL] Allow nested schema pruning thru window/sort/filter plans

2020-07-13 Thread GitBox
SparkQA commented on pull request #28898: URL: https://github.com/apache/spark/pull/28898#issuecomment-657993700 **[Test build #125795 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125795/testReport)** for PR 28898 at commit [`2637974`](https://github.co

[GitHub] [spark] SaurabhChawla100 commented on a change in pull request #29045: [SPARK-32234][SQL] Spark sql commands are failing on selecting the orc tables

2020-07-13 Thread GitBox
SaurabhChawla100 commented on a change in pull request #29045: URL: https://github.com/apache/spark/pull/29045#discussion_r454128710 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcUtils.scala ## @@ -116,47 +116,53 @@ object OrcUtils ext

[GitHub] [spark] viirya commented on pull request #29018: [SPARK-32202][ML][WIP] tree models auto infer compact integer type

2020-07-13 Thread GitBox
viirya commented on pull request #29018: URL: https://github.com/apache/spark/pull/29018#issuecomment-657993178 Despite the significant memory save, I'm also not sure how often memory is an issue when training the model. I guess CPU is more important here. This win only happens when maxBin

[GitHub] [spark] AmplabJenkins commented on pull request #29095: [SPARK-32298][ML] tree models prediction optimization

2020-07-13 Thread GitBox
AmplabJenkins commented on pull request #29095: URL: https://github.com/apache/spark/pull/29095#issuecomment-657990273 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #29095: [SPARK-32298][ML] tree models prediction optimization

2020-07-13 Thread GitBox
SparkQA removed a comment on pull request #29095: URL: https://github.com/apache/spark/pull/29095#issuecomment-657967512 **[Test build #125804 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125804/testReport)** for PR 29095 at commit [`50510dd`](https://gi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29095: [SPARK-32298][ML] tree models prediction optimization

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #29095: URL: https://github.com/apache/spark/pull/29095#issuecomment-657990273 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #29095: [SPARK-32298][ML] tree models prediction optimization

2020-07-13 Thread GitBox
SparkQA commented on pull request #29095: URL: https://github.com/apache/spark/pull/29095#issuecomment-657990059 **[Test build #125804 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125804/testReport)** for PR 29095 at commit [`50510dd`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29093: [SPARK-32220][SQL][3.0][FOLLOW-UP]SHUFFLE_REPLICATE_NL Hint should not change Non-Cartesian Product join result

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #29093: URL: https://github.com/apache/spark/pull/29093#issuecomment-657989500 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29093: [SPARK-32220][SQL][3.0][FOLLOW-UP]SHUFFLE_REPLICATE_NL Hint should not change Non-Cartesian Product join result

2020-07-13 Thread GitBox
AmplabJenkins commented on pull request #29093: URL: https://github.com/apache/spark/pull/29093#issuecomment-657989500 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29093: [SPARK-32220][SQL][3.0][FOLLOW-UP]SHUFFLE_REPLICATE_NL Hint should not change Non-Cartesian Product join result

2020-07-13 Thread GitBox
SparkQA commented on pull request #29093: URL: https://github.com/apache/spark/pull/29093#issuecomment-657988627 **[Test build #125796 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125796/testReport)** for PR 29093 at commit [`1c078ce`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #29093: [SPARK-32220][SQL][3.0][FOLLOW-UP]SHUFFLE_REPLICATE_NL Hint should not change Non-Cartesian Product join result

2020-07-13 Thread GitBox
SparkQA removed a comment on pull request #29093: URL: https://github.com/apache/spark/pull/29093#issuecomment-657914276 **[Test build #125796 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125796/testReport)** for PR 29093 at commit [`1c078ce`](https://gi

[GitHub] [spark] cloud-fan commented on a change in pull request #28840: [SPARK-31999][SQL] Add REFRESH FUNCTION command

2020-07-13 Thread GitBox
cloud-fan commented on a change in pull request #28840: URL: https://github.com/apache/spark/pull/28840#discussion_r454123447 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala ## @@ -236,6 +236,45 @@ case class ShowFunctionsCommand(

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29087: [SPARK-28227][SQL] Support TRANSFORM with aggregation

2020-07-13 Thread GitBox
AngersZh commented on a change in pull request #29087: URL: https://github.com/apache/spark/pull/29087#discussion_r454102278 ## File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ## @@ -496,7 +496,9 @@ fromStatementBody querySpecificat

[GitHub] [spark] SparkQA commented on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-07-13 Thread GitBox
SparkQA commented on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-657987750 **[Test build #125806 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125806/testReport)** for PR 28708 at commit [`5a0cd2a`](https://github.com

[GitHub] [spark] cloud-fan commented on a change in pull request #29045: [SPARK-32234][SQL] Spark sql commands are failing on selecting the orc tables

2020-07-13 Thread GitBox
cloud-fan commented on a change in pull request #29045: URL: https://github.com/apache/spark/pull/29045#discussion_r454122245 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcUtils.scala ## @@ -116,47 +116,53 @@ object OrcUtils extends Lo

[GitHub] [spark] holdenk commented on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-07-13 Thread GitBox
holdenk commented on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-657985918 Jenkins retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] SaurabhChawla100 commented on a change in pull request #29045: [SPARK-32234][SQL] Spark sql commands are failing on selecting the orc tables

2020-07-13 Thread GitBox
SaurabhChawla100 commented on a change in pull request #29045: URL: https://github.com/apache/spark/pull/29045#discussion_r454120426 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFileFormat.scala ## @@ -179,12 +179,17 @@ class OrcFileF

[GitHub] [spark] cloud-fan commented on a change in pull request #29045: [SPARK-32234][SQL] Spark sql commands are failing on selecting the orc tables

2020-07-13 Thread GitBox
cloud-fan commented on a change in pull request #29045: URL: https://github.com/apache/spark/pull/29045#discussion_r454119852 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFileFormat.scala ## @@ -179,12 +179,17 @@ class OrcFileFormat

[GitHub] [spark] zhengruifeng commented on pull request #29018: [SPARK-32202][ML][WIP] tree models auto infer compact integer type

2020-07-13 Thread GitBox
zhengruifeng commented on pull request #29018: URL: https://github.com/apache/spark/pull/29018#issuecomment-657984250 @huaxingao @WeichenXu123 @viirya How do you think about saving ~70% (Array[Int] -> Array[Byte]) RAM at the cost of somewhat regression (1% ~ 10%)?

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-657984010 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-07-13 Thread GitBox
AmplabJenkins commented on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-657984010 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-07-13 Thread GitBox
SparkQA removed a comment on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-657927290 **[Test build #125799 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125799/testReport)** for PR 28708 at commit [`5a0cd2a`](https://gi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-657937025 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8

[GitHub] [spark] SparkQA commented on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-07-13 Thread GitBox
SparkQA commented on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-657983486 **[Test build #125799 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125799/testReport)** for PR 28708 at commit [`5a0cd2a`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29090: [WIP][SPARK-32293] Fix inconsistency between Spark memory configs and JVM option

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #29090: URL: https://github.com/apache/spark/pull/29090#issuecomment-657982803 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SaurabhChawla100 edited a comment on pull request #29045: [SPARK-32234][SQL] Spark sql commands are failing on selecting the orc tables

2020-07-13 Thread GitBox
SaurabhChawla100 edited a comment on pull request #29045: URL: https://github.com/apache/spark/pull/29045#issuecomment-657978027 > Can you be more specific about the problem? Are you saying that the actual file schema doesn't match the table schema specified by the user? So in case o

[GitHub] [spark] AmplabJenkins commented on pull request #29090: [WIP][SPARK-32293] Fix inconsistency between Spark memory configs and JVM option

2020-07-13 Thread GitBox
AmplabJenkins commented on pull request #29090: URL: https://github.com/apache/spark/pull/29090#issuecomment-657982803 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] cloud-fan commented on pull request #29091: [SPARK-32258][SQL] Not duplicate normalization on children for float/double If/CaseWhen/Coalesce

2020-07-13 Thread GitBox
cloud-fan commented on pull request #29091: URL: https://github.com/apache/spark/pull/29091#issuecomment-657982389 thanks, merging to master! This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [spark] cloud-fan closed pull request #29091: [SPARK-32258][SQL] Not duplicate normalization on children for float/double If/CaseWhen/Coalesce

2020-07-13 Thread GitBox
cloud-fan closed pull request #29091: URL: https://github.com/apache/spark/pull/29091 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [spark] SparkQA commented on pull request #29090: [WIP][SPARK-32293] Fix inconsistency between Spark memory configs and JVM option

2020-07-13 Thread GitBox
SparkQA commented on pull request #29090: URL: https://github.com/apache/spark/pull/29090#issuecomment-657982312 **[Test build #125801 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125801/testReport)** for PR 29090 at commit [`dfbce91`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #29090: [WIP][SPARK-32293] Fix inconsistency between Spark memory configs and JVM option

2020-07-13 Thread GitBox
SparkQA removed a comment on pull request #29090: URL: https://github.com/apache/spark/pull/29090#issuecomment-657931374 **[Test build #125801 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125801/testReport)** for PR 29090 at commit [`dfbce91`](https://gi

[GitHub] [spark] SaurabhChawla100 commented on pull request #29045: [SPARK-32234][SQL] Spark sql commands are failing on selecting the orc tables

2020-07-13 Thread GitBox
SaurabhChawla100 commented on pull request #29045: URL: https://github.com/apache/spark/pull/29045#issuecomment-657978027 > Can you be more specific about the problem? Are you saying that the actual file schema doesn't match the table schema specified by the user? So in case of orc d

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29077: [SPARK-31985][SS] Remove incomplete/undocumented stateful aggregation in continuous mode

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #29077: URL: https://github.com/apache/spark/pull/29077#issuecomment-657976343 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29077: [SPARK-31985][SS] Remove incomplete/undocumented stateful aggregation in continuous mode

2020-07-13 Thread GitBox
AmplabJenkins commented on pull request #29077: URL: https://github.com/apache/spark/pull/29077#issuecomment-657976343 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #29077: [SPARK-31985][SS] Remove incomplete/undocumented stateful aggregation in continuous mode

2020-07-13 Thread GitBox
SparkQA removed a comment on pull request #29077: URL: https://github.com/apache/spark/pull/29077#issuecomment-657891341 **[Test build #125792 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125792/testReport)** for PR 29077 at commit [`5459d58`](https://gi

[GitHub] [spark] SparkQA commented on pull request #29077: [SPARK-31985][SS] Remove incomplete/undocumented stateful aggregation in continuous mode

2020-07-13 Thread GitBox
SparkQA commented on pull request #29077: URL: https://github.com/apache/spark/pull/29077#issuecomment-657975832 **[Test build #125792 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125792/testReport)** for PR 29077 at commit [`5459d58`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29088: [SPARK-32289][SQL] Some characters are garbled when opening csv files with Excel

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #29088: URL: https://github.com/apache/spark/pull/29088#issuecomment-657974472 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29088: [SPARK-32289][SQL] Some characters are garbled when opening csv files with Excel

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #29088: URL: https://github.com/apache/spark/pull/29088#issuecomment-657974464 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins commented on pull request #29088: [SPARK-32289][SQL] Some characters are garbled when opening csv files with Excel

2020-07-13 Thread GitBox
AmplabJenkins commented on pull request #29088: URL: https://github.com/apache/spark/pull/29088#issuecomment-657974464 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #29088: [SPARK-32289][SQL] Some characters are garbled when opening csv files with Excel

2020-07-13 Thread GitBox
SparkQA removed a comment on pull request #29088: URL: https://github.com/apache/spark/pull/29088#issuecomment-657904577 **[Test build #125794 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125794/testReport)** for PR 29088 at commit [`6111a0a`](https://gi

[GitHub] [spark] AmplabJenkins commented on pull request #28901: [SPARK-32064][SQL] Supporting create temporary table

2020-07-13 Thread GitBox
AmplabJenkins commented on pull request #28901: URL: https://github.com/apache/spark/pull/28901#issuecomment-657974354 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28901: [SPARK-32064][SQL] Supporting create temporary table

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #28901: URL: https://github.com/apache/spark/pull/28901#issuecomment-657974354 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #29088: [SPARK-32289][SQL] Some characters are garbled when opening csv files with Excel

2020-07-13 Thread GitBox
SparkQA commented on pull request #29088: URL: https://github.com/apache/spark/pull/29088#issuecomment-657974102 **[Test build #125794 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125794/testReport)** for PR 29088 at commit [`6111a0a`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #28901: [SPARK-32064][SQL] Supporting create temporary table

2020-07-13 Thread GitBox
SparkQA commented on pull request #28901: URL: https://github.com/apache/spark/pull/28901#issuecomment-657973941 **[Test build #125805 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125805/testReport)** for PR 28901 at commit [`9b11aac`](https://github.com

[GitHub] [spark] LantaoJin commented on pull request #28901: [SPARK-32064][SQL] Supporting create temporary table

2020-07-13 Thread GitBox
LantaoJin commented on pull request #28901: URL: https://github.com/apache/spark/pull/28901#issuecomment-657972128 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29095: [SPARK-32298][ML] tree models prediction optimization

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #29095: URL: https://github.com/apache/spark/pull/29095#issuecomment-657967907 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29095: [SPARK-32298][ML] tree models prediction optimization

2020-07-13 Thread GitBox
AmplabJenkins commented on pull request #29095: URL: https://github.com/apache/spark/pull/29095#issuecomment-657967907 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29087: [SPARK-28227][SQL] Support TRANSFORM with aggregation

2020-07-13 Thread GitBox
AngersZh commented on a change in pull request #29087: URL: https://github.com/apache/spark/pull/29087#discussion_r454102278 ## File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ## @@ -496,7 +496,9 @@ fromStatementBody querySpecificat

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29087: [SPARK-28227][SQL] Support TRANSFORM with aggregation

2020-07-13 Thread GitBox
AngersZh commented on a change in pull request #29087: URL: https://github.com/apache/spark/pull/29087#discussion_r454045113 ## File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ## @@ -496,7 +496,9 @@ fromStatementBody querySpecificat

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29087: [SPARK-28227][SQL] Support TRANSFORM with aggregation

2020-07-13 Thread GitBox
AngersZh commented on a change in pull request #29087: URL: https://github.com/apache/spark/pull/29087#discussion_r454101882 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala ## @@ -2558,6 +2558,131 @@ abstract class SQLQuerySuit

[GitHub] [spark] SparkQA commented on pull request #29095: [SPARK-32298][ML] tree models prediction optimization

2020-07-13 Thread GitBox
SparkQA commented on pull request #29095: URL: https://github.com/apache/spark/pull/29095#issuecomment-657967512 **[Test build #125804 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125804/testReport)** for PR 29095 at commit [`50510dd`](https://github.com

[GitHub] [spark] zhengruifeng commented on pull request #29095: [SPARK-32298][ML] tree models prediction optimization

2020-07-13 Thread GitBox
zhengruifeng commented on pull request #29095: URL: https://github.com/apache/spark/pull/29095#issuecomment-657966575 test: ``` import org.apache.spark.ml.linalg._ import org.apache.spark.ml.classification._ import org.apache.spark.storage.StorageLevel val df = spark.r

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28840: [SPARK-31999][SQL] Add REFRESH FUNCTION command

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #28840: URL: https://github.com/apache/spark/pull/28840#issuecomment-657965897 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125

[GitHub] [spark] ulysses-you commented on a change in pull request #28840: [SPARK-31999][SQL] Add REFRESH FUNCTION command

2020-07-13 Thread GitBox
ulysses-you commented on a change in pull request #28840: URL: https://github.com/apache/spark/pull/28840#discussion_r454099903 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala ## @@ -236,6 +236,45 @@ case class ShowFunctionsCommand(

[GitHub] [spark] zhengruifeng opened a new pull request #29095: [SPARK-32298][ML] tree models prediction optimization

2020-07-13 Thread GitBox
zhengruifeng opened a new pull request #29095: URL: https://github.com/apache/spark/pull/29095 ### What changes were proposed in this pull request? use while-loop instead of the recursive way ### Why are the changes needed? 3% ~ 10% faster ### Does this PR introdu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28840: [SPARK-31999][SQL] Add REFRESH FUNCTION command

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #28840: URL: https://github.com/apache/spark/pull/28840#issuecomment-657965895 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins commented on pull request #28840: [SPARK-31999][SQL] Add REFRESH FUNCTION command

2020-07-13 Thread GitBox
AmplabJenkins commented on pull request #28840: URL: https://github.com/apache/spark/pull/28840#issuecomment-657965895 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #28840: [SPARK-31999][SQL] Add REFRESH FUNCTION command

2020-07-13 Thread GitBox
SparkQA removed a comment on pull request #28840: URL: https://github.com/apache/spark/pull/28840#issuecomment-657893231 **[Test build #125793 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125793/testReport)** for PR 28840 at commit [`c129a54`](https://gi

[GitHub] [spark] SparkQA commented on pull request #28840: [SPARK-31999][SQL] Add REFRESH FUNCTION command

2020-07-13 Thread GitBox
SparkQA commented on pull request #28840: URL: https://github.com/apache/spark/pull/28840#issuecomment-657965588 **[Test build #125793 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125793/testReport)** for PR 28840 at commit [`c129a54`](https://github.co

[GitHub] [spark] viirya commented on pull request #29091: [SPARK-32258][SQL] Not duplicate normalization on children for float/double If/CaseWhen/Coalesce

2020-07-13 Thread GitBox
viirya commented on pull request #29091: URL: https://github.com/apache/spark/pull/29091#issuecomment-657965371 cc @cloud-fan This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] ulysses-you commented on a change in pull request #28840: [SPARK-31999][SQL] Add REFRESH FUNCTION command

2020-07-13 Thread GitBox
ulysses-you commented on a change in pull request #28840: URL: https://github.com/apache/spark/pull/28840#discussion_r454098536 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala ## @@ -236,6 +236,45 @@ case class ShowFunctionsCommand(

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27428: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #27428: URL: https://github.com/apache/spark/pull/27428#issuecomment-657964078 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125

[GitHub] [spark] AmplabJenkins commented on pull request #28939: [SPARK-32119][CORE] ExecutorPlugin doesn't work with Standalone Cluster

2020-07-13 Thread GitBox
AmplabJenkins commented on pull request #28939: URL: https://github.com/apache/spark/pull/28939#issuecomment-657964151 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #27428: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-07-13 Thread GitBox
AmplabJenkins commented on pull request #27428: URL: https://github.com/apache/spark/pull/27428#issuecomment-657964073 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28939: [SPARK-32119][CORE] ExecutorPlugin doesn't work with Standalone Cluster

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #28939: URL: https://github.com/apache/spark/pull/28939#issuecomment-657964151 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27428: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #27428: URL: https://github.com/apache/spark/pull/27428#issuecomment-657964073 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28939: [SPARK-32119][CORE] ExecutorPlugin doesn't work with Standalone Cluster

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #28939: URL: https://github.com/apache/spark/pull/28939#issuecomment-657890028 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125

[GitHub] [spark] SparkQA commented on pull request #28939: [SPARK-32119][CORE] ExecutorPlugin doesn't work with Standalone Cluster

2020-07-13 Thread GitBox
SparkQA commented on pull request #28939: URL: https://github.com/apache/spark/pull/28939#issuecomment-657963838 **[Test build #125803 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125803/testReport)** for PR 28939 at commit [`449df2b`](https://github.com

[GitHub] [spark] SparkQA removed a comment on pull request #27428: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-07-13 Thread GitBox
SparkQA removed a comment on pull request #27428: URL: https://github.com/apache/spark/pull/27428#issuecomment-657927315 **[Test build #125800 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125800/testReport)** for PR 27428 at commit [`20ad143`](https://gi

[GitHub] [spark] SparkQA commented on pull request #27428: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-07-13 Thread GitBox
SparkQA commented on pull request #27428: URL: https://github.com/apache/spark/pull/27428#issuecomment-657963736 **[Test build #125800 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125800/testReport)** for PR 27428 at commit [`20ad143`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29064: [SPARK-32272][SQL] Add SQL standard command SET TIME ZONE

2020-07-13 Thread GitBox
AmplabJenkins removed a comment on pull request #29064: URL: https://github.com/apache/spark/pull/29064#issuecomment-657962666 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29064: [SPARK-32272][SQL] Add SQL standard command SET TIME ZONE

2020-07-13 Thread GitBox
AmplabJenkins commented on pull request #29064: URL: https://github.com/apache/spark/pull/29064#issuecomment-657962666 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #29064: [SPARK-32272][SQL] Add SQL standard command SET TIME ZONE

2020-07-13 Thread GitBox
SparkQA removed a comment on pull request #29064: URL: https://github.com/apache/spark/pull/29064#issuecomment-657876739 **[Test build #125791 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125791/testReport)** for PR 29064 at commit [`5501213`](https://gi

  1   2   3   4   5   6   7   >