[GitHub] [spark] AmplabJenkins removed a comment on pull request #29015: [SPARK-32215] Expose a (protected) /workers/kill endpoint on the MasterWebUI

2020-07-16 Thread GitBox
AmplabJenkins removed a comment on pull request #29015: URL: https://github.com/apache/spark/pull/29015#issuecomment-659203698 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125

[GitHub] [spark] AmplabJenkins commented on pull request #27694: [SPARK-30946][SS] Serde entry via DataInputStream/DataOutputStream with LZ4 compression on FileStream(Source/Sink)Log

2020-07-16 Thread GitBox
AmplabJenkins commented on pull request #27694: URL: https://github.com/apache/spark/pull/27694#issuecomment-659204104 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29101: [SPARK-32302][SQL] Partially push down disjunctive predicates through Join/Partitions

2020-07-16 Thread GitBox
SparkQA commented on pull request #29101: URL: https://github.com/apache/spark/pull/29101#issuecomment-659204292 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29064: [SPARK-32272][SQL] Add SQL standard command SET TIME ZONE

2020-07-16 Thread GitBox
AmplabJenkins removed a comment on pull request #29064: URL: https://github.com/apache/spark/pull/29064#issuecomment-659203193 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125

[GitHub] [spark] AmplabJenkins commented on pull request #28904: [SPARK-30462][SS] Streamline the logic on file stream source and sink metadata log to avoid memory issue

2020-07-16 Thread GitBox
AmplabJenkins commented on pull request #28904: URL: https://github.com/apache/spark/pull/28904#issuecomment-659204164 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28961: [SPARK-32143][SQL] Prevent a skewed join from producing too many partition splits

2020-07-16 Thread GitBox
AmplabJenkins removed a comment on pull request #28961: URL: https://github.com/apache/spark/pull/28961#issuecomment-659203593 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29130: [SPARK-32330][SQL] Preserve shuffled hash join build side partitioning

2020-07-16 Thread GitBox
AmplabJenkins removed a comment on pull request #29130: URL: https://github.com/apache/spark/pull/29130#issuecomment-659176704 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29126: [SPARK-32324][SQL]Fix error messages during using PIVOT and lateral view

2020-07-16 Thread GitBox
AmplabJenkins removed a comment on pull request #29126: URL: https://github.com/apache/spark/pull/29126#issuecomment-659203468 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29002: [SPARK-32175][CORE] Fix the order between initialization for ExecutorPlugin and starting heartbeat thread

2020-07-16 Thread GitBox
AmplabJenkins removed a comment on pull request #29002: URL: https://github.com/apache/spark/pull/29002#issuecomment-659204047 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27694: [SPARK-30946][SS] Serde entry via DataInputStream/DataOutputStream with LZ4 compression on FileStream(Source/Sink)Log

2020-07-16 Thread GitBox
AmplabJenkins removed a comment on pull request #27694: URL: https://github.com/apache/spark/pull/27694#issuecomment-659204104 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29002: [SPARK-32175][CORE] Fix the order between initialization for ExecutorPlugin and starting heartbeat thread

2020-07-16 Thread GitBox
AmplabJenkins removed a comment on pull request #29002: URL: https://github.com/apache/spark/pull/29002#issuecomment-659204058 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125

[GitHub] [spark] AmplabJenkins commented on pull request #28804: [SPARK-31973][SQL] Add ability to disable Sort,Spill in Partial aggregation

2020-07-16 Thread GitBox
AmplabJenkins commented on pull request #28804: URL: https://github.com/apache/spark/pull/28804#issuecomment-659204777 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27694: [SPARK-30946][SS] Serde entry via DataInputStream/DataOutputStream with LZ4 compression on FileStream(Source/Sink)Log

2020-07-16 Thread GitBox
AmplabJenkins removed a comment on pull request #27694: URL: https://github.com/apache/spark/pull/27694#issuecomment-659204116 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29032: [SPARK-32217] Plumb whether a worker would also be decommissioned along with executor

2020-07-16 Thread GitBox
AmplabJenkins removed a comment on pull request #29032: URL: https://github.com/apache/spark/pull/29032#issuecomment-659204466 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28904: [SPARK-30462][SS] Streamline the logic on file stream source and sink metadata log to avoid memory issue

2020-07-16 Thread GitBox
AmplabJenkins removed a comment on pull request #28904: URL: https://github.com/apache/spark/pull/28904#issuecomment-659204164 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins commented on pull request #29032: [SPARK-32217] Plumb whether a worker would also be decommissioned along with executor

2020-07-16 Thread GitBox
AmplabJenkins commented on pull request #29032: URL: https://github.com/apache/spark/pull/29032#issuecomment-659204466 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29032: [SPARK-32217] Plumb whether a worker would also be decommissioned along with executor

2020-07-16 Thread GitBox
AmplabJenkins removed a comment on pull request #29032: URL: https://github.com/apache/spark/pull/29032#issuecomment-659204481 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28804: [SPARK-31973][SQL] Add ability to disable Sort,Spill in Partial aggregation

2020-07-16 Thread GitBox
AmplabJenkins removed a comment on pull request #28804: URL: https://github.com/apache/spark/pull/28804#issuecomment-659204777 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins commented on pull request #27366: [SPARK-30648][SQL] Support filters pushdown in JSON datasource

2020-07-16 Thread GitBox
AmplabJenkins commented on pull request #27366: URL: https://github.com/apache/spark/pull/27366#issuecomment-659204950 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27366: [SPARK-30648][SQL] Support filters pushdown in JSON datasource

2020-07-16 Thread GitBox
AmplabJenkins removed a comment on pull request #27366: URL: https://github.com/apache/spark/pull/27366#issuecomment-659204950 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28904: [SPARK-30462][SS] Streamline the logic on file stream source and sink metadata log to avoid memory issue

2020-07-16 Thread GitBox
AmplabJenkins removed a comment on pull request #28904: URL: https://github.com/apache/spark/pull/28904#issuecomment-659204179 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28804: [SPARK-31973][SQL] Add ability to disable Sort,Spill in Partial aggregation

2020-07-16 Thread GitBox
AmplabJenkins removed a comment on pull request #28804: URL: https://github.com/apache/spark/pull/28804#issuecomment-659204788 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125

[GitHub] [spark] maropu commented on a change in pull request #29079: [SPARK-32286][SQL] Coalesce bucketed table for shuffled hash join if applicable

2020-07-16 Thread GitBox
maropu commented on a change in pull request #29079: URL: https://github.com/apache/spark/pull/29079#discussion_r47231 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/bucketing/CoalesceBucketsInJoin.scala ## @@ -0,0 +1,175 @@ +/* + * Licensed to the Ap

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27366: [SPARK-30648][SQL] Support filters pushdown in JSON datasource

2020-07-16 Thread GitBox
AmplabJenkins removed a comment on pull request #27366: URL: https://github.com/apache/spark/pull/27366#issuecomment-659204960 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125

[GitHub] [spark] maropu commented on pull request #29079: [SPARK-32286][SQL] Coalesce bucketed table for shuffled hash join if applicable

2020-07-16 Thread GitBox
maropu commented on pull request #29079: URL: https://github.com/apache/spark/pull/29079#issuecomment-659207696 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [spark] HeartSaVioR commented on pull request #27694: [SPARK-30946][SS] Serde entry via DataInputStream/DataOutputStream with LZ4 compression on FileStream(Source/Sink)Log

2020-07-16 Thread GitBox
HeartSaVioR commented on pull request #27694: URL: https://github.com/apache/spark/pull/27694#issuecomment-659208937 retest this, please This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [spark] HeartSaVioR commented on pull request #28904: [SPARK-30462][SS] Streamline the logic on file stream source and sink metadata log to avoid memory issue

2020-07-16 Thread GitBox
HeartSaVioR commented on pull request #28904: URL: https://github.com/apache/spark/pull/28904#issuecomment-659208890 retest this, please This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [spark] HeartSaVioR commented on pull request #29129: [SPARK-31831][SQL][TESTS] Put mocks in hive version subdirectory

2020-07-16 Thread GitBox
HeartSaVioR commented on pull request #29129: URL: https://github.com/apache/spark/pull/29129#issuecomment-659209080 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29129: [SPARK-31831][SQL][TESTS] Put mocks in hive version subdirectory

2020-07-16 Thread GitBox
AmplabJenkins removed a comment on pull request #29129: URL: https://github.com/apache/spark/pull/29129#issuecomment-659158107 Can one of the admins verify this patch? This is an automated message from the Apache Git Service.

[GitHub] [spark] SparkQA commented on pull request #28904: [SPARK-30462][SS] Streamline the logic on file stream source and sink metadata log to avoid memory issue

2020-07-16 Thread GitBox
SparkQA commented on pull request #28904: URL: https://github.com/apache/spark/pull/28904#issuecomment-659210212 **[Test build #125956 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125956/testReport)** for PR 28904 at commit [`247a0a1`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #29079: [SPARK-32286][SQL] Coalesce bucketed table for shuffled hash join if applicable

2020-07-16 Thread GitBox
SparkQA commented on pull request #29079: URL: https://github.com/apache/spark/pull/29079#issuecomment-659210167 **[Test build #125955 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125955/testReport)** for PR 29079 at commit [`11d138b`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #27694: [SPARK-30946][SS] Serde entry via DataInputStream/DataOutputStream with LZ4 compression on FileStream(Source/Sink)Log

2020-07-16 Thread GitBox
SparkQA commented on pull request #27694: URL: https://github.com/apache/spark/pull/27694#issuecomment-659210241 **[Test build #125957 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125957/testReport)** for PR 27694 at commit [`2559928`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #29117: [WIP] Debug flaky pip installation test failure

2020-07-16 Thread GitBox
SparkQA commented on pull request #29117: URL: https://github.com/apache/spark/pull/29117#issuecomment-659210878 **[Test build #125942 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125942/testReport)** for PR 29117 at commit [`25e87b5`](https://github.co

[GitHub] [spark] AmplabJenkins commented on pull request #29079: [SPARK-32286][SQL] Coalesce bucketed table for shuffled hash join if applicable

2020-07-16 Thread GitBox
AmplabJenkins commented on pull request #29079: URL: https://github.com/apache/spark/pull/29079#issuecomment-659210905 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #28904: [SPARK-30462][SS] Streamline the logic on file stream source and sink metadata log to avoid memory issue

2020-07-16 Thread GitBox
AmplabJenkins commented on pull request #28904: URL: https://github.com/apache/spark/pull/28904#issuecomment-659210920 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #29117: [WIP] Debug flaky pip installation test failure

2020-07-16 Thread GitBox
AmplabJenkins commented on pull request #29117: URL: https://github.com/apache/spark/pull/29117#issuecomment-659210980 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29079: [SPARK-32286][SQL] Coalesce bucketed table for shuffled hash join if applicable

2020-07-16 Thread GitBox
AmplabJenkins removed a comment on pull request #29079: URL: https://github.com/apache/spark/pull/29079#issuecomment-659210905 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29117: [WIP] Debug flaky pip installation test failure

2020-07-16 Thread GitBox
AmplabJenkins removed a comment on pull request #29117: URL: https://github.com/apache/spark/pull/29117#issuecomment-659210980 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] SparkQA removed a comment on pull request #29117: [WIP] Debug flaky pip installation test failure

2020-07-16 Thread GitBox
SparkQA removed a comment on pull request #29117: URL: https://github.com/apache/spark/pull/29117#issuecomment-659201907 **[Test build #125942 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125942/testReport)** for PR 29117 at commit [`25e87b5`](https://gi

[GitHub] [spark] AmplabJenkins commented on pull request #27694: [SPARK-30946][SS] Serde entry via DataInputStream/DataOutputStream with LZ4 compression on FileStream(Source/Sink)Log

2020-07-16 Thread GitBox
AmplabJenkins commented on pull request #27694: URL: https://github.com/apache/spark/pull/27694#issuecomment-659211273 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28904: [SPARK-30462][SS] Streamline the logic on file stream source and sink metadata log to avoid memory issue

2020-07-16 Thread GitBox
AmplabJenkins removed a comment on pull request #28904: URL: https://github.com/apache/spark/pull/28904#issuecomment-659210920 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] moomindani commented on pull request #27690: [SPARK-21514][SQL] Added a new option to use non-blobstore storage when writing into blobstore storage

2020-07-16 Thread GitBox
moomindani commented on pull request #27690: URL: https://github.com/apache/spark/pull/27690#issuecomment-659211589 @viirya, sorry for pinging you multiple times. It would be great if you can take a look when you have a time. -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29117: [WIP] Debug flaky pip installation test failure

2020-07-16 Thread GitBox
AmplabJenkins removed a comment on pull request #29117: URL: https://github.com/apache/spark/pull/29117#issuecomment-659210990 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27694: [SPARK-30946][SS] Serde entry via DataInputStream/DataOutputStream with LZ4 compression on FileStream(Source/Sink)Log

2020-07-16 Thread GitBox
AmplabJenkins removed a comment on pull request #27694: URL: https://github.com/apache/spark/pull/27694#issuecomment-659211273 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #29117: [WIP] Debug flaky pip installation test failure

2020-07-16 Thread GitBox
SparkQA commented on pull request #29117: URL: https://github.com/apache/spark/pull/29117#issuecomment-659214173 **[Test build #125943 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125943/testReport)** for PR 29117 at commit [`791e8ff`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29117: [WIP] Debug flaky pip installation test failure

2020-07-16 Thread GitBox
AmplabJenkins removed a comment on pull request #29117: URL: https://github.com/apache/spark/pull/29117#issuecomment-659214215 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins commented on pull request #29117: [WIP] Debug flaky pip installation test failure

2020-07-16 Thread GitBox
AmplabJenkins commented on pull request #29117: URL: https://github.com/apache/spark/pull/29117#issuecomment-659214215 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #29117: [WIP] Debug flaky pip installation test failure

2020-07-16 Thread GitBox
SparkQA removed a comment on pull request #29117: URL: https://github.com/apache/spark/pull/29117#issuecomment-659202365 **[Test build #125943 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125943/testReport)** for PR 29117 at commit [`791e8ff`](https://gi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29117: [WIP] Debug flaky pip installation test failure

2020-07-16 Thread GitBox
AmplabJenkins removed a comment on pull request #29117: URL: https://github.com/apache/spark/pull/29117#issuecomment-659214225 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125

[GitHub] [spark] imback82 commented on a change in pull request #29127: [SPARK-32327][SQL] Introduce UnresolvedTableOrPermanentView for commands that support a table and permanent view, but not a temp

2020-07-16 Thread GitBox
imback82 commented on a change in pull request #29127: URL: https://github.com/apache/spark/pull/29127#discussion_r455567057 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ## @@ -920,7 +920,7 @@ case class ShowTablePropertiesCommand(t

[GitHub] [spark] imback82 commented on pull request #29127: [SPARK-32327][SQL] Introduce UnresolvedTableOrPermanentView for commands that support a table and permanent view, but not a temporary view

2020-07-16 Thread GitBox
imback82 commented on pull request #29127: URL: https://github.com/apache/spark/pull/29127#issuecomment-659215915 cc: @cloud-fan @viirya This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [spark] MaxGekk commented on pull request #27366: [SPARK-30648][SQL] Support filters pushdown in JSON datasource

2020-07-16 Thread GitBox
MaxGekk commented on pull request #27366: URL: https://github.com/apache/spark/pull/27366#issuecomment-659217624 jenkins, retest this, please This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [spark] SparkQA commented on pull request #27366: [SPARK-30648][SQL] Support filters pushdown in JSON datasource

2020-07-16 Thread GitBox
SparkQA commented on pull request #27366: URL: https://github.com/apache/spark/pull/27366#issuecomment-659217990 **[Test build #125958 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125958/testReport)** for PR 27366 at commit [`57524d6`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27366: [SPARK-30648][SQL] Support filters pushdown in JSON datasource

2020-07-16 Thread GitBox
AmplabJenkins removed a comment on pull request #27366: URL: https://github.com/apache/spark/pull/27366#issuecomment-659218583 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #27366: [SPARK-30648][SQL] Support filters pushdown in JSON datasource

2020-07-16 Thread GitBox
AmplabJenkins commented on pull request #27366: URL: https://github.com/apache/spark/pull/27366#issuecomment-659218583 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] GuoPhilipse commented on a change in pull request #29056: [SPARK-31753][SQL][DOCS] Add missing keywords in the SQL docs

2020-07-16 Thread GitBox
GuoPhilipse commented on a change in pull request #29056: URL: https://github.com/apache/spark/pull/29056#discussion_r455571961 ## File path: docs/sql-ref-syntax-qry-select-case.md ## @@ -0,0 +1,114 @@ +--- +layout: global +title: CASE Clause +displayTitle: CASE Clause +license

[GitHub] [spark] GuoPhilipse commented on a change in pull request #29056: [SPARK-31753][SQL][DOCS] Add missing keywords in the SQL docs

2020-07-16 Thread GitBox
GuoPhilipse commented on a change in pull request #29056: URL: https://github.com/apache/spark/pull/29056#discussion_r455572972 ## File path: docs/sql-ref-syntax-qry-select-case.md ## @@ -0,0 +1,114 @@ +--- +layout: global +title: CASE Clause +displayTitle: CASE Clause +license

[GitHub] [spark] SparkQA commented on pull request #29064: [SPARK-32272][SQL] Add SQL standard command SET TIME ZONE

2020-07-16 Thread GitBox
SparkQA commented on pull request #29064: URL: https://github.com/apache/spark/pull/29064#issuecomment-659221768 **[Test build #125959 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125959/testReport)** for PR 29064 at commit [`11f0fed`](https://github.com

[GitHub] [spark] AmplabJenkins commented on pull request #29064: [SPARK-32272][SQL] Add SQL standard command SET TIME ZONE

2020-07-16 Thread GitBox
AmplabJenkins commented on pull request #29064: URL: https://github.com/apache/spark/pull/29064#issuecomment-65934 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29064: [SPARK-32272][SQL] Add SQL standard command SET TIME ZONE

2020-07-16 Thread GitBox
AmplabJenkins removed a comment on pull request #29064: URL: https://github.com/apache/spark/pull/29064#issuecomment-65934 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] maropu commented on pull request #29126: [SPARK-32324][SQL]Fix error messages during using PIVOT and lateral view

2020-07-16 Thread GitBox
maropu commented on pull request #29126: URL: https://github.com/apache/spark/pull/29126#issuecomment-659222596 The mssage update itself seems okay; cc: @maryannxue @gatorsmile cuz I checked the original PR for `PIVOT`: https://github.com/apache/spark/pull/21187 --

[GitHub] [spark] cloud-fan commented on a change in pull request #29064: [SPARK-32272][SQL] Add SQL standard command SET TIME ZONE

2020-07-16 Thread GitBox
cloud-fan commented on a change in pull request #29064: URL: https://github.com/apache/spark/pull/29064#discussion_r455574818 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ## @@ -90,6 +92,41 @@ class SparkSqlAstBuilder(conf: SQLConf)

[GitHub] [spark] GuoPhilipse commented on a change in pull request #29056: [SPARK-31753][SQL][DOCS] Add missing keywords in the SQL docs

2020-07-16 Thread GitBox
GuoPhilipse commented on a change in pull request #29056: URL: https://github.com/apache/spark/pull/29056#discussion_r455576141 ## File path: docs/sql-ref-syntax-qry.md ## @@ -45,4 +45,7 @@ ability to generate logical and physical plan for a given query using * [TABLESAMPLE

[GitHub] [spark] yaooqinn commented on a change in pull request #29064: [SPARK-32272][SQL] Add SQL standard command SET TIME ZONE

2020-07-16 Thread GitBox
yaooqinn commented on a change in pull request #29064: URL: https://github.com/apache/spark/pull/29064#discussion_r455577033 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ## @@ -90,6 +92,41 @@ class SparkSqlAstBuilder(conf: SQLConf)

[GitHub] [spark] yaooqinn commented on a change in pull request #29064: [SPARK-32272][SQL] Add SQL standard command SET TIME ZONE

2020-07-16 Thread GitBox
yaooqinn commented on a change in pull request #29064: URL: https://github.com/apache/spark/pull/29064#discussion_r455577033 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ## @@ -90,6 +92,41 @@ class SparkSqlAstBuilder(conf: SQLConf)

[GitHub] [spark] yaooqinn commented on a change in pull request #29064: [SPARK-32272][SQL] Add SQL standard command SET TIME ZONE

2020-07-16 Thread GitBox
yaooqinn commented on a change in pull request #29064: URL: https://github.com/apache/spark/pull/29064#discussion_r455582428 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ## @@ -90,6 +92,41 @@ class SparkSqlAstBuilder(conf: SQLConf)

[GitHub] [spark] HeartSaVioR commented on pull request #29129: [SPARK-31831][SQL][TESTS][FOLLOWUP] Put mocks for HiveSessionImplSuite in hive version related subdirectories

2020-07-16 Thread GitBox
HeartSaVioR commented on pull request #29129: URL: https://github.com/apache/spark/pull/29129#issuecomment-659228558 Could you update the PR description to be self-explanation? That description becomes a commit message, so we tend to put the best effort to fill up the content. And c

[GitHub] [spark] cloud-fan commented on pull request #29067: [SPARK-32274][SQL] Make SQL cache serialization pluggable

2020-07-16 Thread GitBox
cloud-fan commented on pull request #29067: URL: https://github.com/apache/spark/pull/29067#issuecomment-659229267 Yea IMO this is not a big feature that requires SPIP. At a high-level, this idea makes sense to me. With the columnar engine extension, the current table cache format ma

[GitHub] [spark] GuoPhilipse commented on a change in pull request #29056: [SPARK-31753][SQL][DOCS] Add missing keywords in the SQL docs

2020-07-16 Thread GitBox
GuoPhilipse commented on a change in pull request #29056: URL: https://github.com/apache/spark/pull/29056#discussion_r455594631 ## File path: docs/sql-ref-syntax-qry-select-groupby.md ## @@ -38,6 +38,8 @@ GROUP BY GROUPING SETS (grouping_set [ , ...]) While aggregate functions

[GitHub] [spark] AmplabJenkins commented on pull request #29117: [WIP] Debug flaky pip installation test failure

2020-07-16 Thread GitBox
AmplabJenkins commented on pull request #29117: URL: https://github.com/apache/spark/pull/29117#issuecomment-659233868 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29117: [WIP] Debug flaky pip installation test failure

2020-07-16 Thread GitBox
AmplabJenkins removed a comment on pull request #29117: URL: https://github.com/apache/spark/pull/29117#issuecomment-659233868 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] HyukjinKwon commented on pull request #29117: [WIP] Debug flaky pip installation test failure

2020-07-16 Thread GitBox
HyukjinKwon commented on pull request #29117: URL: https://github.com/apache/spark/pull/29117#issuecomment-659237020 retest this please This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [spark] AmplabJenkins commented on pull request #29117: [WIP] Debug flaky pip installation test failure

2020-07-16 Thread GitBox
AmplabJenkins commented on pull request #29117: URL: https://github.com/apache/spark/pull/29117#issuecomment-659237626 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29117: [WIP] Debug flaky pip installation test failure

2020-07-16 Thread GitBox
AmplabJenkins removed a comment on pull request #29117: URL: https://github.com/apache/spark/pull/29117#issuecomment-659237626 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] Ngone51 removed a comment on pull request #29106: [SPARK-32307][SQL] ScalaUDF's canonicalized expression should exclude inputEncoders

2020-07-16 Thread GitBox
Ngone51 removed a comment on pull request #29106: URL: https://github.com/apache/spark/pull/29106#issuecomment-659240765 test("SPARK-32307: Aggression that use array type input UDF as group expression") { spark.udf.register("key", udf((m: Array[Int]) => m.head)) Seq(Array(1)).toDF

[GitHub] [spark] Ngone51 commented on pull request #29106: [SPARK-32307][SQL] ScalaUDF's canonicalized expression should exclude inputEncoders

2020-07-16 Thread GitBox
Ngone51 commented on pull request #29106: URL: https://github.com/apache/spark/pull/29106#issuecomment-659240765 test("SPARK-32307: Aggression that use array type input UDF as group expression") { spark.udf.register("key", udf((m: Array[Int]) => m.head)) Seq(Array(1)).toDF("a").cr

[GitHub] [spark] LantaoJin commented on a change in pull request #29021: [WIP][SPARK-32201][SQL] More general skew join pattern matching

2020-07-16 Thread GitBox
LantaoJin commented on a change in pull request #29021: URL: https://github.com/apache/spark/pull/29021#discussion_r450674200 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala ## @@ -730,6 +713,67 @@ class AdaptiveQueryE

[GitHub] [spark] LantaoJin removed a comment on pull request #29021: [WIP][SPARK-32201][SQL] More general skew join pattern matching

2020-07-16 Thread GitBox
LantaoJin removed a comment on pull request #29021: URL: https://github.com/apache/spark/pull/29021#issuecomment-654698752 To simply the UT. I introduced this pattern. And I have recognized there is problem for agg. It can coalesce but split. I will refactor code and description. Emm. Make

[GitHub] [spark] AmplabJenkins commented on pull request #29021: [WIP][SPARK-32201][SQL] More general skew join pattern matching

2020-07-16 Thread GitBox
AmplabJenkins commented on pull request #29021: URL: https://github.com/apache/spark/pull/29021#issuecomment-659243520 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] LantaoJin commented on a change in pull request #29021: [WIP][SPARK-32201][SQL] More general skew join pattern matching

2020-07-16 Thread GitBox
LantaoJin commented on a change in pull request #29021: URL: https://github.com/apache/spark/pull/29021#discussion_r450666963 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala ## @@ -730,6 +713,67 @@ class AdaptiveQueryE

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29021: [WIP][SPARK-32201][SQL] More general skew join pattern matching

2020-07-16 Thread GitBox
AmplabJenkins removed a comment on pull request #29021: URL: https://github.com/apache/spark/pull/29021#issuecomment-659243520 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] LantaoJin commented on pull request #29021: [SPARK-32201][SQL] More general skew join pattern matching

2020-07-16 Thread GitBox
LantaoJin commented on pull request #29021: URL: https://github.com/apache/spark/pull/29021#issuecomment-659245767 Now I add another test case which is very similar with the user case in the description. I think it's done. Could you have a chance to review it? @cloud-fan ---

[GitHub] [spark] cloud-fan commented on a change in pull request #29064: [SPARK-32272][SQL] Add SQL standard command SET TIME ZONE

2020-07-16 Thread GitBox
cloud-fan commented on a change in pull request #29064: URL: https://github.com/apache/spark/pull/29064#discussion_r455619306 ## File path: docs/sql-ref-syntax-aux-conf-mgmt-set-timezone.md ## @@ -0,0 +1,67 @@ +--- +layout: global +title: SET TIME ZONE +displayTitle: SET TIME Z

[GitHub] [spark] cloud-fan commented on pull request #29125: [SPARK-32018][SQL][3.0] UnsafeRow.setDecimal should set null with overflowed value

2020-07-16 Thread GitBox
cloud-fan commented on pull request #29125: URL: https://github.com/apache/spark/pull/29125#issuecomment-659252029 > No need to fix Sum.scala? That sum fix is in master only. I don't know if we can backport it as it breaks the streaming state store.

[GitHub] [spark] maropu commented on a change in pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-16 Thread GitBox
maropu commented on a change in pull request #29085: URL: https://github.com/apache/spark/pull/29085#discussion_r455605548 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/BaseScriptTransformationExec.scala ## @@ -56,10 +65,45 @@ trait BaseScriptTransformat

[GitHub] [spark] Ngone51 commented on pull request #29106: [SPARK-32307][SQL] ScalaUDF's canonicalized expression should exclude inputEncoders

2020-07-16 Thread GitBox
Ngone51 commented on pull request #29106: URL: https://github.com/apache/spark/pull/29106#issuecomment-659253331 It has been reverted at 4ef535fffbc1cacbacb035b2b1ac1dffcc0352b4. `branch-3.0` build fail at test `SPARK-32307: Aggression that use array type input UDF as group expressio

[GitHub] [spark] peter-toth commented on a change in pull request #28885: [SPARK-29375][SPARK-28940][SPARK-32041][SQL] Whole plan exchange and subquery reuse

2020-07-16 Thread GitBox
peter-toth commented on a change in pull request #28885: URL: https://github.com/apache/spark/pull/28885#discussion_r452926017 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/util/ReuseMap.scala ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] [spark] cloud-fan commented on pull request #29106: [SPARK-32307][SQL] ScalaUDF's canonicalized expression should exclude inputEncoders

2020-07-16 Thread GitBox
cloud-fan commented on pull request #29106: URL: https://github.com/apache/spark/pull/29106#issuecomment-659255564 OK, then let's not backport. @Ngone51 can you update the PR description to make it clear? This is an automate

[GitHub] [spark] Ngone51 commented on pull request #29106: [SPARK-32307][SQL] ScalaUDF's canonicalized expression should exclude inputEncoders

2020-07-16 Thread GitBox
Ngone51 commented on pull request #29106: URL: https://github.com/apache/spark/pull/29106#issuecomment-659256027 Sure This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] yaooqinn commented on a change in pull request #29064: [SPARK-32272][SQL] Add SQL standard command SET TIME ZONE

2020-07-16 Thread GitBox
yaooqinn commented on a change in pull request #29064: URL: https://github.com/apache/spark/pull/29064#discussion_r455628397 ## File path: docs/sql-ref-syntax-aux-conf-mgmt-set-timezone.md ## @@ -0,0 +1,67 @@ +--- +layout: global +title: SET TIME ZONE +displayTitle: SET TIME ZO

[GitHub] [spark] AmplabJenkins commented on pull request #29125: [SPARK-32018][SQL][3.0] UnsafeRow.setDecimal should set null with overflowed value

2020-07-16 Thread GitBox
AmplabJenkins commented on pull request #29125: URL: https://github.com/apache/spark/pull/29125#issuecomment-659260465 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29125: [SPARK-32018][SQL][3.0] UnsafeRow.setDecimal should set null with overflowed value

2020-07-16 Thread GitBox
AmplabJenkins removed a comment on pull request #29125: URL: https://github.com/apache/spark/pull/29125#issuecomment-659260465 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29064: [SPARK-32272][SQL] Add SQL standard command SET TIME ZONE

2020-07-16 Thread GitBox
AmplabJenkins removed a comment on pull request #29064: URL: https://github.com/apache/spark/pull/29064#issuecomment-659289221 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29064: [SPARK-32272][SQL] Add SQL standard command SET TIME ZONE

2020-07-16 Thread GitBox
AmplabJenkins commented on pull request #29064: URL: https://github.com/apache/spark/pull/29064#issuecomment-659289221 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] peter-toth commented on a change in pull request #28885: [SPARK-29375][SPARK-28940][SPARK-32041][SQL] Whole plan exchange and subquery reuse

2020-07-16 Thread GitBox
peter-toth commented on a change in pull request #28885: URL: https://github.com/apache/spark/pull/28885#discussion_r455648388 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/Exchange.scala ## @@ -95,46 +89,3 @@ case class ReusedExchangeExec(overr

[GitHub] [spark] HeartSaVioR commented on pull request #29129: [SPARK-31831][SQL][TESTS][FOLLOWUP] Put mocks for HiveSessionImplSuite in hive version related subdirectories

2020-07-16 Thread GitBox
HeartSaVioR commented on pull request #29129: URL: https://github.com/apache/spark/pull/29129#issuecomment-659291520 Just updated the PR description. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29067: [SPARK-32274][SQL] Make SQL cache serialization pluggable

2020-07-16 Thread GitBox
HyukjinKwon commented on a change in pull request #29067: URL: https://github.com/apache/spark/pull/29067#discussion_r455652745 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryRelation.scala ## @@ -19,84 +19,301 @@ package org.apache.spark

[GitHub] [spark] peter-toth commented on a change in pull request #28885: [SPARK-29375][SPARK-28940][SPARK-32041][SQL] Whole plan exchange and subquery reuse

2020-07-16 Thread GitBox
peter-toth commented on a change in pull request #28885: URL: https://github.com/apache/spark/pull/28885#discussion_r455648388 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/Exchange.scala ## @@ -95,46 +89,3 @@ case class ReusedExchangeExec(overr

[GitHub] [spark] maropu commented on a change in pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-16 Thread GitBox
maropu commented on a change in pull request #29085: URL: https://github.com/apache/spark/pull/29085#discussion_r455621459 ## File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveScriptTransformationExec.scala ## @@ -175,15 +168,7 @@ case class HiveScript

[GitHub] [spark] HyukjinKwon commented on pull request #29067: [SPARK-32274][SQL] Make SQL cache serialization pluggable

2020-07-16 Thread GitBox
HyukjinKwon commented on pull request #29067: URL: https://github.com/apache/spark/pull/29067#issuecomment-659306235 Okay, I took a look too. I think the actual API here itself is not very big as it seems. It is a developer API. The idea makes sense to me too. I guess the main concer

<    5   6   7   8   9   10   11   >