[GitHub] [spark] SparkQA commented on pull request #28685: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-08-14 Thread GitBox
SparkQA commented on pull request #28685: URL: https://github.com/apache/spark/pull/28685#issuecomment-673923756 **[Test build #127435 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127435/testReport)** for PR 28685 at commit

[GitHub] [spark] PedroCorreiaLuis commented on a change in pull request #26319: [SPARK-29594][SQL] Provide better error message when creating a Dataset from a Sequence of Case class where a field name

2020-08-14 Thread GitBox
PedroCorreiaLuis commented on a change in pull request #26319: URL: https://github.com/apache/spark/pull/26319#discussion_r470512398 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala ## @@ -543,6 +543,12 @@ object ScalaReflection

[GitHub] [spark] SparkQA commented on pull request #28939: [SPARK-32119][CORE] ExecutorPlugin doesn't work with Standalone Cluster and Kubernetes with --jars

2020-08-14 Thread GitBox
SparkQA commented on pull request #28939: URL: https://github.com/apache/spark/pull/28939#issuecomment-673987976 **[Test build #127445 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127445/testReport)** for PR 28939 at commit

[GitHub] [spark] PedroCorreiaLuis commented on a change in pull request #26319: [SPARK-29594][SQL] Provide better error message when creating a Dataset from a Sequence of Case class where a field name

2020-08-14 Thread GitBox
PedroCorreiaLuis commented on a change in pull request #26319: URL: https://github.com/apache/spark/pull/26319#discussion_r470520548 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala ## @@ -543,6 +543,13 @@ object ScalaReflection

[GitHub] [spark] SparkQA removed a comment on pull request #28939: [SPARK-32119][CORE] ExecutorPlugin doesn't work with Standalone Cluster and Kubernetes with --jars

2020-08-14 Thread GitBox
SparkQA removed a comment on pull request #28939: URL: https://github.com/apache/spark/pull/28939#issuecomment-673929805 **[Test build #127445 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127445/testReport)** for PR 28939 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29428: [SPARK-32608][SQL] Script Transform ROW FORMAT DELIMIT value should format value

2020-08-14 Thread GitBox
AmplabJenkins removed a comment on pull request #29428: URL: https://github.com/apache/spark/pull/29428#issuecomment-673997664 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29428: [SPARK-32608][SQL] Script Transform ROW FORMAT DELIMIT value should format value

2020-08-14 Thread GitBox
AmplabJenkins commented on pull request #29428: URL: https://github.com/apache/spark/pull/29428#issuecomment-673997664 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] sarutak commented on pull request #28939: [SPARK-32119][CORE] ExecutorPlugin doesn't work with Standalone Cluster and Kubernetes with --jars

2020-08-14 Thread GitBox
sarutak commented on pull request #28939: URL: https://github.com/apache/spark/pull/28939#issuecomment-673929285 retest this please. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] cloud-fan commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-14 Thread GitBox
cloud-fan commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r470463130 ## File path: core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ## @@ -428,6 +428,68 @@ public MapIterator destructiveIterator() {

[GitHub] [spark] cloud-fan commented on pull request #29415: [SPARK-32590][SQL] Remove fullOutput from RowDataSourceScanExec

2020-08-14 Thread GitBox
cloud-fan commented on pull request #29415: URL: https://github.com/apache/spark/pull/29415#issuecomment-673948844 thanks, merging to master! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] cloud-fan closed pull request #29415: [SPARK-32590][SQL] Remove fullOutput from RowDataSourceScanExec

2020-08-14 Thread GitBox
cloud-fan closed pull request #29415: URL: https://github.com/apache/spark/pull/29415 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] beliefer commented on a change in pull request #28685: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-08-14 Thread GitBox
beliefer commented on a change in pull request #28685: URL: https://github.com/apache/spark/pull/28685#discussion_r470474638 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala ## @@ -474,6 +479,54 @@ case class

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29395: [3.0][SPARK-32518][CORE] CoarseGrainedSchedulerBackend.maxNumConcurrentTasks should consider all kinds of resources

2020-08-14 Thread GitBox
AmplabJenkins removed a comment on pull request #29395: URL: https://github.com/apache/spark/pull/29395#issuecomment-673979514 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #26319: [SPARK-29594][SQL] Provide better error message when creating a Dataset from a Sequence of Case class where a field name started with a

2020-08-14 Thread GitBox
AmplabJenkins commented on pull request #26319: URL: https://github.com/apache/spark/pull/26319#issuecomment-673992319 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #26319: [SPARK-29594][SQL] Provide better error message when creating a Dataset from a Sequence of Case class where a field name starte

2020-08-14 Thread GitBox
AmplabJenkins removed a comment on pull request #26319: URL: https://github.com/apache/spark/pull/26319#issuecomment-673992319 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #26319: [SPARK-29594][SQL] Provide better error message when creating a Dataset from a Sequence of Case class where a field name started with

2020-08-14 Thread GitBox
SparkQA removed a comment on pull request #26319: URL: https://github.com/apache/spark/pull/26319#issuecomment-673991562 **[Test build #127452 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127452/testReport)** for PR 26319 at commit

[GitHub] [spark] SparkQA commented on pull request #26319: [SPARK-29594][SQL] Provide better error message when creating a Dataset from a Sequence of Case class where a field name started with a numbe

2020-08-14 Thread GitBox
SparkQA commented on pull request #26319: URL: https://github.com/apache/spark/pull/26319#issuecomment-673992306 **[Test build #127452 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127452/testReport)** for PR 26319 at commit

[GitHub] [spark] SparkQA commented on pull request #29428: [SPARK-32608][SQL] Script Transform ROW FORMAT DELIMIT value should format value

2020-08-14 Thread GitBox
SparkQA commented on pull request #29428: URL: https://github.com/apache/spark/pull/29428#issuecomment-674032131 **[Test build #127444 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127444/testReport)** for PR 29428 at commit

[GitHub] [spark] SparkQA commented on pull request #29395: [3.0][SPARK-32518][CORE] CoarseGrainedSchedulerBackend.maxNumConcurrentTasks should consider all kinds of resources

2020-08-14 Thread GitBox
SparkQA commented on pull request #29395: URL: https://github.com/apache/spark/pull/29395#issuecomment-674032283 **[Test build #127450 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127450/testReport)** for PR 29395 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #29428: [SPARK-32608][SQL] Script Transform ROW FORMAT DELIMIT value should format value

2020-08-14 Thread GitBox
SparkQA removed a comment on pull request #29428: URL: https://github.com/apache/spark/pull/29428#issuecomment-673927028 **[Test build #127444 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127444/testReport)** for PR 29428 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #29395: [3.0][SPARK-32518][CORE] CoarseGrainedSchedulerBackend.maxNumConcurrentTasks should consider all kinds of resources

2020-08-14 Thread GitBox
SparkQA removed a comment on pull request #29395: URL: https://github.com/apache/spark/pull/29395#issuecomment-673978933 **[Test build #127450 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127450/testReport)** for PR 29395 at commit

[GitHub] [spark] HyukjinKwon commented on pull request #29431: [SPARK-32615][SQL] Fix AQE aggregateMetrics java.util.NoSuchElementException

2020-08-14 Thread GitBox
HyukjinKwon commented on pull request #29431: URL: https://github.com/apache/spark/pull/29431#issuecomment-673928393 cc @maryannxue and @hvanhovell This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] SparkQA commented on pull request #29360: [SPARK-32542][SQL] Add an optimizer rule to split an Expand into multiple Expands for aggregates

2020-08-14 Thread GitBox
SparkQA commented on pull request #29360: URL: https://github.com/apache/spark/pull/29360#issuecomment-673941158 **[Test build #127446 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127446/testReport)** for PR 29360 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-14 Thread GitBox
cloud-fan commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r470465338 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala ## @@ -66,6 +66,30 @@ private[execution] sealed trait

[GitHub] [spark] Comonut commented on pull request #29424: [MINOR][SQL] Fixed approx_count_distinct rsd param description

2020-08-14 Thread GitBox
Comonut commented on pull request #29424: URL: https://github.com/apache/spark/pull/29424#issuecomment-673952022 Thanks! Style issues should be fine now This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29424: [MINOR][SQL] Fixed approx_count_distinct rsd param description

2020-08-14 Thread GitBox
AmplabJenkins removed a comment on pull request #29424: URL: https://github.com/apache/spark/pull/29424#issuecomment-673953626 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #29395: [3.0][SPARK-32518][CORE] CoarseGrainedSchedulerBackend.maxNumConcurrentTasks should consider all kinds of resources

2020-08-14 Thread GitBox
SparkQA commented on pull request #29395: URL: https://github.com/apache/spark/pull/29395#issuecomment-673971653 **[Test build #127442 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127442/testReport)** for PR 29395 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29395: [3.0][SPARK-32518][CORE] CoarseGrainedSchedulerBackend.maxNumConcurrentTasks should consider all kinds of resources

2020-08-14 Thread GitBox
AmplabJenkins removed a comment on pull request #29395: URL: https://github.com/apache/spark/pull/29395#issuecomment-673972163 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #29395: [3.0][SPARK-32518][CORE] CoarseGrainedSchedulerBackend.maxNumConcurrentTasks should consider all kinds of resources

2020-08-14 Thread GitBox
SparkQA removed a comment on pull request #29395: URL: https://github.com/apache/spark/pull/29395#issuecomment-67392 **[Test build #127442 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127442/testReport)** for PR 29395 at commit

[GitHub] [spark] PedroCorreiaLuis commented on a change in pull request #26319: [SPARK-29594][SQL] Provide better error message when creating a Dataset from a Sequence of Case class where a field name

2020-08-14 Thread GitBox
PedroCorreiaLuis commented on a change in pull request #26319: URL: https://github.com/apache/spark/pull/26319#discussion_r470514288 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala ## @@ -543,6 +543,12 @@ object ScalaReflection

[GitHub] [spark] AmplabJenkins removed a comment on pull request #26319: [SPARK-29594][SQL] Provide better error message when creating a Dataset from a Sequence of Case class where a field name starte

2020-08-14 Thread GitBox
AmplabJenkins removed a comment on pull request #26319: URL: https://github.com/apache/spark/pull/26319#issuecomment-673982798 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] cloud-fan commented on a change in pull request #28490: [SPARK-31670][SQL]Resolve Struct Field in Grouping Aggregate with same ExprId

2020-08-14 Thread GitBox
cloud-fan commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r470523167 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1479,6 +1479,33 @@ class Analyzer( //

[GitHub] [spark] AmplabJenkins removed a comment on pull request #26319: [SPARK-29594][SQL] Provide better error message when creating a Dataset from a Sequence of Case class where a field name starte

2020-08-14 Thread GitBox
AmplabJenkins removed a comment on pull request #26319: URL: https://github.com/apache/spark/pull/26319#issuecomment-673994868 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29432: [SPARK-32616][SQL] Window operators should be added determinedly

2020-08-14 Thread GitBox
AmplabJenkins removed a comment on pull request #29432: URL: https://github.com/apache/spark/pull/29432#issuecomment-673994940 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #29378: [SPARK-30069][CORE][YARN] Clean up non-shuffle disk block manager files following executor exists on YARN

2020-08-14 Thread GitBox
SparkQA removed a comment on pull request #29378: URL: https://github.com/apache/spark/pull/29378#issuecomment-673924459 **[Test build #127443 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127443/testReport)** for PR 29378 at commit

[GitHub] [spark] SparkQA commented on pull request #29378: [SPARK-30069][CORE][YARN] Clean up non-shuffle disk block manager files following executor exists on YARN

2020-08-14 Thread GitBox
SparkQA commented on pull request #29378: URL: https://github.com/apache/spark/pull/29378#issuecomment-673995403 **[Test build #127443 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127443/testReport)** for PR 29378 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #29395: [3.0][SPARK-32518][CORE] CoarseGrainedSchedulerBackend.maxNumConcurrentTasks should consider all kinds of resources

2020-08-14 Thread GitBox
AmplabJenkins commented on pull request #29395: URL: https://github.com/apache/spark/pull/29395#issuecomment-674032657 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29428: [SPARK-32608][SQL] Script Transform ROW FORMAT DELIMIT value should format value

2020-08-14 Thread GitBox
AmplabJenkins removed a comment on pull request #29428: URL: https://github.com/apache/spark/pull/29428#issuecomment-674032848 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29395: [3.0][SPARK-32518][CORE] CoarseGrainedSchedulerBackend.maxNumConcurrentTasks should consider all kinds of resources

2020-08-14 Thread GitBox
AmplabJenkins removed a comment on pull request #29395: URL: https://github.com/apache/spark/pull/29395#issuecomment-674032657 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #29428: [SPARK-32608][SQL] Script Transform ROW FORMAT DELIMIT value should format value

2020-08-14 Thread GitBox
AmplabJenkins commented on pull request #29428: URL: https://github.com/apache/spark/pull/29428#issuecomment-674032848 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29395: [3.0][SPARK-32518][CORE] CoarseGrainedSchedulerBackend.maxNumConcurrentTasks should consider all kinds of resources

2020-08-14 Thread GitBox
AmplabJenkins removed a comment on pull request #29395: URL: https://github.com/apache/spark/pull/29395#issuecomment-674032665 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] maropu commented on a change in pull request #29428: [SPARK-32608][SQL] Script Transform ROW FORMAT DELIMIT value should format value

2020-08-14 Thread GitBox
maropu commented on a change in pull request #29428: URL: https://github.com/apache/spark/pull/29428#discussion_r470442824 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/SparkSqlParserSuite.scala ## @@ -330,4 +331,44 @@ class SparkSqlParserSuite extends

[GitHub] [spark] SparkQA commented on pull request #28939: [SPARK-32119][CORE] ExecutorPlugin doesn't work with Standalone Cluster and Kubernetes with --jars

2020-08-14 Thread GitBox
SparkQA commented on pull request #28939: URL: https://github.com/apache/spark/pull/28939#issuecomment-673919276 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/32059/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29428: [SPARK-32608][SQL] Script Transform ROW FORMAT DELIMIT value should format value

2020-08-14 Thread GitBox
AmplabJenkins removed a comment on pull request #29428: URL: https://github.com/apache/spark/pull/29428#issuecomment-673927549 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28939: [SPARK-32119][CORE] ExecutorPlugin doesn't work with Standalone Cluster and Kubernetes with --jars

2020-08-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28939: URL: https://github.com/apache/spark/pull/28939#issuecomment-673926964 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] leanken commented on pull request #29431: [SPARK-32615][SQL] Fix AQE aggregateMetrics java.util.NoSuchElementException

2020-08-14 Thread GitBox
leanken commented on pull request #29431: URL: https://github.com/apache/spark/pull/29431#issuecomment-673927760 Before this Fix. Exception Log as follow. ``` [info] AdaptiveQueryExecSuite: 14:40:36.591 WARN org.apache.spark.util.Utils: Your hostname, linxuewei-2.local

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29431: [SPARK-32615][SQL] Fix AQE aggregateMetrics java.util.NoSuchElementException

2020-08-14 Thread GitBox
AmplabJenkins removed a comment on pull request #29431: URL: https://github.com/apache/spark/pull/29431#issuecomment-673926846 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] [spark] AmplabJenkins commented on pull request #29431: [SPARK-32615][SQL] Fix AQE aggregateMetrics java.util.NoSuchElementException

2020-08-14 Thread GitBox
AmplabJenkins commented on pull request #29431: URL: https://github.com/apache/spark/pull/29431#issuecomment-673927376 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #29428: [SPARK-32608][SQL] Script Transform ROW FORMAT DELIMIT value should format value

2020-08-14 Thread GitBox
AmplabJenkins commented on pull request #29428: URL: https://github.com/apache/spark/pull/29428#issuecomment-673927549 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #29360: [SPARK-32542][SQL] Add an optimizer rule to split an Expand into multiple Expands for aggregates

2020-08-14 Thread GitBox
AmplabJenkins commented on pull request #29360: URL: https://github.com/apache/spark/pull/29360#issuecomment-673941594 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] cloud-fan commented on a change in pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-14 Thread GitBox
cloud-fan commented on a change in pull request #29342: URL: https://github.com/apache/spark/pull/29342#discussion_r470466370 ## File path: core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ## @@ -428,6 +428,68 @@ public MapIterator destructiveIterator() {

[GitHub] [spark] cloud-fan commented on pull request #29431: [SPARK-32615][SQL] Fix AQE aggregateMetrics java.util.NoSuchElementException

2020-08-14 Thread GitBox
cloud-fan commented on pull request #29431: URL: https://github.com/apache/spark/pull/29431#issuecomment-673945816 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29431: [SPARK-32615][SQL] Fix AQE aggregateMetrics java.util.NoSuchElementException

2020-08-14 Thread GitBox
AmplabJenkins removed a comment on pull request #29431: URL: https://github.com/apache/spark/pull/29431#issuecomment-673927376 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] [spark] SparkQA commented on pull request #28939: [SPARK-32119][CORE] ExecutorPlugin doesn't work with Standalone Cluster and Kubernetes with --jars

2020-08-14 Thread GitBox
SparkQA commented on pull request #28939: URL: https://github.com/apache/spark/pull/28939#issuecomment-673965813 **[Test build #127449 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127449/testReport)** for PR 28939 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #26319: [SPARK-29594][SQL] Provide better error message when creating a Dataset from a Sequence of Case class where a field name starte

2020-08-14 Thread GitBox
AmplabJenkins removed a comment on pull request #26319: URL: https://github.com/apache/spark/pull/26319#issuecomment-673986292 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on pull request #26319: [SPARK-29594][SQL] Provide better error message when creating a Dataset from a Sequence of Case class where a field name started with

2020-08-14 Thread GitBox
SparkQA removed a comment on pull request #26319: URL: https://github.com/apache/spark/pull/26319#issuecomment-673985362 **[Test build #127451 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127451/testReport)** for PR 26319 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #26319: [SPARK-29594][SQL] Provide better error message when creating a Dataset from a Sequence of Case class where a field name started with a

2020-08-14 Thread GitBox
AmplabJenkins commented on pull request #26319: URL: https://github.com/apache/spark/pull/26319#issuecomment-673986281 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #26319: [SPARK-29594][SQL] Provide better error message when creating a Dataset from a Sequence of Case class where a field name started with a numbe

2020-08-14 Thread GitBox
SparkQA commented on pull request #26319: URL: https://github.com/apache/spark/pull/26319#issuecomment-673986269 **[Test build #127451 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127451/testReport)** for PR 26319 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #26319: [SPARK-29594][SQL] Provide better error message when creating a Dataset from a Sequence of Case class where a field name starte

2020-08-14 Thread GitBox
AmplabJenkins removed a comment on pull request #26319: URL: https://github.com/apache/spark/pull/26319#issuecomment-673986281 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA commented on pull request #29428: [SPARK-32608][SQL] Script Transform ROW FORMAT DELIMIT value should format value

2020-08-14 Thread GitBox
SparkQA commented on pull request #29428: URL: https://github.com/apache/spark/pull/29428#issuecomment-673997198 **[Test build #127455 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127455/testReport)** for PR 29428 at commit

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #28490: [SPARK-31670][SQL]Resolve Struct Field in Grouping Aggregate with same ExprId

2020-08-14 Thread GitBox
AngersZh commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r470555710 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1479,6 +1479,33 @@ class Analyzer( //

[GitHub] [spark] cloud-fan commented on pull request #29423: [SPARK-20680][SQL][FOLLOW-UP] Add HiveVoidType in HiveClientImpl

2020-08-14 Thread GitBox
cloud-fan commented on pull request #29423: URL: https://github.com/apache/spark/pull/29423#issuecomment-673921605 thanks, merging to master! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] cloud-fan closed pull request #29423: [SPARK-20680][SQL][FOLLOW-UP] Add HiveVoidType in HiveClientImpl

2020-08-14 Thread GitBox
cloud-fan closed pull request #29423: URL: https://github.com/apache/spark/pull/29423 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] ScrapCodes opened a new pull request #29334: [SPARK-32495][2.4] Update jackson versions to a maintained release, to fix various security vulnerabilities.

2020-08-14 Thread GitBox
ScrapCodes opened a new pull request #29334: URL: https://github.com/apache/spark/pull/29334 ### What changes were proposed in this pull request? Update pom, with the latest release of jackson to 2.9.10 and 2.9.10.5. Which have fixes for all the reported CVEs so far - as per

[GitHub] [spark] ScrapCodes closed pull request #29334: [SPARK-32495][2.4] Update jackson versions to a maintained release, to fix various security vulnerabilities.

2020-08-14 Thread GitBox
ScrapCodes closed pull request #29334: URL: https://github.com/apache/spark/pull/29334 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] leanken commented on pull request #29431: [SPARK-32615][SQL] Fix AQE aggregateMetrics java.util.NoSuchElementEx…

2020-08-14 Thread GitBox
leanken commented on pull request #29431: URL: https://github.com/apache/spark/pull/29431#issuecomment-673926785 @cloud-fan could you have a look at this minor fix. This is an automated message from the Apache Git Service.

[GitHub] [spark] SparkQA commented on pull request #29428: [SPARK-32608][SQL] Script Transform ROW FORMAT DELIMIT value should format value

2020-08-14 Thread GitBox
SparkQA commented on pull request #29428: URL: https://github.com/apache/spark/pull/29428#issuecomment-673927028 **[Test build #127444 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127444/testReport)** for PR 29428 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #29431: [SPARK-32615][SQL] Fix AQE aggregateMetrics java.util.NoSuchElementEx…

2020-08-14 Thread GitBox
AmplabJenkins commented on pull request #29431: URL: https://github.com/apache/spark/pull/29431#issuecomment-673926846 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA commented on pull request #28939: [SPARK-32119][CORE] ExecutorPlugin doesn't work with Standalone Cluster and Kubernetes with --jars

2020-08-14 Thread GitBox
SparkQA commented on pull request #28939: URL: https://github.com/apache/spark/pull/28939#issuecomment-673926935 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/32059/

[GitHub] [spark] AmplabJenkins commented on pull request #28939: [SPARK-32119][CORE] ExecutorPlugin doesn't work with Standalone Cluster and Kubernetes with --jars

2020-08-14 Thread GitBox
AmplabJenkins commented on pull request #28939: URL: https://github.com/apache/spark/pull/28939#issuecomment-673926956 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28939: [SPARK-32119][CORE] ExecutorPlugin doesn't work with Standalone Cluster and Kubernetes with --jars

2020-08-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28939: URL: https://github.com/apache/spark/pull/28939#issuecomment-673926956 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] beliefer commented on a change in pull request #28685: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-08-14 Thread GitBox
beliefer commented on a change in pull request #28685: URL: https://github.com/apache/spark/pull/28685#discussion_r470473071 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala ## @@ -363,6 +363,11 @@ abstract class

[GitHub] [spark] cloud-fan commented on pull request #29431: [SPARK-32615][SQL] Fix AQE aggregateMetrics java.util.NoSuchElementException

2020-08-14 Thread GitBox
cloud-fan commented on pull request #29431: URL: https://github.com/apache/spark/pull/29431#issuecomment-673946988 > During AQE, when sub-plan changed, LiveExecutionData is using the new sub-plan SQLMetrics to override the old ones This is expected. The old subquery should not be

[GitHub] [spark] SparkQA commented on pull request #29431: [SPARK-32615][SQL] Fix AQE aggregateMetrics java.util.NoSuchElementException

2020-08-14 Thread GitBox
SparkQA commented on pull request #29431: URL: https://github.com/apache/spark/pull/29431#issuecomment-673947308 **[Test build #127447 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127447/testReport)** for PR 29431 at commit

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #28490: [SPARK-31670][SQL]Resolve Struct Field in Grouping Aggregate with same ExprId

2020-08-14 Thread GitBox
AngersZh commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r470509589 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1479,6 +1479,33 @@ class Analyzer( //

[GitHub] [spark] cloud-fan commented on a change in pull request #28490: [SPARK-31670][SQL]Resolve Struct Field in Grouping Aggregate with same ExprId

2020-08-14 Thread GitBox
cloud-fan commented on a change in pull request #28490: URL: https://github.com/apache/spark/pull/28490#discussion_r470508893 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1479,6 +1479,33 @@ class Analyzer( //

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29378: [SPARK-30069][CORE][YARN] Clean up non-shuffle disk block manager files following executor exists on YARN

2020-08-14 Thread GitBox
AmplabJenkins removed a comment on pull request #29378: URL: https://github.com/apache/spark/pull/29378#issuecomment-673996369 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29378: [SPARK-30069][CORE][YARN] Clean up non-shuffle disk block manager files following executor exists on YARN

2020-08-14 Thread GitBox
AmplabJenkins commented on pull request #29378: URL: https://github.com/apache/spark/pull/29378#issuecomment-673996369 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28939: [SPARK-32119][CORE] ExecutorPlugin doesn't work with Standalone Cluster and Kubernetes with --jars

2020-08-14 Thread GitBox
SparkQA commented on pull request #28939: URL: https://github.com/apache/spark/pull/28939#issuecomment-674021038 **[Test build #127449 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127449/testReport)** for PR 28939 at commit

[GitHub] [spark] leanken commented on pull request #29431: [SPARK-32615][SQL] Fix AQE aggregateMetrics java.util.NoSuchElementException

2020-08-14 Thread GitBox
leanken commented on pull request #29431: URL: https://github.com/apache/spark/pull/29431#issuecomment-674030541 Done some code investigation, come out with some information, FYI. First, the effect of the `java.util.NoSuchElementException` will be SparkUI error like follow All

[GitHub] [spark] sarutak commented on pull request #28939: [SPARK-32119][CORE] ExecutorPlugin doesn't work with Standalone Cluster and Kubernetes with --jars

2020-08-14 Thread GitBox
sarutak commented on pull request #28939: URL: https://github.com/apache/spark/pull/28939#issuecomment-674030481 retest this please. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] leanken edited a comment on pull request #29431: [SPARK-32615][SQL] Fix AQE aggregateMetrics java.util.NoSuchElementException

2020-08-14 Thread GitBox
leanken edited a comment on pull request #29431: URL: https://github.com/apache/spark/pull/29431#issuecomment-674030541 Done some code investigation, come out with some information, FYI. 1. the effect of the `java.util.NoSuchElementException` will be SparkUI error like follow

[GitHub] [spark] HyukjinKwon closed pull request #29429: [DO-NOT-MERGE] Verify GitHub Actions test report

2020-08-14 Thread GitBox
HyukjinKwon closed pull request #29429: URL: https://github.com/apache/spark/pull/29429 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] cloud-fan commented on pull request #29395: [3.0][SPARK-32518][CORE] CoarseGrainedSchedulerBackend.maxNumConcurrentTasks should consider all kinds of resources

2020-08-14 Thread GitBox
cloud-fan commented on pull request #29395: URL: https://github.com/apache/spark/pull/29395#issuecomment-673977082 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] SparkQA commented on pull request #28939: [SPARK-32119][CORE] ExecutorPlugin doesn't work with Standalone Cluster and Kubernetes with --jars

2020-08-14 Thread GitBox
SparkQA commented on pull request #28939: URL: https://github.com/apache/spark/pull/28939#issuecomment-673985365 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/32070/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28939: [SPARK-32119][CORE] ExecutorPlugin doesn't work with Standalone Cluster and Kubernetes with --jars

2020-08-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28939: URL: https://github.com/apache/spark/pull/28939#issuecomment-673988487 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on pull request #26319: [SPARK-29594][SQL] Provide better error message when creating a Dataset from a Sequence of Case class where a field name started with a

2020-08-14 Thread GitBox
AmplabJenkins commented on pull request #26319: URL: https://github.com/apache/spark/pull/26319#issuecomment-673989003 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28939: [SPARK-32119][CORE] ExecutorPlugin doesn't work with Standalone Cluster and Kubernetes with --jars

2020-08-14 Thread GitBox
AmplabJenkins commented on pull request #28939: URL: https://github.com/apache/spark/pull/28939#issuecomment-673988477 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28939: [SPARK-32119][CORE] ExecutorPlugin doesn't work with Standalone Cluster and Kubernetes with --jars

2020-08-14 Thread GitBox
AmplabJenkins removed a comment on pull request #28939: URL: https://github.com/apache/spark/pull/28939#issuecomment-673988477 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] Ngone51 commented on pull request #29432: [SPARK-32616][SQL] Window operators should be added determinedly

2020-08-14 Thread GitBox
Ngone51 commented on pull request #29432: URL: https://github.com/apache/spark/pull/29432#issuecomment-673993472 cc @cloud-fan @maropu This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] cloud-fan commented on a change in pull request #29242: [SPARK-31448] [PYTHON] Fix storage level used in cache() in dataframe.py

2020-08-14 Thread GitBox
cloud-fan commented on a change in pull request #29242: URL: https://github.com/apache/spark/pull/29242#discussion_r470526777 ## File path: python/pyspark/sql/dataframe.py ## @@ -674,7 +674,7 @@ def cache(self): .. note:: The default storage level has changed to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #26319: [SPARK-29594][SQL] Provide better error message when creating a Dataset from a Sequence of Case class where a field name starte

2020-08-14 Thread GitBox
AmplabJenkins removed a comment on pull request #26319: URL: https://github.com/apache/spark/pull/26319#issuecomment-673992326 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on pull request #28939: [SPARK-32119][CORE] ExecutorPlugin doesn't work with Standalone Cluster and Kubernetes with --jars

2020-08-14 Thread GitBox
SparkQA removed a comment on pull request #28939: URL: https://github.com/apache/spark/pull/28939#issuecomment-673965813 **[Test build #127449 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127449/testReport)** for PR 28939 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28939: [SPARK-32119][CORE] ExecutorPlugin doesn't work with Standalone Cluster and Kubernetes with --jars

2020-08-14 Thread GitBox
AmplabJenkins commented on pull request #28939: URL: https://github.com/apache/spark/pull/28939#issuecomment-674021532 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29431: [SPARK-32615][SQL] Fix AQE aggregateMetrics java.util.NoSuchElementException

2020-08-14 Thread GitBox
SparkQA commented on pull request #29431: URL: https://github.com/apache/spark/pull/29431#issuecomment-674029251 **[Test build #127456 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127456/testReport)** for PR 29431 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #29378: [SPARK-30069][CORE][YARN] Clean up non-shuffle disk block manager files following executor exists on YARN

2020-08-14 Thread GitBox
AmplabJenkins commented on pull request #29378: URL: https://github.com/apache/spark/pull/29378#issuecomment-673922256 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29378: [SPARK-30069][CORE][YARN] Clean up non-shuffle disk block manager files following executor exists on YARN

2020-08-14 Thread GitBox
AmplabJenkins removed a comment on pull request #29378: URL: https://github.com/apache/spark/pull/29378#issuecomment-673922256 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] cloud-fan commented on pull request #29342: [SPARK-32399][SQL] Full outer shuffled hash join

2020-08-14 Thread GitBox
cloud-fan commented on pull request #29342: URL: https://github.com/apache/spark/pull/29342#issuecomment-673945250 @agrawaldevesh @maropu @viirya any more comments? The benchmark shows that the previous "store matched bit in value payload" approach and the current "bitset/hashset"

[GitHub] [spark] AmplabJenkins commented on pull request #26319: [SPARK-29594][SQL] Provide better error message when creating a Dataset from a Sequence of Case class where a field name started with a

2020-08-14 Thread GitBox
AmplabJenkins commented on pull request #26319: URL: https://github.com/apache/spark/pull/26319#issuecomment-673982798 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] PedroCorreiaLuis commented on a change in pull request #26319: [SPARK-29594][SQL] Provide better error message when creating a Dataset from a Sequence of Case class where a field name

2020-08-14 Thread GitBox
PedroCorreiaLuis commented on a change in pull request #26319: URL: https://github.com/apache/spark/pull/26319#discussion_r470513309 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala ## @@ -543,6 +543,12 @@ object ScalaReflection

<    1   2   3   4   5   >